Copy offload

2014-05-28 Thread Martin K. Petersen
Several people have poked me about the copy offload patches. Aside from being able to fit into Jens' 3.16/core branch there hasn't been any changes, nor any bug reports since LSF/MM. This patch series implements support for copy offload. Storage arrays that implement copy operations can be told to

[PATCH 2/6] block: Implement support for copy offload operations

2014-05-28 Thread Martin K. Petersen
Many modern SCSI devices support copy offloading operations in which one can copy a block range from one LUN to another without the need for data to be copied sent to the host and back. This is particularly useful for things like cloning LUNs or virtual machine images. Implement support for REQ_CO

[PATCH 4/6] block: Copy offload ioctl

2014-05-28 Thread Martin K. Petersen
Add an ioctl which can be used to clone a block range within a single block device. This is useful for testing the copy offload code. Signed-off-by: Martin K. Petersen --- block/ioctl.c | 35 +++ include/uapi/linux/fs.h | 1 + 2 files changed, 36 insert

[PATCH 1/6] block: Replace bi_integrity with bi_special

2014-05-28 Thread Martin K. Petersen
For commands like REQ_COPY we need a way to pass extra information along with each bio. Like integrity metadata this information must be available at the bottom of the stack so bi_private does not suffice. Rename the existing bi_integrity field to bi_special and make it a union so we can have diff

[PATCH 3/6] block: Introduce copy offload library function

2014-05-28 Thread Martin K. Petersen
blkdev_issue_copy() is a library function that filesystems can use to clone block ranges between devices that support copy offloading. Both source and target device must have max_copy_sectors > 0 in the queue limits. blkdev_issue_copy() will iterate over the blocks in the source range and issue co

[PATCH 6/6] [SCSI] sd: Implement copy offload support

2014-05-28 Thread Martin K. Petersen
Implement support for hardware copy offload. This initial implementation only supports EXTENDED COPY(LID1). If need be we can add support for LID4 or token copy at a later date. If a device has the 3PC flag set in the standard INQUIRY response we'll issue a RECEIVE COPY OPERATION PARAMETERS comman

[PATCH 5/6] [SCSI] Look up and store NAA if VPD page 0x83 is present

2014-05-28 Thread Martin K. Petersen
Copy offloading requires us to know the NAA descriptor for both source target device. This descriptor is mandatory in the Device Identification VPD page. Locate this descriptor in the returned VPD data so we don't have to do lookups for every copy command. Signed-off-by: Martin K. Petersen --- d

[PATCH 12/14] block: Add specific data integrity errors

2014-05-28 Thread Martin K. Petersen
Introduce a set of error codes that can be used by the block integrity subsystem to signal which class of error was encountered by either the I/O controller or the storage device. Signed-off-by: Martin K. Petersen --- block/blk-core.c | 12 drivers/md/dm-mpath.c

[PATCH 07/14] block: Add prefix to block integrity profile flags

2014-05-28 Thread Martin K. Petersen
Add a BLK_ prefix to the integrity profile flags. Also rename the flags to be more consistent with the generate/verify terminology in the rest of the integrity code. Signed-off-by: Martin K. Petersen --- block/bio-integrity.c | 4 ++-- block/blk-integrity.c | 43 ++

[PATCH 04/14] block: Remove bip_buf

2014-05-28 Thread Martin K. Petersen
bip_buf is not really needed so we can remove it. Signed-off-by: Martin K. Petersen --- block/bio-integrity.c | 10 ++ include/linux/bio.h | 3 --- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/block/bio-integrity.c b/block/bio-integrity.c index f59cdc2e0e63..e06b3c80

[PATCH 06/14] block: Clean up the code used to generate and verify integrity metadata

2014-05-28 Thread Martin K. Petersen
Instead of the "operate" parameter we pass in a seed value and a pointer to a function that can be used to process the integrity metadata. The generation function is changed to have a return value to fit into this scheme. Signed-off-by: Martin K. Petersen --- block/bio-integrity.c | 82 +++

[PATCH 08/14] block: Add a disk flag to block integrity profile

2014-05-28 Thread Martin K. Petersen
So far we have relied on the app tag size to determine whether a disk has been formatted with T10 protection information or not. However, not all target devices provide application tag storage. Add a flag to the block integrity profile that indicates whether the disk has been formatted with protec

[PATCH 10/14] block: Integrity checksum flag

2014-05-28 Thread Martin K. Petersen
Make the choice of checksum a per-I/O property by introducing a flag that can be inspected by the SCSI layer. Signed-off-by: Martin K. Petersen --- block/bio-integrity.c | 3 +++ drivers/scsi/sd_dif.c | 6 -- include/linux/bio.h| 1 + include/linux/blkdev.h | 1 + 4 files changed, 9 in

[PATCH 14/14] sd: Honor block layer integrity handling flags

2014-05-28 Thread Martin K. Petersen
A set of flags introduced in the block layer enable better control over how protection information is handled. These flags are useful for both error injection and data recovery purposes. Checking can be enabled and disabled for controller and disk, and the guard tag format is now a per-I/O property

[PATCH 11/14] block: Don't merge requests if integrity flags differ

2014-05-28 Thread Martin K. Petersen
We'd occasionally merge requests with conflicting integrity flags. Introduce a merge helper which checks that the requests have compatible integrity payloads. Signed-off-by: Martin K. Petersen --- block/blk-integrity.c | 36 ++-- block/blk-merge.c | 6 +++--

[PATCH 09/14] block: Relocate integrity flags

2014-05-28 Thread Martin K. Petersen
Move flags affecting the integrity code out of the bio bi_flags and into the block integrity payload. Signed-off-by: Martin K. Petersen --- block/bio-integrity.c | 4 ++-- drivers/scsi/sd_dif.c | 4 ++-- include/linux/bio.h | 27 ++- include/linux/blk_type

[PATCH 02/14] block: Replace bi_integrity with bi_special

2014-05-28 Thread Martin K. Petersen
For commands like REQ_COPY we need a way to pass extra information along with each bio. Like integrity metadata this information must be available at the bottom of the stack so bi_private does not suffice. Rename the existing bi_integrity field to bi_special and make it a union so we can have diff

[PATCH 13/14] lib: Add T10 Protection Information functions

2014-05-28 Thread Martin K. Petersen
The T10 Protection Information format is also used by some devices that do not go through the SCSI layer (virtual block devices, NVMe). Relocate the relevant functions to a library that can be used without involving SCSI. Signed-off-by: Martin K. Petersen --- block/Kconfig | 1 +

[PATCH 05/14] block: Deprecate the use of the term sector in the context of block integrity

2014-05-28 Thread Martin K. Petersen
The protection interval is not necessarily tied to the logical block size of a block device. Stop using the terms sector and sectors. Signed-off-by: Martin K. Petersen --- block/bio-integrity.c | 46 +- block/blk-integrity.c | 10 +- drivers/

[PATCH 03/14] block: Deprecate integrity tagging functions

2014-05-28 Thread Martin K. Petersen
None of the filesystems appear interested in using the integrity tagging feature. Potentially because very few storage devices actually permit using the application tag space. Deprecate the tagging functions. Signed-off-by: Martin K. Petersen --- Documentation/block/data-integrity.txt | 34

[PATCH 01/14] block: Get rid of bdev_integrity_enabled()

2014-05-28 Thread Martin K. Petersen
bdev_integrity_enabled() is only used by bio_integrity_enabled(). Combine these two functions. Signed-off-by: Martin K. Petersen --- Documentation/block/data-integrity.txt | 10 - block/bio-integrity.c | 39 +++--- include/linux/bio.h

Data integrity update

2014-05-28 Thread Martin K. Petersen
Here's an update to the block layer and SCSI data integrity code. There are a whole bunch of cleanups, some as a result of the work that Kent did to the block layer a while back. A bunch of dead code is removed, mainly the tagging functionality that nobody ended up using. There's also some prep wo

Re: [Open-FCoE] Open-FCoE Maintainer Transition

2014-05-28 Thread Prasad Gondi
Robert Thanks for your help and support with open-fcoe project and I really appreciate your help all along. Hope you have a very good luck with your new assignment. Thanks, Prasad Gondi Tech Lead (Storage Protocols) VMware Inc - Original Message - From: "Robert Love" To: fcoe-de...@

[PATCH] Transition maintainership to Vasu.

2014-05-28 Thread Robert Love
Acked-by: Vasu Dev Signed-off-by: Robert Love --- MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8ccf31c..c9afcf3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3539,7 +3539,7 @@ F:Documentation/fault-injection/ F:

Re: Make SCSI error handler code easier to understand

2014-05-28 Thread Joe Lawrence
On Mon, 26 May 2014 17:12:27 +0200 Bart Van Assche wrote: > Every now and then someone asks how it is avoided that the SCSI error > handler and the SCSI completion handler are invoked concurrently for > the same SCSI command. Hence this patch series that should make the SCSI > error handler code

Re: [PATCHv2 0/5] Support 64-bit LUNs

2014-05-28 Thread Ewan Milne
On Tue, 2014-05-20 at 13:03 +0200, Hannes Reinecke wrote: > Hi all, > > this patchset updates the SCSI stack to support full 64-bit LUNs. > The first patch is a simple fix; the next patch updates > the sequential scan logic to be compliant with SPC. > The third patch addresses a firmware issue wit

[Bug 76681] Adaptec 7805H SAS HBA (pm80xx) cannot survive ACPI S3 or ACPI S4

2014-05-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=76681 Bradley Grove changed: What|Removed |Added CC||bgr...@attotech.com --- Comment #2 from B

Open-FCoE Maintainer Transition

2014-05-28 Thread Robert Love
Hello community, It is with mixed feelings that I send this mail to state that I am transitioning maintainership of Open-FCoE. I'm still working on Linux solutions, but now I'm focusing on SDN/NfV technologies. I'll still be around and I'll continue to help where I can. Vasu Dev will t

[PATCH 1/1] drivers/scsi/aic7xxx/aic79xx_core.c: replace kmalloc/memset 0 by kzalloc

2014-05-28 Thread Fabian Frederick
Cc: Hannes Reinecke Cc: "James E.J. Bottomley" Signed-off-by: Fabian Frederick --- drivers/scsi/aic7xxx/aic79xx_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c b/drivers/scsi/aic7xxx/aic79xx_core.c index 0bcacf7..9ce383c 100644

[PATCH 1/1] drivers/scsi/aic7xxx/aic7xxx_core.c: replace 3 kmalloc/memset 0 by kzalloc

2014-05-28 Thread Fabian Frederick
Cc: "James E.J. Bottomley" Cc: Hannes Reinecke Signed-off-by: Fabian Frederick --- drivers/scsi/aic7xxx/aic7xxx_core.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c index 10172a3..7f34d25

Re: [PATCH 39/42] qla2xxx: ABTS cause double free of qla_tgt_cmd +.

2014-05-28 Thread Quinn Tran
Nicholas, At this point we can forgo this patch to stable tree. There are additional tweaks in this path during testing. We will update the stable tree with new findings. Thanks. Regards, Quinn Tran On 5/22/14 8:00 PM, "Nicholas A. Bellinger" wrote: >Hi Saurav + Quinn, > >Just curious if

Re: [PATCH V2 0/5] lpfc 10.2.8001.0: Update lpfc to revision 10.2.8001.0

2014-05-28 Thread Dick Kennedy
looks good Signed-By: Dick Kennedy -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] acornscsi: remove linked command support

2014-05-28 Thread Paul Bolle
On Sun, 2014-05-25 at 11:42 +0400, James Bottomley wrote: > On Sat, 2014-05-24 at 15:16 +0200, Paul Bolle wrote: > > On Sat, 2014-05-24 at 16:13 +0400, James Bottomley wrote: > > > Wait, no, that's not a good idea. We leave obsolete drivers to bitrot. > > > Particularly we try not to touch them un

[PATCH] [SCSI] Fix T10-DIF-TYPE3 get_tag handler for multi-sector bios

2014-05-28 Thread Andreas Gruenbacher
The combined tag size in this case is 6 bytes; fix the loop. Signed-off-by: Andreas Gruenbacher --- drivers/scsi/sd_dif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/sd_dif.c b/drivers/scsi/sd_dif.c index a7a691d..d657a8c 100644 --- a/drivers/scsi/sd_dif.c ++

RE: [PATCH 3/4] scsi: increase upper limit for max_sectors

2014-05-28 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Akinobu Mita > Sent: Sunday, 25 May, 2014 7:44 AM > To: linux-scsi@vger.kernel.org > Cc: Akinobu Mita; Jens Axboe; James E.J. Bottomley; Douglas Gilbert > Subject: [PATCH

Re: [ANNOUNCE] scsi patch queue tree

2014-05-28 Thread Christoph Hellwig
On Wed, May 28, 2014 at 11:04:31AM -0500, Mike Christie wrote: > Did you see these patchsets: > > [PATCH 00/10] qla4xxx: 5.04.00-k5: Updates for scsi "misc" branch > and > [PATCH 0/6] qla4xxx: 5.04.00-k6: Updates for scsi "misc" branch > > ? I think they should be ok for your tree if you did not

Re: [ANNOUNCE] scsi patch queue tree

2014-05-28 Thread Mike Christie
On 05/28/2014 10:50 AM, Christoph Hellwig wrote: > On Wed, May 28, 2014 at 10:37:31AM -0500, Mike Christie wrote: >> On 05/28/2014 05:54 AM, Christoph Hellwig wrote: >>> be2iscsi: Fix processing cqe for cxn whose endpoint is freed >> >> I didn't look at your tree, but when this patch was post

[PATCH, repost] mptfusion: fix msgContext in mptctl_hp_hostinfo

2014-05-28 Thread Tomas Henzl
Hi, without this patch the istwiRWRequest->MsgContext is always set to zero, this patch saves the MsgContext in a msgcontext variable and then restores the value. Thanks to David Jeffery who found the issue and did the analysis. Signed-off-by: Tomas Henzl Acked-by: Desai, Kashyap --- drivers/

Re: [ANNOUNCE] scsi patch queue tree

2014-05-28 Thread Christoph Hellwig
On Wed, May 28, 2014 at 09:31:14PM +0530, Sujit Reddy Thumma wrote: > The above 4 patches are just posted to mailing lists with no > review/ack's yet. I believe it still went in because the sender has > modified the author name to himself and signed-off by is present by the > original author which

Re: [ANNOUNCE] scsi patch queue tree

2014-05-28 Thread Sujit Reddy Thumma
On 5/28/2014 4:24 PM, Christoph Hellwig wrote: I've pushed the following changes to the drivers-for-3.16 tree. I've there's anyting matching the rules that I did forget please resend and/or ping me. Benoit Taine (2): qla4x

Re: [PATCH] scsi/NCR5380: dprintk macro

2014-05-28 Thread Christoph Hellwig
On Thu, May 29, 2014 at 12:43:43AM +1000, Finn Thain wrote: > > This is the delta between the two submissions: > [PATCH 00/12] scsi/NCR5380: fix debugging macros and #include structure > and > [PATCH v2 00/12] scsi/NCR5380: fix debugging macros and #include structure > > The macro definition chan

Re: [PATCH 7/8] be2iscsi: Fix processing cqe for cxn whose endpoint is freed

2014-05-28 Thread Christoph Hellwig
On Wed, May 07, 2014 at 05:18:38PM -0500, Mike Christie wrote: > It looks like if that race is possible then we could also free the ep > while you are accessing right? I think you would need to get a ref to > the ep. > > What command/function tells the card to stop sending the driver > events/noti

Re: [ANNOUNCE] scsi patch queue tree

2014-05-28 Thread Christoph Hellwig
On Wed, May 28, 2014 at 10:37:31AM -0500, Mike Christie wrote: > On 05/28/2014 05:54 AM, Christoph Hellwig wrote: > > be2iscsi: Fix processing cqe for cxn whose endpoint is freed > > I didn't look at your tree, but when this patch was posted on the list I > think it had a bug. > > http://ww

Re: [ANNOUNCE] scsi patch queue tree

2014-05-28 Thread Mike Christie
On 05/28/2014 05:54 AM, Christoph Hellwig wrote: > be2iscsi: Fix processing cqe for cxn whose endpoint is freed I didn't look at your tree, but when this patch was posted on the list I think it had a bug. http://www.spinics.net/lists/linux-scsi/msg74191.html -- To unsubscribe from this list

Re: [PATCH] acornscsi: remove linked command support

2014-05-28 Thread Russell King - ARM Linux
On Wed, May 28, 2014 at 06:26:44PM +0400, James Bottomley wrote: > On Wed, 2014-05-28 at 03:41 -0700, Christoph Hellwig wrote: > > Looks good, > > > > Reviewed-by: Christoph Hellwig > > > > And I have to disagree with James here, removing code that isn't even > > compiled always is an improvemen

[PATCH] scsi/NCR5380: dprintk macro

2014-05-28 Thread Finn Thain
This is the delta between the two submissions: [PATCH 00/12] scsi/NCR5380: fix debugging macros and #include structure and [PATCH v2 00/12] scsi/NCR5380: fix debugging macros and #include structure The macro definition changes were discussed on the mailing list during review. The idea is to get

Re: [PATCH] acornscsi: remove linked command support

2014-05-28 Thread James Bottomley
On Wed, 2014-05-28 at 03:41 -0700, Christoph Hellwig wrote: > On Sat, May 24, 2014 at 12:13:53PM +0200, Paul Bolle wrote: > > The acornscsi driver was added in v2.1.88. It has always #undef-ed > > CONFIG_SCSI_ACORNSCSI_LINK near the top of acornscsi.c. And, just to be > > sure, it has also always t

Re: [PATCH] scsi_lib: replace ambiguous "Unhandled error code" messages.

2014-05-28 Thread James Bottomley
On Wed, 2014-05-28 at 04:00 -0700, Christoph Hellwig wrote: > On Mon, May 26, 2014 at 09:27:15PM +0200, Maurizio Lombardi wrote: > > > How about simple not setting description at all for this case? > > > > > > > It has already been proposed before but James didn't like the idea. > > > > http://m

Re: [PATCH 3/4] scsi: increase upper limit for max_sectors

2014-05-28 Thread Akinobu Mita
Hi Christoph, Thanks for your review. 2014-05-28 19:39 GMT+09:00 Christoph Hellwig : > Looks good, but I think this should be three patches, one for the ioctl > in sg, one for the command selection in sd, and one to change the field > with in the scsi core. OK, I'll break this into three patches

Re: [PATCH 05/12] scsi/NCR5380: fix build failures when debugging is enabled

2014-05-28 Thread Christoph Hellwig
On Wed, May 28, 2014 at 10:09:33PM +1000, Finn Thain wrote: > [PATCH v2 05/12] scsi/NCR5380: fix build failures when debugging is enabled > [PATCH v2 06/12] scsi/NCR5380: fix dprintk macro usage and definition > [PATCH v2 09/12] scsi/NCR5380: fix and standardize NDEBUG macros > > And several patch

Re: [PATCH 05/12] scsi/NCR5380: fix build failures when debugging is enabled

2014-05-28 Thread Finn Thain
On Wed, 28 May 2014, Christoph Hellwig wrote: > Looks good, > > Reviewed-by: Christoph Hellwig > Thanks for reviewing. There was a later submission (version 2) with changes made to three of these patches, [PATCH v2 05/12] scsi/NCR5380: fix build failures when debugging is enabled [PATCH v2

Re: [PATCH] scsi: pm8001: pm8001_hwi.c: Fix for possible null pointer dereference

2014-05-28 Thread Tomas Henzl
On 05/28/2014 01:28 PM, Christoph Hellwig wrote: > On Sun, May 18, 2014 at 06:14:00PM +0200, Rickard Strandqvist wrote: >> There is otherwise a risk of a possible null pointer dereference. >> >> Was largely found by using a static code analysis program called cppcheck. > I can't see how dev->lldd_d

Re: [PATCH] scsi: pm8001: pm8001_hwi.c: Fix for possible null pointer dereference

2014-05-28 Thread Christoph Hellwig
On Sun, May 18, 2014 at 06:14:00PM +0200, Rickard Strandqvist wrote: > There is otherwise a risk of a possible null pointer dereference. > > Was largely found by using a static code analysis program called cppcheck. I can't see how dev->lldd_dev would be NULL here. -- To unsubscribe from this lis

Re: [PATCH] scsi: mvsas: mv_sas.c: Fix for possible null pointer dereference

2014-05-28 Thread Christoph Hellwig
On Sun, May 18, 2014 at 06:12:26PM +0200, Rickard Strandqvist wrote: > There is otherwise a risk of a possible null pointer dereference. > > Was largely found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist Looks good, although I'd love to know ho

Re: [PATCH] scsi: mpt2sas: mpt2sas_base.c: Fix for possible null pointer dereference

2014-05-28 Thread Christoph Hellwig
> - ioc_status = le16_to_cpu(mpi_reply->IOCStatus) & MPI2_IOCSTATUS_MASK; > + if (mpi_reply) { > + ioc_status = le16_to_cpu(mpi_reply->IOCStatus) & > MPI2_IOCSTATUS_MASK; > + } > > if (ioc_status != MPI2_IOCSTATUS_SUCCESS) > ioc->port_enable_failed = 1

Re: [target:for-next 20/20] drivers/scsi/virtio_scsi.c:531:48: error: dereferencing pointer to incomplete type

2014-05-28 Thread Paolo Bonzini
Il 28/05/2014 00:21, Nicholas A. Bellinger ha scritto: On Mon, 2014-05-26 at 13:30 -0400, Martin K. Petersen wrote: "Nic" == Nicholas A Bellinger writes: What about #ifdef'ing VIRTIO_SCSI_F_T10_PI support out if !CONFIG_BLK_DEV_INTEGRITY? Nic> I figured it was slightly cleaner to enable BL

Re: [PATCH] notify block layer when using temporary change to cache_type

2014-05-28 Thread Christoph Hellwig
On Wed, May 28, 2014 at 12:58:27PM +0800, Vaughan Cao wrote: > No, I just want to keep the modification as small as possible. Checked > the actions of sd_revalidate_disk() again, it seems no harm to call it > from here. Also actual actions are skipped in sd_read_cache_type() if > cache_override!=0,

Re: [PATCH] qla2xxx: remove stub qlt_check_srr_debug()

2014-05-28 Thread Christoph Hellwig
On Sat, May 24, 2014 at 04:03:12PM +0200, Paul Bolle wrote: > qlt_check_srr_debug() was added in v3.5. It is a stub function unless > CONFIG_QLA_TGT_DEBUG_SRR is defined. But CONFIG_QLA_TGT_DEBUG_SRR will > never be defined, because the Kconfig symbol QLA_TGT_DEBUG_SRR was never > added to the tree

Re: PATCH: mvsas: add support for Supermicro AOC-SAS2LP-MV8

2014-05-28 Thread Christoph Hellwig
On Fri, May 16, 2014 at 02:06:42PM +0200, Jan Kasprzak wrote: > any news with this patch? Will it be acked by you and submitted upstream? > Thanks! Give me an Acked-by and I'll pull it in. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord.

Re: [PATCH] scsi_lib: replace ambiguous "Unhandled error code" messages.

2014-05-28 Thread Christoph Hellwig
On Mon, May 26, 2014 at 09:27:15PM +0200, Maurizio Lombardi wrote: > > How about simple not setting description at all for this case? > > > > It has already been proposed before but James didn't like the idea. > > http://markmail.org/message/dumujpz4gfp3s4fp#query:+page:1+mid:dumujpz4gfp3s4fp+st

Re: [PATCHv2 0/5] Support 64-bit LUNs

2014-05-28 Thread Christoph Hellwig
James, can you take a look at this series? I would be great to get it merged for 3.16! -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [ANNOUNCE] scsi patch queue tree

2014-05-28 Thread Christoph Hellwig
I've pushed the following changes to the drivers-for-3.16 tree. I've there's anyting matching the rules that I did forget please resend and/or ping me. Benoit Taine (2): qla4xxx: Use kmemdup instead of kmalloc + memcpy

Re: [PATCH] [SCSI] mpt2sas: Don't disable device twice at suspend.

2014-05-28 Thread Christoph Hellwig
On Fri, Apr 25, 2014 at 04:41:04PM -0400, Tyler Stachecki wrote: > On suspend, _scsih_suspend calls mpt2sas_base_free_resources, which > in turn calls pci_disable_device if the device is enabled prior to > suspending. However, _scsih_suspend also calls pci_disable_device > itself. > > Thus, in the

Re: [PATCH 1/1] drivers/scsi/aic7xxx/aic7xxx_osm.c: replace kmalloc/memset 0 by kzalloc

2014-05-28 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] drivers/scsi/aic7xxx/aic79xx_osm.c: replace kmalloc/memset by kzalloc

2014-05-28 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] drivers/scsi/lpfc/lpfc_init.c: remove unnecessary casting

2014-05-28 Thread Christoph Hellwig
On Tue, May 27, 2014 at 07:49:18PM +0200, Fabian Frederick wrote: > Fix coccicheck warning: > "WARNING: casting value returned by k[cmz]alloc to (struct lpfc_sli_ring *) > is useless." > > Cc: James Smart > Cc: "James E.J. Bottomley" > Signed-off-by: Fabian Frederick Looks good, Reviewed-by:

Re: [PATCH] acornscsi: remove linked command support

2014-05-28 Thread Christoph Hellwig
On Sat, May 24, 2014 at 12:13:53PM +0200, Paul Bolle wrote: > The acornscsi driver was added in v2.1.88. It has always #undef-ed > CONFIG_SCSI_ACORNSCSI_LINK near the top of acornscsi.c. And, just to be > sure, it has also always triggered a preprocessor error if > CONFIG_SCSI_ACORNSCSI_LINK was st

Re: [PATCH 3/4] scsi: increase upper limit for max_sectors

2014-05-28 Thread Christoph Hellwig
On Sun, May 25, 2014 at 09:43:35PM +0900, Akinobu Mita wrote: > max_sectors in struct Scsi_Host specifies maximum number of sectors > allowed in a single SCSI command. The data type of max_sectors is > unsigned short, so the maximum transfer length per SCSI command is > limited to less than 256MB

Re: [PATCH 4/4] scsi_debug: allow huge transfer length for read/write commands

2014-05-28 Thread Christoph Hellwig
On Sun, May 25, 2014 at 09:43:36PM +0900, Akinobu Mita wrote: > This change enables to test read/write commands with huge transfer > length such as 1GB. For example: > > # modprobe scsi_debug dev_size_mb=1024 clustering=1 opts=1 > # cat /sys/block/$DEV/queue/max_hw_sectors_kb > \ >

Re: [PATCH 2/4] block: fix SG_[GS]ET_RESERVED_SIZE ioctl when max_sectors is huge

2014-05-28 Thread Christoph Hellwig
On Sun, May 25, 2014 at 09:43:34PM +0900, Akinobu Mita wrote: > SG_GET_RESERVED_SIZE and SG_SET_RESERVED_SIZE ioctls access a reserved > buffer in bytes as int type. The value needs to be capped at the request > queue's max_sectors. But integer overflow is not correctly handled in > the calculati

Re: [PATCH 1/4] block: fix BLKSECTGET ioctl when max_sectors is greater than USHRT_MAX

2014-05-28 Thread Christoph Hellwig
On Sun, May 25, 2014 at 09:43:33PM +0900, Akinobu Mita wrote: > BLKSECTGET ioctl loads the request queue's max_sectors as unsigned > short value to the argument pointer. So if the max_sector is greater > than USHRT_MAX, the upper 16 bits of that is just discarded. > > In such case, USHRT_MAX is m

Re: [PATCH 12/12] scsi/NCR5380: merge sun3_scsi_vme.c into sun3_scsi.c

2014-05-28 Thread Christoph Hellwig
On Tue, Mar 18, 2014 at 11:42:24AM +1100, Finn Thain wrote: > The sun3 drivers suffer from a whole bunch of duplicated code. Fix this > by following the g_NCR5380_mmio example. (Notionally, sun3_scsi relates to > sun3_scsi_vme in the same way that g_NCR5380 relates to g_NCR5380_mmio.) > > Dead cod

Re: [PATCH 11/12] scsi/NCR5380: reduce depth of sun3_scsi nested includes

2014-05-28 Thread Christoph Hellwig
On Tue, Mar 18, 2014 at 11:42:23AM +1100, Finn Thain wrote: > Move the #include "NCR5380.h" out of the sun3_scsi.h header file and into > the driver .c files, like all the other NCR5380 drivers in the tree. > > This improves uniformity and reduces the depth of nested includes. The > sequence of #i

Re: [PATCH 09/12] scsi/NCR5380: fix and standardize NDEBUG macros

2014-05-28 Thread Christoph Hellwig
On Tue, Mar 18, 2014 at 11:42:21AM +1100, Finn Thain wrote: > All three NCR5380 core driver implementations share the same NCR5380.h > header file so they need to agree on certain macro definitions. > > The flag bit used by the NDEBUG_MERGING macro in atari_NCR5380 and > sun3_NCR5380 collides with

Re: [PATCH 10/12] scsi/NCR5380: remove unused macro definitions

2014-05-28 Thread Christoph Hellwig
On Tue, Mar 18, 2014 at 11:42:22AM +1100, Finn Thain wrote: > Remove the unused (and divergent) debugging macro definitions from > the sun3_NCR5380 and atari_NCR5380 drivers. These drivers have been > converted to use the common macros in NCR5380.h. > > Signed-off-by: Finn Thain Looks good, Rev

Re: [PATCH 08/12] scsi/NCR5380: adopt dprintk()

2014-05-28 Thread Christoph Hellwig
On Tue, Mar 18, 2014 at 11:42:20AM +1100, Finn Thain wrote: > All NCR5380 drivers already include the NCR5380.h header. Better to > adopt those macros rather than have three variations on them. > > Moreover, the macros in NCR5380.h are preferable because the atari_NCR5380 > and sun3_NCR5380 versio

Re: [PATCH 07/12] scsi/NCR5380: adopt NCR5380_dprint() and NCR5380_dprint_phase()

2014-05-28 Thread Christoph Hellwig
On Tue, Mar 18, 2014 at 11:42:19AM +1100, Finn Thain wrote: > All NCR5380 drivers already include the NCR5380.h header. Better to > adopt those macros rather than have three variations on them. > > Moreover, the macros in NCR5380.h are preferable anyway: the atari_NCR5380 > and sun3_NCR5380 versio

Re: [PATCH 06/12] scsi/NCR5380: fix dprintk macro usage and definition

2014-05-28 Thread Christoph Hellwig
On Tue, Mar 18, 2014 at 11:42:18AM +1100, Finn Thain wrote: > There are three implementations of the core NCR5380 driver and three sets > of debugging macro definitions. And all three implementations use the > NCR5380.h header as well. > > Two of the definitions of the dprintk macro accept a varia

Re: [PATCH 05/12] scsi/NCR5380: fix build failures when debugging is enabled

2014-05-28 Thread Christoph Hellwig
On Tue, Mar 18, 2014 at 11:42:17AM +1100, Finn Thain wrote: > The change from cmd->target to cmd->device->id was apparently the purpose of > commit a7f251228390e87d86c5e3846f99a455517fdd8e in > kernel/git/tglx/history.git but some instances have been missed. > > Also fix the "NDEBUG_LAST_WRITE_SEN

Re: [PATCH 04/12] scsi/NCR5380: use NCR5380_dprint() instead of NCR5380_print()

2014-05-28 Thread Christoph Hellwig
On Tue, Mar 18, 2014 at 11:42:16AM +1100, Finn Thain wrote: > Only the NCR5380_dprint() macro should invoke the NCR5380_print() function. > That's why NCR5380.c only defines the function #if NDEBUG. Use the standard > macro. > > Signed-off-by: Finn Thain Looks good, Reviewed-by: Christoph Hellw

Re: [PATCH 02/12] scsi/NCR5380: remove redundant HOSTS_C macro tests

2014-05-28 Thread Christoph Hellwig
On Tue, Mar 18, 2014 at 11:42:14AM +1100, Finn Thain wrote: > HOSTS_C is always undefined. There is no hosts.c anymore. > > Signed-off-by: Finn Thain Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: [PATCH 03/12] scsi/NCR5380: remove old CVS keywords

2014-05-28 Thread Christoph Hellwig
On Tue, Mar 18, 2014 at 11:42:15AM +1100, Finn Thain wrote: > Signed-off-by: Finn Thain Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.k

Re: [PATCH 01/12] scsi/NCR5380: remove unused BOARD_NORMAL and BOARD_NCR53C400

2014-05-28 Thread Christoph Hellwig
On Tue, Mar 18, 2014 at 11:42:13AM +1100, Finn Thain wrote: > BOARD_NORMAL is completely unused and BOARD_NCR53C400 is used only by > g_NCR5380 internally. Remove the unused definitions. > > Signed-off-by: Finn Thain Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list:

Re: [PATCH] virtio-scsi: replace target spinlock with seqcount

2014-05-28 Thread Paolo Bonzini
Il 28/05/2014 03:48, Ming Lei ha scritto: On Wed, May 28, 2014 at 12:57 AM, Paolo Bonzini wrote: Il 27/05/2014 18:50, Venkatesh Srinivas ha scritto: Hi, I think this patch has a small race involving just two commands: 1. The first command to a target is in virtscsi_pick_vq(), after atomi