Re: [PATCH 0/5][RFC] Support 64-bit LUNs

2014-05-14 Thread Hannes Reinecke
On 05/15/2014 08:38 AM, Christoph Hellwig wrote: Any chance you could resend this with review comments addressed and against a current tree? Sure. But it'll have to wait until next week; currently I'm busy with getting the next Beta out of the door... Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH] scsi: replace numeric messages with string error messages when blk_execute_rq fails. Also add printing of sense info.

2014-05-14 Thread Christoph Hellwig
On Tue, May 13, 2014 at 04:24:02PM +0200, Maurizio Lombardi wrote: > On Tue, May 13, 2014 at 04:14:47PM +0200, Hannes Reinecke wrote: > > If you were to go ahead with the patch please strip the first > > scsi_execute() altogether and use the VPD information already > > provided by the scsi device.

Re: [PATCH 0/5][RFC] Support 64-bit LUNs

2014-05-14 Thread Christoph Hellwig
Any chance you could resend this with review comments addressed and against a current tree? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/5] qla2xxx: Restrict max_luns to 16-bit for older HBAs

2014-05-14 Thread Christoph Hellwig
On Tue, Dec 10, 2013 at 01:26:21PM -0500, Chad Dupuis wrote: > >+if (!IS_QLAFX00(ha) && !IS_FWI2_CAPABLE(ha)) { > >+/* HW supports only 16-bit LUNs */ > >+if (ql2xmaxlun > 0x) > >+ql2xmaxlun = 0x; > >+} > > host->max_lun = ql2xmaxlun;

RE: [PATCH] Set correct completion code in scsi_send_eh_cmnd()

2014-05-14 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Hannes Reinecke > Sent: Thursday, May 08, 2014 1:10 AM > To: James Bottomley > Cc: linux-scsi@vger.kernel.org; Hannes Reinecke; Stephen Cameron > Subject: [PATCH] Set corr

SCSI "staging" tree for linux-next?

2014-05-14 Thread Christoph Hellwig
Hi James, we're past -rc5 and no SCSI patches have been collected for 3.16 yet, despite a lot of patches including a lot of reviewed ones pending on the list. I'd really love to get at least some testing for all the work that sometimes has been pending for months in linux-next and would offer to

[Bug 76241] USB Device Not Recognised

2014-05-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=76241 --- Comment #1 from zhouqi --- Created attachment 136141 --> https://bugzilla.kernel.org/attachment.cgi?id=136141&action=edit The normal state -- You are receiving this mail because: You are the assignee for the bug. -- To unsubscribe from thi

[Bug 76241] New: USB Device Not Recognised

2014-05-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=76241 Bug ID: 76241 Summary: USB Device Not Recognised Product: IO/Storage Version: 2.5 Kernel Version: linux-2.6.37 Hardware: All OS: Linux Tree: Mainline

Re: [PATCH 1/2] target: Don't allow setting WC emulation if device doesn't support

2014-05-14 Thread Andy Grover
On 05/14/2014 05:57 PM, Nicholas A. Bellinger wrote: On Wed, 2014-05-14 at 17:22 -0700, Andy Grover wrote: On 05/14/2014 05:07 PM, Nicholas A. Bellinger wrote: On Wed, 2014-05-14 at 15:48 -0700, Andy Grover wrote: Just like for pSCSI, if the transport sets get_write_cache, then it is not valid

Re: [PATCH 1/2] target: Don't allow setting WC emulation if device doesn't support

2014-05-14 Thread Nicholas A. Bellinger
On Wed, 2014-05-14 at 17:22 -0700, Andy Grover wrote: > On 05/14/2014 05:07 PM, Nicholas A. Bellinger wrote: > > On Wed, 2014-05-14 at 15:48 -0700, Andy Grover wrote: > >> Just like for pSCSI, if the transport sets get_write_cache, then it is > >> not valid to enable write cache emulation for it. R

Re: [PATCH] block: Export REQ_FLUSH status via sysfs

2014-05-14 Thread Andy Grover
On 05/14/2014 05:11 PM, Nicholas A. Bellinger wrote: On Wed, 2014-05-14 at 15:51 -0700, Andy Grover wrote: Whether this is set or not is important for whether good performance is possible, when using the block device as a backstore for the kernel target. Exposing this will let kernel target conf

Re: [PATCH 1/2] target: Don't allow setting WC emulation if device doesn't support

2014-05-14 Thread Andy Grover
On 05/14/2014 05:07 PM, Nicholas A. Bellinger wrote: On Wed, 2014-05-14 at 15:48 -0700, Andy Grover wrote: Just like for pSCSI, if the transport sets get_write_cache, then it is not valid to enable write cache emulation for it. Return an error. see https://bugzilla.redhat.com/show_bug.cgi?id=10

Re: [PATCH] block: Export REQ_FLUSH status via sysfs

2014-05-14 Thread Nicholas A. Bellinger
On Wed, 2014-05-14 at 15:51 -0700, Andy Grover wrote: > Whether this is set or not is important for whether good performance is > possible, when using the block device as a backstore for the kernel > target. Exposing this will let kernel target configuration tools provide > this information to the

Re: [PATCH 1/2] target: Don't allow setting WC emulation if device doesn't support

2014-05-14 Thread Nicholas A. Bellinger
On Wed, 2014-05-14 at 15:48 -0700, Andy Grover wrote: > Just like for pSCSI, if the transport sets get_write_cache, then it is > not valid to enable write cache emulation for it. Return an error. > > see https://bugzilla.redhat.com/show_bug.cgi?id=1082675 > > Reviewed-by: Chris Leech > Signed-of

[PATCH] block: Export REQ_FLUSH status via sysfs

2014-05-14 Thread Andy Grover
Whether this is set or not is important for whether good performance is possible, when using the block device as a backstore for the kernel target. Exposing this will let kernel target configuration tools provide this information to the user when configuring LIO targets. Reviewed-by: Chris Leech

[PATCH 2/2] target: Fix a comment in emulate_evpd_86

2014-05-14 Thread Andy Grover
Fix comment to make it clear that check_dev_wce can return true if emulation is in use, but also if it's *not* emulated but the underlying device supports it. Reviewed-by: Chris Leech Signed-off-by: Andy Grover --- drivers/target/target_core_spc.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 1/2] target: Don't allow setting WC emulation if device doesn't support

2014-05-14 Thread Andy Grover
Just like for pSCSI, if the transport sets get_write_cache, then it is not valid to enable write cache emulation for it. Return an error. see https://bugzilla.redhat.com/show_bug.cgi?id=1082675 Reviewed-by: Chris Leech Signed-off-by: Andy Grover --- drivers/target/target_core_device.c | 8

Re: [PATCH RESEND] aic79xx: fix misuse of static variables

2014-05-14 Thread Mathias Krause
On 1 May 2014 11:48, Mathias Krause wrote: > The format strings for various printk()s make use of a temporary > variable that is declared 'static'. This is probably not intended, > so fix those. > > Found in the PaX patch, written by the PaX Team. > > Signed-off-by: Mathias Krause > Acked-by: Han

Re: [PATCH v1.2 17/16] arcmsr: fixed calling scsi_scan_host after all initialization done

2014-05-14 Thread Tomas Henzl
On 05/14/2014 01:55 PM, ching wrote: > From: Ching > > This is a new patch after patch v1.1 series. > > Fixed calling scsi_scan_host until all initialization are done. > And fixed error path free allocated resource. > > Signed-off-by: Ching > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c >

[PATCH v1.2 17/16] arcmsr: fixed calling scsi_scan_host after all initialization done

2014-05-14 Thread ching
From: Ching This is a new patch after patch v1.1 series. Fixed calling scsi_scan_host until all initialization are done. And fixed error path free allocated resource. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arc

[PATCH v1.2 16/16] arcmsr: support new adapter ARC12x4

2014-05-14 Thread ching
From: Ching Adding code for support Areca new Raid adapter ARC12x4 series. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15:29:54.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h 2014-05

[PATCH v1.2 15/16] arcmsr: modify some character string

2014-05-14 Thread ching
From: Ching Revise comment and some character strings. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-05-07 18:51:50.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-05-08 17:43:02

[PATCH v1.2 14/16] arcmsr: fix sparse checking error

2014-05-14 Thread ching
From: Ching Fix sparse utility checking errors. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-05-07 18:51:16.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-05-07 18:51:50.00

[PATCH v1.2 13/16] arcmsr: fix ioctl data read/write error for adapter type C

2014-05-14 Thread ching
From: Ching Rewrite IOCTL entry and its relate functions. This patch fix ioctl data read/write error for adapter type C. Change data I/O from byte access to dword access. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_attr.c b/drivers/scsi/arcmsr/arcmsr_attr.c --- a/drivers/sc

[PATCH v1.2 12/16] arcmsr: revise alloction of second dma_coherent_handle for type B adapter

2014-05-14 Thread ching
From: Ching This modification is for consistency with up-coming adapter type D. They have similar H/W and S/W structure. Also, it makes code easier reading. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2

[PATCH v1.2 11/16] arcmsr: rename some variable and function name

2014-05-14 Thread ching
From: Ching Rename some variable and function name for readability and consistency. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15:27:14.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h

[PATCH v1.2 10/16] arcmsr: clear outbound doorbell buffer completely

2014-05-14 Thread ching
From: Ching Clearing outbound doorbell buffer completely for adapter type C. This is to prevent getting garbage data input from IOP before ioctl command beginning. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr

[PATCH v1.2 9/16] arcmsr: modify printing adapter model number and F/W messages

2014-05-14 Thread ching
From: Ching Revise printing model name and firmware version order. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-05-07 18:46:46.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-05

[PATCH v1.2 8/16] arcmsr: remove calling arcmsr_hbb_enable_driver_mode

2014-05-14 Thread ching
From: Ching Removing call arcmsr_hbb_enable_driver_mode by in-line code. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-05-07 18:46:14.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2

[PATCH v1.2 7/16] arcmsr: revise message_isr_bh_fn to delete duplicate code

2014-05-14 Thread ching
From: Ching Revise message_isr_bh_fn to remove the duplicate code for each adapter type. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-05-07 18:45:20.0 +0800 +++ b/drivers/scsi/arcmsr

[PATCH v1.2 6/16] arcmsr: precise checking adapter ID

2014-05-14 Thread ching
From: Ching Rewriteing the arcmsr_define_adapter_type function to precisely check adapter ID. This can prevent an unknown adapter be used as a default adapter type by driver. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/

[PATCH v1.2 5/16] arcmsr: bugfix of abort command return status

2014-05-14 Thread ching
From: Ching Fix a bug of return status from calling arcmsr_polling_ccbdone. The original code may return a FAILED if abort command is SUCCESS. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-05

[PATCH v1.2 4/16] arcmsr: limit max number of SCSI command request

2014-05-14 Thread ching
From: Ching Have a limitation of max number of SCSI command request to prevent command overflow. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15:24:06.0 +0800 +++ b/drivers/scsi/arcms

[PATCH v1.2 3/16] arcmsr: adding code to support system hibernation

2014-05-14 Thread ching
From: Ching Adding code to support system hibernation. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-05-07 18:42:40.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-05-07 18:26:42

[PATCH v1.2 2/16] arcmsr: Adding code to support MSI-X interrupt

2014-05-14 Thread ching
From: Ching Adding code for supporting MSI-X interrupt. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-04-28 16:02:46.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15:24:36.00

[PATCH v1.2 1/16] arcmsr: Revise interrupt service routine relate function to fix command timeout

2014-05-14 Thread ching
From: Ching Rewrite interrupt service routine relate function to fix command timeout on controller very heavy loading. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-02-06 17:47:43.0 +0800 ++

[PATCH 1.2 0/16] arcmsr: bugfix and support new adapters ARC12x4 series

2014-05-14 Thread ching
In last patch v1.1 16/16 series, patch2 has been updated several time. The patch line number, from patch3 to patch16, are all shifted. So I repost the corrected patch files, patch v1.2 17/16 series. In the meantime, I add a new patch 17 to fix of calling scsi_scan_host() after every initializati