Re: [PATCHv2 RESEND 0/9] target: Save memory on unused se_dev_entrys and se_luns

2014-05-01 Thread Andy Grover
On 05/01/2014 02:21 PM, Nicholas A. Bellinger wrote: So now that target code (plus Sagi's patches) is finally working correctly with active I/O shutdown with iser + friends, I'm not exactly crazy about introducing a bunch of changes that potentially break long standing assumptions about how se_l

Re: [PATCHv2 RESEND 0/9] target: Save memory on unused se_dev_entrys and se_luns

2014-05-01 Thread Nicholas A. Bellinger
On Thu, 2014-05-01 at 10:53 -0700, Andy Grover wrote: > On 04/24/2014 10:34 PM, Christoph Hellwig wrote: > > On Wed, Apr 23, 2014 at 03:36:27PM -0700, Andy Grover wrote: > >> Does this set look ok, or any other changes needed? Just haven't heard > >> anything. > > > > the series looks reasonable to

rebased target userback repo available

2014-05-01 Thread Andy Grover
Hi all, In case anyone is interested in playing with it, I've rebased Shaohua's userspace backend patches to nab's latest for-next repo. There's growing interest in this capability, so Shaohua I hope you don't mind me taking the initiative to move towards seeing your work merged :) git repo

Re: scsi midlayer updates for 3.15 (resend)

2014-05-01 Thread Christoph Hellwig
The subject line should of course read "... for 3.16", sorry. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2 RESEND 0/9] target: Save memory on unused se_dev_entrys and se_luns

2014-05-01 Thread Andy Grover
On 04/24/2014 10:34 PM, Christoph Hellwig wrote: On Wed, Apr 23, 2014 at 03:36:27PM -0700, Andy Grover wrote: Does this set look ok, or any other changes needed? Just haven't heard anything. the series looks reasonable to me, at least for the points I previously comment on. Cheers, Ch

[PATCH 2/2] scsi_debug: simple short transfer injection

2014-05-01 Thread Christoph Hellwig
Add an option to only transfer half the data for every n-th command. Signed-off-by: Christoph Hellwig Acked-by: Douglas Gilbert --- drivers/scsi/scsi_debug.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index f3e9cc0..1328a

misc driver updates

2014-05-01 Thread Christoph Hellwig
Two small driver updates that were a fallout from the scsi multiqueue work. Both have been ACKed by the maintainers. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majord

[PATCH 1/2] virtio_scsi: use cmd_size

2014-05-01 Thread Christoph Hellwig
Taken almost entirely from Nicholas Bellinger's scsi-mq conversion. Signed-off-by: Christoph Hellwig Acked-by: Paolo Bonzini --- drivers/scsi/virtio_scsi.c | 25 +++-- include/scsi/scsi_cmnd.h |9 + 2 files changed, 16 insertions(+), 18 deletions(-) diff --g

[PATCH 3/4] scsi: reintroduce scsi_driver.init_command

2014-05-01 Thread Christoph Hellwig
Instead of letting the ULD play games with the prep_fn move back to the model of a central prep_fn with a callback to the ULD. This already cleans up and shortens the code by itself, and will be required to properly support blk-mq in the SCSI midlayer. Signed-off-by: Christoph Hellwig Reviewed-b

[PATCH 4/4] scsi: handle command allocation failure in scsi_reset_provider

2014-05-01 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig Reviewed-by: Nicholas Bellinger Reviewed-by: Mike Christie --- drivers/scsi/scsi_error.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index f17aa7a..abe51ea 100644 --- a/drivers/scsi/scsi_erro

[PATCH 1/4] scsi: explicitly release bidi buffers

2014-05-01 Thread Christoph Hellwig
Instead of trying to guess when we have a BIDI buffer in scsi_release_buffers add a function to explicitly free the BIDI ressoures in the one place that handles them. This avoids needing a special __scsi_release_buffers for the case where we already have freed the request as well. Signed-off-by:

scsi midlayer updates for 3.15 (resend)

2014-05-01 Thread Christoph Hellwig
Various patches from the scsi multiqueue development that make sense on their own. Changes since the version from 5 weeks ago: - rebase on top of minor changes in 3.15-rc3 - add a struct request forward declaration to avoid a warning in the OSD ULD. - add the reviewed-by tags from Nic and M

[PATCH 2/4] scsi: remove scsi_end_request

2014-05-01 Thread Christoph Hellwig
By folding scsi_end_request into its only caller we can significantly clean up the completion logic. We can use simple goto labels now to only have a single place to finish or requeue command there instead of the previous convoluted logic. Signed-off-by: Christoph Hellwig Reviewed-by: Nicholas B

[PATCH V3] bio: modify __bio_add_page() to accept pages that don't start a new segment

2014-05-01 Thread Maurizio Lombardi
The original behaviour is to refuse to add a new page if the maximum number of segments has been reached, regardless of the fact the page we are going to add can be merged into the last segment or not. Unfortunately, when the system runs under heavy memory fragmentation conditions, a driver may tr

[PATCH RESEND] aic79xx: fix misuse of static variables

2014-05-01 Thread Mathias Krause
The format strings for various printk()s make use of a temporary variable that is declared 'static'. This is probably not intended, so fix those. Found in the PaX patch, written by the PaX Team. Signed-off-by: Mathias Krause Acked-by: Hannes Reinecke Cc: "James E.J. Bottomley" Cc: PaX Team --