Re: [PATCH 02/16] scsi: atari_scsi: fix sleep_on race

Arnd Bergmann wrote: sleep_on is known broken and going away. The atari_scsi driver is one of two remaining users in the falcon_get_lock() function, which is a rather crazy piece of code. This does not attempt to fix the driver's locking scheme in general, but at least prevents falcon_get_lock fr

Re: [PATCH 00/16] sleep_on removal, second try

Arnd, It's been a while since the first submission of these patches, but a lot of them have made it into linux-next already, so here is the stuff that is not merged yet, hopefully addressing all the comments. Geert and Michael: the I was expecting the ataflop and atari_scsi patches to be merge

Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line

Hi Hannes, Although I sent you a message 6 days ago to ask your work which is similar to my patch, I resend my patch because I'm considering this problem should be fixed as soon as possible. Thank you, Yoshihiro YUNOMAE (2014/02/27 13:17), Yoshihiro YUNOMAE wrote: Output error messages using s

[PATCH RESEND] scsi: Output error messages using structured printk in single line

Output error messages using structured printk in single line. In SCSI drivers, some error messages which should be output in single line are divided in multiple lines. When user tools handle the error messages, those divided messages will create some inconveniences. The reason why this problem is

Re: [PATCH 00/16] sleep_on removal, second try

On Wed, Feb 26 2014, Arnd Bergmann wrote: > It's been a while since the first submission of these patches, > but a lot of them have made it into linux-next already, so here > is the stuff that is not merged yet, hopefully addressing all > the comments. > > Geert and Michael: the I was expecting th

Re: Proposal for a scalable SCSI midlayer

On Wed, 2014-02-26 at 11:59 +0100, Bart Van Assche wrote: > On 02/23/14 21:10, James Bottomley wrote: > > Right ... my ideal here if we can achieve it would be lockless threaded > > models, where we could make guarantees like single thread of execution > > per command, so all command state could be

Re: [PATCH 1/2] scsi: remove scsi_end_request

Turns out the bidi handling could cause a use after free in this version, I'll respin it with a fix for that. On Wed, Feb 26, 2014 at 06:23:21AM -0800, Christoph Hellwig wrote: > By folding scsi_end_request into its only caller we can significantly clean > up the completion logic. We can use simp

Re: [PATCH 13/17] scsi: push host_lock down into scsi_{host,target}_queue_ready

On 02/17/14 23:00, Christoph Hellwig wrote: > Most of the scsi multiqueue work so far has been about modifying the > block layer, so I'm definitively now shy about doing that were needed. > And I think we will eventually need to be able to have n:m queue to hctx > mapping instead of the current 1:n

Re: [PATCH v2 4/9] ipr: Use pci_enable_msi_range() and pci_enable_msix_range()

On 02/24/2014 02:12 AM, Alexander Gordeev wrote: > On Thu, Jan 30, 2014 at 03:06:30PM +0100, Alexander Gordeev wrote: >> On Wed, Jan 29, 2014 at 02:26:52PM +0100, Alexander Gordeev wrote: Do you want me to rediff your patches on top of this one, or do you want to keep the entire MSI serie

Re: [PATCH 2/2] ipr: Add new CCIN definition for new hardware support

Acked-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ipr: Format HCAM overlay ID 0x21

Acked-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] scsi: remove __scsi_release_buffers

We always do the bidi check now, so it can be folded into scsi_release_buffers. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_lib.c | 38 +++--- 1 file changed, 15 insertions(+), 23 deletions(-) diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_

[PATCH 1/2] scsi: remove scsi_end_request

By folding scsi_end_request into its only caller we can significantly clean up the completion logic. We can use simple goto labels now to only have a single place to finish or requeue command there instead of the previous convoluted logic. Note that the switch from __scsi_release_buffers without

[PATCH v3 2/7] scsi_debug: make pseudo_primary static

As pseudo_primary is only used in scsi_debug.c, it should be static. Signed-off-by: Akinobu Mita Reviewed-by: Douglas Gilbert Reviewed-by: Martin K. Petersen Cc: "James E.J. Bottomley" Cc: Douglas Gilbert Cc: linux-scsi@vger.kernel.org --- drivers/scsi/scsi_debug.c | 2 +- 1 file changed, 1

[PATCH v3 7/7] scsi_debug: add ability to enable clustering

This adds a module parameter to enable clustering. Without enabling clustering support, the transfer length for read and write scsi commands is limited upto 8MB when page size is 4KB and sg_tablesize is 2048 (= SCSI_MAX_SG_CHAIN_SEGMENTS). I would like to test commands with more than that transfe

[PATCH v3 6/7] scsi_debug: protect device access with atomic_rw lock

This change ensures that concurrent device access including ramdisk storage, protection info, and provisioning map by read, write, and unmap commands are protected with atomic_rw spinlock. Signed-off-by: Akinobu Mita Reviewed-by: Douglas Gilbert Reviewed-by: Martin K. Petersen Cc: "James E.J. B

[PATCH v3 5/7] scsi_debug: prepare to enable clustering

Currently, clustering support for scsi_debug is disabled. This is because there are for_each_sg() loops which assume that each sg list element is consisted with a single page. But enabling clustering support, each sg list element for scsi commands can be consisted with multiple pages. This repla

[PATCH v3 3/7] scsi_debug: fix duplicate dif_errors increment

It is unnecessary to increase dif_errors in dif_verify(), because the caller will increment it when dif_verify() detects failure. This bug was introduced by commit beb40ea42bd6 ("[SCSI] scsi_debug: reduce duplication between prot_verify_read and prot_verify_write") Signed-off-by: Akinobu Mita Ac

[PATCH v3 0/7] scsi_debug: several bug fixes and enable clustering support

Hi James, Please consider to apply these patches to your tree. There is no change since the previous version except for adding Reviewed-by lines from Douglas and Martin. This patch set includes several bug fixes and patches for enabling clustering support for scsi_debug. The reason why I would

[PATCH v3 4/7] scsi_debug: fix resp_xdwriteread() return value when running out of memory

When resp_xdwriteread() can't allocate temporary buffer, it returns -1. But the return value is used as scsi status code and -1 is not interpreted as correct code. target_core_mod has similar xdwriteread emulation code. So this mimics what target_core_mod does for xdwriteread when running out of m

[PATCH v3 1/7] scsi_debug: fix false positive logical block reference tag check fail

Reading partially unwritten sectors generates a false positive logical block reference tag check failure when DIF is enabled. This bug is caused by missing ei_lba increment in loop of dif_verify() when unwritten sector is skipped. Signed-off-by: Akinobu Mita Acked-by: Martin K. Petersen Reviewe

[PATCH] bfa: Updating Maintainers email ids

From: Anil Gurumurthy Signed-off-by: Anil Gurumurthy --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0dba50b..0dff580 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1917,8 +1917,8 @@ F:drivers/bcma/ F: include/

[PATCH 02/16] scsi: atari_scsi: fix sleep_on race

sleep_on is known broken and going away. The atari_scsi driver is one of two remaining users in the falcon_get_lock() function, which is a rather crazy piece of code. This does not attempt to fix the driver's locking scheme in general, but at least prevents falcon_get_lock from going to sleep when

[PATCH 00/16] sleep_on removal, second try

It's been a while since the first submission of these patches, but a lot of them have made it into linux-next already, so here is the stuff that is not merged yet, hopefully addressing all the comments. Geert and Michael: the I was expecting the ataflop and atari_scsi patches to be merged already,

Re: Proposal for a scalable SCSI midlayer

On 02/23/14 21:10, James Bottomley wrote: > Right ... my ideal here if we can achieve it would be lockless threaded > models, where we could make guarantees like single thread of execution > per command, so all command state could be lockless. This approach sounds interesting but could be challeng

[PATCH RESUBMIT 07/23] qla2xxx: Enable the Flash Access Control (FAC) mailbox command.

From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_init.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index e7e5f4f..9b271cc 100644 --- a/

[PATCH RESUBMIT 08/23] qla2xxx: Properly handle 32 bit mailbox register for ISPFX00.

Signed-off-by: Giridhar Malavali Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_mr.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index 9839da8..ed44ec6 100644 --- a/drivers/scsi/qla2

[PATCH RESUBMIT 18/23] qla2xxx: Correctly set the read_optrom pointer for ISP8044.

Signed-off-by: Giridhar Malavali Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_os.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 7c36eb2..61d42af 100644 --- a/drivers/scsi/qla2xxx/qla_os

[PATCH RESUBMIT 10/23] scsi_transport_fc: Add 32Gbps speed definition.

From: Chad Dupuis Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/scsi_transport_fc.c |1 + include/scsi/scsi_transport_fc.h |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.

[PATCH RESUBMIT 17/23] qla2xxx: Read capture firmware dump on mailbox timeout for ISP8044 and ISP82XX.

From: Chad Dupuis Allow for the capture of a firmware dump but have a sysfs node (allow_cna_fw_dump) to allow the feature to be enabled/disabled dynamically. The default is off. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_attr.c | 35 ++

[PATCH RESUBMIT 04/23] qla2xxx: Use proper message for Non owner reset ACK Timeout.

From: Atul Deshmukh Signed-off-by: Atul Deshmukh Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_nx2.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nx2.c b/drivers/scsi/qla2xxx/qla_nx2.c index f60989d..1f4c72a 100644 --- a/driv

[PATCH RESUBMIT 09/23] qla2xxx: Set host can_queue value based on available resources.

From: Chad Dupuis Tell the mid-layer that number of commands we can queue is the available resources we have minus a small amount for internal commands. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_os.c | 19 ++- 1 files changed, 10 i

[PATCH RESUBMIT 03/23] qla2xxx: Replace constant value for IOCTL IOCB abort execution status with a macro for ISPFX00.

From: Armen Baloyan Signed-off-by: Armen Baloyan Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_mr.c |3 ++- drivers/scsi/qla2xxx/qla_mr.h |3 +++ 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c in

[PATCH RESUBMIT 16/23] qla2xxx: Simplify the ISPFX00 interrupt handler code for ISPFX00.

Signed-off-by: Giridhar Malavali Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_mr.c | 25 + drivers/scsi/qla2xxx/qla_mr.h |4 2 files changed, 9 insertions(+), 20 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_m

[PATCH RESUBMIT 20/23] qla2xxx: Update the driver version to 8.07.00.02-k.

Signed-off-by: Saurav Kashyap Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_version.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 31d1953..e36b947 100644 --- a/drivers/s

[PATCH RESUBMIT 02/23] qla2xxx: Add handling for boot indication progress AENs for ISPFX00.

From: Armen Baloyan Signed-off-by: Armen Baloyan Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_def.h |2 +- drivers/scsi/qla2xxx/qla_mr.c |3 +++ 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h

[PATCH RESUBMIT 05/23] qla2xxx: Remove init control block related dead code for ISPFX00.

Signed-off-by: Giridhar Malavali Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_def.h | 24 drivers/scsi/qla2xxx/qla_mr.c | 14 -- drivers/scsi/qla2xxx/qla_os.c |1 - 3 files changed, 0 insertions(+), 39 deletions(-) diff --git a/driver

[PATCH 00/23] qla2xxx: Patches for 3.15 scsi "misc" branch.

From: Chad Dupuis Hi James, Please apply the following patches to the scsi tree, misc branch at your earliest convenience. This patch set is a resubmission of a patch set we had previously submitted plus three new patches and that this supersedes what was posted in December. Thanks, ~Saurav

[PATCH RESUBMIT 06/23] qla2xxx: Select correct request queue for error type IOCB for ISPFX00.

Signed-off-by: Giridhar Malavali Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_mr.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index 4542247..9839da8 100644 --- a/drivers/scsi/qla2xxx/qla_mr

[PATCH RESUBMIT 15/23] qla2xxx: Avoid poisoning in the response queue for ISPFX00.

Signed-off-by: Giridhar Malavali Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_mr.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index 03e2050..290322f 100644 --- a/drivers/scsi/q

[PATCH RESUBMIT 01/23] qla2xxx: Add mutex around optrom calls to serialize accesses.

From: Chad Dupuis Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_attr.c | 61 ++ drivers/scsi/qla2xxx/qla_bsg.c | 12 ++- drivers/scsi/qla2xxx/qla_def.h |1 + drivers/scsi/qla2xxx/qla_os.c |1 + 4 fi

[PATCH 22/23] qla2xxx: Fix Task Management command asynchronous handling

From: Armen Baloyan - Fix interpreting the wrong IOCB type for task management functions in the response path. - Merge the task management function handling for various adapters. Signed-off-by: Armen Baloyan Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_dbg.c |1 + drivers/s

[PATCH RESUBMIT 14/23] qla2xxx: Add changes in the IOCB structures to adjust driver source codes to ISPFX00 firmware spec.

From: Armen Baloyan Signed-off-by: Armen Baloyan Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_mr.c | 10 +- drivers/scsi/qla2xxx/qla_mr.h | 26 +- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/

[PATCH RESUBMIT 12/23] qla2xxx: Remove Marker type IOCB logic for ISPFX00.

From: Armen Baloyan Signed-off-by: Armen Baloyan Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_iocb.c | 11 +-- drivers/scsi/qla2xxx/qla_mr.c | 12 drivers/scsi/qla2xxx/qla_mr.h | 24 3 files changed, 1 insertions(+), 46 dele

[PATCH] qla2xxx: Poll during initialization for ISP25xx and ISP83xx.

From: Giridhar Malavali This patch is for 3.14-rc. Cc: sta...@vger.kernel.org Signed-off-by: Giridhar Malavali Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_def.h |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/s

[PATCH 21/23] qla2xxx: Correct the port no assignment for ISP82XX.

Signed-off-by: Giridhar Malavali Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_os.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 61d42af..7b54e0a 100644 --- a/drivers/scsi/qla2xxx/qla_os

[PATCH RESUBMIT 19/23] qla2xxx: Fix multiqueue MSI-X registration.

From: Chad Dupuis This fixes requesting of the MSI-X vectors for the base response queue. The iteration in the for loop in qla24xx_enable_msix() was incorrect. We should only iterate of the first two MSI-X vectors and not the total number of MSI-X vectors that have given to the driver for this de

[PATCH RESUBMIT 13/23] qla2xxx: Remove ISP_ABORT_NEEDED and ISP_ABORT_RETRY checks from watchdog function for ISP8044.

From: Atul Deshmukh Signed-off-by: Atul Deshmukh Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_nx2.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nx2.c b/drivers/scsi/qla2xxx/qla_nx2.c index 1f4c72a..b7ed478 100644 --- a/driver

[PATCH 23/23] qla2xxx: Add IOCB Abort command asynchronous handling.

From: Armen Baloyan Send aborts to the firmware via the request/response queue mechanism. Signed-off-by: Armen Baloyan Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_gbl.h |2 +- drivers/scsi/qla2xxx/qla_init.c | 88 +++ drivers/scsi/qla2