memory-barriers.txt again (was Re: [PATCH 4/9] firewire: don't use PREPARE_DELAYED_WORK)

2014-02-22 Thread Stefan Richter
Hi Paul, in patch "Documentation/memory-barriers.txt: Downgrade UNLOCK+BLOCK" (sic), you wrote: + Memory operations issued before the LOCK may be completed after the + LOCK operation has completed. An smp_mb__before_spinlock(), combined + with a following LOCK, orders prior loads agai

Re: [PATCH 4/9] firewire: don't use PREPARE_DELAYED_WORK

2014-02-22 Thread Peter Hurley
On 02/22/2014 01:52 PM, James Bottomley wrote: On Sat, 2014-02-22 at 13:48 -0500, Peter Hurley wrote: On 02/22/2014 01:43 PM, James Bottomley wrote: On Fri, 2014-02-21 at 18:01 -0500, Peter Hurley wrote: On 02/21/2014 11:57 AM, Tejun Heo wrote: Yo, On Fri, Feb 21, 2014 at 11:53:46AM -0500,

Re: [PATCH 4/9] firewire: don't use PREPARE_DELAYED_WORK

2014-02-22 Thread James Bottomley
On Sat, 2014-02-22 at 13:48 -0500, Peter Hurley wrote: > On 02/22/2014 01:43 PM, James Bottomley wrote: > > > > On Fri, 2014-02-21 at 18:01 -0500, Peter Hurley wrote: > >> On 02/21/2014 11:57 AM, Tejun Heo wrote: > >>> Yo, > >>> > >>> On Fri, Feb 21, 2014 at 11:53:46AM -0500, Peter Hurley wrote: >

Re: [PATCH 4/9] firewire: don't use PREPARE_DELAYED_WORK

2014-02-22 Thread Peter Hurley
On 02/22/2014 01:43 PM, James Bottomley wrote: On Fri, 2014-02-21 at 18:01 -0500, Peter Hurley wrote: On 02/21/2014 11:57 AM, Tejun Heo wrote: Yo, On Fri, Feb 21, 2014 at 11:53:46AM -0500, Peter Hurley wrote: Ok, I can do that. But AFAIK it'll have to be an smp_rmb(); there is no mb__after u

Re: [PATCH 4/9] firewire: don't use PREPARE_DELAYED_WORK

2014-02-22 Thread James Bottomley
On Fri, 2014-02-21 at 18:01 -0500, Peter Hurley wrote: > On 02/21/2014 11:57 AM, Tejun Heo wrote: > > Yo, > > > > On Fri, Feb 21, 2014 at 11:53:46AM -0500, Peter Hurley wrote: > >> Ok, I can do that. But AFAIK it'll have to be an smp_rmb(); there is > >> no mb__after unlock. > > > > We do have smp

Re: [PATCH 4/9] firewire: don't use PREPARE_DELAYED_WORK

2014-02-22 Thread Peter Hurley
On 02/22/2014 09:38 AM, Tejun Heo wrote: Hey, On Fri, Feb 21, 2014 at 06:46:24PM -0500, Peter Hurley wrote: It's a long story but the short version is that Documentation/memory-barriers.txt recently was overhauled to reflect what cpus actually do and what the different archs actually deliver.

Re: [PATCH 4/9] firewire: don't use PREPARE_DELAYED_WORK

2014-02-22 Thread Tejun Heo
Hey, On Fri, Feb 21, 2014 at 06:46:24PM -0500, Peter Hurley wrote: > It's a long story but the short version is that > Documentation/memory-barriers.txt recently was overhauled to reflect > what cpus actually do and what the different archs actually > deliver. > > Turns out that unlock + lock is

[Bug 69441] WARNING: CPU: 0 PID: 4992 at fs/sysfs/group.c:214 sysfs_remove_group+0xc6/0xd0()

2014-02-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=69441 Igor Gnatenko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---