Re: status of drivers/scsi/scsi_tgt_lib.c

2014-01-24 Thread FUJITA Tomonori
Hey, On Fri, 24 Jan 2014 05:15:25 -0800 Christoph Hellwig wrote: > Do you know if either SRP or ibmvscsi are used regularly these days? > Does tgtd userspace still support this interface? It doesn't. I think that ibm pseries switched to virtual fc driver from virtual srp long ago. Only very old

[PATCH 2/3] target/iscsi: Convert np_lock from a spinlock to a mutex

2014-01-24 Thread Andy Grover
All callers are in process context. Convert spin_lock to spin_lock_bh in iscsit_get_np since outer spin_lock_bh is now not there. Signed-off-by: Andy Grover --- drivers/target/iscsi/iscsi_target.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/dr

[PATCH 0/3] target/iscsi networkportal race fixes

2014-01-24 Thread Andy Grover
see https://bugzilla.redhat.com/show_bug.cgi?id=1055064 Summary: if thread doesn't run before 2nd identical portal is created, it misses the existing one and the kernel_bind returns an error. The first one-line patch fixes the issue for a single thread creating multiple network portals via config

[PATCH 3/3] target/iscsi: hold np_lock mutex across adding new net portal to g_np_list

2014-01-24 Thread Andy Grover
This prevents a race where two threads may attempt to create the same network portal, resulting in one of them failing. Signed-off-by: Andy Grover --- drivers/target/iscsi/iscsi_target.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/target/iscsi/is

[PATCH 1/3] target/iscsi: Set np_thread_state to ACTIVE before adding to g_np_list

2014-01-24 Thread Andy Grover
When creating network portals rapidly, such as when restoring a configuration, LIO's code to reuse existing portals can return a false negative if the thread hasn't run yet and set np_thread_state to ISCSI_NP_THREAD_ACTIVE. This causes an error in the network stack when attempting to bind to the sa

Re: Open/INQUIRY fails on RESERVE'd tape device

2014-01-24 Thread Matthias Eble
Hi all, 2014/1/24 Jeremy Linton : > On 1/23/2014 4:02 PM, Matthias Eble wrote: >> So: should open() fail on a reserved tape device? > > Yes, this is expected behavior for tape devices, reserve 6/release is > sometimes > used by backup applications in SAN environments as an arbitration mec

Re: [PATCH] sg: fix integer overflow (fwd)

2014-01-24 Thread Mikulas Patocka
On Fri, 24 Jan 2014, Mikulas Patocka wrote: > > > On Fri, 24 Jan 2014, James Bottomley wrote: > > > On Fri, 2014-01-24 at 11:34 -0500, Mikulas Patocka wrote: > > > On alpha, USER_HZ may be higher than HZ. This results in integer overflow > > > in MULDIV. > > > > > > Signed-off-by: Mikulas Pa

Re: [LSF/MM ATTEND] interest in blk-mq, scsi-mq, dm-cache, dm-thinp, dm-*

2014-01-24 Thread Mike Christie
On 01/24/2014 01:12 AM, Hannes Reinecke wrote: > On 01/24/2014 03:37 AM, Mike Christie wrote: >> On 01/13/2014 05:36 AM, Hannes Reinecke wrote: >>> On 01/10/2014 07:27 PM, Mike Snitzer wrote: I would like to attend to participate in discussions related to topics listed in the subject. As

Re: [PATCH] sg: fix integer overflow

2014-01-24 Thread Mikulas Patocka
On Fri, 24 Jan 2014, Mikulas Patocka wrote: > > > On Fri, 24 Jan 2014, James Bottomley wrote: > > > On Fri, 2014-01-24 at 11:34 -0500, Mikulas Patocka wrote: > > > On alpha, USER_HZ may be higher than HZ. This results in integer overflow > > > in MULDIV. > > > > > > Signed-off-by: Mikulas Pa

Re: [PATCH] sg: fix integer overflow

2014-01-24 Thread Mikulas Patocka
On Fri, 24 Jan 2014, James Bottomley wrote: > On Fri, 2014-01-24 at 11:34 -0500, Mikulas Patocka wrote: > > On alpha, USER_HZ may be higher than HZ. This results in integer overflow > > in MULDIV. > > > > Signed-off-by: Mikulas Patocka > > Cc: sta...@vger.kernel.org > > > > --- > > drivers/s

Re: [PATCH] sg: fix integer overflow

2014-01-24 Thread James Bottomley
On Fri, 2014-01-24 at 11:34 -0500, Mikulas Patocka wrote: > On alpha, USER_HZ may be higher than HZ. This results in integer overflow > in MULDIV. > > Signed-off-by: Mikulas Patocka > Cc: sta...@vger.kernel.org > > --- > drivers/scsi/sg.c |2 ++ > 1 file changed, 2 insertions(+) > > Index:

Re: [PATCH] sg: fix integer overflow

2014-01-24 Thread Douglas Gilbert
On 14-01-24 11:34 AM, Mikulas Patocka wrote: On alpha, USER_HZ may be higher than HZ. This results in integer overflow in MULDIV. Signed-off-by: Mikulas Patocka Acked-by: Douglas Gilbert Cc: sta...@vger.kernel.org --- drivers/scsi/sg.c |2 ++ 1 file changed, 2 insertions(+) Index:

[PATCH] sg: fix integer overflow

2014-01-24 Thread Mikulas Patocka
On alpha, USER_HZ may be higher than HZ. This results in integer overflow in MULDIV. Signed-off-by: Mikulas Patocka Cc: sta...@vger.kernel.org --- drivers/scsi/sg.c |2 ++ 1 file changed, 2 insertions(+) Index: linux-3.13/drivers/scsi/sg.c ==

Re: Open/INQUIRY fails on RESERVE'd tape device

2014-01-24 Thread Douglas Gilbert
On 14-01-24 03:35 AM, kai.makis...@kolumbus.fi wrote: Matthias Eble [psychotr...@gmail.com] kirjoitti: Hi list, When a tape device is reserved with old reserve/release commands, we see inquiry only works on the scsi generic device. For scsi tape devices open() fails already: # lsscsi -g | grep

Re: [usb-storage] Re: usb disk recognized but fails

2014-01-24 Thread Alan Stern
Matthieu: Can you help with this problem? On Fri, 24 Jan 2014, Milan Svoboda wrote: > >I don't see how that could have made any difference. The Cypress-ATACB > >driver works just like the default driver, except for two commands > >(ATA(12) and ATA(16)) neither of which appeared in the usbmon t

Re: [Lsf-pc] [LSF/MM TOPIC] really large storage sectors - going beyond 4096 bytes

2014-01-24 Thread Christoph Lameter
On Fri, 24 Jan 2014, Mel Gorman wrote: > That'd be okish for 64-bit at least although it would show up as > degraded performance in some cases when virtually contiguous buffers were > used. Aside from the higher setup, access costs and teardown costs of a > virtual contiguous buffer, the underlyin

Re: Open/INQUIRY fails on RESERVE'd tape device

2014-01-24 Thread Jeremy Linton
On 1/23/2014 4:02 PM, Matthias Eble wrote: > So: should open() fail on a reserved tape device? Yes, this is expected behavior for tape devices, reserve 6/release is sometimes used by backup applications in SAN environments as an arbitration mechanism across multiple machines. It

status of drivers/scsi/scsi_tgt_lib.c

2014-01-24 Thread Christoph Hellwig
Hi Tomo-san, what is the status of scsi_tgt_lib.c? I've recently been auditing the command allocation and I/O path for various possible improvements, and the use of many functions in this path in addition to the normal initiator code path is going to make a few things a bit harder. The code seem

Re: Persistent reservation behaviour/compliance with redundant controllers

2014-01-24 Thread Pasi Kärkkäinen
On Thu, Jan 23, 2014 at 10:31:00AM -0800, Lee Duncan wrote: > On 01/07/2014 12:18 PM, Pasi Kärkkäinen wrote: > > On Mon, Jan 06, 2014 at 11:53:44PM +0100, Matthias Eble wrote: > >> > >>> I have a "persistent reservations for dummies" document I wrote that I > >>> can send you off list, if you like.

Re: [Lsf-pc] [LSF/MM TOPIC] really large storage sectors - going beyond 4096 bytes

2014-01-24 Thread Mel Gorman
On Thu, Jan 23, 2014 at 02:47:10PM -0600, Christoph Lameter wrote: > On Wed, 22 Jan 2014, Mel Gorman wrote: > > > Large block support was proposed years ago by Christoph Lameter > > (http://lwn.net/Articles/232757/). I think I was just getting started > > in the community at the time so I do not r

Re: [Lsf-pc] [LSF/MM TOPIC] really large storage sectors - going beyond 4096 bytes

2014-01-24 Thread Mel Gorman
On Thu, Jan 23, 2014 at 11:55:35AM -0800, James Bottomley wrote: > > > > > > > > > > > > The real benefit is when and how the reads get scheduled. We're > > > > > > able to > > > > > > do a much better job pipelining the reads, controlling our caches > > > > > > and > > > > > > reducing write l

Re: [PATCH 1/6] megaraid_sas: Do not wait forever

2014-01-24 Thread Hannes Reinecke
On 01/24/2014 09:34 AM, Desai, Kashyap wrote: > > >> -Original Message- >> From: Hannes Reinecke [mailto:h...@suse.de] >> Sent: Friday, January 24, 2014 1:54 PM >> To: Desai, Kashyap; James Bottomley >> Cc: linux-scsi@vger.kernel.org; Adam Radford; Saxena, Sumit >> Subject: Re: [PATCH 1/6

RE: [PATCH 5/6] megaraid_sas_fusion: Return correct error value in megasas_get_ld_map_info()

2014-01-24 Thread Desai, Kashyap
ACK this patch. ` Kashyap > -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, January 16, 2014 3:56 PM > To: James Bottomley > Cc: linux-scsi@vger.kernel.org; Hannes Reinecke; Desai, Kashyap; Adam > Radford > Subject: [PATCH 5/6] megaraid_sas_fusion: Retur

Re: Open/INQUIRY fails on RESERVE'd tape device

2014-01-24 Thread kai . makisara
Matthias Eble [psychotr...@gmail.com] kirjoitti: Hi list, When a tape device is reserved with old reserve/release commands, we see inquiry only works on the scsi generic device. For scsi tape devices open() fails already: # lsscsi -g | grep st15 [2:0:6:0]tapeHP Ultrium 5-SCSI I5

RE: [PATCH 3/6] megaraid_sas_fusion: correctly pass queue info pointer

2014-01-24 Thread Desai, Kashyap
ACK this patch. ` Kashyap > -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, January 16, 2014 3:56 PM > To: James Bottomley > Cc: linux-scsi@vger.kernel.org; Hannes Reinecke; Desai, Kashyap; Adam > Radford > Subject: [PATCH 3/6] megaraid_sas_fusion: corr

RE: [PATCH 6/6] megaraid_sas: check return value for megasas_get_pd_list()

2014-01-24 Thread Desai, Kashyap
ACK this patch. > -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, January 16, 2014 3:56 PM > To: James Bottomley > Cc: linux-scsi@vger.kernel.org; Hannes Reinecke; Desai, Kashyap; Adam > Radford > Subject: [PATCH 6/6] megaraid_sas: check return value for

RE: [PATCH 4/6] megaraid_sas: catch errors from megasas_get_map_info()

2014-01-24 Thread Desai, Kashyap
Hannes, This patch really not required, since MR controller can still operate even if ld map info is failed. We just disable Fast Path IO if LD map info is failed, so we can still continue without ld map. This patch is not required for megaraid_sas driver. ` Kashyap > -Original Message--

RE: [PATCH 1/6] megaraid_sas: Do not wait forever

2014-01-24 Thread Desai, Kashyap
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Friday, January 24, 2014 1:54 PM > To: Desai, Kashyap; James Bottomley > Cc: linux-scsi@vger.kernel.org; Adam Radford; Saxena, Sumit > Subject: Re: [PATCH 1/6] megaraid_sas: Do not wait forever > > On 01/24/2014 0

Re: [PATCH 1/6] megaraid_sas: Do not wait forever

2014-01-24 Thread Hannes Reinecke
On 01/24/2014 08:46 AM, Desai, Kashyap wrote: > Hannes: > > We have already worked on "wait_event" usage in "megasas_issue_blocked_cmd". > That code will be posted by LSI once we received test result from LSI Q/A team. > > If you see the current OCR code in Linux Driver we do "re-send the IOCTL