Re: [PATCH 02/14] target: Add DIF CHECK_CONDITION ASC/ASCQ exception cases

On 1/10/2014 8:53 AM, Nicholas A. Bellinger wrote: On Thu, 2014-01-09 at 12:43 +0200, Sagi Grimberg wrote: On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger This patch adds support for DIF related CHECK_CONDITION ASC/ASCQ exception cases into transport_send_check_con

Re: [PATCH] qla2xxx: Enhancements to enable NPIV support for QLOGIC ISPs with TCM/LIO.

Hey Saurav & Co, Another quick question.. So I'm trying to configure a QLogic Sanbox 5600 switch to test the NPIV target related code.. However, I'm currently running into failures during qla_mid.c:qla24xx_vport_create_req_sanity_check() at the point where the switch is checked for NPIV support,

Re: [PATCH] qla2xxx: Enhancements to enable NPIV support for QLOGIC ISPs with TCM/LIO.

Hi Saurav & Co, Thanks for posting, and apologies for the slight delay. Comments are below. On Thu, 2014-01-09 at 15:13 -0500, Saurav Kashyap wrote: > Signed-off-by: Sawan Chandak > Signed-off-by: Quinn Tran > Signed-off-by: Saurav Kashyap > --- > drivers/scsi/qla2xxx/qla_attr.c|2 +

Re: [PATCH/RESEND v2 0/2] Hard disk S3 resume time optimization

On Tue, Jan 7, 2014 at 4:55 PM, Todd E Brandt wrote: > > This patch reduces S3 resume time from 10+ seconds to less than a second > on systems with SATA drives. It does this by making ata port and scsi disk > resume non-blocking. > > This is another resend of the patch I send out in early December

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

On Mon, Jan 13, 2014 at 3:51 PM, Todd E Brandt wrote: > On Mon, Jan 13, 2014 at 12:37:01PM -0800, Dan Williams wrote: >> On Mon, Jan 13, 2014 at 12:06 PM, Todd E Brandt >> > Actually there's one other reason. In the ata_port_request_pm function it >> > checks to see if there's a previous resume op

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

On Mon, Jan 13, 2014 at 12:37:01PM -0800, Dan Williams wrote: > On Mon, Jan 13, 2014 at 12:06 PM, Todd E Brandt > wrote: > > On Fri, Jan 10, 2014 at 07:13:11PM -0800, Dan Williams wrote: > >> On Fri, Jan 10, 2014 at 6:13 PM, Phillip Susi wrote: > >> > -BEGIN PGP SIGNED MESSAGE- > >> > Has

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst [NEW HARDWARE]

On 01/09/2014 03:50 PM, Sarah Sharp wrote: >>> On Tue, Jan 07, 2014 at 03:57:00PM -0800, walt wrote: >> >> I've wondered if my xhci problems might be caused by hardware quirks, and >> wondering why I seem to be the only one who has this problem. >> >> Maybe I could "take one for the team" by buyin

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

On Mon, Jan 13, 2014 at 03:30:07PM -0500, Tejun Heo wrote: > Hello, > > On Mon, Jan 13, 2014 at 11:55:44AM -0800, Todd E Brandt wrote: > > I see your point, why have two paths if one will do. The only thing that > > worries me is that the PM resume from hibernate function doesn't have > > an error

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

On Mon, Jan 13, 2014 at 12:06 PM, Todd E Brandt wrote: > On Fri, Jan 10, 2014 at 07:13:11PM -0800, Dan Williams wrote: >> On Fri, Jan 10, 2014 at 6:13 PM, Phillip Susi wrote: >> > -BEGIN PGP SIGNED MESSAGE- >> > Hash: SHA512 >> > >> > On 01/10/2014 06:11 PM, Brandt, Todd E wrote: >> >> Ye

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

Hello, On Mon, Jan 13, 2014 at 11:55:44AM -0800, Todd E Brandt wrote: > I see your point, why have two paths if one will do. The only thing that > worries me is that the PM resume from hibernate function doesn't have > an error handler. What happens when it tries to read the image from swap > and

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

> "James" == James Bottomley writes: James> I'm intrigued by this: how do you get the extra space, since I James> heard all the drive vendors were adamant that 520 was it for the James> current manufacturing processes. Well, you've been able to get 528-byte sector drives for a long time. The

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

On Mon, 2014-01-13 at 15:19 -0500, Martin K. Petersen wrote: > > "nab" == Nicholas A Bellinger writes: > > >> What proposed 16 byte scheme? The only DIF proposals I know for > >> SBC-4 are 13-185R0 and 12-369R0 and that's a couple of new algorithms > >> and types because we cannot change the

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

> "nab" == Nicholas A Bellinger writes: >> What proposed 16 byte scheme? The only DIF proposals I know for >> SBC-4 are 13-185R0 and 12-369R0 and that's a couple of new algorithms >> and types because we cannot change the 8 byte PI. nab> Then I'm probably getting the SBC version wrong.. It

Re: [PATCH 14/14] tcm_loop: Enable DIF/DIX modes in SCSI host LLD

> "nab" == Nicholas A Bellinger writes: nab> Sure, this can be exposed at a tcm_loop configfs attribute that is nab> accessible after scsi_add_host() has been called, which I assume is nab> OK to do.. As long as it's set before we discover devices. -- Martin K. Petersen Oracle Linux E

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

On Fri, Jan 10, 2014 at 07:13:11PM -0800, Dan Williams wrote: > On Fri, Jan 10, 2014 at 6:13 PM, Phillip Susi wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA512 > > > > On 01/10/2014 06:11 PM, Brandt, Todd E wrote: > >> Yes yours is simpler, but it also opens a potential memory issue >

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

On Sat, Jan 11, 2014 at 02:13:15PM -0500, Tejun Heo wrote: > Hello, > > On Tue, Jan 07, 2014 at 04:56:07PM -0800, Todd E Brandt wrote: > > On resume, the ATA port driver currently waits until the AHCI controller > > finishes executing the port wakeup command. This patch changes the > > Is there a

Re: [PATCH 07/11] IB/isert: pass scatterlist instead of cmd to fast_reg_mr routine

On Thu, 2014-01-09 at 18:40 +0200, Sagi Grimberg wrote: > This routine may help for protection registration as well. > This patch does not change any functionality. > > Signed-off-by: Sagi Grimberg > --- > drivers/infiniband/ulp/isert/ib_isert.c | 28 > 1 files cha

Re: [PATCH 04/11] IB/isert: Move fastreg descriptor creation to a function

On Thu, 2014-01-09 at 18:40 +0200, Sagi Grimberg wrote: > This routine may be called both by fast registration > descriptors for data and for integrity buffers. > > This patch does not change any functionality. > > Signed-off-by: Sagi Grimberg > --- > drivers/infiniband/ulp/isert/ib_isert.c |

Re: [PATCH 03/11] IB/isert: Avoid frwr notation, user fastreg

On Thu, 2014-01-09 at 18:40 +0200, Sagi Grimberg wrote: > Use fast registration lingo. fast registration will > also incorporate signature/DIF registration. > > Signed-off-by: Sagi Grimberg > --- > drivers/infiniband/ulp/isert/ib_isert.c | 84 > --- > drivers/infin

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

On Mon, 2014-01-13 at 11:27 -0800, Nicholas A. Bellinger wrote: > On Mon, 2014-01-13 at 10:52 -0800, James Bottomley wrote: > > On Mon, 2014-01-13 at 10:30 -0800, Nicholas A. Bellinger wrote: > > > Hey MKP, > > > > > > On Fri, 2014-01-10 at 16:01 -0500, Martin K. Petersen wrote: > > > > > "nab

Re: [PATCH 02/11] IB/isert: seperate connection protection domains and dma MRs

Hi Sagi, On Thu, 2014-01-09 at 18:40 +0200, Sagi Grimberg wrote: > It is more correct to seperate connections protection domains > and dma_mr handles. protection information support requires to > do so. > > Signed-off-by: Sagi Grimberg > --- > drivers/infiniband/ulp/isert/ib_isert.c | 46 > +

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #40 from Tommy Apel --- Hello all, I've actually been playing around with this a bit more and found out that the PERR and SERR might only hide problem for a while, sustained load over longer periods (4-5 hours) will still unfold in a

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

On Mon, 2014-01-13 at 10:52 -0800, James Bottomley wrote: > On Mon, 2014-01-13 at 10:30 -0800, Nicholas A. Bellinger wrote: > > Hey MKP, > > > > On Fri, 2014-01-10 at 16:01 -0500, Martin K. Petersen wrote: > > > > "nab" == Nicholas A Bellinger writes: > > > > > > nab> This patch adds support

Re: [PATCH 03/14] target/sbc: Add sbc_check_prot + update sbc_parse_cdb for DIF

On Sun, 2014-01-12 at 13:59 +0200, Sagi Grimberg wrote: > On 1/10/2014 9:04 AM, Nicholas A. Bellinger wrote: > > On Thu, 2014-01-09 at 16:58 +0200, Sagi Grimberg wrote: > >> On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote: > >>> diff --git a/drivers/target/target_core_sbc.c > >>> b/drivers/ta

Re: [PATCH 13/14] target/rd: Add DIF protection into rd_execute_rw

On Sun, 2014-01-12 at 13:53 +0200, Sagi Grimberg wrote: > > > >> I wander how we can skip sbc_dif_verify_ if the transport already > >> offloaded DIF verify. > >> I think that the transport should signal the core layer that it is able > >> to offload DIF (ADD/STRIP/PASS/VERIFY), in which cas

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

On Mon, 2014-01-13 at 10:30 -0800, Nicholas A. Bellinger wrote: > Hey MKP, > > On Fri, 2014-01-10 at 16:01 -0500, Martin K. Petersen wrote: > > > "nab" == Nicholas A Bellinger writes: > > > > nab> This patch adds support for exposing DIF protection device > > nab> attributes via configfs. T

Re: [PATCH 14/14] tcm_loop: Enable DIF/DIX modes in SCSI host LLD

On Fri, 2014-01-10 at 16:09 -0500, Martin K. Petersen wrote: > > "nab" == Nicholas A Bellinger writes: > > nab> This patch updates tcm_loop_driver_probe() to set protection > nab> information using scsi_host_set_prot() and scsi_host_set_guard(), > nab> which currently enabled all modes of DIF

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

Hey MKP, On Fri, 2014-01-10 at 16:01 -0500, Martin K. Petersen wrote: > > "nab" == Nicholas A Bellinger writes: > > nab> This patch adds support for exposing DIF protection device > nab> attributes via configfs. This includes: > > nab>pi_prot_type: Protection Type (0, 1, 3 currently su

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #39 from Sreekanth Reddy --- I am on vacation till 17th Janury 2014. I will have limited access to emails during this time. For urgent issues, please contact my manager Krishna (krishnaraddi.mank...@lsi.com

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #38 from Jeff Johnson --- Apologies, I forgot to add important information.. I am not running a 3.x kernel, I am running a 2.6 kernel. It would appear that this problem is a hardware issue (LSI) and not a driver or kernel issue. I am

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #37 from Jeff Johnson --- I can confirm Tommy's observations about disabling PERR and SERR solving the issue. The motherboard I am using (Supermicro X8DTH-iF) does not have those exact BIOS settings to control. In my case the followin

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

Back to the original question, I don't think Sagi was asking if it was valid to do a legacy/unprotected READ, it was what to expect with a protected READ on unwritten blocks: > So this takes me to a corner I still don't understand, if > a LUN is pre-formatted as T10-protected, what happens to >

Re: [PATCH] gdth: Fixup section annotations

On Mon, 2014-01-13 at 09:23 +0100, Hannes Reinecke wrote: > On 01/10/2014 06:07 PM, James Bottomley wrote: > > On Fri, 2014-01-10 at 16:31 +0100, Hannes Reinecke wrote: > >> Fixup section annotations so that kbuild doesn't complain anymore. > > > > This doesn't look right: __devinit is now an obso

Re: [PATCH v8 3/4] ata: Add APM X-Gene SoC SATA host controller driver

Hello, Loc. On Sun, Jan 12, 2014 at 08:01:59PM -0800, Loc Ho wrote: > Yes but Let me summary what overrides are required for this X-Gene > SATA controller driver: > > 1. For Query ID, these two functions - ahci_read_id and ahci_qc_issue > requires override. But the comment in ahci_qc_issue() says

[PATCH v2] scsi_transport_srp: Fix kernel-doc warnings

The following command has been used to verify that the kernel-doc tool no longer complains about undocumented fields: scripts/kernel-doc -html drivers/scsi/scsi_transport_srp.c \ include/scsi/scsi_transport_srp.h >srp-transport-doc.html Signed-off-by: Bart Van Assche Acked-by: Sebastian Riemer

Re: [LSF/MM ATTEND] interest in blk-mq, scsi-mq, dm-cache, dm-thinp, dm-*

On 01/10/2014 07:27 PM, Mike Snitzer wrote: > I would like to attend to participate in discussions related to topics > listed in the subject. As a maintainer of DM I'd be interested to > learn/discuss areas that should become a development focus in the months > following LSF. > +1 I've been thin

Re: [PATCH 1/1] aacraid: kdump fix

On 01/13/2014 09:20 AM, Mahesh Rajashekhara wrote: > Thanks for your review comments, Tomas > > We have initialized var in this driver patch. This patch fixes kernel panic > issue while booting into the kdump kernel. > > We have triggered crash and kdump vmcore was successful. No issues seen while

[PATCH 1/1] aacraid: kdump fix

Thanks for your review comments, Tomas We have initialized var in this driver patch. This patch fixes kernel panic issue while booting into the kdump kernel. We have triggered crash and kdump vmcore was successful. No issues seen while booting into the OS. Signed-off-by: Mahesh Rajashekhara -

Re: [PATCH] gdth: Fixup section annotations

On 01/10/2014 06:07 PM, James Bottomley wrote: > On Fri, 2014-01-10 at 16:31 +0100, Hannes Reinecke wrote: >> Fixup section annotations so that kbuild doesn't complain anymore. > > This doesn't look right: __devinit is now an obsolete annotation. > Hmm. Patch has been in our internal kernel repos