Hi, Hannes:
I'm sorry that I don't know why you didn't consider my former patch
below which not only raises the minimum valid value of 'eh_deadline'
as '0' for your former patchset but also includes some fix for your
this patchset:
http://www.spinics.net/lists/linux-scsi/msg69361.html
If you th
On 11/01/2013 03:20 AM, Douglas Gilbert wrote:
> On 13-10-31 11:56 AM, Christoph Hellwig wrote:
>>> +struct semaphore or_sem; /* protect co-incident opens and
>>> releases */
>>
>> Seems like this should be a mutex.
>
> Yes, it is being used as a mutex. However looking at
> their semantics (mu
On 11/01/2013 03:20 AM, Douglas Gilbert wrote:
> On 13-10-31 11:56 AM, Christoph Hellwig wrote:
>>> +struct semaphore or_sem; /* protect co-incident opens and
>>> releases */
>>
>> Seems like this should be a mutex.
>
> Yes, it is being used as a mutex. However looking at
> their semantics (mu
On Wed, Oct 30, 2013 at 4:27 AM, Jiri Kosina wrote:
> Attached is dmesg output leading to timeouts (that are cured by my
> original patch in this thread) and lspci.
I opened https://bugzilla.kernel.org/show_bug.cgi?id=64141 for this
issue and attached your dmesg log and lspci output.
> Please le
On 13-10-31 11:56 AM, Christoph Hellwig wrote:
+ struct semaphore or_sem; /* protect co-incident opens and releases */
Seems like this should be a mutex.
Yes, it is being used as a mutex. However looking at
their semantics (mutex.h versus semaphore.h), a mutex
takes into account the ta
Hello dear!
Please kindly send us your contact infomations to our email: (dan.f...@aim.com)
to enable us send your voucher.
Kind regards
Daniel F
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
> + struct semaphore or_sem; /* protect co-incident opens and releases */
Seems like this should be a mutex.
> sfds_list_empty(Sg_device *sdp)
> {
> unsigned long flags;
> int ret;
>
> + spin_lock_irqsave(&sdp->sfd_lock, flags);
> + ret = list_empty(&sdp->sfds);
> +
Looks reasonable to me, but a few minor nitpicks:
> + spin_lock_irqsave(sdev->host->host_lock, flags);
> + if (scsi_host_eh_past_deadline(sdev->host)) {
I don't have the implementation of scsi_host_eh_past_deadline in my
local tree, but do we really need the host lock for it?
> +int
> +s
On Thu, Oct 31, 2013 at 09:46:40AM -0200, Mauro Carvalho Chehab wrote:
> Hi Russell,
>
> Em Mon, 30 Sep 2013 13:57:47 +0200
> Hans Verkuil escreveu:
>
> > On 09/19/2013 11:44 PM, Russell King wrote:
> > > Replace the following sequence:
> > >
> > > dma_set_mask(dev, mask);
> > > dma_set_coh
The blk-core dead queue checks introduce an error scenario to
blk_get_request that returns NULL if the request queue has been
shutdown. This affects the behavior for __GFP_WAIT callers, who should
verify the return value before dereferencing.
Signed-off-by: Joe Lawrence
---
block/scsi_ioctl.c
This is a patchset rebased to the latest Jens linux-block tree,
for-3.13/core branch to 1) protect blk_get_request __GFP_WAIT callers
from dead queues and then 2) convert blk_get_request to return ERR_PTR
to distinguish between dead queues and low-memory scenarios [1]. A
similar bug report appeare
The blk_get_request function may fail in low-memory conditions or during
device removal (even if __GFP_WAIT is set). To distinguish between these
errors, modify the blk_get_request call stack to return the appropriate
ERR_PTR. Verify that all callers check the return status and consider
IS_ERR inst
ChangeLog:
- update sg MAINTAINERS file entry: web site and documentation
entry
Signed-off-by: Douglas Gilbert
diff --git a/MAINTAINERS b/MAINTAINERS
index a7c34ef..472b0c6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7316,8 +7316,9 @@ F: include/scsi/srp.h
SCSI SG DRIVER
M: Doug Gilbe
When a command runs into a timeout we need to send an 'ABORT TASK'
TMF. This is typically done by the 'eh_abort_handler' LLDD callback.
Conceptually, however, this function is a normal SCSI command, so
there is no need to enter the error handler.
This patch implements a new scsi_abort_command() f
Hi all,
this patchset implements a new SCSI EH command timeout handler
which will be sending command aborts inline without actually
engaging SCSI EH.
SCSI EH will only be invoked if command abort fails.
In addition the commands will be returned directly
if the command abort succeeded, cutting dow
From: James Bottomley
Commit 18a4d0a22ed6c54b67af7718c305cd010f09ddf8
(Handle disk devices which can not process medium access commands)
was introduced to offline any device which cannot process medium
access commands.
However, commit 3eef6257de48ff84a5d98ca533685df8a3beaeb8
(Reduce error recover
The documentation has gone out-of-sync, so update it to
the current status.
Signed-off-by: Hannes Reinecke
---
Documentation/scsi/scsi_eh.txt | 69 +++--
Documentation/scsi/scsi_mid_low_api.txt | 9 -
drivers/scsi/scsi.c | 6 +--
3 f
Hi Russell,
Em Mon, 30 Sep 2013 13:57:47 +0200
Hans Verkuil escreveu:
> On 09/19/2013 11:44 PM, Russell King wrote:
> > Replace the following sequence:
> >
> > dma_set_mask(dev, mask);
> > dma_set_coherent_mask(dev, mask);
> >
> > with a call to the new helper dma_set_mask_and_coherent
On Thu, Oct 31, 2013 at 02:01:02PM +0530, Mahesh Rajashekhara wrote:
> It appears that driver runs into a problem here if fibsize is too small
> because we allocate user_srbcmd with fibsize size only but later we access it
> until user_srbcmd->sg.count to copy it over to srbcmd. Seems to be not
It appears that driver runs into a problem here if fibsize is too small because
we allocate user_srbcmd with fibsize size only but later we access it until
user_srbcmd->sg.count to copy it over to srbcmd. Seems to be not correct to
test (fibsize < sizeof(*user_srbcmd)) because this structure alr
20 matches
Mail list logo
