On Sat, 2013-08-31 at 21:40 +0530, Santosh Y wrote:
> From: Seungwon Jeon
>
> 'drivers/scsi/ufs/unipro.h' is added.
> Attributes in the layers of the UNIPRO stack can be
> read and written via the DME.
A dangling unused header file is a bit of a strange commit. I merged it
into the next one whi
On Fri, 2013-09-06 at 20:51 +, Hiral Patel (hiralpat) wrote:
> Hi James,
>
> Yes for this patch Narsimhulu Musini is the author of this patch.
>
> Thanks,
> Hiral
>
> On 9/6/13 10:35 AM, "James Bottomley"
> wrote:
>
> >On Thu, 2013-08-29 at 10:57 -0700, Hiral Patel wrote:
> >> Code to rese
On Fri, Sep 6, 2013 at 3:51 AM, Jiri Kosina wrote:
> On Wed, 28 Aug 2013, Bjorn Helgaas wrote:
>
>> [+cc another email addr for Adam from git logs]
>
> Thanks. Adam, would you happen to have any possible explanation /
> background?
>
>> >> > Commit d5dea7d95 ("PCI: msi: Disable msi interrupts when
On Fri, Sep 06, 2013 at 06:54:48PM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Thursday, September 05, 2013 05:38:53 PM Todd E Brandt wrote:
> > This is the final draft of the non-blocking hard disk resume patch. I've
> > included some performance results to demonstrate the real benefi
On 9/6/13, James Bottomley wrote:
> Checkpatch doesn't like this. It thinks (correctly) that these should
> all be in megaraid_sas.h so we can't get the prototype different from
> the actual function without some type of warning. Can you move them,
> please?
James,
Corrected patch is in-line b
Sorry for the missing description, I've submitted it several times so I
just assumed that the previous entries in the thread were enough. I'll
resubmit with a full description.
As for replacing sd_resume altogether, the reason I didn't is because
there are three callbacks which use sd_resume. I've
I'll fix those, thanks for the feedback.
On Fri, Sep 06, 2013 at 04:37:00PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 06-09-2013 4:44, Todd E Brandt wrote:
>
> >Part 2 of the hard disk resume optimization patch, this one applies
> >to the scsi subsystem.
>
>Don't give the same name to
On Thu, Sep 05, 2013 at 03:55:25PM +0800, Yijing Wang wrote:
> v1->v2: use pcie_get/set_readrq to simplify code
> a lot suggestd by Bjorn.
>
> Use pcie_get_readrq()/pcie_set_readrq() to simplify
> code.
>
> Signed-off-by: Yijing Wang
> Cc: Jiang Liu
> Cc: Anil Gurumurthy
> Cc: Vijaya Mohan Guv
I'll resubmit with a better description. As for the return value, if you look
at the mailing list history you'll see that I already tried that approach (and
was actually advised to do it this way):
http://marc.info/?l=linux-scsi&m=136881989601276&w=2
On Fri, Sep 06, 2013 at 07:03:26PM +0200, Bar
The blk-core dead queue checks introduce an error scenario to
blk_get_request that returns NULL if the request queue has been
shutdown. This affects the behavior for __GFP_WAIT callers, who should
verify the return value before dereferencing.
Signed-off-by: Joe Lawrence
Cc: Jens Axboe
Cc: Jiri K
The blk_get_request function may fail in low-memory conditions or during
device removal (even if __GFP_WAIT is set). To distinguish between these
errors, modify the blk_get_request call stack to return the appropriate
ERR_PTR. Verify that all callers check the return status and consider
IS_ERR inst
Hi Jens, James,
This is a resend of a patchset to 1) protect blk_get_request __GFP_WAIT
callers from dead queues and then 2) convert blk_get_request to return
ERR_PTR to distinguish between dead queues and low-memory scenarios. [1]
A similar bug report appeared on LKML in June [2], (although I don
Hi James,
Yes for this patch Narsimhulu Musini is the author of this patch.
Thanks,
Hiral
On 9/6/13 10:35 AM, "James Bottomley"
wrote:
>On Thu, 2013-08-29 at 10:57 -0700, Hiral Patel wrote:
>> Code to reset fc_host statistics.
>> echo 1 > /sys/class/fc_host/hostX/statistics/reset_statistics cl
On Tue, 2013-09-03 at 10:04 +1000, Anton Blanchard wrote:
> The hypervisor is big endian, so little endian kernel builds need
> to byteswap.
>
> Signed-off-by: Anton Blanchard
You have two serious checkpatch errors in this:
ERROR: trailing whitespace
#57: FILE: drivers/scsi/ibmvscsi/ibmvscs
On 9/6/2013 11:22 AM, James Smart wrote:
> Fixed issue of task management commands having a fixed timeout
I'm surprised about this change, since it appears a number of issues in
the
send_taskmgmt() still exist that keep it from handling task management
failures correctly. It also continue
On Sat, 2013-08-31 at 16:54 -0700, adam radford wrote:
> --- scsi-misc.old/drivers/scsi/megaraid/megaraid_sas_fusion.c
> 2013-08-31 16:17:56.909172648 -0700
> +++ scsi-misc.new/drivers/scsi/megaraid/megaraid_sas_fusion.c
> 2013-08-31 16:24:51.861078589 -0700
> @@ -77,9 +77,12 @@
> MR_BuildRaidCont
On Thu, 2013-08-29 at 15:55 -0400, Bradley Grove wrote:
> Signed-off-by: Bradley Grove
This additional SCSI: in the subject is unnecessary and just causes me
extra work to remove it.
There should be a Reported-by: before the signoff indicating whoever you
got the report from (it's about the only
On Thu, Sep 5, 2013 at 12:55 AM, Yijing Wang wrote:
> v1->v2: use pcie_get/set_readrq to simplify code
> a lot suggestd by Bjorn.
>
> Use pcie_get_readrq()/pcie_set_readrq() to simplify
> code.
Very similar to a patch I sent out in 2011
http://www.spinics.net/lists/linux-scsi/msg52990.html
Hopef
On Thu, 2013-08-29 at 10:57 -0700, Hiral Patel wrote:
> Code to reset fc_host statistics.
> echo 1 > /sys/class/fc_host/hostX/statistics/reset_statistics clears fc_host
> stats,
> the code also issues command to fnic firmware to clear vnic stats.
>
> Signed-off-by: Narsimhulu Musini
> Signed-off
Sorry, I said I was going to push this through my PCI tree, but I
forgot all about it. I put it (finally) in my pci/misc branch, and
will merge it during the v3.13 merge window.
On Fri, Jan 4, 2013 at 12:31 PM, Bjorn Helgaas wrote:
> I haven't heard anything, so I'm going to push this through th
Hi,
On Thursday, September 05, 2013 05:38:53 PM Todd E Brandt wrote:
> This is the final draft of the non-blocking hard disk resume patch. I've
> included some performance results to demonstrate the real benefits
> of this patch. Please note that this patch provides a MASSIVE performance
> improv
Hi,
On Thursday, September 05, 2013 05:44:25 PM Todd E Brandt wrote:
> Part 2 of the hard disk resume optimization patch, this one applies
> to the scsi subsystem.
Please update the patch description to say what the patch does (and why).
> Signed-off-by: Todd Brandt
> Signed-off-by: Arjan van
Il 06/09/2013 17:49, Alan Stern ha scritto:
> This patch fixes an out-of-bounds error in sd_read_cache_type(), found
> by Google's AddressSanitizer tool. When the loop ends, we know that
> "offset" lies beyond the end of the data in the buffer, so no Caching
> mode page was found. In theory it ma
Fixed function mode field defined too small for not recognizing dual-chute mode
Signed-off-by: James Smart
---
lpfc_sli4.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -upNr a/drivers/scsi/lpfc/lpfc_sli4.h b/drivers/scsi/lpfc/lpfc_sli4.h
--- a/drivers/scsi/lpfc/lpfc_sli4.h
On Fri, 6 Sep 2013, James Bottomley wrote:
> > layer runtime PM. Accordingly, the SCSI bus layer runtime PM callback is
> > simplified as all SCSI devices that implement runtime PM are now request
> > based.
>
> OK, let's now try for a descriptive changelog. All SCSI devices
> (including sr) are
This patch fixes an out-of-bounds error in sd_read_cache_type(), found
by Google's AddressSanitizer tool. When the loop ends, we know that
"offset" lies beyond the end of the data in the buffer, so no Caching
mode page was found. In theory it may be present, but the buffer size
is limited to 512
Fixed issue of task management commands having a fixed timeout
Signed-off-by: James Smart
---
lpfc.h |1 +
lpfc_attr.c |8
lpfc_scsi.c |2 +-
3 files changed, 10 insertions(+), 1 deletion(-)
diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.
Fixed back to back RSCNs discovery failure.
Signed-off-by: James Smart
---
lpfc_hbadisc.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff -upNr a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
--- a/drivers/scsi/lpfc/lpfc_hbadisc.c 2013-09-06 10
Back out data count,(residual fcfi_parm) fix for bad target.
Signed-off-by: James Smart
---
lpfc_scsi.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
--- a/drivers/scsi/lpfc/lpfc_scsi.c 2013-09-
Update lpfc version to driver version 8.3.42
Signed-off-by: James Smart
---
lpfc_version.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -upNr a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h
--- a/drivers/scsi/lpfc/lpfc_version.h 2013-09-04 13:18:04.0
Fixed not able to log informational messages at early stage of driver init time
Signed-off-by: James Smart
---
lpfc_init.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff -upNr a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
--- a/drivers/scsi/lpfc
Fix WARN_ON when driver unloads
Signed-off-by: James Smart
---
lpfc_init.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff -upNr a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
--- a/drivers/scsi/lpfc/lpfc_init.c 2013-09-06 10:04:23.071058739 -04
Fixed using unsafe linked list macro for walking and deleting linked list
Signed-off-by: James Smart
---
lpfc_bsg.c |4 ++--
lpfc_sli.c |5 +++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff -upNr a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
--- a/drivers/
Fixed driver iocbq structure's iocb_flag field running out of space
Signed-off-by: James Smart
---
lpfc_bsg.c | 14 +++---
lpfc_sli.h |5 ++---
2 files changed, 9 insertions(+), 10 deletions(-)
diff -upNr a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
--- a/dri
Fix ramdom errors using first burst
Signed-off-by: James Smart
---
lpfc_scsi.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
--- a/drivers/scsi/lpfc/lpfc_scsi.c 2013-09-04 13:18:04.0
Avoided making pci bar ioremap call during dual-chute WQ/RQ pci bar selection
Signed-off-by: James Smart
---
lpfc_init.c | 34 --
lpfc_sli.c | 16
2 files changed, 12 insertions(+), 38 deletions(-)
diff -upNr a/drivers/scsi/lpfc/lpfc_in
Fixed failure to allocate SCSI buffer on PPC64 platform for SLI4 devices
Signed-off-by: James Smart
---
lpfc_scsi.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
--- a/drivers/scsi/lpfc/lpfc_scsi
Fix driver's abort loop functionality to skip IOs already getting aborted
Signed-off-by: James Smart
---
lpfc_scsi.c |3 +++
lpfc_sli.c | 12 +++-
2 files changed, 14 insertions(+), 1 deletion(-)
diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
---
Fixed race condition between BSG I/O dispatch and timeout handling
Signed-off-by: James Smart
---
lpfc_bsg.c | 86 +
lpfc_sli.h |3 +-
2 files changed, 72 insertions(+), 17 deletions(-)
diff -upNr a/drivers/scsi/lpfc/lpfc_bs
Fixed inconsistent spin lock usage.
Signed-off-by: James Smart
---
lpfc_init.c |8
lpfc_scsi.c | 26 --
2 files changed, 16 insertions(+), 18 deletions(-)
diff -upNr a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
--- a/drivers/scsi/l
Fixed logging format of setting driver sysfs attributes hard to interpret
Signed-off-by: James Smart
---
lpfc_attr.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
--- a/drivers/scsi/lpfc/lpfc_attr.c
Fix crash on driver load due to cpu affinity logic
Signed-off-by: James Smart
---
lpfc_attr.c |5 -
lpfc_init.c | 28 +++-
2 files changed, 27 insertions(+), 6 deletions(-)
diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
--- a/dr
Fixed mailbox memory leak.
Signed-off-by: James Smart
---
lpfc_hbadisc.c |1 +
1 file changed, 1 insertion(+)
diff -upNr a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
--- a/drivers/scsi/lpfc/lpfc_hbadisc.c 2013-09-04 13:18:04.0 -0400
+++ b/drivers/scsi/
This patch set updates the lpfc driver to revision 8.3.42
The patches for 8.3.42 contain:
- Fixed using unsafe linked list macro for walking and deleting linked list
- Fixed not able to log informational messages at early stage of driver init
time
- Fix ramdom errors using first burst
- Fixed ma
On Fri, 2013-09-06 at 10:01 +0800, Aaron Lu wrote:
> Migrate SCSI Optical Disk Drive(ODD)
I'm not very keen on this description because it's not quite accurate.
sr stands for SCSI ROM. You could say optical SCSI ROM perhaps, but
Magneto Optical disks are handled by sd not sr.
> driver sr to mak
On Thu, 2013-09-05 at 17:44 -0700, Todd E Brandt wrote:
> Part 2 of the hard disk resume optimization patch, this one applies
> to the scsi subsystem.
This is a horrible patch description, it won't tell the next reader
anything about what is going on and why. Give the patches two separate
summari
On Fri, 6 Sep 2013, Aaron Lu wrote:
> Migrate SCSI Optical Disk Drive(ODD) driver sr to make use of block
> layer runtime PM. Accordingly, the SCSI bus layer runtime PM callback is
> simplified as all SCSI devices that implement runtime PM are now request
> based.
>
> Note that due to ODD will be
Hello.
On 06-09-2013 4:44, Todd E Brandt wrote:
Part 2 of the hard disk resume optimization patch, this one applies
to the scsi subsystem.
Don't give the same name to both patches. In this case, you could prefix
the patch name with e.g. "sd: ".
Signed-off-by: Todd Brandt
Signed-off-by
On Wed, 28 Aug 2013, Bjorn Helgaas wrote:
> [+cc another email addr for Adam from git logs]
Thanks. Adam, would you happen to have any possible explanation /
background?
> >> > Commit d5dea7d95 ("PCI: msi: Disable msi interrupts when we initialize a
> >> > pci device") makes MSIs be forcibly di
49 matches
Mail list logo
