Re: [RFC][PATCH] Add a flight data recorder for scsi commands

2013-08-27 Thread Nicholas A. Bellinger
On Tue, 2013-08-27 at 18:17 -0400, Jörn Engel wrote: > Here is a fun patch in an early state. Essentially I want to trace > scsi commands, which has already been done long ago. The problem I > have is that I care about all the scsi commands for one particular > device - without knowing in advance

RE: [PATCH 00/29] Update driver to 8.06.00.08-k

2013-08-27 Thread Saurav Kashyap
HI James, There is some issue with an exchange server and this particular patch is not going out. Please find the patch inline and attached with this email. Thanks, ~Saurav From: Joe Carnuccio Date: Fri, 23 Aug 2013 07:25:37 -0700 Subject: [PATCH 26/29] qla2xxx: Correctly print out/in mailbox

Re: [PATCH v5 1/4] [SCSI] sg: use rwsem to solve race during exclusive open

2013-08-27 Thread James Bottomley
On Mon, 2013-07-22 at 12:40 +0800, Vaughan Cao wrote: > A race condition may happen if two threads are both trying to open the same sg > with O_EXCL simultaneously. It's possible that they both find fsds list is > empty and get_exclude(sdp) returns 0, then they both call set_exclude() and > break o

Re: [PATCH 00/29] Update driver to 8.06.00.08-k

2013-08-27 Thread James Bottomley
On Tue, 2013-08-27 at 01:37 -0400, Saurav Kashyap wrote: > Hi James, > > Please apply the following patches to the scsi tree, misc branch at your > earliest convenience. Patch 26/29 is missing. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a messa

Re: [PATCH v5 0/4] [SCSI] sg: fix race condition in sg_open

2013-08-27 Thread vaughan
On 08/27/2013 09:13 PM, Douglas Gilbert wrote: > On 13-08-27 10:16 AM, vaughan wrote: >> On 08/13/2013 11:16 AM, Douglas Gilbert wrote: >>> On 13-08-12 10:46 PM, vaughan wrote: On 08/06/2013 04:52 AM, Douglas Gilbert wrote: > On 13-08-04 10:19 PM, vaughan wrote: >> On 08/03/2013 01:25

Re: [RFC][PATCH] Add a flight data recorder for scsi commands

2013-08-27 Thread Steven Rostedt
On Tue, 27 Aug 2013 18:41:47 -0400 Jörn Engel wrote: > On Tue, 27 August 2013 19:54:22 -0400, Steven Rostedt wrote: > > On Tue, 27 Aug 2013 18:03:25 -0400 > > Jörn Engel wrote: > > > > > Here is a fun patch in an early state. Essentially I want to trace > > > scsi commands, which has already b

Re: [RFC][PATCH] Add a flight data recorder for scsi commands

2013-08-27 Thread Jörn Engel
On Tue, 27 August 2013 19:54:22 -0400, Steven Rostedt wrote: > On Tue, 27 Aug 2013 18:03:25 -0400 > Jörn Engel wrote: > > > Here is a fun patch in an early state. Essentially I want to trace > > scsi commands, which has already been done long ago. The problem I > > have is that I care about all

Re: [RFC][PATCH] Add a flight data recorder for scsi commands

2013-08-27 Thread Steven Rostedt
On Tue, 27 Aug 2013 18:03:25 -0400 Jörn Engel wrote: > Here is a fun patch in an early state. Essentially I want to trace > scsi commands, which has already been done long ago. The problem I > have is that I care about all the scsi commands for one particular > device - without knowing in advan

[RFC][PATCH] Add a flight data recorder for scsi commands

2013-08-27 Thread Jörn Engel
Here is a fun patch in an early state. Essentially I want to trace scsi commands, which has already been done long ago. The problem I have is that I care about all the scsi commands for one particular device - without knowing in advance which device it will be. Once I know the device in question

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-08-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #22 from livea...@live.com --- Hi . Thank you Hannes very much for the patch . I compiled it inside a 3.11-rc7 , and put "mpt2sas.disable_watchdog=1" in the boot parameters . It helped the driver to survive longer -around an hour long

RE: [PATCH v3 2/2] Hard disk S3 resume time optimization

2013-08-27 Thread Brandt, Todd E
All the same checks are preserved, including the manage_start_stop check: + if (!sdkp->device->manage_start_stop) + goto error; That function is just a simplified version of sd_start_stop_device but with only the start functionality used. -Original Message- From: Oli

Re: [patch|rfc] block: fix race between request completion and timeout handling

2013-08-27 Thread Hannes Reinecke
On 08/27/2013 04:28 PM, Jeff Moyer wrote: > Hi, > > We have several reports (against a distro kernel) of panics in > blk_requeue_request that look like this: > > kernel BUG at block/blk-core.c:1045! > invalid opcode: [#1] SMP > last sysfs file: > /sys/devices/pci:40/:40:03.0/:55

[PATCH v3 2/2] Hard disk S3 resume time optimization

2013-08-27 Thread Brandt, Todd E
This is v3 of the non-blocking S3 resume patch. It's been broken into two pieces, this part is for the scsi subsystem. I've addressed Alan Stern's comments in particular by reformatting the call to conform to the proper style guidelines. Note - the two patches will function separately but both ar

[PATCH v3 1/2] Hard disk S3 resume time optimization

2013-08-27 Thread Brandt, Todd E
This is v3 of the non-blocking S3 resume patch. It's been broken into two pieces, this part is for the ata subsystem. I've addressed Oliver Neukum's comments in particular by removing any potential race conditions. In the previous version I used the ata_port_request_pm function to handle the ca

[patch|rfc] block: fix race between request completion and timeout handling

2013-08-27 Thread Jeff Moyer
Hi, We have several reports (against a distro kernel) of panics in blk_requeue_request that look like this: kernel BUG at block/blk-core.c:1045! invalid opcode: [#1] SMP last sysfs file: /sys/devices/pci:40/:40:03.0/:55:00.0/infiniband_mad/umad0/port CPU 0 Modules linked in: ipm

Re: [PATCH v5 0/4] [SCSI] sg: fix race condition in sg_open

2013-08-27 Thread Douglas Gilbert
On 13-08-27 10:16 AM, vaughan wrote: On 08/13/2013 11:16 AM, Douglas Gilbert wrote: On 13-08-12 10:46 PM, vaughan wrote: On 08/06/2013 04:52 AM, Douglas Gilbert wrote: On 13-08-04 10:19 PM, vaughan wrote: On 08/03/2013 01:25 PM, Douglas Gilbert wrote: On 13-08-01 01:01 AM, Douglas Gilbert wr

RE: [PATCH 1/7] qla4xxx: Allow removal of failed session using logout.

2013-08-27 Thread Adheer Chandravanshi
James, Thanks for pointing this out. We will send the fix for this in the next patch-set. -- Adheer > -Original Message- > From: James Bottomley [mailto:jbottom...@parallels.com] > Sent: Saturday, August 24, 2013 1:03 AM > To: Adheer Chandravanshi > Cc: micha...@cs.wisc.edu; linux-scsi;

RE: [PATCH v3 5/6] scsi: ufs: add operation for the uic power mode change

2013-08-27 Thread Seungwon Jeon
On Tue, August 27, 2013, Subhash Jadavani wrote: > On 8/27/2013 4:58 PM, Seungwon Jeon wrote: > > On Tue, August 27, 2013, Subhash Jadavani wrote: > >> On 8/26/2013 8:10 PM, Seungwon Jeon wrote: > >>> Setting PA_PWRMode using DME_SET triggers the power mode > >>> change. And then the result will be

Re: [PATCH v3 5/6] scsi: ufs: add operation for the uic power mode change

2013-08-27 Thread Subhash Jadavani
On 8/27/2013 4:58 PM, Seungwon Jeon wrote: On Tue, August 27, 2013, Subhash Jadavani wrote: On 8/26/2013 8:10 PM, Seungwon Jeon wrote: Setting PA_PWRMode using DME_SET triggers the power mode change. And then the result will be given by the HCS.UPMCRS. This operation should be done atomically.

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-08-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #21 from Hannes Reinecke --- Try with this patch. With a bit of luck it's just the firmware becoming sluggish under high load, so disabling the watchdog will be circumvent this. And any real error would still be handled by SCSI EH. Ke

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-08-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 Hannes Reinecke changed: What|Removed |Added CC||h...@suse.de --- Comment #20 from Hanne

RE: [PATCH v3 5/6] scsi: ufs: add operation for the uic power mode change

2013-08-27 Thread Seungwon Jeon
On Tue, August 27, 2013, Subhash Jadavani wrote: > On 8/26/2013 8:10 PM, Seungwon Jeon wrote: > > Setting PA_PWRMode using DME_SET triggers the power mode > > change. And then the result will be given by the HCS.UPMCRS. > > This operation should be done atomically. > > > > Signed-off-by: Seungwon J

Re: [PATCH v3 6/6] scsi: ufs: configure the attribute for power mode

2013-08-27 Thread Subhash Jadavani
On 8/27/2013 3:51 PM, Subhash Jadavani wrote: On 8/26/2013 8:11 PM, Seungwon Jeon wrote: UIC attributes can be set with using DME_SET command for power mode change. For configuration the link capability attributes are used, which is updated after successful link startup. Signed-off-by: Seungwon

Re: [PATCH v3 6/6] scsi: ufs: configure the attribute for power mode

2013-08-27 Thread Subhash Jadavani
On 8/26/2013 8:11 PM, Seungwon Jeon wrote: UIC attributes can be set with using DME_SET command for power mode change. For configuration the link capability attributes are used, which is updated after successful link startup. Signed-off-by: Seungwon Jeon Reviewed-by: Subhash Jadavani --- dri

Re: [PATCH v3 5/6] scsi: ufs: add operation for the uic power mode change

2013-08-27 Thread Subhash Jadavani
On 8/26/2013 8:10 PM, Seungwon Jeon wrote: Setting PA_PWRMode using DME_SET triggers the power mode change. And then the result will be given by the HCS.UPMCRS. This operation should be done atomically. Signed-off-by: Seungwon Jeon --- drivers/scsi/ufs/ufshcd.c | 84

Re: [PATCH] PCI: add quirk for 3ware 9650SE controller

2013-08-27 Thread Jiri Kosina
[ adding Bjorn and Eric to CC, sorry for omitting you originally ] On Tue, 27 Aug 2013, Jiri Kosina wrote: > Commit d5dea7d95 ("PCI: msi: Disable msi interrupts when we initialize a > pci device") makes MSIs be forcibly disabled at boot time. > > It turns out that this breaks 3ware controller

[PATCH] PCI: add quirk for 3ware 9650SE controller

2013-08-27 Thread Jiri Kosina
Commit d5dea7d95 ("PCI: msi: Disable msi interrupts when we initialize a pci device") makes MSIs be forcibly disabled at boot time. It turns out that this breaks 3ware controller -- if MSIs are disabled during PCI discovery of this controller, the device doesn't work properly (it doesn't respon

Re: [PATCH v3 3/6] scsi: ufs: add dme configuration primitives

2013-08-27 Thread Subhash Jadavani
Looks good to me. Reviewed-by: Subhash Jadavani On 8/26/2013 8:10 PM, Seungwon Jeon wrote: Implements to support GET and SET operations of the DME. These operations are used to configure the behavior of the UNIPRO. Along with basic operation, {Peer/AttrSetType} can be mixed. Signed-off-by: Se

Re: [PATCH v3 4/6] scsi: ufs: add unipro attribute IDs

2013-08-27 Thread Subhash Jadavani
Looks good to me. Reviewed-by: Subhash Jadavani On 8/26/2013 8:10 PM, Seungwon Jeon wrote: 'drivers/scsi/ufs/unipro.h' is added. Attributes in the layers of the UNIPRO stack can be read and written via the DME. Signed-off-by: Seungwon Jeon Reviewed-by: Subhash Jadavani --- drivers/scsi/uf

Re: [PATCH v3 2/6] scsi: ufs: fix the setting interrupt aggregation counter

2013-08-27 Thread Subhash Jadavani
Looks good to me. Reviewed-by: Subhash Jadavani On 8/26/2013 8:10 PM, Seungwon Jeon wrote: IACTH(Interrupt aggregation counter threshold) value is allowed up to 0x1F and current setting value is the maximum. This value is related with NUTRS(max:0x20) of HCI's capability. Considering HCI contro

Re: [PATCH] scsi: ufs: read door bell register after clearing interrupt aggregation

2013-08-27 Thread Subhash Jadavani
On 8/27/2013 1:50 PM, Subhash Jadavani wrote: Looks good to me. Reviewed-by: Subhash Jadavani On 8/25/2013 4:06 PM, Dolev Raviv wrote: In interrupt context, after reading and comparing the UTRLDBR to hba->outstanding_request and before resetting the interrupt aggregation, there might be comp

Re: [PATCH v3 1/6] scsi: ufs: find out sense data over scsi status values

2013-08-27 Thread Subhash Jadavani
Looks good to me. Reviewed-by: Subhash Jadavani On 8/26/2013 8:10 PM, Seungwon Jeon wrote: Unlike 'GOOD' and 'CHECK CONDITION', other status values in Response UPIU may or may not contain sense data. That is returning sense data isn't obvious. So, in this case the Data Segment Length field sho

Re: [PATCH V2 2/3] scsi: ufs: Add regulator enable support

2013-08-27 Thread Subhash Jadavani
Looks good to me. Reviewed-by: Subhash Jadavani On 8/27/2013 9:48 AM, Sujit Reddy Thumma wrote: UFS devices are powered by at most three external power supplies - - VCC - The flash memory core power supply, 2.7V to 3.6V or 1.70V to 1.95V - VCCQ - The controller and I/O power supply, 1.1V to 1

Re: [PATCH] scsi: ufs: read door bell register after clearing interrupt aggregation

2013-08-27 Thread Subhash Jadavani
Looks good to me. Reviewed-by: Subhash Jadavani On 8/25/2013 4:06 PM, Dolev Raviv wrote: In interrupt context, after reading and comparing the UTRLDBR to hba->outstanding_request and before resetting the interrupt aggregation, there might be completion of another transfer request (TR). Such T

Re: [PATCH V2 3/3] scsi: ufs: Add clock initialization support

2013-08-27 Thread Subhash Jadavani
Looks good to me. Reviewed-by: Subhash Jadavani On 8/27/2013 9:48 AM, Sujit Reddy Thumma wrote: Add generic clock initialization support for UFSHCD platform driver. The clock info is read from device tree using standard clock bindings. A generic max-clock-frequency-hz property is defined to sa

Re: [PATCH V2 1/3] scsi: ufs: Allow vendor specific initialization

2013-08-27 Thread Subhash Jadavani
Looks good to me. Reviewed-by: Subhash Jadavani On 8/27/2013 9:48 AM, Sujit Reddy Thumma wrote: Some vendor specific controller versions might need to configure vendor specific - registers, clocks, voltage regulators etc. to initialize the host controller UTP layer and Uni-Pro stack. Provide s

Re: [PATCH v5 0/4] [SCSI] sg: fix race condition in sg_open

2013-08-27 Thread vaughan
On 08/13/2013 11:16 AM, Douglas Gilbert wrote: > On 13-08-12 10:46 PM, vaughan wrote: >> On 08/06/2013 04:52 AM, Douglas Gilbert wrote: >>> On 13-08-04 10:19 PM, vaughan wrote: On 08/03/2013 01:25 PM, Douglas Gilbert wrote: > On 13-08-01 01:01 AM, Douglas Gilbert wrote: >> On 13-07-22

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-08-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #19 from livea...@live.com --- It seems the LSI isn't interested in fixing this . I also purchased a 9211-8i card lately , and it has the same issue . Perhaps , I might consider buying an Adaptec HBA to replace these LSI controllers .