Re: [PATCH 3/8] [SCSI] dc395x: use NULL instead of 0

2013-08-06 Thread Jingoo Han
On Wednesday, August 07, 2013 3:50 PM, Oliver Neukum wrote: > On Wed, 2013-08-07 at 12:55 +0900, Jingoo Han wrote: > > > @@ -4183,15 +4183,17 @@ static void check_eeprom(struct NvRamType *eeprom, > > unsigned long io_port) > > */ > > dprintkl(KERN_WARNING, > >

Re: [PATCH 3/8] [SCSI] dc395x: use NULL instead of 0

2013-08-06 Thread Oliver Neukum
On Wed, 2013-08-07 at 12:55 +0900, Jingoo Han wrote: > @@ -4183,15 +4183,17 @@ static void check_eeprom(struct NvRamType *eeprom, > unsigned long io_port) >*/ > dprintkl(KERN_WARNING, > "EEProm checksum error: using default values and > options

Re: [PATCHv2 0/7] Limit overall SCSI EH runtime

2013-08-06 Thread Ren Mingxin
Hi, James: On 07/11/2013 04:35 AM, Ewan Milne wrote: Looks good. We have been testing this extensively. Acked-by: Ewan D. Milne Do you think this patchset can be applied? If so, When? Perhaps you are waiting for someone's feedback? We've also tested and got the duration could be shortened f

[PATCH 8/8] [SCSI] aic94xx: fix bit masking

2013-08-06 Thread Jingoo Han
Bit masking should happen before casting (u16), thus parentheses are necessary in order to fix the following sparse warning: drivers/scsi/aic94xx/aic94xx_seq.c:748:35: warning: cast truncates bits from constant value (93ef7f becomes ef7f) Signed-off-by: Jingoo Han --- drivers/scsi/aic94xx/aic9

[PATCH 7/8] [SCSI] osst: Staticize local symbols

2013-08-06 Thread Jingoo Han
These local symbols are used only in this file. Fix the following sparse warnings: drivers/scsi/osst.c:5698:1: warning: symbol 'dev_attr_ADR_rev' was not declared. Should it be static? drivers/scsi/osst.c:5712:1: warning: symbol 'dev_attr_media_version' was not declared. Should it be static? dri

[PATCH 6/8] [SCSI] 3w-sas: add missing __iomem annotation

2013-08-06 Thread Jingoo Han
Added missing __iomem annotation in order to fix the following sparse warnings: drivers/scsi/3w-sas.c:1291:21: warning: incorrect type in argument 1 (different address spaces) drivers/scsi/3w-sas.c:1291:21:expected void const volatile [noderef] *addr drivers/scsi/3w-sas.c:1291:21:got voi

[PATCH 5/8] [SCSI] initio: Staticize local symbols

2013-08-06 Thread Jingoo Han
These local symbols are used only in this file. Fix the following sparse warnings: drivers/scsi/initio.c:338:6: warning: symbol 'initio_se2_ew_en' was not declared. Should it be static? drivers/scsi/initio.c:352:6: warning: symbol 'initio_se2_ew_ds' was not declared. Should it be static? drivers

[PATCH 4/8] [SCSI] megaraid: add missing __iomem annotation

2013-08-06 Thread Jingoo Han
Added missing __iomem annotation in order to fix the following sparse warnings: drivers/scsi/megaraid.c:4595:26: warning: incorrect type in argument 1 (different address spaces) drivers/scsi/megaraid.c:4595:26:expected void volatile [noderef] *addr drivers/scsi/megaraid.c:4595:26:got voi

[PATCH 3/8] [SCSI] dc395x: use NULL instead of 0

2013-08-06 Thread Jingoo Han
%p is used, thus NULL should be used instead of 0. Also, bit maskings are added in order to fix the following sparse warnings: drivers/scsi/dc395x.c:1525:17: warning: Using plain integer as NULL pointer drivers/scsi/dc395x.c:4186:48: warning: cast truncates bits from constant value (1de1 becomes

[PATCH 2/8] [SCSI] tgt: add __user annotation

2013-08-06 Thread Jingoo Han
Added __user annotation to fix the following sparse warnings: drivers/scsi/scsi_tgt_lib.c:365:45: warning: incorrect type in argument 4 (different address spaces) drivers/scsi/scsi_tgt_lib.c:365:45:expected void [noderef] * drivers/scsi/scsi_tgt_lib.c:365:45:got void * Signed-off-by: Jin

[PATCH 1/8] [SCSI] scsi_sysfs: Staticize local symbols

2013-08-06 Thread Jingoo Han
These local symbols are used only in this file. Fix the following sparse warnings: drivers/scsi/scsi_sysfs.c:201:25: warning: symbol 'dev_attr_hstate' was not declared. Should it be static? drivers/scsi/scsi_sysfs.c:314:24: warning: symbol 'scsi_shost_attr_group' was not declared. Should it be s

Re: Toshiba USB disk stopped working in 3.10.3

2013-08-06 Thread Giuliano Pochini
On Mon, 05 Aug 2013 22:59:11 -0400 "Martin K. Petersen" wrote: > > "Giuliano" == Giuliano Pochini writes: > > Giuliano, > > Giuliano> My Toshiba 1TB Stor.e basics does not work anymore since > Giuliano> 3.10.3. I have another USB3 disk which works fine. > > Do the following two patches f

Re: [PATCH 1/3] hpsa: remove unneeded loop

2013-08-06 Thread scameron
On Fri, Aug 02, 2013 at 01:13:59PM +0200, Tomas Henzl wrote: > On 08/01/2013 06:18 PM, scame...@beardog.cce.hp.com wrote: > > On Thu, Aug 01, 2013 at 05:39:36PM +0200, Tomas Henzl wrote: > >> On 08/01/2013 05:19 PM, scame...@beardog.cce.hp.com wrote: > > [...] > > > Btw. on line 1284 - isn't i

Re: [PATCH v3 10/10] [RFC] SCSI: esas2r: Add Makefile, Kconfig, and MAINTAINERS files

2013-08-06 Thread Bradley Grove
James, Do you have any comments on this last patch post? I probably shouldn't have posted it as an RFC. We've completed our internal testing of the driver, and I think it's probably ready to submit. Brad On 08/02/2013 12:59 PM, Bradley Grove wrote: Signed-off-by: Bradley Grove --- MA

Re: [PATCH] [SCSI] sg: Fix user memory corruption when SG_IO is interrupted by a signal

2013-08-06 Thread Douglas Gilbert
On 13-08-05 11:54 PM, Peter Chang wrote: 2013/8/5 Roland Dreier : From: Roland Dreier There is a nasty bug in the SCSI SG_IO ioctl that in some circumstances leads to one process writing data into the address space of some other random unrelated process if the ioctl is interrupted by a signal.

RE: [PATCH 7/7] scsi: ufs: configure the attribute for power mode

2013-08-06 Thread Seungwon Jeon
On Wednesday, July 31, 2013, Subhash Jadavani wrote: > Change looks good (except one minor question). > > Reviewed-by: Subhash Jadavani > > On 7/26/2013 7:19 PM, Seungwon Jeon wrote: > > UIC attributes can be set with using DME_SET command for > > power mode change. For configuration the link ca

RE: [PATCH 2/7] scsi: ufs: find out sense data over scsi status values

2013-08-06 Thread Seungwon Jeon
Hi Elliott, Thank you for information. It might be considered, if UFS has the extension someday. Thanks, Seungwon Jeon On Wed, July 31, 2013, Elliott, Robert wrote: > I don't know how well UFS keeps up with SCSI architecture, but SCSI > has expanded from the old 18-byte fixed format sense data t

[Bug 60686] USB 3.0 disks do not mount

2013-08-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60686 Peter changed: What|Removed |Added CC||lekenst...@gmail.com --- Comment #1 from Peter -