Re: [PATCH v5 0/4] [SCSI] sg: fix race condition in sg_open

2013-07-30 Thread vaughan
On 07/26/2013 04:33 AM, Douglas Gilbert wrote: > On 13-07-25 11:32 AM, vaughan wrote: >> On 07/23/2013 01:03 AM, Jörn Engel wrote: >>> On Mon, 22 July 2013 12:40:29 +0800, Vaughan Cao wrote: There is a race when open sg with O_EXCL flag. Also a race may happen between sg_open and sg_

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-30 Thread Marc C
>> One thing which would probably be worthwhile tho is getting rid of the >> bitmap based qc tag allocator in libata. That one is just borderline >> stupid to keep around on any setup which is supposed to be scalable. > Your border might be wider than mine :-). Yes, the bitmap should > definitely

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-30 Thread Martin K. Petersen
> "Nick" == Nick Alcock writes: Nick> in which case we don't actually know that your Areca controller Nick> supports the VPD page we thought it did: quite possibly only this Nick> underlying disk does. The ATA Information VPD page is created by the SCSI-ATA Translation layer. The controller

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-30 Thread Martin K. Petersen
> "Bernd" == Bernd Schubert writes: Bernd, >> Product revision level: R001 It's clearly not verbatim passthrough... Bernd> Besides the firmware, the difference might be that I'm exporting Bernd> single disks without any areca-raidset in between. I can try to Bernd> confirm that tomorrow,

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-30 Thread Martin K. Petersen
> "Doug" == Douglas Gilbert writes: Doug> I just examined a more recent Areca SAS RAID controller and would Doug> describe it as the SCSI device from hell. One solution to this Doug> problem is to modify the arcmsr driver so it returns a more Doug> consistent set of lies to the management SCS

Re: Kernel 3.10.3 "reset SuperSpeed USB device number 2 using xhci_hcd"

2013-07-30 Thread Martin K. Petersen
> "Alan" == Alan Stern writes: Alan> On Mon, 29 Jul 2013, Stuart Foster wrote: >> Hi Alan, >> >> The patch is good for me. >> >> thanks Alan> There also have been positive reports from Marc Meledandri and Alan> Philipp Dreimann. Alan> Martin, please submit your patch for inclusion in the

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-30 Thread Nick Alcock
On 30 Jul 2013, Bernd Schubert told this: > On 07/30/2013 01:34 AM, Martin K. Petersen wrote: >> (wheezy)fslab1:~# sg_inq -v /dev/sdc >> inquiry cdb: 12 00 00 00 24 00 >> standard INQUIRY: >> inquiry cdb: 12 00 00 00 60 00 >> PQual=0 Device_type=0 RMB=0 version=0x05 [SPC-3] >> [AER

RE: [PATCH 2/7] scsi: ufs: find out sense data over scsi status values

2013-07-30 Thread Elliott, Robert (Server Storage)
I don't know how well UFS keeps up with SCSI architecture, but SCSI has expanded from the old 18-byte fixed format sense data to a variable-length descriptor format sense data, in which an 8 byte header precedes a variable number of descriptors. This was devised to support 8-byte LBAs in the INFO

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-30 Thread Nix
On 30 Jul 2013, Bernd Schubert told this: > On 07/30/2013 02:56 AM, Nix wrote: >> On 30 Jul 2013, Douglas Gilbert outgrape: >> >>> Please supply the information that Martin Petersen asked >>> for. >> >> Did it in private IRC (the advantage of working for the same division of >> the same company!)

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-30 Thread Oliver Neukum
On Tue, 2013-07-30 at 13:00 -0400, Alan Stern wrote: > That's why I said the patch would fix the immediate problem but it > wasn't the best solution. You do agree that the patch is correct, as > far as it goes? It will allow the system to sleep. But it seems to me that a genuine error while flus

Re: [PATCH 25/36] SCSI: sd: convert class code to use dev_groups

2013-07-30 Thread James Bottomley
On Tue, 2013-07-30 at 12:01 -0700, Greg Kroah-Hartman wrote: > On Tue, Jul 30, 2013 at 04:11:52PM +, James Bottomley wrote: > > On Wed, 2013-07-24 at 15:05 -0700, Greg Kroah-Hartman wrote: > > > The dev_attrs field of struct class is going away soon, dev_groups > > > should be used instead. Th

Re: [PATCH 25/36] SCSI: sd: convert class code to use dev_groups

2013-07-30 Thread Greg Kroah-Hartman
On Tue, Jul 30, 2013 at 04:11:52PM +, James Bottomley wrote: > On Wed, 2013-07-24 at 15:05 -0700, Greg Kroah-Hartman wrote: > > The dev_attrs field of struct class is going away soon, dev_groups > > should be used instead. This converts the scsi disk class code to use > > the correct field. >

Re: Kernel 3.10.3 "reset SuperSpeed USB device number 2 using xhci_hcd"

2013-07-30 Thread Alan Stern
On Mon, 29 Jul 2013, Stuart Foster wrote: > > Stuart and Ed, does Martin's patch fix your problem? > > > > Alan Stern > > > > > Hi Alan, > > The patch is good for me. > > thanks There also have been positive reports from Marc Meledandri and Philipp Dreimann. Martin, please submit your patch f

Re: [PATCH 26/36] SCSI: st: convert class code to use dev_groups

2013-07-30 Thread James Bottomley
Adding linux-scsi to cc. James On Wed, 2013-07-24 at 15:05 -0700, Greg Kroah-Hartman wrote: > The dev_attrs field of struct class is going away soon, dev_groups > should be used instead. This converts the scsi tape class code to use > the correct field. > > Cc: Kai Mäkisara > Cc: James E.J. Bo

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-30 Thread Bernd Schubert
On 07/30/2013 02:56 AM, Nix wrote: On 30 Jul 2013, Douglas Gilbert outgrape: Please supply the information that Martin Petersen asked for. Did it in private IRC (the advantage of working for the same division of the same company!) I didn't realise the original fix was actually implemented to

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-30 Thread Bernd Schubert
On 07/30/2013 01:34 AM, Martin K. Petersen wrote: "Nix" == Nix writes: Bernd, Nix> I can now confirm that reverting this commit causes this problem to Nix> go away, and my machine boots fine again. Can you please send me the output of sq_inq with your 1.49 firmware? I made a tweak that all

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-30 Thread Alan Stern
On Tue, 30 Jul 2013, Oliver Neukum wrote: > On Mon, 2013-07-29 at 10:21 -0400, Alan Stern wrote: > > On Mon, 29 Jul 2013, Oliver Neukum wrote: > > > > > On Fri, 2013-07-26 at 16:31 -0400, Alan Stern wrote: > > > > > > > In addition to my earlier comment, the patch below should be applied. > >

Re: [PATCH 25/36] SCSI: sd: convert class code to use dev_groups

2013-07-30 Thread James Bottomley
On Wed, 2013-07-24 at 15:05 -0700, Greg Kroah-Hartman wrote: > The dev_attrs field of struct class is going away soon, dev_groups > should be used instead. This converts the scsi disk class code to use > the correct field. > > It required some functions to be moved around to place the show and >

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-30 Thread Oliver Neukum
On Mon, 2013-07-29 at 10:21 -0400, Alan Stern wrote: > On Mon, 29 Jul 2013, Oliver Neukum wrote: > > > On Fri, 2013-07-26 at 16:31 -0400, Alan Stern wrote: > > > > > In addition to my earlier comment, the patch below should be applied. > > > It will fix your immediate problem, although not in t

RE: [PATCH 2/7] scsi: ufs: find out sense data over scsi status values

2013-07-30 Thread Seungwon Jeon
On Tue, July 30, 2013, Santosh Y wrote: > On Fri, Jul 26, 2013 at 7:16 PM, Seungwon Jeon wrote: > > Except for 'GOOD' and 'CHECK CONDITION', other status value > > in Response UPIU may or may contain sense data. If a non-zero > > value is in the Data Segment Length field, it means that UPIU > > ha

RE: [PATCH 1/7] scsi: ufs: amend the ocs handling with fatal error

2013-07-30 Thread Seungwon Jeon
On Mon, July 29, 2013, Sujit Reddy Thumma wrote: > On 7/29/2013 11:47 AM, Subhash Jadavani wrote: > > On 7/26/2013 7:15 PM, Seungwon Jeon wrote: > >> Fatal error in OCS(overall command status) field indicates > >> error conditions which is not covered by UFSHCI. > >> It means that host cannot defin

RE: [PATCH 2/7] scsi: ufs: find out sense data over scsi status values

2013-07-30 Thread Seungwon Jeon
On Mon, July 29, 2013, Sujit Reddy Thumma wrote: > On 7/26/2013 7:16 PM, Seungwon Jeon wrote: > > Except for 'GOOD' and 'CHECK CONDITION', other status value > > in Response UPIU may or may contain sense data. If a non-zero > > value is in the Data Segment Length field, it means that UPIU > > has S

RE: [PATCH 6/7] scsi: ufs: add operation for the uic power mode change

2013-07-30 Thread Seungwon Jeon
On Mon, July 29, 2013, Subhash Jadavani wrote: > Change looks good except few minor comments. Thank you for comments. > > On 7/26/2013 7:18 PM, Seungwon Jeon wrote: > > Setting PA_PWRMode using DME_SET triggers the power mode > > change. And then the result will be given by the HCS.UPMCRS. > > Th

RE: [PATCH 4/7] scsi: ufs: add dme configuration primitives

2013-07-30 Thread Seungwon Jeon
On Mon, July 29, 2013, Subhash Jadavani wrote: > On 7/26/2013 7:17 PM, Seungwon Jeon wrote: > > Implements to support GET and SET operations of the DME. > > These operations are used to configure the behavior of > > the UNIPRO. Along with basic operation, {Peer/AttrSetType} > > can be mixed. > > >

RE: [PATCH 2/7] scsi: ufs: find out sense data over scsi status values

2013-07-30 Thread Seungwon Jeon
On Mon, July 29, 2013, Subhash Jadavani wrote: > On 7/26/2013 7:16 PM, Seungwon Jeon wrote: > > Except for 'GOOD' and 'CHECK CONDITION', other status value > This is what UFS device spec says: "A GOOD status indicates successful > SCSI completion and therefore no Sense Data will be returned." So pl

RE: [PATCH 3/7] scsi: ufs: fix the setting interrupt aggregation counter

2013-07-30 Thread Seungwon Jeon
On Mon, July 29, 2013, Subhash Jadavani wrote: > On 7/26/2013 7:16 PM, Seungwon Jeon wrote: > > LACTH(Interrupt aggregation counter threshold) value is allowed > > I guess you mean "IACTH" not "LACTH". Other than this, change looks good > to me. > Reviewed-by: Subhash Jadavani Right, Typo will be

[PATCH 1/1] Trivial cleanup : Updated sd_do_mode_sense() description

2013-07-30 Thread ChinmayVS
sd_do_mode_sense() is no longer called with a fixed length buffer. Updated the descriptive comment to reflect the same. Signed-off-by: ChinmayVS --- drivers/scsi/sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index c1c5552..7890bec

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-07-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #13 from livea...@live.com --- One more thing , the MD-RAID0 has XFS but that doesn't matter because it used to have EXT4 with the same results . -- You are receiving this mail because: You are watching the assignee of the bug. -- To

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-07-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #12 from livea...@live.com --- Hi . I can easily reproduce this issue in a second by running : btrfs scrub start /MOUNTPOINT The btrfs system is a RAID1 that consists of 5 drives . Also in an MD-RAID0 that consists of 3 drives by r

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-07-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #11 from Sreekanth Reddy --- Hi, Thanks for providing the logs. >From the logs what I observed is that controller is going in to the non operational state and so we are seeing the messages "mpt2sas0: _base_fault_reset_work : SAS host

Re: sparc ESP SCSI error handling BUG+hang

2013-07-30 Thread Meelis Roos
> > Therefore I think the fix is going to involve adding a member to > > "struct esp_cmd_entry" called "->orig_tag[]" so that we can see what > > the original tag[] values were at esp_alloc_lun_tag() time. > > Please try this patch: It works on 3 consecutive boots, thank you! Tested-by: Meelis R

[PATCH 35/35] sgiwd93: use dev_get_platdata()

2013-07-30 Thread Jingoo Han
Use the wrapper function for retrieving the platform data instead of accessing dev->platform_data directly. Signed-off-by: Jingoo Han --- drivers/scsi/sgiwd93.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/sgiwd93.c b/drivers/scsi/sgiwd93.c index a464d9