On Tue, 2013-07-09 at 15:12 -0700, adam radford wrote:
> On Tue, Jul 9, 2013 at 2:18 PM, James Bottomley
> > Adam, you do drive by coding on this for LSI ... ack or reject, please.
> I have just now located my box of MegaRAID Parallel SCSI controllers.
> I will review and test the patch series fro
On Tue, Jul 9, 2013 at 2:18 PM, James Bottomley
wrote:
> On Tue, 2013-07-09 at 14:39 -0600, Myron Stowe wrote:
>> Is the "megaraid" driver still actively used and maintained? I originally
>> posted this series on 06.07.2013 and after receiving no comments, pinged
>> the list again on 06.17.2013 a
On Tue, 2013-07-09 at 14:39 -0600, Myron Stowe wrote:
> Is the "megaraid" driver still actively used and maintained? I originally
> posted this series on 06.07.2013 and after receiving no comments, pinged
> the list again on 06.17.2013 and still received no comments/feedback.
>
> Trying again as
With the driver now setup for default 32-bit DMA capabilities, remove the
64-bit DMA related dead code.
Signed-off-by: Myron Stowe
---
drivers/scsi/megaraid.c | 45 +
drivers/scsi/megaraid.h |1 -
2 files changed, 9 insertions(+), 37 deletions(-
Is the "megaraid" driver still actively used and maintained? I originally
posted this series on 06.07.2013 and after receiving no comments, pinged
the list again on 06.17.2013 and still received no comments/feedback.
Trying again as I believe there is a real issue here, which I'd like
confirmatio
With the driver now setup for default 32-bit DMA capabilities, remove the
broken make_local_pdev() implementation and usages.
Signed-off-by: Myron Stowe
---
drivers/scsi/megaraid.c | 98 ---
1 files changed, 16 insertions(+), 82 deletions(-)
diff -
If the megaraid device is 64-bit DMA capable then, once it is setup, any
subsequent DMA allocations for "internal commands" would not be properly
restricted due to megaraid_probe_one() having called pci_set_dma_mask() on
pdev with DMA_BIT_MASK(64). The driver attempts to solve this by using
make_l
On Tue, Jul 09, 2013 at 12:47:37PM -0700, Robert Love wrote:
> ctlr_dev was initialized to NULL, and never re-assigned. This
> caused the log statement to always report failure. This patch
> removes the unused variable and fixes the log statement to always
> report 'success', as that is what should
On Tue, Jul 09, 2013 at 12:47:31PM -0700, Robert Love wrote:
> There are two debug statements with the same output string regarding
> echange timer cancellation. This patch simply changes the output of
> one string so that they can be differentiated.
>
> Signed-off-by: Robert Love
> Tested-by: Ja
On Tue, Jul 09, 2013 at 12:47:26PM -0700, Robert Love wrote:
> Simply remove an extra space that violates coding style.
>
> Signed-off-by: Robert Love
> Tested-by: Jack Morgan
> Acked-by: Neil Horman
> ---
> drivers/scsi/libfc/fc_exch.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-
From: Mark Rustad
When repeatedly doing rmmod and modprobe on the ixgbe
driver while FCoE is active in a VN2VN configuration,
memory leaks would be discovered by kmemleak with the
following backtrace:
unreferenced object 0x88003d076000 (size 1024):
comm "kworker/0:3", pid 2998, jiffies 429
ctlr_dev was initialized to NULL, and never re-assigned. This
caused the log statement to always report failure. This patch
removes the unused variable and fixes the log statement to always
report 'success', as that is what should be logged if the code
reaches this point.
Signed-off-by: Robert Lov
The following changes since commit 8bb495e3f02401ee6f76d1b1d77f3ac9f079e376:
Linux 3.10 (2013-06-30 15:13:29 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/rwlove/fcoe.git
tags/fixes_for_3.10
for you to fetch changes up to 7a5ed75a782a1f2de7f
From: Bart Van Assche
Declare local variables and functions 'static'. This patch does not
change any functionality.
Signed-off-by: Bart Van Assche
Signed-off-by: Robert Love
---
drivers/scsi/fcoe/fcoe_sysfs.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
From: Mark Rustad
Reject a PLOGI from a node with an incompatible role,
that is, initiator-to-initiator or target-to-target.
Signed-off-by: Mark Rustad
Reviewed-by: Yi Zou
Tested-by: Jack Morgan
Signed-off-by: Robert Love
---
drivers/scsi/libfc/fc_rport.c | 27 +++
Simply remove an extra space that violates coding style.
Signed-off-by: Robert Love
Tested-by: Jack Morgan
Acked-by: Neil Horman
---
drivers/scsi/libfc/fc_exch.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c
i
There are two debug statements with the same output string regarding
echange timer cancellation. This patch simply changes the output of
one string so that they can be differentiated.
Signed-off-by: Robert Love
Tested-by: Jack Morgan
Acked-by: Neil Horman
---
drivers/scsi/libfc/fc_exch.c |
From: Neerav Parikh
This patch fixes a smatch warning as below:
smatch warnings:
drivers/scsi/fcoe/fcoe.c:782 fcoe_fdmi_info() warn: 'fdmi' puts 896 bytes on
stack
Reported-by: Fengguang Wu
Signed-off-by: Neerav Parikh
Tested-by: Jack Morgan
Signed-off-by: Robert Love
---
drivers/scsi/fcoe
From: Yi Zou
Both fcoe_fc_els_lesb and fc_els_lesb are in __be32 already, and both are
exactly the same size in bytes, with somewhat different member names to
reflect the fact the former is for Ethernet media the latter is for Fiber
Channel, so, remove conversion and use __be32 directly. This fix
The following series implements a few random fixes. I know this series may be a
bit
late for the merge window, but they're fairly simple fixes and I think they
should be
fine for RC if I've missed the merge window.
---
Bart Van Assche (1):
fcoe: Reduce number of sparse warnings
Mark Rust
On Tue, 2013-07-09 at 17:38 +0800, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc
> head: 06ba9fa7f8cec5b9c04e511bfe21c5aa7cc3044c
> commit: eb7b211bac8e0aad45c2349a853be13cef20048a [34/37] [SCSI] scsi_debug:
> reduce duplication between prot_
Tested with error injection.
Tested-by: Maya Erez
> Error handling in UFS driver is broken and resets the host controller
> for fatal errors without re-initialization. Correct the fatal error
> handling sequence according to UFS Host Controller Interface (HCI)
> v1.1 specification.
>
> o Upon de
Tested with error injection.
Tested-by: Maya Erez
> As of now SCSI initiated error handling is broken because,
> the reset APIs don't try to bring back the device initialized and
> ready for further transfers.
>
> In case of timeouts, the scsi error handler takes care of handling aborts
> and re
Tested-by: Maya Erez
> Currently, sending Task Management (TM) command to the card might
> be broken in some scenarios as listed below:
>
> Problem: If there are more than 8 TM commands the implementation
> returns error to the caller.
> Fix: Wait for one of the slots to be emptied a
Tested-by: Maya Erez
> There is a possible race condition in the hardware when the abort
> command is issued to terminate the ongoing SCSI command as described
> below:
>
> - A bit in the door-bell register is set in the controller for a
> new SCSI command.
> - In some rare situations, before c
Tested-by: Maya Erez
> Add runtime PM helpers to suspend/resume UFS controller at runtime.
> Enable runtime PM by default for pci and platform drivers as the
> initialized hardware can suspend if it is not used after bootup.
>
> Signed-off-by: Sujit Reddy Thumma
> ---
> drivers/scsi/ufs/ufshcd-
Tested-by: Maya Erez
> Background operations in the UFS device can be disabled by
> the host to reduce the response latency of transfer requests.
> Add support for enabling/disabling the background operations
> during runtime suspend/resume of the device.
>
> If the device is in critical need of
Tested-by: Maya Erez
> As part of device initialization sequence, sending NOP OUT UPIU and
> waiting for NOP IN UPIU response is mandatory. This confirms that the
> device UFS Transport (UTP) layer is functional and the host can configure
> the device with further commands. Add support for sendin
Tested-by: Maya Erez
> From: Dolev Raviv
>
> Allow UFS device to complete its initialization and accept
> SCSI commands by setting fDeviceInit flag. The device may take
> time for this operation and hence the host should poll until
> fDeviceInit flag is toggled to zero. This step is mandated by
Add runtime PM helpers to suspend/resume UFS controller at runtime.
Enable runtime PM by default for pci and platform drivers as the
initialized hardware can suspend if it is not used after bootup.
Signed-off-by: Sujit Reddy Thumma
---
drivers/scsi/ufs/ufshcd-pci.c| 65
Background operations in the UFS device can be disabled by
the host to reduce the response latency of transfer requests.
Add support for enabling/disabling the background operations
during runtime suspend/resume of the device.
If the device is in critical need of BKOPS it will raise an
URGENT_BKOP
The first patch fixes many issues with current task management handling
in UFSHCD driver. Others improve error handling in various scenarios.
These patches depends on:
[PATCH V3 1/2] scsi: ufs: Add support for sending NOP OUT UPIU
[PATCH V3 2/2] scsi: ufs: Set fDeviceInit flag to initiate device i
As of now SCSI initiated error handling is broken because,
the reset APIs don't try to bring back the device initialized and
ready for further transfers.
In case of timeouts, the scsi error handler takes care of handling aborts
and resets. Improve the error handling in such scenario by resetting t
Currently, sending Task Management (TM) command to the card might
be broken in some scenarios as listed below:
Problem: If there are more than 8 TM commands the implementation
returns error to the caller.
Fix: Wait for one of the slots to be emptied and send the command.
Problem: Som
There is a possible race condition in the hardware when the abort
command is issued to terminate the ongoing SCSI command as described
below:
- A bit in the door-bell register is set in the controller for a
new SCSI command.
- In some rare situations, before controller get a chance to issue
th
Error handling in UFS driver is broken and resets the host controller
for fatal errors without re-initialization. Correct the fatal error
handling sequence according to UFS Host Controller Interface (HCI)
v1.1 specification.
o Upon determining fatal error condition the host controller may hang
f
This patch series replace the previous Query Request and NOP patches:
[PATCH 1/8] scsi: ufs: add support for query
[PATCH 6/8] scsi: ufs: Add support for sending NOP OUT UPIU
[PATCH 7/8] scsi: ufs: Set fDeviceInit flag to initiate device initialization
Major difference -
Sending the query
Add host assisted background operations for UFS device and runtime PM
helpers for ufshcd platform and pci glue drivers. The background operations
are disabled during runtime resume and enabled when the device is idle and
runtime suspended.
These patches depends on:
[PATCH V3 1/2] scsi: ufs: Add su
As part of device initialization sequence, sending NOP OUT UPIU and
waiting for NOP IN UPIU response is mandatory. This confirms that the
device UFS Transport (UTP) layer is functional and the host can configure
the device with further commands. Add support for sending NOP OUT UPIU to
check the dev
From: Dolev Raviv
Allow UFS device to complete its initialization and accept
SCSI commands by setting fDeviceInit flag. The device may take
time for this operation and hence the host should poll until
fDeviceInit flag is toggled to zero. This step is mandated by
UFS device specification for devic
40 matches
Mail list logo
