RE: [PATCH 1/1] scsi/megaraid: minor cut and paste error fixed.

2013-06-27 Thread Saxena, Sumit
Thanks James for pointing this out, there is no harm with this change. Acked-by: Sumit Saxena Sumit >-Original Message- >From: James Georgas [mailto:soulpa...@gmail.com] >Sent: Wednesday, June 26, 2013 11:33 PM >To: DL-MegaRAID Linux; jbottom...@parallels.com >Cc: linux-ker...@vger.kern

re: [SCSI] cxgb4i: add support for T5 adapter

2013-06-27 Thread Dan Carpenter
Hello Karen Xie, The patch 3bd3e8bf6250: "[SCSI] cxgb4i: add support for T5 adapter" from May 29, 2013, leads to the following Sparse warning: drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:284:29: warning: incorrect type in assignment (different base types) drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:284:29:exp

[PATCH v3 25/45] [SCSI] fcoe: Use get/put_online_cpus_atomic() to prevent CPU offline

2013-06-27 Thread Srivatsa S. Bhat
Once stop_machine() is gone from the CPU offline path, we won't be able to depend on disabling preemption to prevent CPUs from going offline from under us. Use the get/put_online_cpus_atomic() APIs to prevent CPUs from going offline, while invoking from atomic context. Cc: Robert Love Cc: "James

Re: RFC: Allow block drivers to poll for I/O instead of sleeping

2013-06-27 Thread Rik van Riel
On 06/20/2013 04:17 PM, Matthew Wilcox wrote: --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -4527,6 +4527,36 @@ long __sched io_schedule_timeout(long timeout) return ret; } +/* + * Wait for an I/O to complete against this backing_dev_info. If the + * task exhausts its timesl

Re: RFC: Allow block drivers to poll for I/O instead of sleeping

2013-06-27 Thread Rik van Riel
On 06/23/2013 02:29 PM, Linus Torvalds wrote: You could try to do that either *in* the idle thread (which would take the context switch overhead - maybe negating some of the advantages), or alternatively hook into the scheduler idle logic before actually doing the switch. But anything that star

Re: fcoe pull request for 3.9-rc

2013-06-27 Thread Love, Robert W
On Wed 26 Jun 2013 11:14:02 PM PDT, James Bottomley wrote: > On Tue, 2013-06-25 at 20:55 +, Love, Robert W wrote: >> The following changes since commit 1e876e3b1a9df25bb04682b0d48aaa7e8ae1fc82: >> >> Merge branch 'for-linus' of >> git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux (20

Re: [PATCH v3 4/6] [SCSI] Generate uevents for certain Unit Attention codes

2013-06-27 Thread Ewan Milne
On Mon, 2013-06-24 at 14:58 +, James Bottomley wrote: > On Mon, 2013-06-24 at 10:11 -0400, Ewan Milne wrote: > > On Wed, 2013-06-19 at 18:48 +, James Bottomley wrote: > > > On Wed, 2013-06-19 at 13:42 -0400, Ewan D. Milne wrote: > > > > From: "Ewan D. Milne" > > > > > > > > Generate a uev

[PATCH v12 6/6] Avoid re-enabling I/O after the transport became offline

2013-06-27 Thread Bart Van Assche
Disallow the SDEV_TRANSPORT_OFFLINE to SDEV_CANCEL transition such that no I/O is sent to devices for which the transport is offline. Notes: - Functions like sd_shutdown() use scsi_execute_req() and hence set the REQ_PREEMPT flag. Such requests are passed to the LLD queuecommand callback in the

[PATCH v12 5/6] Avoid that scsi_device_set_state() triggers a race

2013-06-27 Thread Bart Van Assche
Make concurrent invocations of scsi_device_set_state() safe. Signed-off-by: Bart Van Assche Acked-by: Hannes Reinecke Cc: James Bottomley Cc: Tejun Heo Cc: Mike Christie --- drivers/scsi/scsi_error.c |4 drivers/scsi/scsi_lib.c | 43 ++- d

[PATCH v12 4/6] Avoid saving/restoring interrupt state inside scsi_remove_host()

2013-06-27 Thread Bart Van Assche
Since it is not allowed to invoke scsi_remove_host() with interrupts disabled, avoid saving and restoring the interrupt state inside scsi_remove_host(). This patch does not change the functionality of the function scsi_remove_host(). Signed-off-by: Bart Van Assche Acked-by: Tejun Heo Acked-by: H

[PATCH v12 3/6] Restrict device state changes allowed via sysfs

2013-06-27 Thread Bart Van Assche
Restrict the SCSI device state changes allowd via sysfs to the OFFLINE<>RUNNING transitions. Other transitions may confuse the SCSI mid-layer. As an example, changing the state of a SCSI device via sysfs into "cancel" or "deleted" prevents removal of a SCSI device by scsi_remove_host(). Signed-off

[PATCH v12 2/6] Avoid calling __scsi_remove_device() twice

2013-06-27 Thread Bart Van Assche
If something goes wrong during LUN scanning, e.g. a transport layer failure occurs, then __scsi_remove_device() can get invoked by the LUN scanning code for a SCSI device in state SDEV_CREATED_BLOCK. If this happens then the SCSI device has not yet been added to sysfs (is_visible == 0). Make sure

[PATCH v12 1/6] Fix race between starved list and device removal

2013-06-27 Thread Bart Van Assche
From: James Bottomley scsi_run_queue() examines all SCSI devices that are present on the starved list. Since scsi_run_queue() unlocks the SCSI host lock a SCSI device can get removed after it has been removed from the starved list and before its queue is run. Protect against that race condition b

[PATCH v12 0/6] SCSI device removal fixes

2013-06-27 Thread Bart Van Assche
Fix a few issues related to SCSI device removal: - Fix a race between starved list processing and device removal that can trigger a kernel oops. - Avoid that __scsi_remove_device() is called twice for the same SCSI device, which also can cause a kernel oops. - Restrict the SCSI device state ch

Re: [PATCH 7/7] scsi: Add 'eh_deadline' to limit SCSI EH runtime

2013-06-27 Thread Ewan Milne
The eh_deadline changes allow for a significant improvement in multipath failover time. It works very well in our testing. I do have a few corrections, see below: On Mon, 2013-06-10 at 13:11 +0200, Hannes Reinecke wrote: > This patchs adds an 'eh_deadline' attribute to the scsi > host which limit

RE: [PATCH 3/5] Drivers: scsi: storvsc: Implement multi-channel support

2013-06-27 Thread KY Srinivasan
> -Original Message- > From: James Bottomley [mailto:jbottom...@parallels.com] > Sent: Wednesday, June 26, 2013 11:22 PM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; h...@infradead.org; linux- > s...@

Re: [PATCH 1/4] scsi: ufs: Fix broken task management command implementation

2013-06-27 Thread Santosh Y
On Thu, Jun 13, 2013 at 8:00 PM, Sujit Reddy Thumma wrote: > Currently, sending Task Management (TM) command to the card might > be broken in some scenarios as listed below: > > - If there are more than 8 TM commands the implementation returns > error to the caller. > Fix: Wait for one of the slot

Re: [PATCH 0/7] Limit overall SCSI EH runtime

2013-06-27 Thread Ren Mingxin
Hi, Hannes & James: On 06/10/2013 07:11 PM, Hannes Reinecke wrote: This patchset implements a new 'eh_deadline' attribute to the SCSI host. It will limit the overall SCSI EH runtime by a given timeout. If the timeout expires all intermediate steps will be skipped and host reset will be scheduled

Re: [PATCH] scsi_prep_fn() check for empty queue

2013-06-27 Thread Maxim Uvarov
On 06/26/2013 01:20 PM, Bart Van Assche wrote: On 06/26/13 11:02, Maxim Uvarov wrote: This fix: end_request: I/O error, dev sdc, sector 976576 rport-0:0-3: blocked FC remote port time out: removing target and saving binding BUG: unable to handle kernel NULL pointer dereference at 00

[Resend with Ack][PATCH 8/9] scsi/pm8001: use pdev->pm_cap instead of pci_find_capability(..,PCI_CAP_ID_PM)

2013-06-27 Thread Yijing Wang
Pci core has been saved pm cap register offset by pdev->pm_cap in pci_pm_init() in init path. So we can use pdev->pm_cap instead of using pci_find_capability(pdev, PCI_CAP_ID_PM) for better performance and simplified code. Acked-by: Lindar Liu Tested-by: Lindar Liu Signed-off-by: Yijing Wang C