Re: SCSI testing/USB devices are amazing

2013-05-13 Thread ronnie sahlberg
Hi Martin, Thanks for your input, and for the link to your nice writeup. On Thu, May 9, 2013 at 7:43 PM, Martin K. Petersen wrote: >> "Ronnie" == ronnie sahlberg writes: > > Ronnie> * please have a look at the tests and the test results I linked > Ronnie> to above. I currently have quite

Re: [PATCH v3 0/4] Patchset to use PCLMULQDQ to accelerate CRC-T10DIF checksum computation

2013-05-13 Thread Herbert Xu
On Wed, May 01, 2013 at 12:52:47PM -0700, Tim Chen wrote: > Currently the CRC-T10DIF checksum is computed using a generic table lookup > algorithm. By switching the checksum to PCLMULQDQ based computation, > we can speedup the computation by 8x for checksumming 512 bytes and > even more for larger

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-13 Thread Jeremy Linton
On 5/13/2013 3:29 PM, Martin K. Petersen wrote: > others. We see cases fairly often where a misbehaving target has > confused the HBA enough that we can not bring the device back without > doing an HBA firmware reset. Despite I/O completing successfully on > other targets connected to the same HBA

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-13 Thread Martin K. Petersen
> "Jeremy" == Jeremy Linton writes: Jeremy> Well, how about generating std inquiry against them if they are Jeremy> idle and the given HBA has a device in error state? Then you can Jeremy> make a rough approximation of what has failed, and escalate the Jeremy> error handling if all the device

Re: [PATCH v2, part 1 3/9] PCI: Convert alloc_pci_dev(void) to pci_alloc_dev(bus) instead

2013-05-13 Thread Yinghai Lu
On Mon, May 13, 2013 at 9:08 AM, Jiang Liu wrote: > From: Gu Zheng > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 4f0bc0a..bc075a3 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -1131,6 +1131,7 @@ static void pci_release_dev(struct device *dev) > str

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-13 Thread Baruch Even
On Mon, May 13, 2013 at 6:58 PM, Jeremy Linton wrote: > On 5/13/2013 10:03 AM, Hannes Reinecke wrote: >> The other LUNs haven't reported an error. But how do you know whether they >> are still okay? The other LUNs might simply be idle, and no commands have >> been send to them. > > Well, h

[PATCH v2, part 1 3/9] PCI: Convert alloc_pci_dev(void) to pci_alloc_dev(bus) instead

2013-05-13 Thread Jiang Liu
From: Gu Zheng From: Gu Zheng Use the new pci_alloc_dev(bus) to replace the existing using of alloc_pci_dev(void). v2: Follow Bjorn's correction to move pci_bus_put() to pci_release_dev() instead. Signed-off-by: Gu Zheng Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: "David S. Mill

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-13 Thread Jeremy Linton
On 5/13/2013 10:03 AM, Hannes Reinecke wrote: > The other LUNs haven't reported an error. But how do you know whether they > are still okay? The other LUNs might simply be idle, and no commands have > been send to them. Well, how about generating std inquiry against them if they are idle

RE: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-13 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Ewan Milne > Sent: Friday, 10 May, 2013 11:59 AM > To: Hannes Reinecke > Cc: Baruch Even; Martin K. Petersen; linux-scsi; michaelc > Subject: Re: [PATCH] scsi: Allow err

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-13 Thread Hannes Reinecke
On 05/13/2013 04:40 PM, Jeremy Linton wrote: > On 5/13/2013 12:46 AM, Hannes Reinecke wrote: > >> True. But and the end of the day, we _do_ want to recover the failed LUN. >> If we were to disable that faulty LUN and continue running with the others >> we won't have a chance of _ever_ recovering t

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-13 Thread Jeremy Linton
On 5/13/2013 12:46 AM, Hannes Reinecke wrote: > True. But and the end of the day, we _do_ want to recover the failed LUN. > If we were to disable that faulty LUN and continue running with the others > we won't have a chance of _ever_ recovering that one LUN. I don't buy this. Especially f

RE: [PATCH V1 0/8] ufs patch siries

2013-05-13 Thread Seungwon Jeon
On Monday, May 13, 2013, Dolev Raviv wrote: > This patch series clusters the latest version of all the UFS patches in the > SCSI mailing list. It gives a stable functional base line for the UFS driver. > > It includes the following versions: > > [PATCH 1/2] Documentation: devicetree: Add DT bindin

[PATCH V1 2/8] scsi: ufs: Fix the response UPIU length setting

2013-05-13 Thread Dolev Raviv
The response UPIU length should be in DWORD and not in bytes. Signed-off-by: Maya Erez Signed-off-by: Sujit Reddy Thumma Signed-off-by: Dolev Raviv Tested-by: Dolev Raviv diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 4ddc8be..7ce40a5 100644 --- a/drivers/scsi/ufs/uf

[PATCH V1 07/17] bfa: Fix FDISC timeout handling

2013-05-13 Thread Vijaya Mohan Guvva
Retry FDISC a max of 6 times. Introduce new events to handle vport login fails due to max logins to fabric/switch. Signed-off-by: Anil Gurumurthy Signed-off-by: Vijaya Mohan Guvva --- drivers/scsi/bfa/bfa_fcs_lport.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) di

[PATCH V1 4/8] scsi: ufs: amend interrupt configuration

2013-05-13 Thread Dolev Raviv
It makes interrupt setting more flexible especially for disabling. And wrong bit mask is fixed for ver 1.0. [17:16] is added for mask. Signed-off-by: Seungwon Jeon Tested-by: Maya Erez Acked-by: Santosh Y diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 3946b9d..c342a38

[PATCH V1 3/8] scsi: ufs: wrap the i/o access operations

2013-05-13 Thread Dolev Raviv
Simplify operations with hiding mmio_base. Signed-off-by: Seungwon Jeon Tested-by: Maya Erez Acked-by: Santosh Y diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 7ce40a5..3946b9d 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -71,7 +71,7 @@ en

[PATCH V1 8/8] scsi: ufs: Set fDeviceInit flag to initiate device initialization

2013-05-13 Thread Dolev Raviv
Allow UFS device to complete its initialization and accept SCSI commands by setting fDeviceInit flag. The device may take time for this operation and hence the host should poll until fDeviceInit flag is toggled to zero. This step is mandated by UFS device specification for device initialization com

[PATCH V1 6/8] scsi: ufs: rework link start-up process

2013-05-13 Thread Dolev Raviv
Link start-up requires long time with multiphase handshakes between UFS host and device. This affects driver's probe time. This patch let link start-up run asynchronously. Link start-up will be executed at the end of prove separately. Along with this change, the following is worked. Defined comple

[PATCH V1 7/8] scsi: ufs: Add support for sending NOP OUT UPIU

2013-05-13 Thread Dolev Raviv
As part of device initialization sequence, sending NOP OUT UPIU and waiting for NOP IN UPIU response is mandatory. This confirms that the device UFS Transport (UTP) layer is functional and the host can configure the device with further commands. Add support for sending NOP OUT UPIU to check the dev

[PATCH V1 5/8] scsi: ufs: fix interrupt status clears

2013-05-13 Thread Dolev Raviv
There is no need to check the version to clear the interrupt status. And the order is changed prior to actual handling. Signed-off-by: Seungwon Jeon Tested-by: Maya Erez Acked-by: Santosh Y diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index c342a38..f4293d1 100644 --- a/d

[PATCH V1 1/8] Documentation: devicetree: Add DT bindings for UFS host controller

2013-05-13 Thread Dolev Raviv
Compatible list is used in commit 03b1781 but is not documented. Add necessary device tree bindings to describe on-chip UFS host controllers. Signed-off-by: Sujit Reddy Thumma diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt b/Documentation/devicetree/bindings/ufs/ufshcd-plt

[PATCH V1 0/8] ufs patch siries

2013-05-13 Thread Dolev Raviv
This patch series clusters the latest version of all the UFS patches in the SCSI mailing list. It gives a stable functional base line for the UFS driver. It includes the following versions: > [PATCH 1/2] Documentation: devicetree: Add DT bindings for UFS host > controller > [PATCH 2/2] scsi: ufs:

[PATCH V1 14/17] bfa: fix endianess issue for firmware stats

2013-05-13 Thread Vijaya Mohan Guvva
Fix endianess issue on Big-endian architecture for firmware statistics Signed-off-by: Vijaya Mohan Guvva --- drivers/scsi/bfa/bfa_ioc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c index c31cb3c..a4f3741 100644 --- a/

[PATCH V1 03/17] bfa: Add dynamic diagnostic port support

2013-05-13 Thread Vijaya Mohan Guvva
D-Port is a new port type created with the intention of running link level diagnostic tests like loopback, traffic test. In static D-port mode, user configures the port to D-port mode and starts the test, but in dynamic D-port, once the Brocade switch port is configured to D-port, it will reject th

[PATCH V1 00/17] Update the driver version to 3.2.21.1

2013-05-13 Thread Vijaya Mohan Guvva
Hi James, Re-submitting the patch sets, Update the driver version to 3.2.21.0 and Update the driver version to 3.2.21.1. It includes bug-fixes, changes to use firmware version 3.2.1.0, adds new features such as Forward Error Correction, FC BB credit recovery, dynamic diagnostic Port (D-port), enabl

[PATCH] bfa: fix for FC Direct Attach LUN discovery failure

2013-05-13 Thread Vijay Mohan Guvva
Resending the patch as it didn't make the linux-scsi list. This patch fixes fcs rport state machine to address ocassional Brocade FC Direct Attach LUN discovery failure due to not sending PLOGI accept to the target. Signed-off-by: Vijaya Mohan Guvva --- drivers/scsi/bfa/bfa_fcs_rport.c | 4 ++--

[PATCH V1 01/17] bfa: Support for FC BB credit recovery

2013-05-13 Thread Vijaya Mohan Guvva
This patch includes changes to 1) Enable/disable fc credit recovery on Brocade FC adapter port operating at max supported speed. 2) Get credit recovery status and stats related to credit loss and recovered credits Signed-off-by: Vijaya Mohan Guvva --- drivers/scsi/bfa/bfa_defs.h | 10 +

[PATCH V1 16/17] bfa: dis-associate bfa path_tov with dev_loss_tmo

2013-05-13 Thread Vijaya Mohan Guvva
Disassoicate path_tov in the driver with the dev_loss_tmo set by the application. Signed-off-by: Vijaya Mohan Guvva --- drivers/scsi/bfa/bfad_attr.c | 33 +++-- 1 file changed, 7 insertions(+), 26 deletions(-) diff --git a/drivers/scsi/bfa/bfad_attr.c b/drivers/scsi/

[PATCH V1 11/17] bfa: firmware statistics update

2013-05-13 Thread Vijaya Mohan Guvva
Get RDS drop interrupts and REC (Read Exchange Concise) related stats from firmware. Signed-off-by: Vijaya Mohan Guvva --- drivers/scsi/bfa/bfa_defs_svc.h | 12 1 file changed, 12 insertions(+) diff --git a/drivers/scsi/bfa/bfa_defs_svc.h b/drivers/scsi/bfa/bfa_defs_svc.h index 3e8

[PATCH V1 17/17] bfa: Update the driver version to 3.2.21.1

2013-05-13 Thread Vijaya Mohan Guvva
Update bfa driver version to 3.2.21.1 Update bfa to use firmware image versions 3.2.1.0 Signed-off-by: Vijaya Mohan Guvva --- drivers/scsi/bfa/bfad.c | 6 +++--- drivers/scsi/bfa/bfad_drv.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/bfa/bfad.c b/drive

[PATCH V1 04/17] bfa: Fix WARN_ON condition check

2013-05-13 Thread Vijaya Mohan Guvva
The WARN_ON condition check in IO completion path is wrong. IOtags returned by the firmware is compared with driver/bfa iotag after masking the retry count bits. Signed-off-by: Vijaya Mohan Guvva --- drivers/scsi/bfa/bfa_fcpim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH V1 12/17] bfa: Allow rsp queue process during ioc disable

2013-05-13 Thread Vijaya Mohan Guvva
Allow processing completions from firmware during IOC_DISABLE request is being processed by the firmware, by setting the queue_process flag appropriately. Signed-off-by: Vijaya Mohan Guvva --- drivers/scsi/bfa/bfa_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drive

[PATCH V1 06/17] bfa: Fix 1860 port initialize when ATC is enabled

2013-05-13 Thread Vijaya Mohan Guvva
On Xen kernels, if ATC (address translation cache) is enabled, the first PCIe DMA read from the adapter fails with an error. This is due to a bug ASIC, which leads to a failure of 1860 ports to be initialised. This patch includes the fix to disable Invalidated Tag Match Enable capability by settin

[PATCH V1 08/17] bfa: kdump fix on 815 and 825 adapters

2013-05-13 Thread Vijaya Mohan Guvva
Root cause: When kernel crashes, On brocade 815/825 adapters, bfa IOC state machine and FW doesn't get a notification and hence are not cleanly shutdown. So registers holding driver/IOC state information are not reset back to valid disabled/parking values. This causes subsequent driver initializat

[PATCH V1 09/17] bfa: driver compatibility with 32bit libs

2013-05-13 Thread Vijaya Mohan Guvva
Replaced usage of void * with u64 in data structure shared between brocade user space libraries and the bfa driver to address pointer size changes across 32-bit vs 64-bit to have the compatibility between 32bit library and 64bit driver and vice versa. Signed-off-by: Vijaya Mohan Guvva --- driver

[PATCH V1 02/17] bfa: Forward Error Correction status query

2013-05-13 Thread Vijaya Mohan Guvva
This patch includes changes to get FC HBA feature Forward Error Correction (FEC) (enabled at 16Gig speed) status from firmware and to return to brocade HBA management utility. Signed-off-by: Vijaya Mohan Guvva --- drivers/scsi/bfa/bfa_defs_svc.h | 15 +-- drivers/scsi/bfa/bfa_svc.c

[PATCH V1] bfa: fix faulty handling of events in lps sm

2013-05-13 Thread Vijay Mohan Guvva
Resending the patch as it didn't make the link-scsi list. When a switch disable/enable or a reboot is done, the HBA port gets an offline and a subsequent online notification. When the port comes up a link up notification is sent to bfa from the firmware. The bfa then send an FLOGI to the firmware

[PATCH V1 10/17] bfa: fru vpd date update changes

2013-05-13 Thread Vijaya Mohan Guvva
1. While FRU VPD data update, inform firmware to send a completion event on I2C bus. Without this change, firmware used to send completion message on I2C bus for every chunk of FRU VPD update. 2. Support for FRU VPN update on CHINOOK2 cards. 3. Append port count to the model name to different

[PATCH V1 05/17] bfa: FDMI enhancements

2013-05-13 Thread Vijaya Mohan Guvva
Update addl. fields in FDMI to confirm to FC-GS6 standard for RPA and RHBA commands. Signed-off-by: Anil Gurumurthy Signed-off-by: Vijaya Mohan Guvva --- drivers/scsi/bfa/bfa_fc.h| 15 drivers/scsi/bfa/bfa_fcs.h | 21 - drivers/scsi/bfa/bfa_fcs_lport.c | 190 +++

[PATCH V1 13/17] bfa: Fix bug_on condition in RPSC rsp handling

2013-05-13 Thread Vijaya Mohan Guvva
Fix bug_on condition check in RPSC (Report Port Speed Capabilities) response processing. Signed-off-by: Vijaya Mohan Guvva --- drivers/scsi/bfa/bfa_fcs_rport.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/bfa/bfa_fcs_rport.c b/drivers/scsi/bfa/bfa_fcs_rpo

[PATCH V1 15/17] bfa: Support for chinook-quad port card

2013-05-13 Thread Vijaya Mohan Guvva
This patch enables support for chinook quad port 16G FC card (falcon) Signed-off-by: Vijaya Mohan Guvva --- drivers/scsi/bfa/bfa_defs.h | 5 - drivers/scsi/bfa/bfa_ioc.c | 1 + drivers/scsi/bfa/bfad.c | 8 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/s

Re: [PATCH RESEND 2/2] [SCSI] a3000: use module_platform_driver_probe()

2013-05-13 Thread Geert Uytterhoeven
On Thu, May 2, 2013 at 8:30 AM, Jingoo Han wrote: > This patch uses module_platform_driver_probe() macro which makes > the code smaller and simpler. > > Acked-by: Geert Uytterhoeven > Signed-off-by: Jingoo Han James, will you take this one? Or shall I queue it in the m68k tree? Thx! Gr{oetje,e