Re: [PATCH] iscsi-target: Make buf param of iscsit_do_crypto_hash_buf() const void *

2013-05-03 Thread Nicholas A. Bellinger
On Fri, 2013-05-03 at 23:22 +0200, Geert Uytterhoeven wrote: > On Fri, May 3, 2013 at 11:15 PM, Geert Uytterhoeven > wrote: > > --- a/drivers/target/iscsi/iscsi_target.c > > +++ b/drivers/target/iscsi/iscsi_target.c > > > @@ -3585,9 +3575,8 @@ static int iscsit_send_reject( > > } > > > >

Re: [PATCH] iscsi-target: Make buf param of iscsit_do_crypto_hash_buf() const void *

2013-05-03 Thread Nicholas A. Bellinger
On Fri, 2013-05-03 at 23:15 +0200, Geert Uytterhoeven wrote: > Make the "buf" input param of iscsit_do_crypto_hash_buf() "const void *". > This allows to remove lots of casts in its callers. > > Signed-off-by: Geert Uytterhoeven > --- Applied to target-pending/queue. Thanks Geert! --nab > dr

Re: [RFC-v4 7/9] iscsi-target: Refactor TX queue logic + export response PDU creation

2013-05-03 Thread Nicholas A. Bellinger
On Fri, 2013-05-03 at 23:04 +0200, Geert Uytterhoeven wrote: > Hi Nicholas, > > On Fri, Apr 12, 2013 at 10:52 PM, Nicholas A. Bellinger > wrote: > > --- a/drivers/target/iscsi/iscsi_target.c > > +++ b/drivers/target/iscsi/iscsi_target.c > > > static int iscsit_send_reject( > > struct is

Re: [PATCH] iscsi-target: Make buf param of iscsit_do_crypto_hash_buf() const void *

2013-05-03 Thread Geert Uytterhoeven
On Fri, May 3, 2013 at 11:15 PM, Geert Uytterhoeven wrote: > --- a/drivers/target/iscsi/iscsi_target.c > +++ b/drivers/target/iscsi/iscsi_target.c > @@ -3585,9 +3575,8 @@ static int iscsit_send_reject( > } > > if (conn->conn_ops->DataDigest) { > - iscsit_do_crypto_ha

[PATCH] iscsi-target: Make buf param of iscsit_do_crypto_hash_buf() const void *

2013-05-03 Thread Geert Uytterhoeven
Make the "buf" input param of iscsit_do_crypto_hash_buf() "const void *". This allows to remove lots of casts in its callers. Signed-off-by: Geert Uytterhoeven --- drivers/target/iscsi/iscsi_target.c | 57 ++- 1 files changed, 23 insertions(+), 34 deletions(-)

Re: [RFC-v4 7/9] iscsi-target: Refactor TX queue logic + export response PDU creation

2013-05-03 Thread Geert Uytterhoeven
Hi Nicholas, On Fri, Apr 12, 2013 at 10:52 PM, Nicholas A. Bellinger wrote: > --- a/drivers/target/iscsi/iscsi_target.c > +++ b/drivers/target/iscsi/iscsi_target.c > static int iscsit_send_reject( > struct iscsi_cmd *cmd, > struct iscsi_conn *conn) > @@ -3505,18 +3548,9 @@ stati

Re: [PATCH -next 2/2] sun3_scsi: switch to ->show_info()

2013-05-03 Thread Geert Uytterhoeven
Ping? Now the build failure is also in Linus' tree: http://kisskb.ellerman.id.au/kisskb/buildresult/8674437/ BTW, this patch depends on "[PATCH 1/2] sun3_scsi: Fill in missing scsi_host_template.proc_info method" On Wed, Apr 10, 2013 at 1:52 PM, Geert Uytterhoeven wrote: > Based on Al's change

Re: [PATCH 3/3] scsi: ufs: add support for query requests

2013-05-03 Thread James Bottomley
On Thu, 2013-05-02 at 17:25 +0530, Santosh Y wrote: > From: Dolev Raviv > > Add support for sending UFS query requests through tagged command > queuing. This design allows queuing query requests in any open slot > along with other SCSI commands. In this way there is no need to > save a slot in th

Re: [PATCH] scsi: Handle MLQUEUE busy response in scsi_send_eh_cmnd

2013-05-03 Thread James Bottomley
On Fri, 2013-05-03 at 10:24 -0400, wenxi...@linux.vnet.ibm.com wrote: > Quoting Hannes Reinecke : > > > scsi_send_eh_cmnd() is calling queuecommand() directly, so > > it needs to check the return value here. > > The only valid return codes for queuecommand() are 'busy' > > states, so we need to wa

Re: [PATCH 1/1] cciss: bug fix to prevent cciss from loading in kdump crash kernel

2013-05-03 Thread Mike Miller (OS Dev)
On Fri, 2013-05-03 at 11:02 -0700, James Bottomley wrote: > On Tue, 2013-04-23 at 12:25 -0500, Mike Miller wrote: > > PATCH 1/1 > > > > By default the cciss driver supports all "older" HP Smart Array controllers > > and hpsa supports all controllers starting with the G6 family. There are > > modul

Re: [PATCH 1/1] cciss: bug fix to prevent cciss from loading in kdump crash kernel

2013-05-03 Thread James Bottomley
On Tue, 2013-04-23 at 12:25 -0500, Mike Miller wrote: > PATCH 1/1 > > By default the cciss driver supports all "older" HP Smart Array controllers > and hpsa supports all controllers starting with the G6 family. There are > module parameters that allow a user to override those defaults and use hpsa

Re: [PATCH] scsi: Handle MLQUEUE busy response in scsi_send_eh_cmnd

2013-05-03 Thread wenxiong
Quoting Hannes Reinecke : scsi_send_eh_cmnd() is calling queuecommand() directly, so it needs to check the return value here. The only valid return codes for queuecommand() are 'busy' states, so we need to wait for a bit to allow the LLDD to recover. Based on an earlier patch from Wen Xiong.

[RFC] scsi: ufs: Rework UFS host driver implementation

2013-05-03 Thread Sujit Reddy Thumma
UFS protocol comprises of two specifications, UFS device and UFS host controller specification. The current UFSHCD driver combines implementation of both the specs into one file. As new features evolve in both specifications one single file looks cumbersome and hard to maintain. Split the UFS drive

[PATCH 1/1] [scsi] ufs: Remove redundant platform_set_drvdata()

2013-05-03 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat --- drivers/scsi/ufs/ufshcd-pltfrm.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi

Re: initial LIO iSER performance numbers [was: GIT PULL] target updates for v3.10-rc1)

2013-05-03 Thread Asias He
On Fri, May 03, 2013 at 09:57:20AM +0300, Or Gerlitz wrote: > On Thu, May 2, 2013 at 10:31 PM, Nicholas A. Bellinger > wrote: > > >> We used RAMDISK_MCP backend which was patched to act as NULL device, so > >> we can test the raw iSER wire performance. > > > Btw, I'll be including a similar patc