Re: [PATCH 03/16] libfcoe: Save some memory and optimize name lookups

2012-12-12 Thread Bart Van Assche
On 12/13/12 00:22, Robert Love wrote: @@ -210,25 +210,23 @@ static ssize_t show_fcoe_fcf_device_##field(struct device *dev, \ #define fcoe_enum_name_search(title, table_type, table) \ static const char *get_fcoe_##title##_name(enum table_type table_key) \ {

FCoE Updates for 3.8

2012-12-12 Thread Robert Love
The following changes since commit b69f0859dc8e633c5d8c06845811588fe17e68b3: Linux 3.7-rc8 (2012-12-03 11:22:37 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/rwlove/fcoe.git for-next-12-12-12 for you to fetch changes up to 04f0ac991b5dd2a32c3f

[PATCH 16/16] debris left by "[SCSI] libfcoe: Remove mutex_trylock/restart_syscall checks"

2012-12-12 Thread Robert Love
From: Al Viro AFAICS, the situation for fcoe_transport_disable() seems to be the same as for fcoe_transport_enable(). IOW, shouldn't it have restart_syscall() removed as well? I don't see any in-tree ->disable() instances that could return -ERESTARTSYS, anyway... Signed-off-by: Al Viro

[PATCH 15/16] bnx2fc: use fcoe_get_lesb/fcoe_ctlr_get_lesb() directly from libfcoe

2012-12-12 Thread Robert Love
From: Yi Zou Drop the bnx2fc_xxx versions as they are basically the same. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 53 + 1 file changed, 7 insertions(+)

[PATCH 14/16] bnx2fc: use fcoe_link_speed_update() from the exported symbol in libfcoe

2012-12-12 Thread Robert Love
From: Yi Zou We have fcoe_link_speed_update() in libfcoe ready for use now, take out the bnx2fc version which is almost the same. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 33 ++

[PATCH 13/16] bnx2fc: add support to get_netdev for bnx2f_interface

2012-12-12 Thread Robert Love
From: Yi Zou Adds support to fcoe_port's newly added get_netdev fucntion pointer for bnx2fc. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions

[PATCH 12/16] libfcoe, fcoe: consolidate the fcoe_ctlr_get_lesb/fcoe_get_lesb

2012-12-12 Thread Robert Love
From: Yi Zou Similarly they can be moved into libfcoe instead of being private to fcoe now. Also add comments particularly on the term LESB to the corresponding function. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- drivers/scsi/f

[PATCH 11/16] libfcoe, fcoe: move fcoe_link_speed_update() to libfcoe and export it

2012-12-12 Thread Robert Love
From: Yi Zou With the previous patch, fcoe_link_speed_update() can be moved into libfcoe and exported to used by fcoe, bnx2fc, and etc. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe.c | 35 ---

[PATCH 10/16] fcoe: add support to the get_netdev() for fcoe_interface

2012-12-12 Thread Robert Love
From: Yi Zou Adds support to fcoe_port's newly added get_netdev fucntion pointer. Signed-off-by: Yi Zou Cc: Bhanu Prakash Gollapudi Tested-by: Marcus Dennis Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe.c |1 + include/scsi/libfcoe.h | 12 2 files changed, 13 in

[PATCH 09/16] fcoe: prep work to start consolidate the usage of fcoe_netdev

2012-12-12 Thread Robert Love
From: Yi Zou Currently, in the default kernel fcoe driver, it is needed to get to the underlying private per fcoe transport's private structure, e.g., fcoe_interface in fcoe.ko, and returns the associated netdev. The similar logic exists in other fcoe drivers, e.g., bnx2fc, so we add a function

[PATCH 08/16] libfc, libfcoe, fcoe: Convert debug_logging macros to pr_info

2012-12-12 Thread Robert Love
Convert libfc, libfcoe and fcoe's debug_logging macros to use pr_info() instead of printk(KERN_INFO, ...). checkpatch.pl now complains about this, so convert libfcoe to preferred method. Signed-off-by: Robert Love Tested-by: Marcus Dennis --- drivers/scsi/fcoe/fcoe.h |6 +++--- drivers

[PATCH 06/16] fcoe: Use the fcoe_sysfs control interface

2012-12-12 Thread Robert Love
This patch adds support for the new fcoe_sysfs control interface to fcoe.ko. It keeps the deprecated interface in tact and therefore either the legacy or the new control interfaces can be used. A mixed mode is not supported. A user must either use the new interfaces or the old ones, but not both.

[PATCH 07/16] bnx2fc: Use the fcoe_sysfs control interface

2012-12-12 Thread Robert Love
This patch adds support for the new fcoe_sysfs control interface to bnx2fc.ko. It keeps the deprecated interface in tact and therefore either the legacy or the new control interfaces can be used. A mixed mode is not supported. A user must either use the new interfaces or the old ones, but not both.

[PATCH 05/16] libfcoe, fcoe, bnx2fc: Add new fcoe control interface

2012-12-12 Thread Robert Love
This patch does a few things. 1) Makes /sys/bus/fcoe/ctlr_{create,destroy} interfaces. These interfaces take an and will either create an FCoE Controller or destroy an FCoE Controller depending on which file is written to. The new FCoE Controller will start in a DISABLED state and

[PATCH 04/16] libfcoe: Add fcoe_sysfs debug logging level

2012-12-12 Thread Robert Love
Add a macro to print fcoe_sysfs debug statements. Signed-off-by: Robert Love Acked-by: Neil Horman --- drivers/scsi/fcoe/fcoe_sysfs.c |7 +++ drivers/scsi/fcoe/libfcoe.h| 11 --- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_sysfs.c

[PATCH 03/16] libfcoe: Save some memory and optimize name lookups

2012-12-12 Thread Robert Love
Instead of creating a structure with an enum and a pointer to a string, simply allocate an array of strings and use the enum values for the indicies. This means that we do not need to iterate through the list of entries when looking up a string name by its enum key. This will also help with a lat

[PATCH 00/16] libfc, libfcoe and fcoe updates for 3.8

2012-12-12 Thread Robert Love
There are two primary changes within this update. Additionally there are two or three fix/cleanup patches. The first change is the addition of the fcoe_sysfs "control" interfaces. These patches were well vetted on the scsi mailing list and have only seen validation and a minor fix or two, as th

[PATCH 01/16] libfc: fix REC handling

2012-12-12 Thread Robert Love
From: Vasu Dev Currently fc_fcp_timeout doesn't check FC_RP_FLAGS_REC_SUPPORTED flag first, this prevents REC request ever going out at all to the target having REC support. So this patches fixes the fc_fcp_timeout by checking FC_RP_FLAGS_REC_SUPPORTED flag first. The changed order won't cause a

[PATCH 02/16] Documentation: Add missing devices/ to devices path

2012-12-12 Thread Robert Love
Add missing 'devices/ subdirectory to /sys/bus/fcoe/devices/ctlr_X and /sys/bus/fcoe/devices/fcf_X references. Signed-off-by: Robert Love Tested-by: Ross Brattain --- Documentation/ABI/testing/sysfs-bus-fcoe |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentatio

Re: [PATCH] [SCSI] scsi_debug: fix deadlock on module unload, also complete queued commands

2012-12-12 Thread Douglas Gilbert
On 12-12-13 04:00 AM, Ewan D. Milne wrote: From: "Ewan D. Milne" The module unload path in scsi_debug was calling del_timer_sync() with the queued_arr_lock held. The timer_intr_handler() function also takes this lock, so if it executes as the timer is being removed, the kernel would deadlock.

[PATCH] Save and restore host_scribble during error handling

2012-12-12 Thread Bart Van Assche
A SCSI LLD may overwrite host_scribble in its queuecommand() implementation. Several drivers need that field to process requests and aborts correctly. Hence this field must be saved by scsi_eh_prep_cmnd() and must be restored by scsi_eh_restore_cmnd(). Signed-off-by: Bart Van Assche Cc: James Bot

[PATCH] [SCSI] scsi_debug: fix deadlock on module unload, also complete queued commands

2012-12-12 Thread Ewan D. Milne
From: "Ewan D. Milne" The module unload path in scsi_debug was calling del_timer_sync() with the queued_arr_lock held. The timer_intr_handler() function also takes this lock, so if it executes as the timer is being removed, the kernel would deadlock. Also changed to complete all queued commands

[GIT PULL] First round of SCSI updates for the 3.7+ merge window

2012-12-12 Thread James Bottomley
This patch set includes two large new drivers: mpt3sas (for the next gen fusion SAS hardware) and csiostor a FCoE offload driver for the Chelsio converged network cards (this includes some net changes which I've OK'd with DaveM). The rest of the patch is driver updates (qla2xxx, lpfc, hptiop, be2i