Re: [PATCH v8 09/11] block: add a new interface to block events

2012-10-31 Thread Aaron Lu
Hi, On 11/01/2012 05:51 AM, Tejun Heo wrote: > Hello, > > On Tue, Oct 30, 2012 at 03:04:17PM +0800, Aaron Lu wrote: >>> check_event() can retry. Just add a per-sr mutex which is try-locked >>> by sr_block_check_events() and grab it when entering zero power. >> >> Good suggestion. I didn't think

RE: tcm_fc+ libfcoe regression on v3.7-rc2

2012-10-31 Thread Nicholas A. Bellinger
On Wed, 2012-10-31 at 23:08 +, Zou, Yi wrote: > > On Fri, 2012-10-26 at 23:59 +, Zou, Yi wrote: > > > > <-- snip --> > > > > > > M, not sure on this one. There have definitely been changes in the > > TCM active I/O shutdown codepath to support tcm_qla2xxx active I/O > > shutdown start

[PATCH] target: Re-add explict zeroing of INQUIRY bounce buffer memory

2012-10-31 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch fixes a regression in spc_emulate_inquiry() code where the local scope bounce buffer was no longer getting it's memory zeroed, causing various problems with SCSI initiators that depend upon areas of INQUIRY EVPD=0x83 payload having been zeroed. This bug was in

Re: [PATCH v8 05/11] libata-eh: allow defer in ata_exec_internal

2012-10-31 Thread Aaron Lu
On 11/01/2012 05:52 AM, Tejun Heo wrote: > Hello, > > On Tue, Oct 30, 2012 at 11:09:21AM +0800, Aaron Lu wrote: >> I'm not aware of a place to store such ODD specific information when >> probing the device. > > You can always add some fields. :) OK. My concern is that, such information is only u

RE: tcm_fc+ libfcoe regression on v3.7-rc2

2012-10-31 Thread Zou, Yi
> On Fri, 2012-10-26 at 23:59 +, Zou, Yi wrote: > > <-- snip --> > > > M, not sure on this one. There have definitely been changes in the > TCM active I/O shutdown codepath to support tcm_qla2xxx active I/O > shutdown starting in v3.5 code, so if pre v3.5 code is working as > expected it

Re: [PATCH v8 05/11] libata-eh: allow defer in ata_exec_internal

2012-10-31 Thread Tejun Heo
Hello, On Tue, Oct 30, 2012 at 11:09:21AM +0800, Aaron Lu wrote: > I'm not aware of a place to store such ODD specific information when > probing the device. You can always add some fields. :) > I'm currently storing the loading mech type in structure zpodd, which > gets created after the corres

Re: [PATCH v8 09/11] block: add a new interface to block events

2012-10-31 Thread Tejun Heo
Hello, On Tue, Oct 30, 2012 at 03:04:17PM +0800, Aaron Lu wrote: > > check_event() can retry. Just add a per-sr mutex which is try-locked > > by sr_block_check_events() and grab it when entering zero power. > > Good suggestion. I didn't think about solving it this way. > > Many people suggest m

[Bug 48871] drivers/scsi/lpfc/lpfc_init.c: 2 * Buffer is accessed out of bounds

2012-10-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=48871 Alan changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[PATCH 2/2] bfa: remove unused bfa_get_pciids() and struct bfa_pciid_s

2012-10-31 Thread Rolf Eike Beer
Signed-off-by: Rolf Eike Beer --- drivers/scsi/bfa/bfa.h | 9 - drivers/scsi/bfa/bfa_core.c | 18 -- 2 files changed, 27 deletions(-) diff --git a/drivers/scsi/bfa/bfa.h b/drivers/scsi/bfa/bfa.h index 4ad7e36..0ef77dc 100644 --- a/drivers/scsi/bfa/bfa.h +++ b/driver

[PATCH 1/2] bfa: remove unused pci_slot from struct bfa_pcidev_s

2012-10-31 Thread Rolf Eike Beer
Signed-off-by: Rolf Eike Beer --- drivers/scsi/bfa/bfa_ioc.h | 1 - drivers/scsi/bfa/bfad.c| 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/scsi/bfa/bfa_ioc.h b/drivers/scsi/bfa/bfa_ioc.h index b2856f9..80a2c15 100644 --- a/drivers/scsi/bfa/bfa_ioc.h +++ b/drivers/scsi/bfa/bfa_ioc

[Bug 49821] New: Random Call traces when using tape device.

2012-10-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=49821 Summary: Random Call traces when using tape device. Product: IO/Storage Version: 2.5 Kernel Version: 3.2.29 Platform: All OS/Version: Linux Tree: Mainline Status: NEW

[Bug 48891] scsi/lpfc/lpfc_ct.c:637: possible finger trouble ?

2012-10-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=48891 --- Comment #1 from James Smart 2012-10-31 19:03:04 --- Thank You. This problem has been addressed by patch6 of our 8.3.36 patch kit: See http://marc.info/?l=linux-scsi&m=135170916626123&w=2 -- james s On 10/17/2012 6:24 AM, bugzilla-d

Re: [Bug 48891] scsi/lpfc/lpfc_ct.c:637: possible finger trouble ?

2012-10-31 Thread James Smart
Thank You. This problem has been addressed by patch6 of our 8.3.36 patch kit: See http://marc.info/?l=linux-scsi&m=135170916626123&w=2 -- james s On 10/17/2012 6:24 AM, bugzilla-dae...@bugzilla.kernel.org wrote: https://bugzilla.kernel.org/show_bug.cgi?id=48891 Alan changed:

[Bug 48871] drivers/scsi/lpfc/lpfc_init.c: 2 * Buffer is accessed out of bounds

2012-10-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=48871 --- Comment #1 from James Smart 2012-10-31 19:02:13 --- Thank You. This problem has been addressed by patch5 of our 8.3.36 patch kit: See http://marc.info/?l=linux-scsi&m=135170915426118&w=2 -- james s On 10/17/2012 6:26 AM, bugzilla-d

Re: [Bug 48871] drivers/scsi/lpfc/lpfc_init.c: 2 * Buffer is accessed out of bounds

2012-10-31 Thread James Smart
Thank You. This problem has been addressed by patch5 of our 8.3.36 patch kit: See http://marc.info/?l=linux-scsi&m=135170915426118&w=2 -- james s On 10/17/2012 6:26 AM, bugzilla-dae...@bugzilla.kernel.org wrote: https://bugzilla.kernel.org/show_bug.cgi?id=48871 Alan changed:

Re: [patch 09/10] lpfc: use scsi_host_alloc_node

2012-10-31 Thread James Smart
Thanks Jeff. -- james s Acked-By: James Smart On 10/30/2012 4:14 PM, Jeff Moyer wrote: Signed-off-by: Jeff Moyer --- drivers/scsi/lpfc/lpfc_init.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_in

[PATCH 7/7] lpfc 8.3.36: Update lpfc version for 8.3.36 driver release

2012-10-31 Thread James Smart
Update lpfc version for 8.3.36 driver release Signed-off-by: James Smart --- lpfc_version.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h --- a/drivers/scsi/lpfc/lpfc_version.h 2012-10-23 09:51:51.

[PATCH 6/7] lpfc 8.3.36: Correct mask error

2012-10-31 Thread James Smart
Correct mask error Reported via: https://bugzilla.kernel.org/show_bug.cgi?id=48891 Signed-off-by: James Smart --- lpfc_ct.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c --- a/drivers/scsi/lpfc/lpfc_ct.c

[PATCH 5/7] lpfc 8.3.36: Correct buffer length overrun

2012-10-31 Thread James Smart
Correct buffer length overrun Reported via: https://bugzilla.kernel.org/show_bug.cgi?id=48871 Signed-off-by: James Smart --- lpfc_init.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c --- a/drivers/scsi/l

[PATCH 4/7] lpfc 8.3.36: Fixed setting sequential delivery bit

2012-10-31 Thread James Smart
Fixed setting sequential delivery bit in a service class that is not valid Signed-off-by: James Smart --- lpfc_els.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c --- a/drivers/scsi/lpfc/lpfc_els.c

[PATCH 3/7] lpfc 8.3.36: Update DIF support for passthru/strip/insert

2012-10-31 Thread James Smart
Update DIF support for passthru/strip/insert Signed-off-by: James Smart --- lpfc_hw4.h |3 +++ lpfc_scsi.c | 16 +++- lpfc_sli.c | 16 lpfc_sli.h |4 +++- 4 files changed, 29 insertions(+), 10 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_hw4.

[PATCH 2/7] lpfc 8.3.36: Fix bug with Target Resets and FCP2 devices

2012-10-31 Thread James Smart
Fix bug with Target Resets and FCP2 devices Create module parameter to disable Target Reset on FCP-Tape devices when a "bus reset" is requested. Default is to reset all devices on bus reset. Signed-off-by: James Smart --- lpfc.h |1 + lpfc_attr.c | 12 lpfc_scsi.c |

[PATCH 1/7] lpfc 8.3.36: Fixed boot from san failure

2012-10-31 Thread James Smart
Fixed boot from san failure when SLI4 FC device presented on the same PCI bus The request_firmware interface can induce delays while looking for firmware files, even if no fw file is present. In some situations the delays exceeded scan_wait timeouts, resulting in situations in which the boot devic

[PATCH 0/7] lpfc 8.3.36: Update lpfc to revision 8.3.36

2012-10-31 Thread James Smart
This patch set updates the lpfc driver to revision 8.3.36 The patches for 8.3.36 contain: - Fixed boot from san failure - Fix bug with Target Resets and FCP2 devices - Update DIF support for passthru/strip/insert - Fixed setting sequential delivery bit - Correct buffer length overrun. - Correct

Your Kernel Bug Tracker bug list needs attention.

2012-10-31 Thread bugzilla-daemon
[This e-mail has been automatically generated.] You have one or more bugs assigned to you in the Kernel Bug Tracker bug tracking system (https://bugzilla.kernel.org/) that require attention. All of these bugs are in the NEW orREOPENED state, and have not been touched in 7 days or more. You need

Re: scsi:sd: provisioning_mode not being set to unmap

2012-10-31 Thread John Washer
The culprit was VPD page 0. Inquiry on VPD page 0 wasn't returning 0xb0 as one of the supported pages. So, the *scsi_get_vpd_page(sdkp->device, 0xb0, buffer, vpd_len))* was failing. Corrected VPD page 0 response. Now everything works as expected... :-) Thanks anyway... -John On Tue, Oct 30, 2012