Re: [RFC PATCH v2 5/5] bnx2fc: Use the fcoe_sysfs control interface

2012-09-30 Thread Bhanu Prakash Gollapudi
On 09/26/2012 07:02 PM, Robert Love wrote: This patch adds support for the new fcoe_sysfs control interface to bnx2fc.ko. It keeps the deprecated interface in tact and therefore either the legacy or the new control interfaces can be used. A mixed mode is not supported. A user must either use the

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-30 Thread Jeff Garzik
On 09/30/2012 03:43 PM, Alan Stern wrote: On Sun, 30 Sep 2012, Jeff Garzik wrote: The simple fact of "only ZPODD devices out there are ATA" is not the decision-maker for where the code should live. It is more a question where ZPODD belongs in the device/command set model currently employed.

Re: [V5 PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

2012-09-30 Thread Naresh Kumar Inna
Hi James, Do you have any update with regards to the review of this driver? You were mentioning about getting FC folks to take a look at it. Thanks, Naresh. On 9/24/2012 10:47 PM, Naresh Kumar Inna wrote: > This is the initial submission of the Chelsio FCoE offload driver (csiostor) > to the ups

Re: [PATCH] qla2xxx: silence two GCC warnings

2012-09-30 Thread Rolf Eike Beer
Am Sonntag 30 September 2012, 13:07:54 schrieb Paul Bolle: > Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC > warnings: > drivers/scsi/qla2xxx/qla_gs.c: In function ‘qla2x00_fdmi_rhba’: > drivers/scsi/qla2xxx/qla_gs.c:1339:7: warning: array subscript is above > array bound

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-30 Thread Alan Stern
On Sun, 30 Sep 2012, Jeff Garzik wrote: > The simple fact of "only ZPODD devices out there are ATA" is not the > decision-maker for where the code should live. It is more a question > where ZPODD belongs in the device/command set model currently employed. I don't really accept this argument.

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-30 Thread Jeff Garzik
On 09/30/2012 10:47 AM, Alan Stern wrote: On Sun, 30 Sep 2012, Aaron Lu wrote: Makes sense to me, but there is a problem if I want to block events checking for the disk, as I do not have a pointer to the gendisk in ATA layer. You may discover the gendisk by going the ATA -> SCSI -> block rout

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-30 Thread Jeff Garzik
On 09/29/2012 06:44 PM, Rafael J. Wysocki wrote: On Saturday, September 29, 2012, Aaron Lu wrote: On 09/29/2012 10:29 PM, Alan Stern wrote: On Sat, 29 Sep 2012, Aaron Lu wrote: I don't think this is a good idea, quite frankly. sr seems to be a too generic place for that. Does this mean sr

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-30 Thread Jeff Garzik
On 09/29/2012 06:31 PM, Rafael J. Wysocki wrote: On Saturday, September 29, 2012, Alan Stern wrote: Can arbitrary SCSI devices be ZP, or does this notion apply only to ATAPI-based drives? That's the key question, and the answer determines where the ZP support belongs. I agree. That said for

Re: [RFC PATCH v2 3/5] libfcoe, fcoe, bnx2fc: Add new fcoe control interface

2012-09-30 Thread Bart Van Assche
On 09/27/12 04:01, Robert Love wrote: +static ssize_t store_ctlr_enabled(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + struct fcoe_ctlr_device *ctlr = dev_to_ctlr(dev); + int v

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-30 Thread Aaron Lu
On 09/30/2012 10:47 PM, Alan Stern wrote: > On Sun, 30 Sep 2012, Aaron Lu wrote: > >> Makes sense to me, but there is a problem if I want to block events >> checking for the disk, as I do not have a pointer to the gendisk in ATA >> layer. > >> The tray will be ejected by the ODD itself when it ha

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-30 Thread Alan Stern
On Sun, 30 Sep 2012, Aaron Lu wrote: > Makes sense to me, but there is a problem if I want to block events > checking for the disk, as I do not have a pointer to the gendisk in ATA > layer. > The tray will be ejected by the ODD itself when it has power, I do not > need to do that. Moreover, I don

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-30 Thread Aaron Lu
On Sun, Sep 30, 2012 at 12:27:41AM +0200, Rafael J. Wysocki wrote: > On Saturday, September 29, 2012, Aaron Lu wrote: > > [Adding more people and list back in] > > > > On 09/29/2012 05:46 AM, Rafael J. Wysocki wrote: > > > On Friday, September 28, 2012, Aaron Lu wrote: > > >> On 09/28/2012 07:15 A

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-30 Thread Aaron Lu
On Sun, Sep 30, 2012 at 12:44:50AM +0200, Rafael J. Wysocki wrote: > On Saturday, September 29, 2012, Aaron Lu wrote: > > On 09/29/2012 10:29 PM, Alan Stern wrote: > > > On Sat, 29 Sep 2012, Aaron Lu wrote: > > > > > >>> I don't think this is a good idea, quite frankly. sr seems to be a too > > >

[PATCH] qla2xxx: silence two GCC warnings

2012-09-30 Thread Paul Bolle
Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC warnings: drivers/scsi/qla2xxx/qla_gs.c: In function ‘qla2x00_fdmi_rhba’: drivers/scsi/qla2xxx/qla_gs.c:1339:7: warning: array subscript is above array bounds [-Warray-bounds] drivers/scsi/qla2xxx/qla_gs.c: In function ‘q