Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-26 Thread Jeff Garzik
On 09/25/2012 06:38 AM, James Bottomley wrote: On Tue, 2012-09-25 at 01:21 -0400, Jeff Garzik wrote: Can you be more specific about sysfs location? A runtime-writable (via sysfs!) module parameter for a module-wide default seemed appropriate. Well, if it's really important, the same thing sho

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-26 Thread James Bottomley
On Wed, 2012-09-26 at 22:20 -0400, Martin K. Petersen wrote: > > "James" == James Bottomley > > writes: > > James> On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: > >> > >> drivers/scsi/sd.c | 4 drivers/scsi/sd.h | 2 +- 2 files changed, > >> 5 insertions(+), 1 deletion(-) >

Re: [PATCH scsi] Add NULL checking of return value from scsi_cmd_to_driver()

2012-09-26 Thread James Bottomley
On Wed, 2012-09-26 at 22:02 -0400, Martin K. Petersen wrote: > > "James" == James Bottomley > > writes: > > James> Plus, I think it fixes a bug where you get different behaviours > James> from REQ_TYPE_BLOCK_PC commands when a driver is and isn't > James> attached (I've cc'd Martin to se

Re: [SCSI] sd: Ensure we correctly disable devices with unknown protection type

2012-09-26 Thread Martin K. Petersen
> "Dan" == Dan Carpenter writes: Dan, Dan> warn: buffer overflow 'cap' 4 <= 4 Argh, yes. Type 3 is 4 because it's a bitmask. -- Martin K. Petersen Oracle Linux Engineering SCSI: Fix range check in scsi_host.h The range checking from fe542396 was bad. We would still end up walk

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-26 Thread Martin K. Petersen
> "James" == James Bottomley writes: James> On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: >> >> drivers/scsi/sd.c | 4 drivers/scsi/sd.h | 2 +- 2 files changed, >> 5 insertions(+), 1 deletion(-) James> I'm not opposed in principle to doing this (except that it should James> be a

Re: [PATCH scsi] Add NULL checking of return value from scsi_cmd_to_driver()

2012-09-26 Thread Martin K. Petersen
> "James" == James Bottomley writes: James> Plus, I think it fixes a bug where you get different behaviours James> from REQ_TYPE_BLOCK_PC commands when a driver is and isn't James> attached (I've cc'd Martin to see what he thinks). I'm fine with having the eh action be triggered for FS reque

[RFC PATCH v2 5/5] bnx2fc: Use the fcoe_sysfs control interface

2012-09-26 Thread Robert Love
This patch adds support for the new fcoe_sysfs control interface to bnx2fc.ko. It keeps the deprecated interface in tact and therefore either the legacy or the new control interfaces can be used. A mixed mode is not supported. A user must either use the new interfaces or the old ones, but not both.

[RFC PATCH v2 4/5] fcoe: Use the fcoe_sysfs control interface

2012-09-26 Thread Robert Love
This patch adds support for the new fcoe_sysfs control interface to fcoe.ko. It keeps the deprecated interface in tact and therefore either the legacy or the new control interfaces can be used. A mixed mode is not supported. A user must either use the new interfaces or the old ones, but not both.

[RFC PATCH v2 3/5] libfcoe, fcoe, bnx2fc: Add new fcoe control interface

2012-09-26 Thread Robert Love
This patch does a few things. 1) Makes /sys/bus/fcoe/ctlr_{create,destroy} interfaces. These interfaces take an and will either create an FCoE Controller or destroy an FCoE Controller depending on which file is written to. The new FCoE Controller will start in a DISABLED state and

[RFC PATCH v2 2/5] libfcoe: Add fcoe_sysfs debug logging level

2012-09-26 Thread Robert Love
Add a macro to print fcoe_sysfs debug statements. Signed-off-by: Robert Love --- drivers/scsi/fcoe/fcoe_sysfs.c |7 +++ drivers/scsi/fcoe/libfcoe.h| 11 --- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_sysfs.c b/drivers/scsi/fcoe/fc

[RFC PATCH v2 1/5] fix_section_mismatch

2012-09-26 Thread Robert Love
Already fixed upstream. --- drivers/scsi/fcoe/fcoe_transport.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c index b46f43d..71cc909 100644 --- a/drivers/scsi/fcoe/fcoe_transport.c +++ b/drivers/scsi/f

[RFC PATCH v2 0/5] Add new fcoe_sysfs based control interfaces to libfcoe, bnx2fc and fcoe

2012-09-26 Thread Robert Love
This series applies to the v3.5 kernel. The following series adds /sys/bus/fcoe based control interfaces to libfcoe. A fcoe_sysfs infrastructure was added to the kernel a few cycles ago, this series builds on that work. The patches deprecate the old create, vn2vn_create, destroy, enable and disabl

Re: [PATCH 00/20, v4] Make ib_srp better suited for H.A. purposes

2012-09-26 Thread David Dillow
On Tue, 2012-09-25 at 17:05 +0200, Bart Van Assche wrote: > On 08/09/12 17:41, Bart Van Assche wrote: > > [ ... ] > > Hello Dave, > > More than six weeks have elapsed since I posted version four of this > patch series. It would be appreciated if you could tell me when review > comments for this

[PATCH] Scsi: Fixed white space and tab errors.

2012-09-26 Thread Josh Taylor
Signed-off-by: Josh Taylor --- drivers/scsi/scsi.c | 66 +-- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 2936b44..00aded9 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-26 Thread Adrian Sandu
2012-09-26T20:13:09.700606+03:00 d3xt3r01 kernel: [ 2466.455403] usb 3-1.1: reset SuperSpeed USB device number 14 using xhci_hcd 2012-09-26T20:13:09.713629+03:00 d3xt3r01 kernel: [ 2466.468373] xhci_hcd :04:00.0: xHCI xhci_drop_endpoint called with disabled ep 88011aea1300 2012-09-26T20:13:

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-26 Thread Adrian Sandu
On Wed, Sep 26, 2012 at 5:50 PM, Alan Stern wrote: > On Tue, 25 Sep 2012, Sarah Sharp wrote: > >> Alan, I'm wondering if the xHCI ring expansion is causing issues with >> USB hard drives under xHCI. Testing with a Buffalo USB 3.0 hard drive >> with an NEC uPD720200 xHCI host, I see that the usb-s

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-26 Thread Aaron Lu
On Wed, Sep 26, 2012 at 7:18 PM, Rafael J. Wysocki wrote: > On Wednesday, September 26, 2012, Aaron Lu wrote: >> On Tue, Sep 25, 2012 at 11:45:34PM +0200, Rafael J. Wysocki wrote: >> > On Tuesday, September 25, 2012, Aaron Lu wrote: >> > > On 09/25/2012 10:23 PM, Oliver Neukum wrote: >> > > > On T

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-26 Thread Alan Stern
On Tue, 25 Sep 2012, Sarah Sharp wrote: > Alan, I'm wondering if the xHCI ring expansion is causing issues with > USB hard drives under xHCI. Testing with a Buffalo USB 3.0 hard drive > with an NEC uPD720200 xHCI host, I see that the usb-storage and SCSI > initialization produces I/O errors on ra

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-26 Thread Rafael J. Wysocki
On Wednesday, September 26, 2012, Aaron Lu wrote: > On Tue, Sep 25, 2012 at 11:45:34PM +0200, Rafael J. Wysocki wrote: > > On Tuesday, September 25, 2012, Aaron Lu wrote: > > > On 09/25/2012 10:23 PM, Oliver Neukum wrote: > > > > On Tuesday 25 September 2012 22:20:21 Aaron Lu wrote: > > > >> On Tue

re: [SCSI] sd: Ensure we correctly disable devices with unknown protection type

2012-09-26 Thread Dan Carpenter
Hi Martin, The patch fe542396da73: "[SCSI] sd: Ensure we correctly disable devices with unknown protection type" from Sep 21, 2012, leads to the following warning: include/scsi/scsi_host.h:879 scsi_host_dif_capable() warn: buffer overflow 'cap' 4 <= 4 838 enum scsi_host_prot_capabili

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-26 Thread Oliver Neukum
On Tuesday 25 September 2012 22:46:06 Aaron Lu wrote: > On 09/25/2012 10:23 PM, Oliver Neukum wrote: > >> BTW, if sr_suspend should be generic, that would suggest I shouldn't > >> write any ZPODD related code there, right? Any suggestion where these > >> code should go then? > > > > libata. Maybe