Re: Tape device request_queue kref accounting bug causes slab corruption

2012-09-14 Thread Joe Lawrence
From: Joe Lawrence Date: Fri, 14 Sep 2012 16:27:48 -0400 Subject: [PATCH] SCSI: st: Take additional queue ref in st_probe The disk_release function expects that add_disk was called and that the latter function took an extra reference to the disk queue. The st driver does not call add_disk, but w

Tape device request_queue kref accounting bug causes slab corruption

2012-09-14 Thread Joe Lawrence
In [PATCH] block: make gendisk hold a reference to its queue (523e1d399ce0e23bec562abe2b2f8d297af81161), add_disk() and disk_release() were modified to get/put an additional reference on a disk queue to fix a reference counting discrepency between bdev release and SCSI device removal. The releven

[scsi:for-next 92/128] drivers/scsi/qla2xxx/qla_isr.c:1684:56: warning: 'rval' may be used uninitialized in this function

2012-09-14 Thread Fengguang Wu
Hi Saurav, FYI, there are new compile warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next head: 71cfff4af0525891941199b142b759d00b293959 commit: 387fddaa3564503c9f82d091d2ebe390f3af62a1 [92/128] [SCSI] qla2xxx: Implementation of bidirectional. confi

Re: [PATCH 22/24] scsi: eesox: use __iomem pointers for MMIO

2012-09-14 Thread Russell King - ARM Linux
On Fri, Sep 14, 2012 at 11:34:50PM +0200, Arnd Bergmann wrote: > ARM is moving to stricter checks on readl/write functions, > so we need to use the correct types everywhere. There's nothing wrong with const iomem pointers. If you think otherwise, patch x86 not to use const in its accessor impleme

[PATCH 22/24] scsi: eesox: use __iomem pointers for MMIO

2012-09-14 Thread Arnd Bergmann
ARM is moving to stricter checks on readl/write functions, so we need to use the correct types everywhere. Cc: "James E.J. Bottomley" Cc: linux-scsi@vger.kernel.org Signed-off-by: Arnd Bergmann --- drivers/scsi/arm/eesox.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH] hpsa: fix handling of protocol error

2012-09-14 Thread Stephen M. Cameron
From: Stephen M. Cameron If a command status of CMD_PROTOCOL_ERR is received, this information should be conveyed to the SCSI mid layer, not dropped on the floor. CMD_PROTOCOL_ERR may be received from the Smart Array for any commands destined for an external RAID controller such as a P2000, or c

Re: [PATCH 42/42] qla2xxx: Update version number to 8.04.00.07-k.

2012-09-14 Thread Chad Dupuis
On Fri, 14 Sep 2012, James Bottomley wrote: On Wed, 2012-08-22 at 14:21 -0400, Chad Dupuis wrote: Signed-off-by: Giridhar Malavali Signed-off-by: Chad Dupuis --- drivers/scsi/qla2xxx/qla_version.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2

Re: [PATCH 42/42] qla2xxx: Update version number to 8.04.00.07-k.

2012-09-14 Thread James Bottomley
On Wed, 2012-08-22 at 14:21 -0400, Chad Dupuis wrote: > Signed-off-by: Giridhar Malavali > Signed-off-by: Chad Dupuis > --- > drivers/scsi/qla2xxx/qla_version.h |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_version.h > b/drivers/scsi/

Re: future FCoE ideas (Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces)

2012-09-14 Thread Love, Robert W
On Thu 13 Sep 2012 03:45:33 PM PDT, Love, Robert W wrote: > On Thu 13 Sep 2012 03:32:50 PM PDT, Chris Leech wrote: >> > anymore> >> That being said, I'm glad this is being reworked. Do you have any other functionality in mind that this is laying the groundwork for? >>> >>> I have on

Re: [scsi:misc 49/55] drivers/scsi/mvumi.c:1880:3: error: implicit declaration of function 'virt_to_bus'

2012-09-14 Thread James Bottomley
On Sat, 2012-09-15 at 00:50 +0800, Fengguang Wu wrote: > Hi Shun, > > FYI, kernel build failed on > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc > head: e1daec5547bdb8a53b023852d578409005c69ea7 > commit: 8b3fa849abc2b62920d7e4fc4f8e6ce3d0783623 [49/55] [SCSI] mvumi

[scsi:misc 49/55] drivers/scsi/mvumi.c:1880:3: error: implicit declaration of function 'virt_to_bus'

2012-09-14 Thread Fengguang Wu
Hi Shun, FYI, kernel build failed on tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc head: e1daec5547bdb8a53b023852d578409005c69ea7 commit: 8b3fa849abc2b62920d7e4fc4f8e6ce3d0783623 [49/55] [SCSI] mvumi: Add support for Marvell SAS/SATA RAID-on-Chip(ROC) 88RC9580 config

Re: [PATCH 14/42] qla2xxx: Update the driver license.

2012-09-14 Thread James Bottomley
On Wed, 2012-08-22 at 14:21 -0400, Chad Dupuis wrote: > Update the driver license from 2003-2011 to 2003-2012. I did s/license/copyright/ in this, since that's what you actually mean. People can get very upset when they think the driver licence is changing ... James -- To unsubscribe from this

Re: [PATCH 10/42] qla2xxx: Implemetation of mctp.

2012-09-14 Thread James Bottomley
On Wed, 2012-08-22 at 14:21 -0400, Chad Dupuis wrote: > diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c > index 71310d3..c8d1aff 100644 > --- a/drivers/scsi/qla2xxx/qla_init.c > +++ b/drivers/scsi/qla2xxx/qla_init.c > @@ -4110,6 +4110,59 @@ exit: > return rval;

Re: + sections-fix-section-conflicts-in-drivers-scsi.patch added to -mm tree

2012-09-14 Thread Andi Kleen
On Fri, Sep 14, 2012 at 03:03:49PM +0100, James Bottomley wrote: > On Fri, 2012-09-14 at 06:50 -0700, Andi Kleen wrote: > > > > -- > > > > From: Andi Kleen > > > > Subject: sections: fix section conflicts in drivers/scsi > > > > > > NAK this, pl

Re: + sections-fix-section-conflicts-in-drivers-scsi.patch added to -mm tree

2012-09-14 Thread James Bottomley
On Fri, 2012-09-14 at 06:50 -0700, Andi Kleen wrote: > > > -- > > > From: Andi Kleen > > > Subject: sections: fix section conflicts in drivers/scsi > > > > NAK this, please. We're fixing all of this by removing CONFIG_HOTPLUG, > > so all __dev

Re: [PATCH 1/2] scsi: sd: set ready_to_power_off for scsi disk

2012-09-14 Thread Aaron Lu
On Fri, Sep 14, 2012 at 11:26:29AM +0100, James Bottomley wrote: > On Fri, 2012-09-14 at 16:48 +0800, Aaron Lu wrote: > > So if we program the device to let it enter standby/stopped power > > condition with the start_stop_unit command, do we need to sync the > > cache? > > No, that's what the spec

Re: + sections-fix-section-conflicts-in-drivers-scsi.patch added to -mm tree

2012-09-14 Thread Andi Kleen
> > -- > > From: Andi Kleen > > Subject: sections: fix section conflicts in drivers/scsi > > NAK this, please. We're fixing all of this by removing CONFIG_HOTPLUG, > so all __dev annotations become nops and there's little point changing > any.

[patch] [SCSI] cleanup some calls to strncmp()

2012-09-14 Thread Dan Carpenter
The main motivation for this patch is that for the first strncmp() we do 'strncmp(src, "-", 20)' but "src" is a 15 character buffer not 20. Also since we know that "-" is only two characters, the compare isn't going to go further than 2 characters into src before deciding that it doesn't match. T

Re: [PATCH 1/2] scsi: sd: set ready_to_power_off for scsi disk

2012-09-14 Thread James Bottomley
On Fri, 2012-09-14 at 16:48 +0800, Aaron Lu wrote: > On 09/14/2012 04:17 PM, James Bottomley wrote: > >> Just read the SPC-4 spec, in section 5.12.3, it has words like this: > >> > >> Logical units that contain cache memory shall write all cached data to > >> the medium for the logical unit(e.g., a

Re: [PATCH 1/2] scsi: sd: set ready_to_power_off for scsi disk

2012-09-14 Thread Aaron Lu
On 09/14/2012 04:17 PM, James Bottomley wrote: >> Just read the SPC-4 spec, in section 5.12.3, it has words like this: >> >> Logical units that contain cache memory shall write all cached data to >> the medium for the logical unit(e.g., as a logical unit would do in >> response to a SYNCHRONIZE CAC

Re: [PATCH 1/2] scsi: sd: set ready_to_power_off for scsi disk

2012-09-14 Thread James Bottomley
On Fri, 2012-09-14 at 13:20 +0800, Aaron Lu wrote: > On Thu, Sep 13, 2012 at 10:26:44AM +0100, James Bottomley wrote: > > On Thu, 2012-09-13 at 17:07 +0800, Aaron Lu wrote: > > > So I think this is basically 2 things, one is the runtime suspend of the > > > disk, another is when it is runtime suspe

Re: [PATCH 1/2] scsi: sd: set ready_to_power_off for scsi disk

2012-09-14 Thread James Bottomley
On Thu, 2012-09-13 at 12:24 -0400, Alan Stern wrote: > On Thu, 13 Sep 2012, Oliver Neukum wrote: > > > Disk runtime power states are defined in the standard and so we rely on > > > the standard taking care of the cache. I suspect the most efficient use > > > may be via the power management mode pa

Re: + sections-fix-section-conflicts-in-drivers-scsi.patch added to -mm tree

2012-09-14 Thread James Bottomley
On Thu, 2012-09-13 at 16:37 -0700, a...@linux-foundation.org wrote: > The patch titled > Subject: sections: fix section conflicts in drivers/scsi > has been added to the -mm tree. Its filename is > sections-fix-section-conflicts-in-drivers-scsi.patch > > Before you just go and hit "repl

Re: [RFC PATCH 4/5] bnx2fc: Use new fcoe_sysfs control interface

2012-09-14 Thread Bhanu Prakash Gollapudi
On 09/10/2012 03:59 PM, Robert Love wrote: Convert bnx2fc to use the new fcoe_sysfs create, delete, enable, disable, start and mode. bnx2fc doesn't support VN2VN. bnx2fc will not initialize the set_fcoe_ctlr_mode routine and therefore its instances will always be in FABRIC mode. There was previo

Re: [RFC PATCH 2/5] libfcoe: Create new libfcoe control interfaces

2012-09-14 Thread Bhanu Prakash Gollapudi
On 9/10/2012 3:59 PM, Robert Love wrote: This patch is the first in a series that will remove libfcoe's create, destroy, enable and disable module parameters and replace them with interface files in the new /sys/bus/fcoe subsystem. Old layout: /sys/module/libfcoe/parameters/{create,destroy,enab