Re: [PATCH 3/4] [SCSI] ufs: Add AMBA glue driver to ufshcd

2012-07-10 Thread vinayak holikatti
On Mon, Jul 2, 2012 at 8:50 PM, Arnd Bergmann wrote: > On Monday 02 July 2012, Vinayak Holikatti wrote: >> +static struct amba_id ufshcd_amba_ids[] = { >> + { >> + /* Fake id for Primecell.*/ >> + .id = 0x00041FF0, >> + .mask = 0x000f, >> +

Re: [PATCH 2/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2012-07-10 Thread vinayak holikatti
On Mon, Jul 2, 2012 at 8:57 PM, Arnd Bergmann wrote: > On Monday 02 July 2012, Vinayak Holikatti wrote: >> +static struct platform_driver ufshcd_pltfrm_driver = { >> + .probe = ufshcd_pltfrm_probe, >> + .remove = __devexit_p(ufshcd_pltfrm_remove), >> +#ifdef CONFIG_PM >> + .susp

Re: [PATCH RESEND 3/3] drivers/scsi/ufs: fix incorrect return value about SUCCESS and FAILED

2012-07-10 Thread Namjae Jeon
Thanks Venkat ! 2012/7/11, Venkatraman S : > From: Namjae Jeon > > Currently the UFS host driver has returned incorrect values for SUCCESS > and FAILED. Fix it to return the correct value to the upper layer. > > Signed-off-by: Namjae Jeon > Acked-by: Santosh Y > Signed-off-by: Venkatraman S >

Re: [PATCH 1/4] [SCSI] ufs: Separate PCI glue driver for ufshcd

2012-07-10 Thread vinayak holikatti
On Mon, Jul 2, 2012 at 8:47 PM, Arnd Bergmann wrote: > On Monday 02 July 2012, Vinayak Holikatti wrote: >> >> This patch separates PCI and core UFS host controller driver. >> In the current implementation PCI specific code is with ufshcd.c. >> To provide way for adding multiple bus glue driver, th

Re: 'Device not ready' issue on mpt2sas since 3.1.10

2012-07-10 Thread Robert Trace
On 07/09/2012 09:51 PM, Robert Trace wrote: > > Huh.. I just retested this and I'm seeing really random behavior. Ok, with a refined test I've been able to reliably reproduce this and I bisected it back to commit 85ef06d1d252f6a2e73b678591ab71caad4667bb in Linus' tree (introduced between 3.0 and

[PATCH RESUBMIT 3/3] lpfc: remove unnecessary read of PCI_CAP_ID_EXP

2012-07-10 Thread Jon Mason
The PCIE capability offset is saved during PCI bus walking. It will remove an unnecessary search in the PCI configuration space if this value is referenced instead of reacquiring it. Also, pci_is_pcie is a better way of determining if the device is PCIE or not (as it uses the same saved PCIE capa

[PATCH RESUBMIT 2/3] qla2xxx: remove unnecessary reads of PCI_CAP_ID_EXP

2012-07-10 Thread Jon Mason
The PCIE capability offset is saved during PCI bus walking. It will remove an unnecessary search in the PCI configuration space if this value is referenced instead of reacquiring it. Also, pci_is_pcie is a better way of determining if the device is PCIE or not (as it uses the same saved PCIE capa

[PATCH RESUBMIT 1/3] qla4xxx: remove unnecessary read of PCI_CAP_ID_EXP

2012-07-10 Thread Jon Mason
The PCIE capability offset is saved during PCI bus walking. It will remove an unnecessary search in the PCI configuration space if this value is referenced instead of reacquiring it. Signed-off-by: Jon Mason Cc: Ravi Anand Cc: Vikas Chaudhary Cc: iscsi-dri...@qlogic.com --- drivers/scsi/qla4x

[PATCH RESUBMIT 0/3] remove unnecessary read of PCI_CAP_ID_EXP

2012-07-10 Thread Jon Mason
This is a resubmission of 3 of 19 patches from ~1 year ago. The rest were integrated by the other subsystem maintainers at the time. I believe the hiccup was some confusion as to whether this would cause an issue on PPC (http://www.spinics.net/lists/linux-scsi/msg53079.html). However, this was l

Re: 'Device not ready' issue on mpt2sas since 3.1.10

2012-07-10 Thread Darrick J. Wong
On Mon, Jul 09, 2012 at 06:24:15PM -0400, Robert Trace wrote: > On 07/09/2012 04:45 PM, Darrick J. Wong wrote: > > > > I suspect that /sys/devices//manage_start_stop > > = 0 > > for the SATA devices hanging off the SAS controller. > > Yep, looks like you're right. For my system: > > # cat /sys/

[PATCH RESEND 3/3] drivers/scsi/ufs: fix incorrect return value about SUCCESS and FAILED

2012-07-10 Thread Venkatraman S
From: Namjae Jeon Currently the UFS host driver has returned incorrect values for SUCCESS and FAILED. Fix it to return the correct value to the upper layer. Signed-off-by: Namjae Jeon Acked-by: Santosh Y Signed-off-by: Venkatraman S Cc: James Bottomley --- drivers/scsi/ufs/ufshcd.c | 10

Re: [PATCH RESEND 3/3] drivers/scsi/ufs: fix incorrect return value about SUCCESS and FAILED

2012-07-10 Thread S, Venkatraman
On Tue, Jul 10, 2012 at 8:12 PM, James Bottomley wrote: > On Tue, 2012-07-10 at 19:39 +0530, Venkatraman S wrote: >> From: Namjae Jeon >> >> Currently the UFS host driver has returned incorrect values for SUCCESS >> and FAILED. Fix it to return the correct value to the upper layer. >> >> Signed-

Re: [PATCH RESEND 3/3] drivers/scsi/ufs: fix incorrect return value about SUCCESS and FAILED

2012-07-10 Thread James Bottomley
On Tue, 2012-07-10 at 19:39 +0530, Venkatraman S wrote: > From: Namjae Jeon > > Currently the UFS host driver has returned incorrect values for SUCCESS > and FAILED. Fix it to return the correct value to the upper layer. > > Signed-off-by: Namjae Jeon > Acked-by: Santosh Y > Cc: James Bottoml

[PATCH RESEND 1/3] drivers/scsi/ufs: use module_pci_driver

2012-07-10 Thread Venkatraman S
Use macro module_pci_driver and get rid of boilerplate code. No functional changes. Signed-off-by: Venkatraman S Acked-by: Santosh Y Cc: "James E.J. Bottomley" Signed-off-by: Andrew Morton --- drivers/scsi/ufs/ufshcd.c | 19 +-- 1 files changed, 1 insertions(+), 18 deletion

[PATCH RESEND 3/3] drivers/scsi/ufs: fix incorrect return value about SUCCESS and FAILED

2012-07-10 Thread Venkatraman S
From: Namjae Jeon Currently the UFS host driver has returned incorrect values for SUCCESS and FAILED. Fix it to return the correct value to the upper layer. Signed-off-by: Namjae Jeon Acked-by: Santosh Y Cc: James Bottomley Signed-off-by: Andrew Morton --- drivers/scsi/ufs/ufshcd.c | 10

[PATCH RESEND 2/3] drivers/scsi/ufs: reverse the ufshcd_is_device_present logic

2012-07-10 Thread Venkatraman S
Otherwise it counter intuitively returns 0 if device is present. Signed-off-by: Venkatraman S Reviewed-by: Namjae Jeon Acked-by: Santosh Y Cc: James Bottomley Signed-off-by: Andrew Morton --- drivers/scsi/ufs/ufshcd.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --gi

[PATCH RESEND 0/3] drivers/scsi/ufs: Misc fixes

2012-07-10 Thread Venkatraman S
Hi James, These patches have been posted to lkml and have been in linux-next for sometime through Andrew Morton's tree. I think they should be taken through your tree for next merge window. Can you please merge these ? Thanks and regards, Venkat. Namjae Jeon (1): drivers/scsi/ufs: fix inco

Re: mptscsi: BUG: unable to handle kernel NULL pointer, in scsi_send_eh_cmnd

2012-07-10 Thread James Bottomley
On Tue, 2012-07-10 at 14:54 +0300, Meelis Roos wrote: > > > I am using Linux 3.4.0 with a 53c1030 and a tape library that sometimes > > > barfs for yet unknown reasons. When it happens, I get a BUG with > > > backtrace and this scsi channel is dead until I reboot. Seems to be > > > something wit

Re: mptscsi: BUG: unable to handle kernel NULL pointer, in scsi_send_eh_cmnd

2012-07-10 Thread Meelis Roos
> > I am using Linux 3.4.0 with a 53c1030 and a tape library that sometimes > > barfs for yet unknown reasons. When it happens, I get a BUG with > > backtrace and this scsi channel is dead until I reboot. Seems to be > > something with either generic scsi error handling or with mpt scsi. > > I

[PATCH 1/1] [SCSI] scsi_debug: Add "removable" parameter

2012-07-10 Thread Martin Pitt
Add "removable" module parameter to set the "removable" attribute of any subsequently created debug block device. It is a writable driver option, so that you can switch between removable and "fixed" media block devices in between the add_host calls. This is useful for being able to test the differ

[PATCH 0/1] Option for scsi_debug to fake removable devices

2012-07-10 Thread Martin Pitt
Hello all, sorry for resending this twice to the lists. Initially I thought mailing James directly was not appropriate, but I was now told that get_maintainer.pl is actually speaking the truth and I am supposed to do just that. For the purposes of automatically testing udisks and gvfs automounti

Re: mptscsi: BUG: unable to handle kernel NULL pointer, in scsi_send_eh_cmnd

2012-07-10 Thread James Bottomley
On Tue, 2012-07-10 at 11:44 +0300, Meelis Roos wrote: > Resending with correct linux-scsi address - please rteply to this one if > you see duplicate messages. > > I am using Linux 3.4.0 with a 53c1030 and a tape library that sometimes > barfs for yet unknown reasons. When it happens, I get a BUG

mptscsi: BUG: unable to handle kernel NULL pointer, in scsi_send_eh_cmnd

2012-07-10 Thread Meelis Roos
Resending with correct linux-scsi address - please rteply to this one if you see duplicate messages. I am using Linux 3.4.0 with a 53c1030 and a tape library that sometimes barfs for yet unknown reasons. When it happens, I get a BUG with backtrace and this scsi channel is dead until I reboot. S