[Bug 10050] message/fusion/mptbase.c: fix use-after-free's

2008-02-24 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=10050 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |CLOSED Resolution|

RE: Aborted commands with arcmsr and 2xWD1500ADFD in RAID1

2008-02-24 Thread nickcheng
Hi Aron, >From our field experiences and customers' feedbacks, all of them direct to vibration and power issues. The vibration could be caused by FANs not only by themselves. You mentioned it could be the F/W issue. If the environment does not meet the prerequisite, FW could not work correctly. Act

Re: arcmsr & areca-1660 - strange behaviour under heavy load

2008-02-24 Thread Andrew Morton
On Sat, 23 Feb 2008 12:20:12 +0100 (CET) Nikola Ciprich <[EMAIL PROTECTED]> wrote: > Hi, > > I've found strange problem either in arcmsr driver, or maybe in > areca-1660 card... > When system on SAS discs RAID connected to areca-1660 card > gets under heavy I/O load, it gets unusable after som

[PATCH] [0/22] Remove isa_unchecked_dma and some more GFP_DMAs in the mid layer

2008-02-24 Thread Andi Kleen
This patchkit fixes all existing drivers that used isa_unchecked_dma to not need that anymore. I have some upcoming infrastructure changes for DMA memory management and isa_unchecked_dma was in the way. Enabling isa_unchecked_dma had several effects: - All incoming scsi_cmnds were in GFP_DMA me

[PATCH] [3/22] Remove unchecked_isa_dma in advansys.c

2008-02-24 Thread Andi Kleen
That patch is a little more complicated than the others. advansys was the only ISA driver who actually passed ->cmnd to the firmware. So I implemented a simple own bounce buffer scheme for this case. Also did sense_buffer bouncing in the driver while I was at it; which means it doesn't require the

[PATCH] [17/22] Switch to a single SCSI command pool

2008-02-24 Thread Andi Kleen
Now that no low level driver relies on ISA DMAable scsi_cmnds anymore it is safe to always use the same static slab for them. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- drivers/scsi/scsi.c | 46 +++--- 1 file changed, 23 insertions(+), 23 deletio

[PATCH] [16/22] Remove unchecked_isa_dma from sysfs

2008-02-24 Thread Andi Kleen
I opted to remove it because it's unlikely that user space uses it. An alternative would be to always make it report 0 now. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- drivers/scsi/scsi_sysfs.c |2 -- 1 file changed, 2 deletions(-) Index: linux/drivers/scsi/scsi_sysfs.c

[PATCH] [15/22] Remove GFP_DMA use in sr_ioctl

2008-02-24 Thread Andi Kleen
Everything should be bounced by the block layer now Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- drivers/scsi/sr_ioctl.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) Index: linux/drivers/scsi/sr_ioctl.c =

[PATCH] Don't use unnecessary GFP_ATOMIC in sg.c

2008-02-24 Thread Andi Kleen
Don't use unnecessary GFP_ATOMIC in sg.c sg.c uses GFP_ATOMIC for a lot of allocations where it isn't necessary. There are no locks hold and I don't see any other reasons why GFP_ATOMIC should be needed here. So remove them for more reliable allocations. Depends on the earlier GFP_DMA patchkit, b

[PATCH] [11/22] Remove unchecked_isa_dma checks in sg.c

2008-02-24 Thread Andi Kleen
They are only used to allocate data buffers, and those are bounced by the block layer anyways. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- drivers/scsi/sg.c | 36 +--- 1 file changed, 9 insertions(+), 27 deletions(-) Index: linux/drivers/scsi/sg.c ==

[PATCH] [2/22] Remove unchecked_isa in BusLogic

2008-02-24 Thread Andi Kleen
- ->cmnd handling audited and does always copy - Allocate hostdata separately - Enable sense_buffer isa bounce buffering - Remove unchecked_isa_dma - Enable block layer bouncing explicitely for isa adapters Untested due to lack of hardware Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- driv

[PATCH] [8/22] Remove random noop unchecked_isa_dma users

2008-02-24 Thread Andi Kleen
Lots of drivers set it to 0. Remove that. Patch should be a nop. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- drivers/scsi/arm/acornscsi.c |1 - drivers/scsi/arm/cumana_1.c |1 - drivers/scsi/dc395x.c|1 - drivers/scsi/eata_pio.c |2 -- drivers/scsi/hptiop.c

[PATCH] [22/22] Remove GFP_DMA in sr_vendor.c

2008-02-24 Thread Andi Kleen
Bounced by the block layer anyways Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Index: linux/drivers/scsi/sr_vendor.c === --- linux.orig/drivers/scsi/sr_vendor.c +++ linux/drivers/scsi/sr_vendor.c @@ -117,7 +117,7 @@ int sr_set_blo

[PATCH] [21/22] Remove GFP_DMA in ch.c

2008-02-24 Thread Andi Kleen
All buffers are bounced by the block layer Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Index: linux/drivers/scsi/ch.c === --- linux.orig/drivers/scsi/ch.c +++ linux/drivers/scsi/ch.c @@ -231,7 +231,7 @@ ch_read_element_status(scsi

[PATCH] [18/22] Finally remove unchecked_isa_dma support for Cmnds

2008-02-24 Thread Andi Kleen
No drivers need it anymore Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- drivers/scsi/scsi.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: linux/drivers/scsi/scsi.c === --- linux.orig/drivers/scsi/scsi.c ++

[PATCH] [7/22] Remove unchecked_isa_dma in aha152x/wd7000/sym53c416/u14-34f/NCR53c406a

2008-02-24 Thread Andi Kleen
I lumped these all together because these old ISA only drivers all look very unmaintained and the changes were relatively simple. I audited them for possible use of unchecked_isa_dma and fixed the cases who needed them: - Allocate separate dma'able hostdata when needed - Checked that they all al

[PATCH] [14/22] Remove automatic block layer bouncing for unchecked_isa_dma

2008-02-24 Thread Andi Kleen
All ISA drivers explicitely tell the block layer now that it needs to bounce for them, so SCSI mid layer doesn't need to do that automatically for unchecked_isa_dma anymore. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- drivers/scsi/scsi_lib.c |2 -- 1 file changed, 2 deletions(-) Inde

[PATCH] [6/22] Remove unchecked_isa_dma in aha1542

2008-02-24 Thread Andi Kleen
- Audited ->cmnd use and it always copies - Allocate DMAable hostdata separately - Tell block layer explicitely to bounce - Audited sense_buffer use and it always copies - Remove unchecked_isa_dma finally Untested due to lack of hardware Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- drive

[PATCH] [4/22] Remove unchecked_isa_dma in gdth

2008-02-24 Thread Andi Kleen
- Audited ->cmnd use and it always copies - Allocate hostdata separately with GFP_DMA for the ISA case - Tell scsi layer to bounce sense_buffer for ISA case - Tell block layer to bounce for isa case - Remove unchecked_isa_dma Untested due to lack of hardware Signed-off-by: Andi Kleen <[EMAIL PRO

[PATCH] [10/22] Remove unchecked_isa_dma support for hostdata

2008-02-24 Thread Andi Kleen
All ISA drivers who relied on dma able hostdata have been converted to allocate it separately. So remove the unchecked_isa_dma hostdata support in the mid layer Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- drivers/scsi/hosts.c |3 --- 1 file changed, 3 deletions(-) Index: linux/driver

[PATCH] [1/22] Add new sense_buffer_mask host template field

2008-02-24 Thread Andi Kleen
sense buffers are something that still needs to be explicitely bounced in the scsi layer. Instead of using the global unchecked_isa_dma flag define a special fine grained mask for this. I decided to use a full dma mask because that is most useful for some future infrastructure work I'm doing. N

[PATCH] [20/22] Remove GFP_DMA in sr.c

2008-02-24 Thread Andi Kleen
All buffers are bounced by the block layer Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Index: linux/drivers/scsi/sr.c === --- linux.orig/drivers/scsi/sr.c +++ linux/drivers/scsi/sr.c @@ -674,7 +674,7 @@ static void get_sectorsize(

[PATCH] [13/22] Don't disable direct_io for unchecked_isa_dma in st.c

2008-02-24 Thread Andi Kleen
Block layer bounces anyways. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- drivers/scsi/st.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/drivers/scsi/st.c === --- linux.orig/drivers/scsi/st.c +++ linu

[PATCH] [19/22] Finally kill unchecked_isa_dma

2008-02-24 Thread Andi Kleen
Now that all users are gone it can be safely completely removed. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- Documentation/scsi/scsi_mid_low_api.txt |3 --- drivers/scsi/hosts.c|1 - include/scsi/scsi_host.h|6 -- 3 files changed, 10 del

[PATCH] [12/22] Remove GFP_DMAs/unchecked_isa_dma checks in scsi_scan.c

2008-02-24 Thread Andi Kleen
Should not be needed because the block layer bounces that all. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- drivers/scsi/scsi_scan.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) Index: linux/drivers/scsi/scsi_scan.c ===

[PATCH] ps3rom: fix wrong resid calculation bug

2008-02-24 Thread FUJITA Tomonori
sg driver rounds up the length in struct scatterlist to be a multiple of 512 in some conditions. So LLDs can't use the data length in a sg list to calculate residual. Instead, the length in struct scsi_cmnd should be used. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> Cc: Geert Uytterhoeven <

[PATCH] scsi_debug: fix wrong resid calculation bug

2008-02-24 Thread FUJITA Tomonori
sg driver rounds up the length in struct scatterlist to be a multiple of 512 in some conditions. So LLDs can't use the data length in a sg list to calculate residual. Instead, the length in struct scsi_cmnd should be used. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> Cc: Douglas Gilbert <[EM

[PATCH] aacraid: READ_CAPACITY_16 shouldn't trust allocation length in cdb

2008-02-24 Thread FUJITA Tomonori
When aacraid spoofs READ_CAPACITY_16, it assumes that the data length in the sg list is equal to allocation length in cdb. But sg can put any value in scb so the driver needs to check both the data length in the sg list and allocation length in cdb. If allocation length is larger than the response

Re: [PATCH 2/2] SCSI tape: show options currently set in sysfs

2008-02-24 Thread Randy Dunlap
On Sun, 24 Feb 2008 22:29:12 +0200 (EET) Kai Makisara wrote: > Documentation/scsi/st.txt |7 ++- > Index: linux-2.6.25-rc2-q/Documentation/scsi/st.txt > === > --- linux-2.6.25-rc2-q.orig/Documentation/scsi/st.txt > +++ linux-

Need help with libata error handling in libsas

2008-02-24 Thread James Bottomley
I keep hearing that we need to convert libsas to use libata's new error handling. Unfortunately, I have very little conception of what that means. Right at the moment, libsas doesn't use any error handling functions of libata at all. I've looked through the libata-eh functions, and I find them f

[PATCH 2/2] SCSI tape: show options currently set in sysfs

2008-02-24 Thread Kai Makisara
Show the current binary tape driver and mode options is sysfs. A file (options) is created in each directory in /sys/class/scsi_tape. The files contain masks showing the options. The mask bit definitions are the same as used when setting the options using the MTSETDRVBUFFER function in the MTIOCTOP

[PATCH 1/2] SCSI tape: add option to use SILI in variable block reads

2008-02-24 Thread Kai Makisara
i/st.c === --- linux-2.6.25-rc2-q.orig/drivers/scsi/st.c +++ linux-2.6.25-rc2-q/drivers/scsi/st.c @@ -17,7 +17,7 @@ Last modified: 18-JAN-1998 Richard Gooch <[EMAIL PROTECTED]> Devfs support */ -static const char *verstr = "20080221"; +static const char *verstr = &

Re: [PATCH] mvsas: convert from rough draft to working driver

2008-02-24 Thread Ke Wei
On Sat, Feb 23, 2008 at 11:28:50AM -0500, Jeff Garzik wrote: > Ke Wei wrote: > >Convert rough draft Marvell 6440 driver to a working driver. > >Added support for SAS and SATA devices, hotplug, wide port, and expanders. > >This patch is based on: > >branch 'mvsas' of > >git.kernel.org:/pub/scm/linu