SCSI RAM driver

2008-02-17 Thread Matthew Wilcox
This is the first release of a driver we've been using internally at Intel for a few weeks which is as low-latency as possible. It's designed to let us find latency issues elsewhere in the storage stack (eg filesystem, block layer, scsi layer) There are a few different options, controlled throug

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-17 Thread Tim Pepper
On Mon 19 Feb at 07:31:56 +0900 [EMAIL PROTECTED] said: > > Can you apply the 0001 and 0002 against 2.6.24 and see how it works? > If it works well, then please apply the 0001, 0002 and 0003. Fujita-san, I've started through the patches in order, cumulatively and after applying 0005 things break

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-17 Thread Tim Pepper
On Mon 18 Feb at 07:31:56 +0900 [EMAIL PROTECTED] said: > > Can you apply the 0001 and 0002 against 2.6.24 and see how it works? > If it works well, then please apply the 0001, 0002 and 0003. > > Please the patches in a step-by-step way and tell me which patch > breaks the driver. I wasn't think

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-17 Thread FUJITA Tomonori
On Sun, 17 Feb 2008 13:15:40 -0800 Tim Pepper <[EMAIL PROTECTED]> wrote: > On Sat 16 Feb at 09:41:48 +0900 [EMAIL PROTECTED] said: > > > > Do you mean that you applied only the following two patches against > > 2.6.24, and then it doesn't work? > > > > 0001-ips-revert-the-changes-for-the-data-bu

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-17 Thread Tim Pepper
On Sun 17 Feb at 15:09:06 +0200 [EMAIL PROTECTED] said: > > > > You just need to also check for sg != NULL in the for() loop. > > > > Tim Please test below patch. It's ontop of 2.6.24 but should also apply to > > 2.6.25-rcx > Disregard that patch it is totally wrong. That's not it. Sorry > > B

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-17 Thread Tim Pepper
On Sat 16 Feb at 09:41:48 +0900 [EMAIL PROTECTED] said: > > Do you mean that you applied only the following two patches against > 2.6.24, and then it doesn't work? > > 0001-ips-revert-the-changes-for-the-data-buffer-accessor.patch I only applies the 0001 patch and the driver appeared to function

Re: [PATCH] ieee1394: sbp2: fix rescan-scsi-bus

2008-02-17 Thread Stefan Richter
>> On Sun, 2008-02-17 at 14:57 +0100, Stefan Richter wrote: >>> rescan-scsi-bus used to add SBP-2 targets which weren't there. PS: It probably wasn't clear: rescan-scsi-bus.sh is *not* necessary for sbp2 (under Linux 2.6, that is). The patch merely prevents weird things from happening if the us

Re: [PATCH] qla2xxx: fix compilation compile

2008-02-17 Thread Andrew Vasquez
On Sat, 16 Feb 2008, FUJITA Tomonori wrote: > scsi/qla2xxx/qla_dfs.c: In function 'qla2x00_dfs_fce_show': > scsi/qla2xxx/qla_dfs.c:26: warning: format '%llx' expects type 'long long > unsigned int', but argument 3 has type 'uint64_t' > > Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> Acked-

[PATCH] firewire: fw-sbp2: fix NULL pointer deref in scsi_remove_device

2008-02-17 Thread Stefan Richter
I wrote: > There is unfortunately another bug. If the user manually removes the > scsi_device by writing into its "delete" sysfs attribute, the following > will happen when the SBP-2 device is plugged out: > > BUG: unable to handle kernel NULL pointer dereference at 00b8 > IP: [] mute

Re: [PATCH] ieee1394: sbp2: fix rescan-scsi-bus

2008-02-17 Thread Stefan Richter
James Bottomley wrote: > On Sun, 2008-02-17 at 14:57 +0100, Stefan Richter wrote: >> rescan-scsi-bus used to add SBP-2 targets which weren't there. ... >> +++ linux/drivers/ieee1394/sbp2.c >> @@ -1974,6 +1974,9 @@ static int sbp2scsi_slave_alloc(struct s >> { >> struct sbp2_lu *lu = (struct s

Re: [PATCH] firewire: fw-sbp2: fix NULL pointer deref in slave_alloc

2008-02-17 Thread Stefan Richter
On 17 Feb, Stefan Richter wrote: > Fix a kernel bug when running rescan-scsi-bus while a FireWire disk is > connected: http://bugzilla.kernel.org/show_bug.cgi?id=10008 > > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > --- > drivers/firewire/fw-sbp2.c |4 > 1 file changed, 4 insert

Re: gdth new set of patches for 2.6.24 stable

2008-02-17 Thread James Bottomley
On Sun, 2008-02-17 at 18:46 +0200, Boaz Harrosh wrote: > On Thu, Feb 14 2008 at 20:47 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote: > > Submitted are a new set of patches, that fix lots of problems > > with the gdth driver. > > > > It fixes the following problems: > > - scan for drives on hosts.

Re: gdth new set of patches for 2.6.24 stable

2008-02-17 Thread Boaz Harrosh
On Thu, Feb 14 2008 at 20:47 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote: > Submitted are a new set of patches, that fix lots of problems > with the gdth driver. > > It fixes the following problems: > - scan for drives on hosts. (Already in mainline) > - truly fixes the exit/reboot problems but

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-17 Thread Jeff Garzik
Boaz Harrosh wrote: On Sat, Feb 16 2008 at 18:37 +0200, Matthew Wilcox <[EMAIL PROTECTED]> wrote: On Wed, Feb 13, 2008 at 10:57:37AM +0200, Boaz Harrosh wrote: I still don't have a card for testing myself. Again anyone wants to send me a card. Intel people anybody home? Apparently Intel sold t

Re: USB regression (and other failures) in 2.6.2[45]*

2008-02-17 Thread Andrew Buehler
On 2/16/2008 10:35 PM, Alan Stern wrote: On Sat, 16 Feb 2008, Andrew Buehler wrote: Messages sent to my address directly are explicitly not filtered into the folders I have set up for various mailing lists, so that if someone does send me a "heads up" reply for a specific topic on a list to wh

Re: USB regression (and other failures) in 2.6.2[45]*

2008-02-17 Thread Paul Jackson
Andrew B wrote: > Windows, which is what I have to use for work purposes. aha -- my condolences ;) Take care. Your last reply made as much sense as we're likely to make of this one. Thanks. -- I won't rest till it's the best ... Programmer, Linux Scalabilit

Re: USB regression (and other failures) in 2.6.2[45]*

2008-02-17 Thread Andrew Buehler
On 2/17/2008 2:20 AM, Paul Jackson wrote: Andrew wrote: (Since there are multiple Andrews on just the LKML, and at least two - one of whom is much more prominent than I am - in the direct address list for this discussion, I'm not sure whether or not this is a sufficient attribution. If it work

Re: [PATCH] ieee1394: sbp2: fix rescan-scsi-bus

2008-02-17 Thread James Bottomley
On Sun, 2008-02-17 at 14:57 +0100, Stefan Richter wrote: > rescan-scsi-bus used to add SBP-2 targets which weren't there. > > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > --- > drivers/ieee1394/sbp2.c |3 +++ > 1 file changed, 3 insertions(+) > > Index: linux/drivers/ieee1394/sbp2.c

Re: [PATCH] scsi_debug: disable clustering

2008-02-17 Thread James Bottomley
On Mon, 2008-02-18 at 00:11 +0900, FUJITA Tomonori wrote: > On Sun, 17 Feb 2008 09:02:14 -0600 > James Bottomley <[EMAIL PROTECTED]> wrote: > > > > > On Sun, 2008-02-17 at 23:52 +0900, FUJITA Tomonori wrote: > > > On Sun, 17 Feb 2008 07:28:48 -0700 > > > Matthew Wilcox <[EMAIL PROTECTED]> wrote:

Re: [PATCH] scsi_debug: disable clustering

2008-02-17 Thread FUJITA Tomonori
On Sun, 17 Feb 2008 09:02:14 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > > On Sun, 2008-02-17 at 23:52 +0900, FUJITA Tomonori wrote: > > On Sun, 17 Feb 2008 07:28:48 -0700 > > Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > > > > On Sun, Feb 17, 2008 at 08:18:11AM -0600, James Bottomley wro

Re: [PATCH] scsi_debug: disable clustering

2008-02-17 Thread James Bottomley
On Sun, 2008-02-17 at 23:52 +0900, FUJITA Tomonori wrote: > On Sun, 17 Feb 2008 07:28:48 -0700 > Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > > On Sun, Feb 17, 2008 at 08:18:11AM -0600, James Bottomley wrote: > > > No, he means that kmap_atomic can only map a page of data. This makes > > > sing

Re: [PATCH] scsi_debug: disable clustering

2008-02-17 Thread FUJITA Tomonori
On Sun, 17 Feb 2008 07:28:48 -0700 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Sun, Feb 17, 2008 at 08:18:11AM -0600, James Bottomley wrote: > > No, he means that kmap_atomic can only map a page of data. This makes > > single page only sg list entries and input assumption into this loop. > > w

[PATCH] ps3rom: disable clustering

2008-02-17 Thread FUJITA Tomonori
ps3rom does: scsi_for_each_sg(cmd, sgpnt, scsi_sg_count(cmd), k) { kaddr = kmap_atomic(sg_page(sgpnt), KM_IRQ0); We cannot do something like that with the clustering enabled (or we can use scsi_kmap_atomic_sg). Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> Cc: Geert Uytterhoeven <[E

Re: [PATCH] scsi_debug: disable clustering

2008-02-17 Thread Matthew Wilcox
On Sun, Feb 17, 2008 at 08:18:11AM -0600, James Bottomley wrote: > No, he means that kmap_atomic can only map a page of data. This makes > single page only sg list entries and input assumption into this loop. > with ENABLE_CLUSTERING, that's potentially not true. Of course, this > accidentally w

Re: [PATCH] scsi_debug: disable clustering

2008-02-17 Thread James Bottomley
On Sun, 2008-02-17 at 07:10 -0700, Matthew Wilcox wrote: > On Sat, Feb 16, 2008 at 11:57:15PM +0900, FUJITA Tomonori wrote: > > scsi_debug does at several places: > > > > for_each_sg(sdb->table.sgl, sg, sdb->table.nents, k) { > > kaddr = (unsigned char *) > > kmap_atomic(sg_page(s

Re: [PATCH] scsi_debug: disable clustering

2008-02-17 Thread Matthew Wilcox
On Sat, Feb 16, 2008 at 11:57:15PM +0900, FUJITA Tomonori wrote: > scsi_debug does at several places: > > for_each_sg(sdb->table.sgl, sg, sdb->table.nents, k) { > kaddr = (unsigned char *) > kmap_atomic(sg_page(sg), KM_USER0); > > > We cannot do something like that with the c

[PATCH] ieee1394: sbp2: fix rescan-scsi-bus

2008-02-17 Thread Stefan Richter
rescan-scsi-bus used to add SBP-2 targets which weren't there. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/ieee1394/sbp2.c |3 +++ 1 file changed, 3 insertions(+) Index: linux/drivers/ieee1394/sbp2.c === --- li

[PATCH] firewire: fw-sbp2: fix NULL pointer deref in slave_alloc

2008-02-17 Thread Stefan Richter
Fix a kernel bug when running rescan-scsi-bus while a FireWire disk is connected: http://bugzilla.kernel.org/show_bug.cgi?id=10008 Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/firewire/fw-sbp2.c |4 1 file changed, 4 insertions(+) Index: linux/drivers/firewire/fw-sbp2.

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-17 Thread Boaz Harrosh
On Sun, Feb 17 2008 at 14:52 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote: > On Sat, Feb 16 2008 at 2:41 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: >> On Fri, 15 Feb 2008 14:50:57 -0800 >> Tim Pepper <[EMAIL PROTECTED]> wrote: >> >>> On Sat 16 Feb at 01:09:43 +0900 [EMAIL PROTECTED] said: >

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-17 Thread Boaz Harrosh
On Sat, Feb 16 2008 at 2:41 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > On Fri, 15 Feb 2008 14:50:57 -0800 > Tim Pepper <[EMAIL PROTECTED]> wrote: > >> On Sat 16 Feb at 01:09:43 +0900 [EMAIL PROTECTED] said: >>> The first one is just reverting the data buffer accessors >>> conversion. It w

Re: USB regression (and other failures) in 2.6.2[45]*

2008-02-17 Thread Sergey Vlasov
On Sat, Feb 16, 2008 at 04:33:41PM -0500, Andrew Buehler wrote: > The associated dmesg (obtained yesterday from booting with the > Flash drive connected) is attached. This dmesg shows that ACPI is not enabled in your kernel config - most likely this is the problem. Try to enable it: 1) In the "

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-17 Thread Boaz Harrosh
On Sat, Feb 16 2008 at 18:37 +0200, Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Wed, Feb 13, 2008 at 10:57:37AM +0200, Boaz Harrosh wrote: >> I still don't have a card for testing myself. Again anyone >> wants to send me a card. Intel people anybody home? > > Apparently Intel sold this line of