On Wed, Feb 13, 2008 at 11:03:45AM -0600, James Bottomley wrote:
> > I don't understand please explain.
> > What does a driver need to do if it needs a consistent shutdown retine?
> > module or built in? unload or shutdown?
>
> It needs to register a reboot notifier, which gdth does.
Well, for c
Linux Kernel Mailing List wrote:
Gitweb:
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=99109301d103fbf0de43fc5a580a406c12a501e0
Commit: 99109301d103fbf0de43fc5a580a406c12a501e0
Parent: 61c92814dc324b541391757062ff02fbf3b08086
Author: Sergio Luis
On Wed, 13 Feb 2008 19:11:53 -0600 James Bottomley <[EMAIL PROTECTED]> wrote:
> > mptbase-reset-ioc-initiator-during-pci-resume.patch
> >
> > Fixes suspend/resume on all of Darrick's MPT cards. I first merged it
> > in September 2007.
>
> Patch presented by LSI but has gone back with commen
On Wed, 2008-02-13 at 17:22 -0800, David Miller wrote:
> From: James Bottomley <[EMAIL PROTECTED]>
> Date: Wed, 13 Feb 2008 19:11:53 -0600
>
> >
> > On Wed, 2008-02-13 at 16:16 -0800, Andrew Morton wrote:
> > > kill-warnings-in-mptbaseh-on-parisc64.patch
> >
> > > Warning fixes.
> >
> > Not
From: James Bottomley <[EMAIL PROTECTED]>
Date: Wed, 13 Feb 2008 19:11:53 -0600
>
> On Wed, 2008-02-13 at 16:16 -0800, Andrew Morton wrote:
> > kill-warnings-in-mptbaseh-on-parisc64.patch
>
> > Warning fixes.
>
> Not sure ... LSI is supposed to be processing this.
James, please don't push bu
On Wed, 2008-02-13 at 16:16 -0800, Andrew Morton wrote:
> On Wed, 13 Feb 2008 18:02:44 -0600
> James Bottomley <[EMAIL PROTECTED]> wrote:
>
> > This one's not too bad given the number of patches we had in the merge
> > window. We have the advansys fix, a gdth severe problem fix (wouldn't
> > sca
one system: initrd get courrupted:
RAMDISK: Compressed image found at block 0
RAMDISK: incomplete write (-28 != 2048) 134217728
crc error
VFS: Mounted root (ext2 filesystem).
Freeing unused kernel memory: 388k freed
init_special_inode: bogus i_mode (17)
Warning: unable to open an initial cons
On Wed, 13 Feb 2008 18:02:44 -0600
James Bottomley <[EMAIL PROTECTED]> wrote:
> This one's not too bad given the number of patches we had in the merge
> window. We have the advansys fix, a gdth severe problem fix (wouldn't
> scan any devices) a bug fix series for lpfc and a few other odds and
> e
(replaced missing cc's including linux-scsi)
On Wed 13 Feb at 14:39:07 -0800 [EMAIL PROTECTED] said:
>
> - Is the command path code even reaching the controller's processor inquiry
> spoofing section?
>
> if (scb->scsi_cmd->cmnd[0] == INQUIRY) {
> IPS_SCSI_INQ_D
This one's not too bad given the number of patches we had in the merge
window. We have the advansys fix, a gdth severe problem fix (wouldn't
scan any devices) a bug fix series for lpfc and a few other odds and
ends.
The patch is available here:
master.kernel.org:/pub/scm/linux/kernel/git/jejb/sc
On Wednesday 13 February 2008 03:25:27 pm James Bottomley wrote:
> On Tue, 2008-02-12 at 23:10 -0800, Yinghai Lu wrote:
> > if (type_ptr[0] != ENCLOSURE_COMPONENT_DEVICE &&
> > type_ptr[0] != ENCLOSURE_COMPONENT_ARRAY_DEVICE)
> > -
On Tue, 2008-02-12 at 23:10 -0800, Yinghai Lu wrote:
> if (type_ptr[0] != ENCLOSURE_COMPONENT_DEVICE &&
> type_ptr[0] != ENCLOSURE_COMPONENT_ARRAY_DEVICE)
> - continue;
> + goto next;
> +
>
We recently upgraded a production x86_64 machine with serveraid
cards to 2.6.24 and noted that /proc/scsi/scsi showed garbage for our
serveraid service processors. sg_inq also returned garbage from the
service processors' sg devices. After a few iterations I started seeing
meaninful stuff in the
This patch contains the following cleanups:
- static functions in .c files shouldn't be marked inline
- make needlessly global code static
- remove the unused aic94xx_seq.c:asd_unpause_lseq()
- #if 0 other unused code
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch has been sent on
This patch #if 0's the unused ses_match_host()
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/ses.c |2 ++
1 file changed, 2 insertions(+)
a9b8c5789924c15d23282da4b2e6bf8fa98449a2 diff --git a/drivers/scsi/ses.c
b/drivers/scsi/ses.c
index 2a6e4f4..9125486 100644
--- a/dri
This patch makes the following needlessly global functions static:
- __iscsi_unblock_session()
- iscsi_session_state_name()
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_transport_iscsi.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
c7b0a4c74538d3a53cd732
This patch makes the needlessly global scsi_end_bidi_request() static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
48e50a33ee11afb02eadc790ae2d9542b0805608
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index b12fb31..148c8b0 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/driv
El Wed, Feb 13, 2008 at 01:09:00PM -0600 James Bottomley ha dit:
> On Wed, 2008-02-13 at 19:34 +0100, Matthias Kaehlcke wrote:
> > Adaptec AACRAID driver: The semaphore fibctx->wait_sem is used for
> > signalling an event. Convert it to a completion.
>
> What's the purpose of doing this? The aac
[EMAIL PROTECTED] wrote on Tue, 12 Feb 2008 15:57 -0600:
> On Tue, 2008-02-12 at 16:46 -0500, Pete Wyckoff wrote:
> > [EMAIL PROTECTED] wrote on Tue, 12 Feb 2008 15:10 -0600:
> > > On Tue, 2008-02-12 at 15:54 -0500, Pete Wyckoff wrote:
> > > > iscsi_iser does not have any hardware DMA restrictions.
On Feb 13 2008 11:03, Boaz Harrosh wrote:
>>
>> I've tested this patch now - and it works fine. Now rmmod, halt and
>> reboot also works.
>>
>> Stefan Priebe
>>
>This is grate news Stefan. Thank you very much for all your time
>and effort, with out we could not have fixed all this.
Do you hav
This patch removes using sa_hash_kern.c and sa_hash.h files. All references
to the sa_hash.h are also removed.
1. Removed libsa/sa_hash_kern.c
2. Removed include/sa_hash.h
3. Removed all references to sa_hash_xxx
4. Updated Makefile accordingly in libsa
Signed-off-by: Yi Zou <[EMAIL PROTECTED]>
-
This patch removes using sa_hash_xxx and sticks to hlist_head and hlist_node
struct for hashing the fc_sess struct, removing the use of the sa_hash struct.
Also, the hash entry counter is removed as it's only used for debugging.
1. Added hash table funcs for fc_sess
2. Removed the fc_sess hash tab
This patch removes hash table for fc_local_port. The fc_local_port is always
created per openfc/fcoe instance, no need to have the hash table. This also
removes any use or references to sa_hash_xxx, as well as the abstraction of
the sa_hash struct.
1. Removed local port hash by fid from struct fc_
The following series remove use of all sa_hash_xxx in hash table operations
for fc_local_port, fc_remote_port, and fc_sess. sa_hash_kern.c and sa_hash.h
are removed. All abstraction using sa_hash_xxx are removed and replaced by
using hlist_head, hlist_node directly. Hash functions are in their own
This patch removes using sa_hash_xxx and sticks to hlist_head and hlist_node
struct for hashing the fc_remote_port, removing abstractions of sa_hash
struct. The hash by world wide port name is redundant and thus removed. Also,
all debugging rouintes are removed. The hash entry counter is removed as
On Wed, 2008-02-13 at 19:34 +0100, Matthias Kaehlcke wrote:
> Adaptec AACRAID driver: The semaphore fibctx->wait_sem is used for
> signalling an event. Convert it to a completion.
What's the purpose of doing this? The aacraid implementation seems to
be a classic PV semaphore, so why does it need
linux/completion is already included in commctrl.c, in the patch fragment it is
noted two lines below the addition. Please explain in the description the
need/advantages for the change from semaphore to completion.
Sincerely -- Mark Salyzyn
> -Original Message-
> From: Matthias Kaehlcke
Adaptec AACRAID driver: The semaphore fibctx->wait_sem is used for
signalling an event. Convert it to a completion.
Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]>
--
diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h
index 3195d29..eef4939 100644
--- a/drivers/sc
On Wed, 2008-02-13 at 09:45 -0800, Kristen Carlson Accardi wrote:
> I don't think I'm arguing whether or not your solution may work, what I
> am arguing is really a more philosophical point. Not "can we do it
> this way", but "should we do it way". I am of the opinion that
> management belongs in
On Tue, 12 Feb 2008 13:28:15 -0600
James Bottomley <[EMAIL PROTECTED]> wrote:
> On Tue, 2008-02-12 at 11:07 -0800, Kristen Carlson Accardi wrote:
> > I understand what you are trying to do - I guess I just doubt the
> > value you've added by doing this. I think that there's going to be
> > so muc
On Wed, 2008-02-13 at 19:12 +0200, Boaz Harrosh wrote:
> On Wed, Feb 13 2008 at 19:03 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> > On Wed, 2008-02-13 at 18:50 +0200, Boaz Harrosh wrote:
> >> On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley <[EMAIL PROTECTED]>
> >> wrote:
> >>> On Wed,
On Wed, 2008-02-13 at 19:18 +0200, Boaz Harrosh wrote:
> On Wed, Feb 13 2008 at 19:03 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> > It needs to register a reboot notifier, which gdth does.
> >
> > However, the notifier is only called on reboot, so it also needs to
> > clean up correctly on
On Wed, Feb 13 2008 at 19:03 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Wed, 2008-02-13 at 18:50 +0200, Boaz Harrosh wrote:
>> On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley <[EMAIL PROTECTED]>
>> wrote:
>>> On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote:
On Wed, Feb 1
On Wed, Feb 13 2008 at 19:03 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Wed, 2008-02-13 at 18:50 +0200, Boaz Harrosh wrote:
>> On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley <[EMAIL PROTECTED]>
>> wrote:
>>> On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote:
On Wed, Feb 1
On Wed, 2008-02-13 at 18:50 +0200, Boaz Harrosh wrote:
> On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> > On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote:
> >> On Wed, Feb 13 2008 at 17:54 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> >>> On Wed, Feb 13 20
On Wed, Feb 13 2008 at 18:45 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote:
>> On Wed, Feb 13 2008 at 17:54 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
>>> On Wed, Feb 13 2008 at 17:44 +0200, James Bottomley <[EMAIL PROTECTED]>
>>> wro
James Bottomley wrote:
... I wouldn't have bothered except that I could see ad-hoc
in-kernel sysfs solutions beginning to appear.
If this is true, and if no one quickly volunteers to do the utility, then
I agree with what you are doing.
-- james s
-
To unsubscribe from this list: send the li
On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote:
> On Wed, Feb 13 2008 at 17:54 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> > On Wed, Feb 13 2008 at 17:44 +0200, James Bottomley <[EMAIL PROTECTED]>
> > wrote:
> >> On Tue, 2008-02-12 at 19:40 +0200, Boaz Harrosh wrote:
> >>> - gdth_flus
On Wed, 2008-02-13 at 11:22 -0500, James Smart wrote:
> James Bottomley wrote:
> > I don't disagree with that, but the fact is that there isn't such a
> > tool. It's also a fact that the enterprise is reasonably unhappy with
> > the lack of an enclosure management infrastructure, since it's somet
On Tue, 2008-02-12 at 22:18 -0800, Nicholas A. Bellinger wrote:
> On Tue, 2008-02-12 at 19:57 -0800, Nicholas A. Bellinger wrote:
> > Greetings all,
> >
> > On Tue, 2008-02-12 at 17:05 +0100, Bart Van Assche wrote:
> > > On Feb 6, 2008 1:11 AM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote:
> >
gdth_exit would first remove all cards then stop the timer
and would not sync with the timer function. This caused a crash
in gdth_timer() when module was unloaded.
So del_timer_sync the timer before we delete the cards.
also a reboot notifier function was registered but is
not needed anymore. An
On Wed, Feb 13 2008 at 17:54 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> On Wed, Feb 13 2008 at 17:44 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
>> On Tue, 2008-02-12 at 19:40 +0200, Boaz Harrosh wrote:
>>> - gdth_flush(ha);
>>> -
>> This piece doesn't look right. gdth_flush() forces
James Bottomley wrote:
I don't disagree with that, but the fact is that there isn't such a
tool. It's also a fact that the enterprise is reasonably unhappy with
the lack of an enclosure management infrastructure, since it's something
they got on all the other unix systems.
I don't disagree.
On Wed, 2008-02-13 at 09:08 -0500, James Smart wrote:
> The keep-it-in-user-space arguments seem fairly compelling to me.
> Especially as we've pushed whole i/o subsystems out to user space
> (iscsi, stgt, talked about fcoe, a lot of dm control, etc).
And to me too.
> The functionality seems to a
On Wed, Feb 13 2008 at 17:44 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Tue, 2008-02-12 at 19:40 +0200, Boaz Harrosh wrote:
>> -gdth_flush(ha);
>> -
>
> This piece doesn't look right. gdth_flush() forces the internal cache
> to disk backing. If you remove it, you're taking the ch
On Tue, 2008-02-12 at 19:40 +0200, Boaz Harrosh wrote:
> - gdth_flush(ha);
> -
This piece doesn't look right. gdth_flush() forces the internal cache
to disk backing. If you remove it, you're taking the chance that the
machine will be powered off without a writeback which can cause data
corru
The keep-it-in-user-space arguments seem fairly compelling to me.
Especially as we've pushed whole i/o subsystems out to user space
(iscsi, stgt, talked about fcoe, a lot of dm control, etc).
The functionality seems to align with Doug's sg/lsscsi utility chain
as well. Granted, the new utility w
ACK
Sincerely -- Mark Salyzyn
> -Original Message-
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, February 12, 2008 6:06 PM
> To: LKML
> Cc: Marcin Slusarz; linux-scsi@vger.kernel.org; AACRAID;
> [EMAIL PROTECTED]
> Subject: [PATCH] scsi: le*_add_cpu conversion
>
> F
Joshua Hoblitt wrote:
I've got a few compilation errors on head. Before I try it, is it
possible to backport the 76d78300a6eb8b7f08e47703b7e68a659ffc2053 change
to 2.6.24.y?
Please just try this patch instead, it's what I am planning to submit to
-stable and add to Gentoo if you report succes
--- On Tue, 2/12/08, James Bottomley [EMAIL PROTECTED]> wrote:
> > I understand what you are trying to do - I guess I
> just doubt the value
> > you've added by doing this. I think that
> there's going to be so much
> > customization that system vendors will want to add,
> that they are going
> >
On Wed, Feb 13 2008 at 1:49 +0200, Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
> ---
> drivers/scsi/gdth.c | 143
> +++-
> 1 file changed, 86 insertions(+), 57 deletions(-)
>
below is the same exact pat
On Tue, Feb 12 2008 at 19:40 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> gdth _exit would first remove all cards then stop the timer
> and would not sync with the timer function. This caused a crash
> in gdth_timer() when module was unloaded.
>
> del_timer_sync the timer before we delete the
--- On Tue, 2/12/08, James Bottomley [EMAIL PROTECTED]> wrote:
> > I apologize for taking so long to review this patch.
> I obviously agree
> > wholeheartedly with Luben. The problem I ran into
> while trying to
> > design an enclosure management interface for the SATA
> devices is that
> > there
On Tue, Feb 12 2008 at 21:41 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Sun, 2008-02-10 at 21:05 +0200, Boaz Harrosh wrote:
>> - struct scsi_cmnd had a 16 bytes command buffer of its own.
>> This is an unnecessary duplication and copy of request's
>> cmd. It is probably left overs f
On 02/13/2008 12:49 AM, Jeff Garzik wrote:
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
---
drivers/scsi/gdth.c | 143 +++-
1 file changed, 86 insertions(+), 57 deletions(-)
06196f50915da97bb897495863f9f084d785c1e4
diff --git a/drivers/scsi/gdt
On Wed, Feb 13 2008 at 9:06 +0200, Stefan Priebe - allied internet ag <[EMAIL
PROTECTED]> wrote:
> Hello!
>
> I've tested this patch now - and it works fine. Now rmmod, halt and
> reboot also works.
>
> Stefan Priebe
>
This is grate news Stefan. Thank you very much for all your time
and effort
On Wed, Feb 13 2008 at 2:17 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Tue, 2008-02-12 at 20:48 -0300, Sergio Luis wrote:
>> reposting an updated version of it. Please check if it's ok.
>
> Looks fine, thanks! You added an extra space at the end of
>
> while ((pdev = pci_get_device(
I have received below message from a tester. Can any one please help me
with the /proc/scsi/gdth/0 problem. Where should I look?
Boaz
On Wed, Feb 13 2008 at 8:39 +0200, Tobias Oetiker <[EMAIL PROTECTED]> wrote:
> Hi Boaz,
>
> I just tested the patch to GDTH you published yesterday on LKML.
> Wi
This message describes another issue about md-RAID10 found by
testing the 2.6.24 md RAID10 using new scsi fault injection framework.
Abstract:
When a scsi command timeout occurs during RAID10 recovery, the kernel
threads for md RAID10 could cause a md RAID10 array deadlock.
The nr_pending flag set
(cc's added)
On Mon, 11 Feb 2008 17:44:08 +0100 "Aron Stansvik" <[EMAIL PROTECTED]> wrote:
> Hello LKML.
>
> Under semi-high disk I/O (e.g. installing a compiled KDE), I get the
> following (accompanied by seconds of lock-ups on the machine):
>
> [ 7727.345183] arcmsr0: abort device command of
60 matches
Mail list logo
