[patch 12/13] scsi: arcmsr updates (1.20.00.15)

2008-02-04 Thread akpm
From: Nick Cheng <[EMAIL PROTECTED]> - add arcmsr_enable_eoi_mode()and readl(reg->iop2drv_doorbell_reg) in arcmsr_handle_hbb_isr() on adapter Type B in case of the doorbell interrupt clearance is cached - add conditional declaration for arcmsr_pci_error_detected() and arcmsr_pci_slot_reset

[patch 10/13] scsi/aic94xx/: cleanups

2008-02-04 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> - static functions in .c files shouldn't be marked inline - make needlessly global code static - remove the unused aic94xx_seq.c:asd_unpause_lseq() - #if 0 other unused code [EMAIL PROTECTED]: coding-style fixes] Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>

[patch 09/13] 3W RAID drivers: memset not needed in probe

2008-02-04 Thread akpm
From: Denis Cheng <[EMAIL PROTECTED]> The memory return from scsi_host_alloc is alloced by kzalloc, which is already zero initilized, so memset not needed. Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> Cc: Adam Radford <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- dr

[patch 06/13] scsi/advansys.c: make 3 functions static

2008-02-04 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/advansys.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -puN drivers/scsi/advansys.c~scsi-advansysc-make-3-functions-stat

[PATCH 5/5] libata: implement drain buffers

2008-02-04 Thread Tejun Heo
From: James Bottomley <[EMAIL PROTECTED]> From: James Bottomley <[EMAIL PROTECTED]> This just updates the libata slave configure routine to take advantage of the block layer drain buffers. It also adjusts the size lengths in the atapi code to add the drain buffer to the DMA length so the driver

[PATCH 4/5] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-04 Thread Tejun Heo
From: James Bottomley <[EMAIL PROTECTED]> From: James Bottomley <[EMAIL PROTECTED]> ATA requires that all DMA transfers begin and end on word boundaries. Because of this, a large amount of machinery grew up in ide to adjust scatterlists on this basis. However, as of 2.5, the block layer has a dm

[PATCH 3/5] block: implement request_queue->dma_drain_needed

2008-02-04 Thread Tejun Heo
Draining shouldn't be done for commands where overflow may indicate data integrity issues. Add dma_drain_needed callback to request_queue. Drain buffer is appened iff this function returns non-zero. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> --- block/b

[PATCH 2/5] block: add request->raw_data_len

2008-02-04 Thread Tejun Heo
With padding and draining moved into it, block layer now may extend requests as directed by queue parameters, so now a request has two sizes - the original request size and the extended size which matches the size of area pointed to by bios and later by sgs. The latter size is what lower layers ar

[PATCHSET #upstream] block/libata: update and use block layer padding and draining

2008-02-04 Thread Tejun Heo
This patchset updates block layer padding and draining support and make libata use it. It's based on James Bottomley's initial work and, of the five, the last two patches are from James with some modifications. Please read the following thread for more info. http://thread.gmane.org/gmane.linu

[PATCH 1/5] block: update bio according to DMA alignment padding

2008-02-04 Thread Tejun Heo
DMA start address and transfer size alignment for PC requests are achieved using bio_copy_user() instead of bio_map_user(). This works because bio_copy_user() always uses full pages and block DMA alignment isn't allowed to go over PAGE_SIZE. However, the implementation didn't update the last bio

[patch 11/13] Small cleanups for scsi_host.h

2008-02-04 Thread akpm
From: Pavel Machek <[EMAIL PROTECTED]> Small cleanups in scsi_host.h. Few #defines make me wonder if their description is still up to date..? Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- include/scsi

[patch 08/13] sg: nopage

2008-02-04 Thread akpm
From: Nick Piggin <[EMAIL PROTECTED]> Convert SG from nopage to fault. Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> Cc: Douglas Gilbert <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/sg.c | 23 +++

[patch 13/13] drivers/scsi/dc395x.c: fix uninitialized var warning

2008-02-04 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> drivers/scsi/dc395x.c: In function 'dc395x_init_one': drivers/scsi/dc395x.c:4270: warning: 'ptr' may be used uninitialized in this function Cc: James Bottomley <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/dc395x.c

[patch 05/13] MegaRAID driver management char device moved to misc

2008-02-04 Thread akpm
From: Thomas Horsten <[EMAIL PROTECTED]> The MegaRAID driver's common management module (megaraid_mm.c) creates a char device used by the management tool "megarc" from LSI Logic (and possibly other management tools). In 2.6 with udev, this device doesn't get created because it is not registered i

[patch 07/13] Dell CERC support for megaraid_mbox

2008-02-04 Thread akpm
From: Hannes Reinecke <[EMAIL PROTECTED]> Newer Dell CERC firmware (>= 6.62) implement a random deletion handling compatible with the legacy megaraid driver. The legacy handling shifted the target ID by 0x80 only for I/O commands (READ/WRITE/etc), whereas megaraid_mbox shifts the target ID always

[patch 03/13] mptbase: reset ioc initiator during PCI resume

2008-02-04 Thread akpm
From: "Darrick J. Wong" <[EMAIL PROTECTED]> It appears that the LSI SAS 1064E chip needs to be reset after a suspend/resume cycle before the driver attempts further communications with the chip. Without this patch, resuming the chip results in this error message being printed repeatedly and no mo

[patch 04/13] kill warnings in mptbase.h on parisc64

2008-02-04 Thread akpm
From: Kyle McMartin <[EMAIL PROTECTED]> Verified all the arches necessary select the CONFIG_64BIT symbol. This also kills the warning (since it was using the 32-bit case) on parisc64 and mips64. Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]> Cc: "Moore, Eric Dean" <[EMAIL PROTECTED]> Cc: James

[patch 02/13] git-scsi-misc gdth fix

2008-02-04 Thread akpm
From: James Bottomley <[EMAIL PROTECTED]> On Sun, 2007-10-14 at 12:21 -0700, Andrew Morton wrote: > On Sun, 14 Oct 2007 22:45:47 +0400 "Dave Milter" <[EMAIL PROTECTED]> wrote: > > > I build linux-2.6.23-mm1 and try to boot it using qemu, > > and it crashed with trace like this: > > do_page_fault >

[patch 01/13] git-scsi-misc: fix isa/pcmcia compile problem

2008-02-04 Thread akpm
From: Tejun Heo <[EMAIL PROTECTED]> aha152x.c and fdomain are built twice - once for the isa driver and once for the PCMCIA one. Through #ifdefs, the compiled codes are slightly different; thus, global symbols need to be given different names depending on which flavor is being built. This patch

Re: [Cbe-oss-dev] LIO Target iSCSI/SE PS3-Linux / FC8 builds

2008-02-04 Thread Bart Van Assche
On Feb 4, 2008 5:44 PM, Marc Dietrich <[EMAIL PROTECTED]> wrote: > ... > Anyway, heres a quick ugly fix for the ARCH detection code, tested on ps3. > ... Architecture detection is indeed broken in LIO. Would it be possible to use the standard config.guess script instead of the custom LIO arch dete

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Tomasz Chmielewski
James Bottomley schrieb: These are both features being independently worked on, are they not? Even if they weren't, the combination of the size of SCST in kernel plus the problem of having to find a migration path for the current STGT users still looks to me to involve the greater amount of work

Re: [PATCH] enclosure: add support for enclosure services

2008-02-04 Thread Luben Tuikov
--- On Mon, 2/4/08, James Bottomley <[EMAIL PROTECTED]> wrote: > > --- On Mon, 2/4/08, James Bottomley > <[EMAIL PROTECTED]> wrote: > > > On Mon, 2008-02-04 at 18:01 -0800, Luben Tuikov > wrote: > > > > --- On Mon, 2/4/08, James Bottomley > > > <[EMAIL PROTECTED]> > wrote: > > > > > > > The enclosu

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-04 Thread Tejun Heo
James Bottomley wrote: >> Oops, I was talking about padding. Sorry about that. > > Oh, OK ... the I thought the changelog was pretty explicit. However, it > works because the dma_aligment parameter of the block layer ensures that > all elements of the sg list begin and end on an address that con

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread James Bottomley
On Tue, 2008-02-05 at 05:43 +0100, Matteo Tescione wrote: > Hi all, > And sorry for intrusion, i am not a developer but i work everyday with iscsi > and i found it fantastic. > Altough Aoe, Fcoe and so on could be better, we have to look in real world > implementations what is needed *now*, and if

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-04 Thread James Bottomley
On Tue, 2008-02-05 at 10:07 +0900, Tejun Heo wrote: > James Bottomley wrote: > No, it doesn't. Drain needs to extend the sg table too > >>> The patches do extend the sg table. > >> Hmm... Where? > > > > It's the block component; it's already in git head with this patch: > > > > commit fa0c

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Matteo Tescione
Hi all, And sorry for intrusion, i am not a developer but i work everyday with iscsi and i found it fantastic. Altough Aoe, Fcoe and so on could be better, we have to look in real world implementations what is needed *now*, and if we look at vmware world, virtual iron, microsoft clustering etc, the

Re: [PATCH] enclosure: add support for enclosure services

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 19:28 -0800, Luben Tuikov wrote: > --- On Mon, 2/4/08, James Bottomley <[EMAIL PROTECTED]> wrote: > > On Mon, 2008-02-04 at 18:01 -0800, Luben Tuikov wrote: > > > --- On Mon, 2/4/08, James Bottomley > > <[EMAIL PROTECTED]> wrote: > > > > > > The enclosure misc device is really

Re: dmesg spam

2008-02-04 Thread Andrew Morton
On Mon, 04 Feb 2008 14:44:18 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > > On Mon, 2008-02-04 at 15:24 -0500, Jeff Garzik wrote: > > James Bottomley wrote: > > > It's here in sr_ioctl.c: > > > > Ah, indeed. My grep-fu sucks today. > > > > > > > I'm not averse to simply nuking the print

Re: [PATCH] enclosure: add support for enclosure services

2008-02-04 Thread Luben Tuikov
--- On Mon, 2/4/08, James Bottomley <[EMAIL PROTECTED]> wrote: > On Mon, 2008-02-04 at 18:01 -0800, Luben Tuikov wrote: > > --- On Mon, 2/4/08, James Bottomley > <[EMAIL PROTECTED]> wrote: > > > > > The enclosure misc device is really > just a > > > library providing > > > > > sysfs > > > > > suppo

Re: new scsi sense handling

2008-02-04 Thread Luben Tuikov
--- On Mon, 2/4/08, Boaz Harrosh <[EMAIL PROTECTED]> wrote: > There are 3 usages of sense handling in drivers > > 1. sense is available in driver internal structure and is > mem-copied to upper level > 2. A CHECK_CONDITION status was returned and the driver > uses the scsi_eh_prep_cmnd() >for

Re: [PATCH] enclosure: add support for enclosure services

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 18:01 -0800, Luben Tuikov wrote: > --- On Mon, 2/4/08, James Bottomley <[EMAIL PROTECTED]> wrote: > > > > The enclosure misc device is really just a > > library providing > > > > sysfs > > > > support for physical enclosure devices and their > > > > components. > > > > > > W

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Chris Weiss
On Feb 4, 2008 11:30 AM, Douglas Gilbert <[EMAIL PROTECTED]> wrote: > Alan Cox wrote: > >> better. So for example, I personally suspect that ATA-over-ethernet is way > >> better than some crazy SCSI-over-TCP crap, but I'm biased for simple and > >> low-level, and against those crazy SCSI people to

Re: [PATCH] enclosure: add support for enclosure services

2008-02-04 Thread Luben Tuikov
--- On Mon, 2/4/08, James Bottomley <[EMAIL PROTECTED]> wrote: > > > The enclosure misc device is really just a > library providing > > > sysfs > > > support for physical enclosure devices and their > > > components. > > > > Who is the target audience/user of those facilities? > > a) The kernel it

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Linus Torvalds
On Mon, 4 Feb 2008, Jeff Garzik wrote: > > Both of these are easily handled if the server is 100% in charge of managing > the filesystem _metadata_ and data. That's what I meant by complete control. > > i.e. it not ext3 or reiserfs or vfat, its a block device or 1000GB file > managed by a user

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-04 Thread Tejun Heo
James Bottomley wrote: No, it doesn't. Drain needs to extend the sg table too >>> The patches do extend the sg table. >> Hmm... Where? > > It's the block component; it's already in git head with this patch: > > commit fa0ccd837e3dddb44c7db2f128a8bb7e4eabc21a > Author: James Bottomley <[EMA

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-04 Thread James Bottomley
On Tue, 2008-02-05 at 09:43 +0900, Tejun Heo wrote: > Hello, > > James Bottomley wrote: > >> No, it doesn't. Drain needs to extend the sg table too > > > > The patches do extend the sg table. > > Hmm... Where? It's the block component; it's already in git head with this patch: commit fa0ccd

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Matt Mackall
On Mon, 2008-02-04 at 16:24 -0800, Linus Torvalds wrote: > > On Mon, 4 Feb 2008, Matt Mackall wrote: > > > > But ATAoE is boring because it's not IP. Which means no routing, > > firewalls, tunnels, congestion control, etc. > > The thing is, that's often an advantage. Not just for performance. >

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-04 Thread Tejun Heo
Hello, James Bottomley wrote: >> No, it doesn't. Drain needs to extend the sg table too > > The patches do extend the sg table. Hmm... Where? >> and it makes controllers lax about buffer overruns for commands they >> shouldn't be. > > So adjust the qc->nbytes to show no drain element in lib

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Jeff Garzik
Linus Torvalds wrote: On Mon, 4 Feb 2008, Matt Mackall wrote: But ATAoE is boring because it's not IP. Which means no routing, firewalls, tunnels, congestion control, etc. The thing is, that's often an advantage. Not just for performance. NBD and iSCSI (for all its hideous growths) can take

Re: [PATCH] enclosure: add support for enclosure services

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 16:32 -0800, Luben Tuikov wrote: > --- On Sun, 2/3/08, James Bottomley <[EMAIL PROTECTED]> wrote: > > > The enclosure misc device is really just a library providing > > sysfs > > support for physical enclosure devices and their > > components. > > Who is the target audience/

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-04 Thread James Bottomley
On Tue, 2008-02-05 at 09:06 +0900, Tejun Heo wrote: > James Bottomley wrote: > > Plus, tape devices are also ATAPI and since the problem seems to be > > handling of ATAPI pio commands, they need all of this too. It really > > is, I think, better just to do the setup in the libata slave configure

Re: [PATCH] enclosure: add support for enclosure services

2008-02-04 Thread Luben Tuikov
--- On Sun, 2/3/08, James Bottomley <[EMAIL PROTECTED]> wrote: > The enclosure misc device is really just a library providing > sysfs > support for physical enclosure devices and their > components. Who is the target audience/user of those facilities? a) The kernel itself needing to read/write SE

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Linus Torvalds
On Mon, 4 Feb 2008, Matt Mackall wrote: > > But ATAoE is boring because it's not IP. Which means no routing, > firewalls, tunnels, congestion control, etc. The thing is, that's often an advantage. Not just for performance. > NBD and iSCSI (for all its hideous growths) can take advantage of the

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Matt Mackall
On Mon, 2008-02-04 at 22:43 +, Alan Cox wrote: > > better. So for example, I personally suspect that ATA-over-ethernet is way > > better than some crazy SCSI-over-TCP crap, but I'm biased for simple and > > low-level, and against those crazy SCSI people to begin with. > > Current ATAoE isn'

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Jeff Garzik
Linus Torvalds wrote: On Mon, 4 Feb 2008, Jeff Garzik wrote: Well, speaking as a complete nutter who just finished the bare bones of an NFSv4 userland server[1]... it depends on your approach. You definitely are a complete nutter ;) If the userland server is the _only_ one accessing the da

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-04 Thread Tejun Heo
James Bottomley wrote: > Plus, tape devices are also ATAPI and since the problem seems to be > handling of ATAPI pio commands, they need all of this too. It really > is, I think, better just to do the setup in the libata slave configure > if the device is atapi. If no SCSI HBA needs it, fine. >

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Linus Torvalds
On Mon, 4 Feb 2008, Jeff Garzik wrote: > > Well, speaking as a complete nutter who just finished the bare bones of an > NFSv4 userland server[1]... it depends on your approach. You definitely are a complete nutter ;) > If the userland server is the _only_ one accessing the data[2] -- i.e. the

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Douglas Gilbert
Alan Cox wrote: better. So for example, I personally suspect that ATA-over-ethernet is way better than some crazy SCSI-over-TCP crap, but I'm biased for simple and low-level, and against those crazy SCSI people to begin with. Current ATAoE isn't. It can't support NCQ. A variant that did NCQ an

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Linus Torvalds
On Mon, 4 Feb 2008, Jeff Garzik wrote: > > For years I have been hoping that someone will invent a simple protocol (w/ > strong auth) that can transit ATA and SCSI commands and responses. Heck, it > would be almost trivial if the kernel had a TLS/SSL implementation. Why would you want authoriza

Re: [PATCH] [SCSI] sd: make error handling more robust (v2)

2008-02-04 Thread Luben Tuikov
--- On Mon, 2/4/08, James Bottomley <[EMAIL PROTECTED]> wrote: > On Mon, 2008-02-04 at 01:11 -0800, Luben Tuikov wrote: > > Looks good except that "End LBA" is usually > defined > > to be something of the sort of "the LBA of the > last > > logical block accessed by the command" or > "the LBA > > of

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Nicholas A. Bellinger
On Mon, 2008-02-04 at 15:12 -0800, Nicholas A. Bellinger wrote: > On Mon, 2008-02-04 at 17:00 -0600, James Bottomley wrote: > > On Mon, 2008-02-04 at 22:43 +, Alan Cox wrote: > > > > better. So for example, I personally suspect that ATA-over-ethernet is > > > > way > > > > better than some cr

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Nicholas A. Bellinger
On Mon, 2008-02-04 at 17:00 -0600, James Bottomley wrote: > On Mon, 2008-02-04 at 22:43 +, Alan Cox wrote: > > > better. So for example, I personally suspect that ATA-over-ethernet is > > > way > > > better than some crazy SCSI-over-TCP crap, but I'm biased for simple and > > > low-level, an

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Jeff Garzik
Alan Cox wrote: better. So for example, I personally suspect that ATA-over-ethernet is way better than some crazy SCSI-over-TCP crap, but I'm biased for simple and low-level, and against those crazy SCSI people to begin with. Current ATAoE isn't. It can't support NCQ. A variant that did NCQ an

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 22:43 +, Alan Cox wrote: > > better. So for example, I personally suspect that ATA-over-ethernet is way > > better than some crazy SCSI-over-TCP crap, but I'm biased for simple and > > low-level, and against those crazy SCSI people to begin with. > > Current ATAoE isn'

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Nicholas A. Bellinger
On Mon, 2008-02-04 at 22:43 +, Alan Cox wrote: > > better. So for example, I personally suspect that ATA-over-ethernet is way > > better than some crazy SCSI-over-TCP crap, but I'm biased for simple and > > low-level, and against those crazy SCSI people to begin with. > > Current ATAoE isn't

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Jeff Garzik
Linus Torvalds wrote: So no, performance is not the only reason to move to kernel space. It can easily be things like needing direct access to internal data queues (for a iSCSI target, this could be things like barriers or just tagged commands - yes, you can probably emulate things like that wi

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Alan Cox
> better. So for example, I personally suspect that ATA-over-ethernet is way > better than some crazy SCSI-over-TCP crap, but I'm biased for simple and > low-level, and against those crazy SCSI people to begin with. Current ATAoE isn't. It can't support NCQ. A variant that did NCQ and IP would p

[PATCH][drivers/scsi/u14-34f.c] duplicate test 'SCpnt->sc_data_direction == DMA_FROM_DEVICE'

2008-02-04 Thread Roel Kluin
It should be like this I guess? this patch was not yet tested, please confirm. -- Note the duplicate test 'SCpnt->sc_data_direction == DMA_FROM_DEVICE' from Documentation/DMA-API.txt: DMA_TO_DEVICE = PCI_DMA_TODEVICE data is going from the

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Nicholas A. Bellinger
On Mon, 2008-02-04 at 13:24 -0800, Linus Torvalds wrote: > > On Mon, 4 Feb 2008, J. Bruce Fields wrote: > > > > I'd assumed the move was primarily because of the difficulty of getting > > correct semantics on a shared filesystem > > .. not even shared. It was hard to get correct semantics full s

Re: (fwd) Bug#11922: I/O error on blank tapes

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 22:28 +0100, Borislav Petkov wrote: > On Mon, Feb 04, 2008 at 03:22:06PM +0100, maximilian attems wrote: > > (Added Bart to CC) > > > hello borislav, > > > > may i forward you that *old* Debian kernel bug, > > have seen you working on ide-tape: > > http://bugs.debian.org/1

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread J. Bruce Fields
On Mon, Feb 04, 2008 at 11:44:31AM -0800, Linus Torvalds wrote: ... > Pure user-space solutions work, but tend to eventually be turned into > kernel-space if they are simple enough and really do have throughput and > latency considerations (eg nfsd), and aren't quite complex and crazy > enough t

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Linus Torvalds
On Mon, 4 Feb 2008, J. Bruce Fields wrote: > > I'd assumed the move was primarily because of the difficulty of getting > correct semantics on a shared filesystem .. not even shared. It was hard to get correct semantics full stop. Which is a traditional problem. The thing is, the kernel always

Re: [PATCH] [SCSI] sd: make error handling more robust (v2)

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 01:11 -0800, Luben Tuikov wrote: > Looks good except that "End LBA" is usually defined > to be something of the sort of "the LBA of the last > logical block accessed by the command" or "the LBA > of the logical block on which the command failed". > > A spec savvy editor of th

Re: [PATCH 7/9] scsi_dh: Add support for SDEV_PASSIVE

2008-02-04 Thread Chandra Seetharaman
On Mon, 2008-02-04 at 14:28 -0600, James Bottomley wrote: > On Mon, 2008-02-04 at 12:15 -0800, Chandra Seetharaman wrote: > > On Mon, 2008-02-04 at 12:58 -0600, James Bottomley wrote: > > > On Wed, 2008-01-23 at 16:32 -0800, Chandra Seetharaman wrote: > > > > Subject: scsi_dh: Add support for SDEV_

Re: dmesg spam

2008-02-04 Thread Andrew Morton
On Mon, 04 Feb 2008 15:21:54 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > James Bottomley wrote: > > The message comes from sr_ioctl.c:sr_do_ioctl(). Which means some user > > level application is poking the drive with a command that's returning > > NOT_READY. Apparently it will shut up if qui

Re: [PATCH] [RFC] sd: make error handling more robust

2008-02-04 Thread Luben Tuikov
--- On Mon, 2/4/08, Tony Battersby <[EMAIL PROTECTED]> wrote: > I _really_ _really_ hope that you don't believe that I > am trying to take > credit for your work. If you take another look, my original > patch had > the following hunk: > > + > + /* Make sure that bad_lba is one of the s

Re: dmesg spam

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 15:24 -0500, Jeff Garzik wrote: > James Bottomley wrote: > > It's here in sr_ioctl.c: > > Ah, indeed. My grep-fu sucks today. > > > > I'm not averse to simply nuking the printk ... it's probably valueless > > in a modern kernel, since something dbussy is supposed to tell

Re: [PATCH 7/9] scsi_dh: Add support for SDEV_PASSIVE

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 12:15 -0800, Chandra Seetharaman wrote: > On Mon, 2008-02-04 at 12:58 -0600, James Bottomley wrote: > > On Wed, 2008-01-23 at 16:32 -0800, Chandra Seetharaman wrote: > > > Subject: scsi_dh: Add support for SDEV_PASSIVE > > > > > > From: Chandra Seetharaman <[EMAIL PROTECTED]

Re: [PATCH 7/9] scsi_dh: Add support for SDEV_PASSIVE

2008-02-04 Thread Mike Anderson
James Bottomley <[EMAIL PROTECTED]> wrote: > > On Wed, 2008-01-23 at 16:32 -0800, Chandra Seetharaman wrote: > > Subject: scsi_dh: Add support for SDEV_PASSIVE > > > > From: Chandra Seetharaman <[EMAIL PROTECTED]> > > > > This patch adds a new device state SDEV_PASSIVE, to correspond to the > >

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Nicholas A. Bellinger
On Mon, 2008-02-04 at 11:44 -0800, Linus Torvalds wrote: > > On Mon, 4 Feb 2008, Nicholas A. Bellinger wrote: > > > > While this does not have anything to do directly with the kernel vs. > > user discussion for target mode storage engine, the scaling and latency > > case is easy enough to make

Re: dmesg spam

2008-02-04 Thread Jeff Garzik
James Bottomley wrote: It's here in sr_ioctl.c: Ah, indeed. My grep-fu sucks today. I'm not averse to simply nuking the printk ... it's probably valueless in a modern kernel, since something dbussy is supposed to tell you to put a CD in the drive, not something in the kernel. The reverse.

Re: dmesg spam

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 15:14 -0500, Jeff Garzik wrote: > Andrew Morton wrote: > > On Mon, 4 Feb 2008 15:24:55 +0100 Bartlomiej Zolnierkiewicz <[EMAIL > > PROTECTED]> wrote: > > > >> On Sunday 03 February 2008, Andrew Morton wrote: > >>> With latest -mm, running fc8 I am getting this in the logs,

Re: dmesg spam

2008-02-04 Thread Jeff Garzik
James Bottomley wrote: The message comes from sr_ioctl.c:sr_do_ioctl(). Which means some user level application is poking the drive with a command that's returning NOT_READY. Apparently it will shut up if quiet is set in the packet command structure. It could be the application is getting the

Re: [PATCH 7/9] scsi_dh: Add support for SDEV_PASSIVE

2008-02-04 Thread Chandra Seetharaman
On Mon, 2008-02-04 at 12:58 -0600, James Bottomley wrote: > On Wed, 2008-01-23 at 16:32 -0800, Chandra Seetharaman wrote: > > Subject: scsi_dh: Add support for SDEV_PASSIVE > > > > From: Chandra Seetharaman <[EMAIL PROTECTED]> > > > > This patch adds a new device state SDEV_PASSIVE, to correspond

Re: dmesg spam

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 12:05 -0800, Andrew Morton wrote: > On Mon, 4 Feb 2008 15:24:55 +0100 Bartlomiej Zolnierkiewicz <[EMAIL > PROTECTED]> wrote: > > > On Sunday 03 February 2008, Andrew Morton wrote: > > > > > > With latest -mm, running fc8 I am getting this in the logs, > >

Re: dmesg spam

2008-02-04 Thread Jeff Garzik
Andrew Morton wrote: On Mon, 4 Feb 2008 15:24:55 +0100 Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: On Sunday 03 February 2008, Andrew Morton wrote: With latest -mm, running fc8 I am getting this in the logs, ^^^ => SCSI/libata cc:ing Jeff once per secon

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread 4news
On lunedì 4 febbraio 2008, Linus Torvalds wrote: > So from a purely personal standpoint, I'd like to say that I'm not really > interested in iSCSI (and I don't quite know why I've been cc'd on this > whole discussion) and think that other approaches are potentially *much* > better. So for example,

Re: [PATCH] bugfix for an underflow condition in usb storage & isd200.c

2008-02-04 Thread Alan Stern
On Sun, 3 Feb 2008, Matthew Dharm wrote: > But, the modifications to usb_stor_access_xfer_buf() look good -- no > request from a sub-driver should be allowed to scribble into memory. The > current code does make the implicit assumption that there is enough > storage, and will walk right off the e

Re: dmesg spam

2008-02-04 Thread Andrew Morton
On Mon, 4 Feb 2008 15:24:55 +0100 Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > On Sunday 03 February 2008, Andrew Morton wrote: > > > > With latest -mm, running fc8 I am getting this in the logs, >^^^ > => SCSI/libata > > cc:ing Jeff > > > once per second.

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Linus Torvalds
On Mon, 4 Feb 2008, Nicholas A. Bellinger wrote: > > While this does not have anything to do directly with the kernel vs. > user discussion for target mode storage engine, the scaling and latency > case is easy enough to make if we are talking about scaling TCP for 10 > Gb/sec storage fabrics

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Nicholas A. Bellinger
On Mon, 2008-02-04 at 11:06 -0800, Nicholas A. Bellinger wrote: > On Mon, 2008-02-04 at 10:29 -0800, Linus Torvalds wrote: > > > > On Mon, 4 Feb 2008, James Bottomley wrote: > > > > > > The way a user space solution should work is to schedule mmapped I/O > > > from the backing store and then send

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Nicholas A. Bellinger
On Mon, 2008-02-04 at 10:29 -0800, Linus Torvalds wrote: > > On Mon, 4 Feb 2008, James Bottomley wrote: > > > > The way a user space solution should work is to schedule mmapped I/O > > from the backing store and then send this mmapped region off for target > > I/O. > > mmap'ing may avoid the cop

Re: [PATCH 3/9] scsi_dh: scsi handling of REQ_LB_OP_TRANSITION

2008-02-04 Thread James Bottomley
On Fri, 2008-02-01 at 14:00 -0600, Mike Christie wrote: > Chandra Seetharaman wrote: > > @@ -1445,9 +1479,24 @@ static void scsi_kill_request(struct req > > static void scsi_softirq_done(struct request *rq) > > { > > struct scsi_cmnd *cmd = rq->completion_data; > > - unsigned long wait_for

Re: [PATCH 3/9] scsi_dh: scsi handling of REQ_LB_OP_TRANSITION

2008-02-04 Thread Chandra Seetharaman
On Fri, 2008-02-01 at 14:00 -0600, Mike Christie wrote: > Chandra Seetharaman wrote: > > @@ -1445,9 +1479,24 @@ static void scsi_kill_request(struct req > > static void scsi_softirq_done(struct request *rq) > > { > > struct scsi_cmnd *cmd = rq->completion_data; > > - unsigned long wait_for

Re: [PATCH 7/9] scsi_dh: Add support for SDEV_PASSIVE

2008-02-04 Thread James Bottomley
On Wed, 2008-01-23 at 16:32 -0800, Chandra Seetharaman wrote: > Subject: scsi_dh: Add support for SDEV_PASSIVE > > From: Chandra Seetharaman <[EMAIL PROTECTED]> > > This patch adds a new device state SDEV_PASSIVE, to correspond to the > passive side access of an active/passive multipathed device

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 21:38 +0300, Vladislav Bolkhovitin wrote: > James Bottomley wrote: > > On Mon, 2008-02-04 at 20:56 +0300, Vladislav Bolkhovitin wrote: > > > >>James Bottomley wrote: > >> > >>>On Mon, 2008-02-04 at 20:16 +0300, Vladislav Bolkhovitin wrote: > >>> > >>> > James Bottomley wr

Re: [PATCH 4/9] scsi_dh: add skeleton for SCSI Device Handlers

2008-02-04 Thread Chandra Seetharaman
On Fri, 2008-02-01 at 13:53 -0600, Mike Christie wrote: > Chandra Seetharaman wrote: > > * mainly associated with tapes and returned SUCCESS. > > Index: linux-2.6.24-rc8/drivers/scsi/scsi_sysfs.c > > === > > --- linux-2.6.24-rc8.o

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 10:29 -0800, Linus Torvalds wrote: > > On Mon, 4 Feb 2008, James Bottomley wrote: > > > > The way a user space solution should work is to schedule mmapped I/O > > from the backing store and then send this mmapped region off for target > > I/O. > > mmap'ing may avoid the cop

RE: [PATCH 3/24][RFC] scsi-drivers: more drivers use new scsi_eh_cpy_sense()

2008-02-04 Thread Salyzyn, Mark
ACK for aacraid and ips with condition that community accepts the RFC's premise. The code changes appear trivial and make sense. I had some upstream changes in the set_sense code in aacraid related to a recent discussion regarding error propagation that is overlapped directly by the changes in

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Vladislav Bolkhovitin
James Bottomley wrote: On Mon, 2008-02-04 at 20:56 +0300, Vladislav Bolkhovitin wrote: James Bottomley wrote: On Mon, 2008-02-04 at 20:16 +0300, Vladislav Bolkhovitin wrote: James Bottomley wrote: So, James, what is your opinion on the above? Or the overall SCSI target project simplicit

RE: [PATCH 5/24][RFC] dpt_i2o: Use new scsi_eh_cpy_sense()

2008-02-04 Thread Salyzyn, Mark
ACK with condition that community accepts the RFC's entire premise. The removed code that shunted the REQUEST_SENSE was based on the assumption that the sense data in the current scsi command packet was left over from the previous command's execution with a check condition as the scsi command pa

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread Linus Torvalds
On Mon, 4 Feb 2008, James Bottomley wrote: > > The way a user space solution should work is to schedule mmapped I/O > from the backing store and then send this mmapped region off for target > I/O. mmap'ing may avoid the copy, but the overhead of a mmap operation is quite often much *bigger* th

RE: [PATCH 07/12] qla4xxx: add qla4xxx async scan support

2008-02-04 Thread David Somayajulu
Mike Christie wrote: > qla4xxx has the old school startup/probe where it finds > presetup sessions > in its flash and then attempts to log into them before > returning from the > probe. This however, makes it very simple to add a iscsi > class scan finished > helper which the driver can use. >

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread James Bottomley
On Mon, 2008-02-04 at 20:56 +0300, Vladislav Bolkhovitin wrote: > James Bottomley wrote: > > On Mon, 2008-02-04 at 20:16 +0300, Vladislav Bolkhovitin wrote: > > > >>James Bottomley wrote: > >> > >>So, James, what is your opinion on the above? Or the overall SCSI > >>target > >>projec

RE: [PATCH 02/12] qla4xxx: have qla4xxx directly call iscsi recovery functions

2008-02-04 Thread David Somayajulu
Mike Christie wrote: > > Qla4xxx can just call the iscsi recovery functions directly. > There is no need for userspace to do this for qla4xxx, because > we do not use the mutex to iterate over devices anymore and > iscsi_block > /unblock_session can be called from interrupt context or the > d

RE: [PATCH 03/12] qla4xxx: have qla4xxx use iscsi class session state check ready

2008-02-04 Thread David Somayajulu
Mike Christie wrote : > This has qla4xxx use the iscsi class's check ready function > in the queue command function, so all iscsi drivers return the > same error value for common problems. > > Signed-off-by: Mike Christie <[EMAIL PROTECTED]> > --- > drivers/scsi/qla4xxx/ql4_os.c | 12 +

RE: [PATCH 05/12] qla4xxx: fix recovery timer and session unblock race

2008-02-04 Thread David Somayajulu
Mike Christie wrote : > If qla4xxx is resetting up a session and the recovery timer > fires we do not want to just set it to dead, because > the dpc thread could have just set it to online and is in the > middle of resetting it up. > > Signed-off-by: Mike Christie <[EMAIL PROTECTED]> > --- > dr

[PATCH 24/24][RFC] scsi: New sense handling

2008-02-04 Thread Boaz Harrosh
Current code allocates a dma-able sense buffer for every scsi command. This is in 99.9% of cases a waste because: - Most commands end successfully and do not need any sense space. - most LLDs have the sense information already in their private data and do not DMA this information.

[PATCH 23/24][RFC] block: Minor changes to sense handling

2008-02-04 Thread Boaz Harrosh
- It is no longer allowed to call blk_execute_rq_nowait() with out a req->senes buffer. This is not a problem because greping all users shows that this does not happen. - Add a sense_max_len which indicate the buffer size at req->sense. If zero then SCSI_SENSE_BUFFERSIZE is assumed

[PATCH 22/24][RFC] scsi upper layer use of sense accessors

2008-02-04 Thread Boaz Harrosh
code that inspects the return sense can use the new scsi_sense() accessor. Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/constants.c |4 ++-- drivers/scsi/sd.c|4 ++-- drivers/scsi/sr.c| 15 +++ 3 files changed, 11 insertions(+), 12 del

  1   2   >