[Bug 9880] dma_free_coherent in arcmsr when calling areca tools

2008-02-03 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=9880 --- Comment #2 from [EMAIL PROTECTED] 2008-02-03 20:36 --- Reply-To: [EMAIL PROTECTED] On Sunday 03 February 2008, James Bottomley wrote: > That's caused by this commit: > > commit aa24886e379d2b641c5117e178b15ce1d5d366ba > Author: Dav

Re: [Bug 9880] dma_free_coherent in arcmsr when calling areca tools

2008-02-03 Thread David Brownell
On Sunday 03 February 2008, James Bottomley wrote: > That's caused by this commit: > > commit aa24886e379d2b641c5117e178b15ce1d5d366ba > Author: David Brownell <[EMAIL PROTECTED]> > Date:   Fri Aug 10 13:10:27 2007 -0700 > >     dma_free_coherent() needs irqs enabled (sigh) >     > I've cc'd the

Re: [PATCH 6/8] kernel-doc: fix scsi docbook

2008-02-03 Thread Randy.Dunlap
On Sun, 3 Feb 2008, James Bottomley wrote: > On Sun, 2008-02-03 at 15:06 -0800, Randy.Dunlap wrote: > > From: Randy Dunlap <[EMAIL PROTECTED]> > > > > Add missing function parameter descriptions. > > Make function short description fit on one line as required. > > > > Signed-off-by: Randy Dunlap

[Bug 9880] dma_free_coherent in arcmsr when calling areca tools

2008-02-03 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=9880 --- Comment #1 from [EMAIL PROTECTED] 2008-02-03 19:55 --- Reply-To: [EMAIL PROTECTED] On Sun, 2008-02-03 at 19:00 -0800, [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9880 > Latest working kernel version: 2.6

Re: [Bug 9880] dma_free_coherent in arcmsr when calling areca tools

2008-02-03 Thread James Bottomley
On Sun, 2008-02-03 at 19:00 -0800, [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9880 > Latest working kernel version: 2.6.23.12 > Earliest failing kernel version: 2.6.24 > Distribution: Gentoo > Hardware Environment: > Intel Core2Quad, 2GB Memory, Areca 1220ML > > Soft

[Bug 9880] dma_free_coherent in arcmsr when calling areca tools

2008-02-03 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=9880 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-03 Thread Tejun Heo
James Bottomley wrote: > On Mon, 2008-02-04 at 00:14 +0900, Tejun Heo wrote: >> James Bottomley wrote: >>> I'm reluctant to add another parameter to the request, but this one you >>> can calculate: you just do it wherever you work out the size of the >>> request. If data_len is the true data leng

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-03 Thread Tejun Heo
James Bottomley wrote: > I'm only really going by what Tejun says about AHCI. The problem as I > understand it is data overrun on PIO mode commands. AHCI apparently > (like aic94xx) processes these internally and doesn't actually use the > libata pio handlers, so it just uses an internal buffer t

Re: [PATCH 6/8] kernel-doc: fix scsi docbook

2008-02-03 Thread James Bottomley
On Sun, 2008-02-03 at 15:06 -0800, Randy.Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > Add missing function parameter descriptions. > Make function short description fit on one line as required. > > Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> > --- > drivers/scsi/scsi.c |5

Re: [PATCH] enclosure: add support for enclosure services

2008-02-03 Thread James Bottomley
On Sun, 2008-02-03 at 23:03 +0100, Sam Ravnborg wrote: > Hi James. > > Nitpicking only. > > Sam Thanks for the review. > > + > > if MISC_DEVICES > > Unrelated change. Yes, removed it. > > +config ENCLOSURE_SERVICES > > + tristate "Enclosure Services" > > + default n > Not needed.

[PATCH 6/8] kernel-doc: fix scsi docbook

2008-02-03 Thread Randy.Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Add missing function parameter descriptions. Make function short description fit on one line as required. Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- drivers/scsi/scsi.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- linux-2.6.2

dmesg spam

2008-02-03 Thread Andrew Morton
With latest -mm, running fc8 I am getting this in the logs, once per second. sr0: CDROM not ready. Make sure there is a disc in the drive. sr0: CDROM not ready. Make sure there is a disc in the drive. sr0: CDROM not ready. Make sure there is a disc in the drive. sr0: CDROM not ready. Make sur

Re: [PATCH] enclosure: add support for enclosure services

2008-02-03 Thread Sam Ravnborg
Hi James. Nitpicking only. Sam > The enclosure misc device is really just a library providing sysfs > support for physical enclosure devices and their components. > > Signed-off-by: James Bottomley <[EMAIL PROTECTED]> > --- > > See the additional ses patch for SCSI enclosure services u

[PATCH] update my email address

2008-02-03 Thread James Bottomley
This updates steeleye -> hansenpartnership in the documentation since some email has been going astray because of this. James --- diff --git a/Documentation/DocBook/scsi.tmpl b/Documentation/DocBook/scsi.tmpl index f299ab1..10a150a 100644 --- a/Documentation/DocBook/scsi.tmpl +++ b/Documentation

[PATCH] ses: add new Enclosure ULD

2008-02-03 Thread James Bottomley
This adds support to SCSI for enclosure services devices. It also makes use of the enclosure services added in an earlier patch to display the enclosure topology in sysfs. At the moment, the enclosures are SAS specific, but if anyone actually has a non-SAS enclosure that follows the SES-2 standard

[PATCH] enclosure: add support for enclosure services

2008-02-03 Thread James Bottomley
The enclosure misc device is really just a library providing sysfs support for physical enclosure devices and their components. Signed-off-by: James Bottomley <[EMAIL PROTECTED]> --- See the additional ses patch for SCSI enclosure services users of this. --- drivers/misc/Kconfig | 10 +

[PATCH] add protocol definitions

2008-02-03 Thread James Bottomley
A lot of SCSI command replies have a protocol ID field. Add definitions for the interpretation of that from SPC-3. Signed-off-by: James Bottomley <[EMAIL PROTECTED]> --- include/scsi/scsi.h | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/include/scsi/scsi.h

Re: [PATCH] bugfix for an underflow condition in usb storage & isd200.c

2008-02-03 Thread Matthew Dharm
One more comment on the patch... On Sun, Feb 03, 2008 at 06:28:48PM +0200, Boaz Harrosh wrote: > + /* Check for overflow */ > + if (buflen > scsi_bufflen(srb)) { This really should have an unlikely() around it. This is an often-executed code path, and we want to optimize it as much as po

Re: [PATCH] bugfix for an underflow condition in usb storage & isd200.c

2008-02-03 Thread Matthew Dharm
On Sun, Feb 03, 2008 at 06:28:48PM +0200, Boaz Harrosh wrote: > >From 3610cfa93c990bbbafb296134ac01ef6d426eb8d Mon Sep 17 00:00:00 2001 > From: Boaz Harrosh <[EMAIL PROTECTED]> > Date: Thu, 31 Jan 2008 21:31:31 +0200 > Subject: [PATCH] bugfix for an overflow condition in usb storage & isd200.c > >

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-03 Thread James Bottomley
On Sun, 2008-02-03 at 11:38 -0500, Jeff Garzik wrote: > James Bottomley wrote: > > The aic94xx sequencer has a very finely honed sense of DMA transfers. > > It's fully automated, and handles both ATA DMA and ATA PIO in the > > sequencer engine (so all the driver sees is DMA). > > ditto AHCI, and

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-03 Thread Jeff Garzik
James Bottomley wrote: The aic94xx sequencer has a very finely honed sense of DMA transfers. It's fully automated, and handles both ATA DMA and ATA PIO in the sequencer engine (so all the driver sees is DMA). ditto AHCI, and most other DMA engines It reports both underrun and overrun conditi

Re: [PATCH] bugfix for an underflow condition in usb storage & isd200.c

2008-02-03 Thread Boaz Harrosh
On Sun, Feb 03 2008 at 18:01 +0200, Alan Stern <[EMAIL PROTECTED]> wrote: > Sorry, I understood only about half of what you wrote -- maybe less! > > On Sun, 3 Feb 2008, Boaz Harrosh wrote: > >> On Thu, Jan 31 2008 at 22:56 +0200, Alan Stern <[EMAIL PROTECTED]> wrote: > >>> I still don't understa

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-03 Thread James Bottomley
On Mon, 2008-02-04 at 00:14 +0900, Tejun Heo wrote: > James Bottomley wrote: > > I'm reluctant to add another parameter to the request, but this one you > > can calculate: you just do it wherever you work out the size of the > > request. If data_len is the true data length and total_data_len is t

Re: [PATCH] bugfix for an underflow condition in usb storage & isd200.c

2008-02-03 Thread Alan Stern
Sorry, I understood only about half of what you wrote -- maybe less! On Sun, 3 Feb 2008, Boaz Harrosh wrote: > On Thu, Jan 31 2008 at 22:56 +0200, Alan Stern <[EMAIL PROTECTED]> wrote: > > I still don't understand. Can you explain exactly what an overflow > > condition (negative residue) reall

Re: [PATCH] [SCSI] sd: make error handling more robust (v2)

2008-02-03 Thread Mike Snitzer
On Feb 2, 2008 5:06 PM, James Bottomley <[EMAIL PROTECTED]> wrote: > > On Fri, 2008-02-01 at 12:03 -0500, Tony Battersby wrote: > > This patch fixes a problem with some out-of-spec SCSI disks that report > > hardware or medium errors incorrectly. Without the patch, the kernel > > may silently igno

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-03 Thread Tejun Heo
James Bottomley wrote: > I'm reluctant to add another parameter to the request, but this one you > can calculate: you just do it wherever you work out the size of the > request. If data_len is the true data length and total_data_len is the > data length plus the drain length, the calculation frag

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-03 Thread James Bottomley
On Sun, 2008-02-03 at 16:37 +0900, Tejun Heo wrote: > James Bottomley wrote: > >> I think the best solution is to update block layer draining such that it > >> can be included together before the merge window closes. I'll dig into it. > > > > Like I said, the block layer pieces are already upstre

Re: [PATCH] bugfix for an underflow condition in usb storage & isd200.c

2008-02-03 Thread Boaz Harrosh
On Thu, Jan 31 2008 at 22:56 +0200, Alan Stern <[EMAIL PROTECTED]> wrote: > On Thu, 31 Jan 2008, Boaz Harrosh wrote: > The code in usb_stor_access_xfer_buf() will now correctly attempt to transfer according to buflen and what ever is available at the passed sg's. Now this can