Re: [PATCH 2.6.24] bugfix for an overflow condition in usb storage & isd200.c

2008-02-01 Thread Mark Glines
On Thu, 31 Jan 2008 21:37:13 +0200 Boaz Harrosh <[EMAIL PROTECTED]> wrote: > > Mark - This is for you on top of vanila v2.6.24 kernel from Linus. Sorry I didn't get back to you sooner. This fixes the issue I was having. > --- > > scsi_scan is issuing a 36-byte INQUIRY request to llds. isd20

Re: [PATCH] [RFC] sd: make error handling more robust

2008-02-01 Thread Luben Tuikov
--- On Fri, 2/1/08, Tony Battersby <[EMAIL PROTECTED]> wrote: > > I disagree only with this part of the commit: > > - good_bytes = (error_sector - > SCpnt->request->sector) << 9; > - if (good_bytes < 0 || good_bytes > >= this_count) > -

Re: [PATCH] [SCSI] sd: make error handling more robust (v2)

2008-02-01 Thread Mike Snitzer
Hi Greg, Given your recent call for review of the next 2.6.22-stable I'd appreciate it if you and the rest of the stable team would strongly consider this SCSI IO error propagation fix for inclusion in 2.6.22.17 (as well as the other stable trees). please advise, thanks. Mike On Feb 1, 2008 3:4

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-01 Thread James Bottomley
On Fri, 2008-02-01 at 15:02 -0500, Jeff Garzik wrote: > James Bottomley wrote: > > Could we please get this in ... I thought I mentioned several times that > > it fixes a fatal oops in both aic94xx and ipr. > > Tejun has a persistent objection... see other email. Actually, see other email .. I

Re: [PATCH] [RFC] sd: make error handling more robust

2008-02-01 Thread Tony Battersby
Luben Tuikov wrote: > --- On Fri, 2/1/08, Tony Battersby <[EMAIL PROTECTED]> wrote: > >> Also, I disagree about treating recovered error like >> hardware/medium >> error. Recovered error is supposed to mean "the last >> command completed >> successfully, with some recovery action performed by t

RE: [PATCH] [SCSI] sd: make error handling more robust (v2)

2008-02-01 Thread Salyzyn, Mark
ACK Signed-off-by: Mark Salyzyn <[EMAIL PROTECTED]> Mike Snitzer tested this also in conjunction with the aacraid driver and it resolved the error propagation problem he experienced with MD on a 2.6.22.16 kernel, recommend that this also be added to any stabilization for these other kernels. B

Re: [PATCH 4/9] scsi_dh: add skeleton for SCSI Device Handlers

2008-02-01 Thread Mike Anderson
Mike Christie <[EMAIL PROTECTED]> wrote: > Chandra Seetharaman wrote: >> * mainly associated with tapes and returned SUCCESS. >> Index: linux-2.6.24-rc8/drivers/scsi/scsi_sysfs.c >> === >> --- linux-2.6.24-rc8.orig/drivers/scsi/s

Re: [PATCH 07/24] arm: scsi convert to accessors and !use_sg cleanup

2008-02-01 Thread Russell King
On Sun, Dec 16, 2007 at 05:28:33PM +0200, Boaz Harrosh wrote: > Russell or any other arm person. Please first see if this compiles at all, as > I do > not have a cross compiler set up, and please check that this code works. > (Should apply on top of Linus latest) This patch seems to work with one

Re: [PATCH] [SCSI] sd: make error handling more robust (v2)

2008-02-01 Thread Luben Tuikov
--- On Fri, 2/1/08, Tony Battersby <[EMAIL PROTECTED]> wrote: > From: Tony Battersby <[EMAIL PROTECTED]> > Subject: [PATCH] [SCSI] sd: make error handling more robust (v2) > To: "linux-scsi@vger.kernel.org" , "James > Bottomley" <[EMAIL PROTECTED]> > Cc: "Luben Tuikov" <[EMAIL PROTECTED]>, "Salyz

Re: [PATCH] [RFC] sd: make error handling more robust

2008-02-01 Thread Luben Tuikov
--- On Fri, 2/1/08, Tony Battersby <[EMAIL PROTECTED]> wrote: > > Also, I disagree about treating recovered error like > hardware/medium > error. Recovered error is supposed to mean "the last > command completed > successfully, with some recovery action performed by the > device > server". Which

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-01 Thread Jeff Garzik
James Bottomley wrote: Could we please get this in ... I thought I mentioned several times that it fixes a fatal oops in both aic94xx and ipr. Tejun has a persistent objection... see other email. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the bo

Re: [PATCH 3/9] scsi_dh: scsi handling of REQ_LB_OP_TRANSITION

2008-02-01 Thread Mike Christie
Chandra Seetharaman wrote: @@ -1445,9 +1479,24 @@ static void scsi_kill_request(struct req static void scsi_softirq_done(struct request *rq) { struct scsi_cmnd *cmd = rq->completion_data; - unsigned long wait_for = (cmd->allowed + 1) * cmd->timeout_per_command; int disposi

Re: [PATCH 4/9] scsi_dh: add skeleton for SCSI Device Handlers

2008-02-01 Thread Mike Christie
Chandra Seetharaman wrote: * mainly associated with tapes and returned SUCCESS. Index: linux-2.6.24-rc8/drivers/scsi/scsi_sysfs.c === --- linux-2.6.24-rc8.orig/drivers/scsi/scsi_sysfs.c +++ linux-2.6.24-rc8/drivers/scsi/scsi

[PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-01 Thread James Bottomley
Could we please get this in ... I thought I mentioned several times that it fixes a fatal oops in both aic94xx and ipr. James --- From: James Bottomley <[EMAIL PROTECTED]> Date: Mon, 31 Dec 2007 15:56:08 -0600 Subject: libata: eliminate the home grown dma padding in favour of that provided by t

[PATCH] [SCSI] sd: make error handling more robust (v2)

2008-02-01 Thread Tony Battersby
This patch fixes a problem with some out-of-spec SCSI disks that report hardware or medium errors incorrectly. Without the patch, the kernel may silently ignore a failed write command or return corrupted data on a failed read command. Signed-off-by: Tony Battersby <[EMAIL PROTECTED]> --- This is

[PATCH] ps3rom: sector size should be 512 bytes

2008-02-01 Thread Geert Uytterhoeven
From: Aegis Lin <[EMAIL PROTECTED]> ps3rom: sector size should be 512 bytes It should be desired that 64 KiB is available for ATAPI transferrring. (Historically) in SCSI/block layer sector size is defined as 512 during sector-byte calculation. Originally in ps3rom.c CD_FRAMESIZE (2048) was used,

Re: [PATCH] [RFC] sd: make error handling more robust

2008-02-01 Thread Tony Battersby
Salyzyn, Mark wrote: > Serendipity, been working an issue for the past week where error reporting > from aacraid's HARDWARE_ERROR when an array was marked DEAD in the Adapter > was not propagating to MD. The trigger for this investigation was "AACRAID > driver broken in 2.6.22.x (and beyond?) [W

Re: [PATCH] [RFC] sd: make error handling more robust

2008-02-01 Thread James Bottomley
On Fri, 2008-02-01 at 10:46 -0500, Tony Battersby wrote: > Luben Tuikov wrote: > > This is due to the fact that the LU/LLDD returned > > sense data with VALID = 1, and so Bad LBA is assumed > > correct. This is as per spec. At this moment given > > the situation you describe it seems that the LU/L

Re: [PATCH] [RFC] sd: make error handling more robust

2008-02-01 Thread Tony Battersby
Luben Tuikov wrote: > This is due to the fact that the LU/LLDD returned > sense data with VALID = 1, and so Bad LBA is assumed > correct. This is as per spec. At this moment given > the situation you describe it seems that the LU/LLDD > is behaving out of spec. > > I agree that my RAID (an exte

Re: Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Nicholas A. Bellinger
On Fri, 2008-02-01 at 14:25 +0100, Bart Van Assche wrote: > On Feb 1, 2008 1:05 PM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: > > > > All of the kernel and C userspace code is open source and available from > > linux-iscsi.org and licensed under the GPL. > > I found a statement on a web pag

RE: [PATCH] [RFC] sd: make error handling more robust

2008-02-01 Thread Salyzyn, Mark
Serendipity, been working an issue for the past week where error reporting from aacraid's HARDWARE_ERROR when an array was marked DEAD in the Adapter was not propagating to MD. The trigger for this investigation was "AACRAID driver broken in 2.6.22.x (and beyond?) [WAS: Re: 2.6.22.16 MD raid1 do

Re: Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Bart Van Assche
On Feb 1, 2008 1:05 PM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: > > All of the kernel and C userspace code is open source and available from > linux-iscsi.org and licensed under the GPL. I found a statement on a web page that the ERL2 implementation is not included in the GPL version (htt

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Vladislav Bolkhovitin
Vladislav Bolkhovitin wrote: Bart Van Assche wrote: On Jan 31, 2008 5:25 PM, Joe Landman <[EMAIL PROTECTED]> wrote: Vladislav Bolkhovitin wrote: Actually, I don't know what kind of conclusions it is possible to make from disktest's results (maybe only how throughput gets bigger or slower

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Vladislav Bolkhovitin
David Dillow wrote: On Thu, 2008-01-31 at 18:08 +0100, Bart Van Assche wrote: If anyone has a suggestion for a better test than dd to compare the performance of SCSI storage protocols, please let it know. xdd on /dev/sda, sdb, etc. using -dio to do direct IO seems to work decently, though it

Re: Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Nicholas A. Bellinger
On Fri, 2008-02-01 at 12:04 +0100, Bart Van Assche wrote: > On Feb 1, 2008 11:39 AM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: > > > > On Fri, 2008-02-01 at 09:11 +0100, Bart Van Assche wrote: > > > On Jan 31, 2008 2:25 PM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: > > > > > > > > The

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Vladislav Bolkhovitin
Bart Van Assche wrote: On Jan 31, 2008 5:25 PM, Joe Landman <[EMAIL PROTECTED]> wrote: Vladislav Bolkhovitin wrote: Actually, I don't know what kind of conclusions it is possible to make from disktest's results (maybe only how throughput gets bigger or slower with increasing number of threads

Re: [PATCH] [RFC] sd: make error handling more robust

2008-02-01 Thread Luben Tuikov
--- On Thu, 1/31/08, Luben Tuikov <[EMAIL PROTECTED]> wrote: > Negate original: > if (driver_byte(result) == DRIVER_SENSE || > (sense_valid && sense_defered)) > Inspect sense. > > Negate your proposed change "&&" -> > "||": > if (driver_byte(result) == DRIVER_SENSE && >

Re: Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Bart Van Assche
On Feb 1, 2008 11:39 AM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: > > On Fri, 2008-02-01 at 09:11 +0100, Bart Van Assche wrote: > > On Jan 31, 2008 2:25 PM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: > > > > > > The PyX storage engine supports a scatterlist linked list algorithm that

Re: Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Nicholas A. Bellinger
On Fri, 2008-02-01 at 09:11 +0100, Bart Van Assche wrote: > On Jan 31, 2008 2:25 PM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: > > > > The PyX storage engine supports a scatterlist linked list algorithm that > > ... > > Which parts of the PyX source code are licensed under the GPL and > whi

Re: Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Bart Van Assche
On Jan 31, 2008 7:15 PM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: > > I meant small referring to storage on IB fabrics which has usually been > in the research and national lab settings, with some other vendors > offering IB as an alternative storage fabric for those who [w,c]ould not > wai

Re: Integration of SCST in the mainstream Linux kernel

2008-02-01 Thread Bart Van Assche
On Jan 31, 2008 2:25 PM, Nicholas A. Bellinger <[EMAIL PROTECTED]> wrote: > > The PyX storage engine supports a scatterlist linked list algorithm that > ... Which parts of the PyX source code are licensed under the GPL and which parts are closed source ? A Google query for PyX + iSCSI showed infor