[PATCH] zfcp: fix sense_buffer access bug

2008-01-26 Thread FUJITA Tomonori
The commit de25deb18016f66dcdede165d07654559bb332bc changed scsi_cmnd.sense_buffer from a static array to a dynamically allocated buffer. We can't access to sense_buffer in '&cmd->sense_buffer' way. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/s390/scsi/zfcp_fsf.c |4 ++-- 1

[PATCH] ncr53c8xx: fix sense_buffer access bug

2008-01-26 Thread FUJITA Tomonori
The commit de25deb18016f66dcdede165d07654559bb332bc changed scsi_cmnd.sense_buffer from a static array to a dynamically allocated buffer. We can't access to sense_buffer in '&cmd->sense_buffer' way. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/ncr53c8xx.c |2 +- 1 files

aic79xx: fix sense_buffer access bug

2008-01-26 Thread FUJITA Tomonori
Ah, I overlooked more LLDs... = From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: [PATCH] aic79xx: fix sense_buffer access bug The commit de25deb18016f66dcdede165d07654559bb332bc changed scsi_cmnd.sense_buffer from a static array to a dynamically allocated buffer. We can't access to sense_buffer

[PATCH] hptiop: fix sense_buffer

2008-01-26 Thread FUJITA Tomonori
Sorry, there was another place that I overlooked in the sense buffer conversion. = From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: [PATCH] hptiop: fix sense_buffer access bug Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/hptiop.c |2 +- 1 files changed, 1 insertions(

Re: [PATCH] sym53c8xx: fix bad memset argument in sym_set_cam_result_error

2008-01-26 Thread Mariusz Kozlowski
Hello, > > > On a big powerpc box I got the following oops with 2.6.24-git2: > > > > > > sym0: <1010-66> rev 0x1 at pci :d0:01.0 irq 215 > > > sym0: No NVRAM, ID 7, Fast-80, LVD, parity checking > > > sym0: SCSI BUS has been reset. > > > scsi0 : sym-2.2.3 > > > target0:0:8: FAST-40 WIDE SCSI

Re: [PATCH] sym53c8xx: fix bad memset argument in sym_set_cam_result_error

2008-01-26 Thread James Bottomley
On Sun, 2008-01-27 at 01:18 +0100, Mariusz Kozlowski wrote: > Hello, > > > On a big powerpc box I got the following oops with 2.6.24-git2: > > > > sym0: <1010-66> rev 0x1 at pci :d0:01.0 irq 215 > > sym0: No NVRAM, ID 7, Fast-80, LVD, parity checking > > sym0: SCSI BUS has been reset. > > scs

Re: [PATCH] sym53c8xx: fix bad memset argument in sym_set_cam_result_error

2008-01-26 Thread Mariusz Kozlowski
Hello, > On a big powerpc box I got the following oops with 2.6.24-git2: > > sym0: <1010-66> rev 0x1 at pci :d0:01.0 irq 215 > sym0: No NVRAM, ID 7, Fast-80, LVD, parity checking > sym0: SCSI BUS has been reset. > scsi0 : sym-2.2.3 > target0:0:8: FAST-40 WIDE SCSI 80.0 MB/s ST (25 ns, offset

Re: [UPDATED PATCH] SGIWD93: use cached memory access to make driver work on IP28

2008-01-26 Thread Thomas Bogendoerfer
On Fri, Jan 25, 2008 at 10:44:40AM -0600, James Bottomley wrote: > > + void *cpu; > > + void *dev; > > This should be struct device *dev; shouldn't it (that seems to be how > it's always used)? of course, no need for the void *. > And that should be dma_free_noncoherent(&pdev->dev, ...) shou

[UPDATED PATCH] SGIWD93: use cached memory access to make driver work on IP28

2008-01-26 Thread Thomas Bogendoerfer
SGI IP28 machines would need special treatment (enable adding addtional wait states) when accessing memory uncached. To avoid this pain I changed the driver to use only cached access to memory. Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> --- Changes to last version: - struct device *

[PATCH] sym53c8xx: fix bad memset argument in sym_set_cam_result_error

2008-01-26 Thread Nathan Lynch
On a big powerpc box I got the following oops with 2.6.24-git2: sym0: <1010-66> rev 0x1 at pci :d0:01.0 irq 215 sym0: No NVRAM, ID 7, Fast-80, LVD, parity checking sym0: SCSI BUS has been reset. scsi0 : sym-2.2.3 target0:0:8: FAST-40 WIDE SCSI 80.0 MB/s ST (25 ns, offset 31) scsi 0:0:8:0: Dir

Re: [PATCH 2.6.24] sym53c8xx_2 modpost section mismatch fix

2008-01-26 Thread Mikael Pettersson
Sam Ravnborg writes: > On Sat, Jan 26, 2008 at 07:03:15PM +0100, Mikael Pettersson wrote: > > Building 2.6.24 with > > > > # CONFIG_HOTPLUG is not set > > CONFIG_SCSI_SYM53C8XX_2=y > > > > results in the following during modpost: > > > > WARNING: vmlinux.o(.text+0x14b36c): Section misma

Re: on patch "[SCSI] relax scsi dma alignment"

2008-01-26 Thread James Bottomley
On Sat, 2008-01-26 at 19:49 +0100, Stefan Richter wrote: > On commit 465ff3185e0cb76d46137335a4d21d0d9d3ac8a2: > > This patch relaxes the default SCSI DMA alignment from 512 bytes to 4 > > bytes. I remember from previous discussions that usb and firewire have > > sector size alignment requirement

on patch "[SCSI] relax scsi dma alignment"

2008-01-26 Thread Stefan Richter
On commit 465ff3185e0cb76d46137335a4d21d0d9d3ac8a2: > This patch relaxes the default SCSI DMA alignment from 512 bytes to 4 > bytes. I remember from previous discussions that usb and firewire have > sector size alignment requirements, so I upped their alignments in the > respective slave allocs. [

Re: [PATCH 2.6.24] sym53c8xx_2 modpost section mismatch fix

2008-01-26 Thread Sam Ravnborg
On Sat, Jan 26, 2008 at 07:03:15PM +0100, Mikael Pettersson wrote: > Building 2.6.24 with > > # CONFIG_HOTPLUG is not set > CONFIG_SCSI_SYM53C8XX_2=y > > results in the following during modpost: > > WARNING: vmlinux.o(.text+0x14b36c): Section mismatch: reference to > .exit.text:sym2_remove (bet

[PATCH 2.6.24] sym53c8xx_2 modpost section mismatch fix

2008-01-26 Thread Mikael Pettersson
Building 2.6.24 with # CONFIG_HOTPLUG is not set CONFIG_SCSI_SYM53C8XX_2=y results in the following during modpost: WARNING: vmlinux.o(.text+0x14b36c): Section mismatch: reference to .exit.text:sym2_remove (between 'sym2_io_error_detected' and 'sym_set_cam_result_error') because sym2_io_error

[PATCH] aic79xx: fix warnings with CONFIG_PM disabled

2008-01-26 Thread FUJITA Tomonori
CC [M] drivers/scsi/aic7xxx/aic79xx_osm_pci.o drivers/scsi/aic7xxx/aic79xx_osm_pci.c:101: warning: 'ahd_linux_pci_dev_suspend' defined but not used drivers/scsi/aic7xxx/aic79xx_osm_pci.c:121: warning: 'ahd_linux_pci_dev_resume' defined but not used This moves aic79xx_pci_driver struct, remove

[PATCH] aic7xxx: fix warnings with CONFIG_PM disabled

2008-01-26 Thread FUJITA Tomonori
CC [M] drivers/scsi/aic7xxx/aic7xxx_osm_pci.o drivers/scsi/aic7xxx/aic7xxx_osm_pci.c:148: warning: 'ahc_linux_pci_dev_suspend' defined but not used drivers/scsi/aic7xxx/aic7xxx_osm_pci.c:166: warning: 'ahc_linux_pci_dev_resume' defined but not used This moves aic7xxx_pci_driver struct, remove