Re: [PATCH] use the cmd_type of a leading request for scsi_init_sgtable

2008-01-25 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Fri, 25 Jan 2008 20:05 -0600: > On Sat, 2008-01-26 at 09:57 +0900, FUJITA Tomonori wrote: > > This is against the scsi-bidi tree. > > > > We need to use the cmd_type of a leading request for scsi_init_sgtable > > to set up scsi_data_buffer:length of a bidi request proper

Re: [PATCH] use the cmd_type of a leading request for scsi_init_sgtable

2008-01-25 Thread FUJITA Tomonori
On Sat, 26 Jan 2008 11:22:47 +0900 FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > On Fri, 25 Jan 2008 20:05:55 -0600 > James Bottomley <[EMAIL PROTECTED]> wrote: > > > On Sat, 2008-01-26 at 09:57 +0900, FUJITA Tomonori wrote: > > > This is against the scsi-bidi tree. > > > > > > We need to use the

Re: [PATCH] use the cmd_type of a leading request for scsi_init_sgtable

2008-01-25 Thread FUJITA Tomonori
On Fri, 25 Jan 2008 20:05:55 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > On Sat, 2008-01-26 at 09:57 +0900, FUJITA Tomonori wrote: > > This is against the scsi-bidi tree. > > > > We need to use the cmd_type of a leading request for scsi_init_sgtable > > to set up scsi_data_buffer:length of

Re: [PATCH] use the cmd_type of a leading request for scsi_init_sgtable

2008-01-25 Thread James Bottomley
On Sat, 2008-01-26 at 09:57 +0900, FUJITA Tomonori wrote: > This is against the scsi-bidi tree. > > We need to use the cmd_type of a leading request for scsi_init_sgtable > to set up scsi_data_buffer:length of a bidi request properly. > > An alternative approach is setting the cmd_type of a leadi

[PATCH] use the cmd_type of a leading request for scsi_init_sgtable

2008-01-25 Thread FUJITA Tomonori
This is against the scsi-bidi tree. We need to use the cmd_type of a leading request for scsi_init_sgtable to set up scsi_data_buffer:length of a bidi request properly. An alternative approach is setting the cmd_type of a leading request and its bidi request (*1). But the block layer and scsi-ml

[GIT PATCH] SCSI updates for 2.6.24 (part 1)

2008-01-25 Thread James Bottomley
We have a difficult merge this time; the SCSI tree is split between components that can go now and pieces that are waiting on other trees. Part 1 is the components that can go now ... you'll be getting part 2 towards the end of the merge window. There's misc driver updates, the accessor conversion

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-01-25 Thread Jeff Garzik
James Bottomley wrote: The lack of interrupt enable looks potentially fatal... See my comments on this specific issue, in this thread, for the reason why that function isn't used... Jeff - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a messa

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-01-25 Thread James Bottomley
On Sat, 2008-01-26 at 00:43 +0800, Ke Wei wrote: > The attached is Marvell 6440 SAS/SATA driver. I will try to send email > by git-send-email. > > Changelog : > Merged from Jeff's branch to James's branch. > > Signed-off-by: Ke Wei <[EMAIL PROTECTED]> A compile test of this seems to show some pr

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-01-25 Thread James Bottomley
On Sat, 2008-01-26 at 00:43 +0800, Ke Wei wrote: > struct mvs_phy { > struct mvs_port *port; > struct asd_sas_phy sas_phy; > + struct sas_identify identify; > + __le32 dev_info; > + __le64 dev_sas_addr; > + __le32 att

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-01-25 Thread Jeff Garzik
Grant Grundler wrote: On Jan 25, 2008 8:43 AM, Ke Wei <[EMAIL PROTECTED]> wrote: The attached is Marvell 6440 SAS/SATA driver. I will try to send email by git-send-email. I know this isn't part of this patch: #define mr32(reg) readl(regs + MVS_##reg) #define mw32(reg,val) writel((val),

Re: sd incorrectly reports write cache disabled on cache-capable drives/controllers

2008-01-25 Thread Halim Issa
On Friday 25 January 2008 22:33:21 James Bottomley wrote: > Just because the inquiry strings say it doesn't have a cache doesn't > really mean it's not using one but not telling anyone. Thank you for explaining this to me. I have been stuck on this for close to six months, and you solved it in le

Re: sd incorrectly reports write cache disabled on cache-capable drives/controllers

2008-01-25 Thread James Bottomley
On Fri, 2008-01-25 at 22:28 +0100, Halim Issa wrote: > Thank you so much for the quick reply - I risk asking one follow-up question. > > On Friday 25 January 2008 22:15:20 James Bottomley wrote: > > The "cache" hear would be referring to the RAID controller cache, not > > the disk cache. Likewis

Re: sd incorrectly reports write cache disabled on cache-capable drives/controllers

2008-01-25 Thread Halim Issa
Thank you so much for the quick reply - I risk asking one follow-up question. On Friday 25 January 2008 22:15:20 James Bottomley wrote: > The "cache" hear would be referring to the RAID controller cache, not > the disk cache. Likewise DPO and FUA refer to what the RAID controller > can support, n

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-01-25 Thread James Bottomley
On Wed, 2008-01-23 at 18:54 +0800, Ke Wei wrote: > Attachment is a patch file for 6440 driver. I will have to spend more > time on setting my mail client. Yesterday I used mutt tool. But Look > like the problem still exists. By default, unfortunately, I think no email tool nowadays inserts plain

Re: sd incorrectly reports write cache disabled on cache-capable drives/controllers

2008-01-25 Thread James Bottomley
On Fri, 2008-01-25 at 21:59 +0100, Halim Issa wrote: > This is my first post to any of the vger lists. I have tried to comply with > the list recommendations and be specific while to the point. If anything is > missing, kindly let me know. > > I am having trouble getting the scsi-subsystem on an

[PATCH] [SCSI] make SPI DV data pattern "d" match T10

2008-01-25 Thread Tony Battersby
The T10 SCSI domain validation draft sdv-r08b.pdf section 5.4 describes data pattern "d" like this: d) shifting bit (h, FFFEh, h, FFFDh, ... then h, 0001h, h, 0002h, ...) The current code in scsi_transport_spi.c produces the following data pattern: FF FF 00 00 | FE FF 01 00 | FC

Re: INITIO scsi driver fails to work properly

2008-01-25 Thread Filippos Papadopoulos
On 1/25/08, James Bottomley <[EMAIL PROTECTED]> wrote: > > Actually, I suspect your issues should be fixed by this patch: > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e2d435ea4084022ab88efa74214accb45b1f9e92 > > Could you download 2.6.24 and try it out to see if t

sd incorrectly reports write cache disabled on cache-capable drives/controllers

2008-01-25 Thread Halim Issa
This is my first post to any of the vger lists. I have tried to comply with the list recommendations and be specific while to the point. If anything is missing, kindly let me know. I am having trouble getting the scsi-subsystem on an IBM x336 eServer with LSI Logic53c1030 SCSI RAID controller t

Re: PATCH: usb-storage-set-last-sector-bug-flag.patch

2008-01-25 Thread Matthew Dharm
ACKed-by: Matthew Dharm <[EMAIL PROTECTED]> Matt On Fri, Jan 25, 2008 at 11:12:21AM -0600, James Bottomley wrote: > On Thu, 2008-01-24 at 09:21 -0800, Greg KH wrote: > > On Thu, Jan 24, 2008 at 06:07:00PM +0100, Stefan Richter wrote: > > > Greg KH wrote: > > > > I just am worried that we are > >

[RFC] aic7xxx - ahc_done check SCB_ACTIVE for tagged transactions

2008-01-25 Thread David Milburn
Hannes, Does ahc_done need to check the SCB_ACTIVE flag only if the SCB is not in the untagged queue before panic? If the driver is in error recovery, you may end panic'ing on a TUR that is in the untagged queue. Attempting to queue an ABORT message CDB: 0x0 0x0 0x0 0x0 0x0 0x0 SCB 3 done'd twic

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-01-25 Thread James Bottomley
On Fri, 2008-01-25 at 09:24 -0800, Grant Grundler wrote: > On Jan 25, 2008 8:43 AM, Ke Wei <[EMAIL PROTECTED]> wrote: > > The attached is Marvell 6440 SAS/SATA driver. I will try to send email > > by git-send-email. > > I know this isn't part of this patch: > #define mr32(reg)readl(regs + MV

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-01-25 Thread Grant Grundler
On Jan 25, 2008 8:43 AM, Ke Wei <[EMAIL PROTECTED]> wrote: > The attached is Marvell 6440 SAS/SATA driver. I will try to send email > by git-send-email. > Sorry, just saw some more issues in +static void mvs_hba_interrupt_enable(struct mvs_info *mvi, int enable) Three comments here: 1) This routi

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-01-25 Thread Grant Grundler
On Jan 25, 2008 8:43 AM, Ke Wei <[EMAIL PROTECTED]> wrote: > The attached is Marvell 6440 SAS/SATA driver. I will try to send email > by git-send-email. I know this isn't part of this patch: #define mr32(reg) readl(regs + MVS_##reg) #define mw32(reg,val) writel((val), regs + MVS_##reg) Bu

Re: PATCH: usb-storage-set-last-sector-bug-flag.patch

2008-01-25 Thread James Bottomley
On Thu, 2008-01-24 at 09:21 -0800, Greg KH wrote: > On Thu, Jan 24, 2008 at 06:07:00PM +0100, Stefan Richter wrote: > > Greg KH wrote: > > > I just am worried that we are > > > now suddenly keeping access from the last sector for devices that > > > currently did work just fine. > > > > This new wo

Re: INITIO scsi driver fails to work properly

2008-01-25 Thread James Bottomley
On Tue, 2008-01-22 at 19:50 +0200, Filippos Papadopoulos wrote: > I get the following: > SAH > SSH > SCB Q > SCB EXEC > SCB EXEC DONE Actually, I suspect your issues should be fixed by this patch: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e2d435ea4084022ab88efa7

Re: [UPDATED PATCH] SGIWD93: use cached memory access to make driver work on IP28

2008-01-25 Thread James Bottomley
On Fri, 2008-01-25 at 17:32 +0100, Thomas Bogendoerfer wrote: > SGI IP28 machines would need special treatment (enable adding addtional > wait states) when accessing memory uncached. To avoid this pain I > changed the driver to use only cached access to memory. > > Signed-off-by: Thomas Bogendoerf

[UPDATED PATCH] SGIWD93: use cached memory access to make driver work on IP28

2008-01-25 Thread Thomas Bogendoerfer
SGI IP28 machines would need special treatment (enable adding addtional wait states) when accessing memory uncached. To avoid this pain I changed the driver to use only cached access to memory. Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> --- Changes to last version: - added Kconfig ch

Scsi error : device overrun on Adaptec AIC-7902B

2008-01-25 Thread alci
Hi, I am experiencing odd error messages on a server and can't sort out if it is a software or hardware problem. Server is running linux 2.6.22 kernel from Ubuntu server distro (2.6.22-14-server) on a bi-AMD64 Opteron machine. The SCSI board is listed as follows by lspci : 0a:07.0 SCSI storage c

[PATCH 1/2] destroy scsi_bidi_sdb_cache in scsi_exit_queue

2008-01-25 Thread FUJITA Tomonori
This patchset is against the scsi-bidi tree. = From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: [PATCH 1/2] destroy scsi_bidi_sdb_cache in scsi_exit_queue Needs to call kmem_cache_destroy for scsi_bidi_sdb_cache in scsi_exit_queue. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- driver

[PATCH 2/2] handle scsi_init_queue failure properly

2008-01-25 Thread FUJITA Tomonori
scsi_init_queue is expected to clean up allocated things when it fails. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/scsi_lib.c | 18 +- 1 files changed, 17 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index