Re: [PATCH 2/2] relax scsi dma alignment

2007-12-31 Thread Alan Stern
On Mon, 31 Dec 2007, James Bottomley wrote: > This patch relaxes the default SCSI DMA alignment from 512 bytes to 4 > bytes. I remember from previous discussions that usb and firewire have > sector size alignment requirements, so I upped their alignments in the > respective slave allocs. > > The

Re: [PATCH] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2007-12-31 Thread Jeff Garzik
James Bottomley wrote: ATA requires that all DMA transfers begin and end on word boundaries. Because of this, a large amount of machinery grew up in ide to adjust scatterlists on this basis. However, as of 2.5, the block layer has a dma_alignment variable which ensures both the beginning and len

[PATCH 2/2] relax scsi dma alignment

2007-12-31 Thread James Bottomley
This patch relaxes the default SCSI DMA alignment from 512 bytes to 4 bytes. I remember from previous discussions that usb and firewire have sector size alignment requirements, so I upped their alignments in the respective slave allocs. The reason for doing this is so that we don't get such a hug

[PATCH 1/2] block: Introduce new blk_queue_update_dma_alignment interface

2007-12-31 Thread James Bottomley
The purpose of this is to allow stacked alignment settings, with the ultimate queue alignment being set to the largest alignment requirement in the stack. The reason for this is so that the SCSI mid-layer can relax the default alignment requirements (which are basically causing a lot of superfluou

[PATCH] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2007-12-31 Thread James Bottomley
ATA requires that all DMA transfers begin and end on word boundaries. Because of this, a large amount of machinery grew up in ide to adjust scatterlists on this basis. However, as of 2.5, the block layer has a dma_alignment variable which ensures both the beginning and length of a DMA transfer are

Re: [PATCH] libsas: don't use made up error codes

2007-12-31 Thread James Bottomley
On Mon, 2007-12-31 at 13:25 -0800, Darrick J. Wong wrote: > On Sun, Dec 30, 2007 at 12:37:31PM -0600, James Bottomley wrote: > > This is bad for two reasons: > > > > 1. If they're returned to outside applications, no-one knows what > > they mean. > > 2. Eventually they'll clash

Re: [PATCH] libsas: don't use made up error codes

2007-12-31 Thread Darrick J. Wong
On Sun, Dec 30, 2007 at 12:37:31PM -0600, James Bottomley wrote: > This is bad for two reasons: > > 1. If they're returned to outside applications, no-one knows what > they mean. > 2. Eventually they'll clash with the ever expanding standard error > codes. > > The proble

[PATCH] [FCoE] Don't create a duplicate port on reset

2007-12-31 Thread Rob Love
P2P mode was failing due to a duplicate remote port being created when a reset occured. Signed-off-by: Rob Love <[EMAIL PROTECTED]> --- drivers/scsi/ofc/libfc/fc_local_port.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/ofc/libfc/fc_local_port.c b/dr

Re: Bad escriptions in Kconfig

2007-12-31 Thread Bodo Eggert
On Mon, 31 Dec 2007, Douglas Gilbert wrote: > Matthew Wilcox wrote: > > On Mon, Dec 31, 2007 at 10:16:43AM -0500, Douglas Gilbert wrote: > >> Bodo Eggert wrote: (Kicking netdev from CC) > >>> --- > >>> SCSI target support (SCSI_TGT) [N/m/y/?] (NEW) ? > >>> > >>> If you want to use SCSI target mod

[PATCH] [FCoE] Don't panic if session is null in fc_sess_seq_alloc(), just return null.

2007-12-31 Thread Rob Love
Signed-off-by: Rob Love <[EMAIL PROTECTED]> --- drivers/scsi/ofc/libfc/fc_sess.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/ofc/libfc/fc_sess.c b/drivers/scsi/ofc/libfc/fc_sess.c index 34cc2b0..8ac6811 100644 --- a/drivers/scsi/ofc/libfc/fc_sess.c +++ b

Re: SCSI errors on powerpc with 2.6.24-rc6-mm1

2007-12-31 Thread FUJITA Tomonori
On Mon, 31 Dec 2007 17:57:35 +0530 Balbir Singh <[EMAIL PROTECTED]> wrote: > FUJITA Tomonori wrote: > > > > Oops, it's for -mm. > > > > Hi, > > I just tested this patch and it works fine for me so far. > > Tested-by: Balbir Singh <[EMAIL PROTECTED]> Thanks! I sent an updated patch including

Re: Bad escriptions in Kconfig

2007-12-31 Thread Douglas Gilbert
Matthew Wilcox wrote: > On Mon, Dec 31, 2007 at 10:16:43AM -0500, Douglas Gilbert wrote: >> Bodo Eggert wrote: >>> --- >>> SCSI target support (SCSI_TGT) [N/m/y/?] (NEW) ? >>> >>> If you want to use SCSI target mode drivers enable this option. >>> If you choose M, the module will be called scsi_tgt

RE: Open-FCoE on linux-scsi

2007-12-31 Thread Love, Robert W
>> Hello SCSI mailing list, >> >> I'd just like to introduce ourselves a bit before we get >> started. My name is Robert Love and I'm joined by a team of engineers >> including Vasu Dev, Chris Leech and Yi Zou. We are committed to >> maintaining the Open-FCoE project. Aside from Intel engineer

Re: Bad escriptions in Kconfig

2007-12-31 Thread Matthew Wilcox
On Mon, Dec 31, 2007 at 10:16:43AM -0500, Douglas Gilbert wrote: > Bodo Eggert wrote: > > --- > > SCSI target support (SCSI_TGT) [N/m/y/?] (NEW) ? > > > > If you want to use SCSI target mode drivers enable this option. > > If you choose M, the module will be called scsi_tgt. > > --- > > > > What

Re: Bad escriptions in Kconfig

2007-12-31 Thread Douglas Gilbert
Bodo Eggert wrote: > In some of the Kconfig files, the options are not adequately decribed. I > collected a few of the bad descriptions I found: > > > --- > Lowlevel video output switch controls (VIDEO_OUTPUT_CONTROL) [M/n/y/?] (NEW) ? > > This framework adds support for low-level control of th

Re: SCSI errors on powerpc with 2.6.24-rc6-mm1

2007-12-31 Thread Balbir Singh
FUJITA Tomonori wrote: > > Oops, it's for -mm. > Hi, I just tested this patch and it works fine for me so far. Tested-by: Balbir Singh <[EMAIL PROTECTED]> -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the

Bad escriptions in Kconfig

2007-12-31 Thread Bodo Eggert
In some of the Kconfig files, the options are not adequately decribed. I collected a few of the bad descriptions I found: --- Lowlevel video output switch controls (VIDEO_OUTPUT_CONTROL) [M/n/y/?] (NEW) ? This framework adds support for low-level control of the video output switch. --- - What