[PATCH 7/7] sg_ring: convert core ATA code to sg_ring.

2007-12-18 Thread Rusty Russell
ATA relies so heavily on scsi that it needs to be converted at the same time. ATA adds padding to scatterlists in scsi commands, but because there was no good way of appending to those scatterlists, it had to use boutique iterators to make sure the padding is included. With sg_ring, ATA can simpl

[PATCH 6/7] sg_ring: libata simplification

2007-12-18 Thread Rusty Russell
[This patch has been obsoleted: Tejun has a more complete one, but it's not in mainline yet, so this serves to make the next patch apply]. libata separates the single buffer case from the scatterlist case internally. It's not clear that this is necessary. Remove the ATA_QCFLAG_SINGLE flag, and b

[PATCH 5/7] sg_ring: Convert core scsi code to sg_ring.

2007-12-18 Thread Rusty Russell
If nothing else, the simplification of this logic shows why I prefer sg_ring over scatterlist chaining. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff --git a/drivers/block/cciss_scsi.c b/drivers/block/cciss_scsi.c --- a/drivers/block/cciss_scsi.c +++ b/drivers/block/cciss_scsi.c @@ -1191,

[PATCH 4/7] sg_ring: dma_map_sg_ring() helper

2007-12-18 Thread Rusty Russell
Obvious counterpart to dma_map_sg. Note that this is arch-independent code; sg_rings are backwards compatible with simple sg arrays. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> --- drivers/base/dma-mapping.c | 13 + include/linux/dma-mapping.h |4 2 files changed, 17

[PATCH 3/7] sg_ring: blk_rq_map_sg_ring as a counterpart to blk_rq_map_sg.

2007-12-18 Thread Rusty Russell
blk_rq_map_sg_ring as a counterpart to blk_rq_map_sg. Obvious counterpart to blk_rq_map_sg. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> --- block/ll_rw_blk.c | 55 include/linux/blkdev.h |1 + 2 files changed, 56 insertions(+), 0 d

[PATCH 2/7] sg_ring: use in virtio.

2007-12-18 Thread Rusty Russell
Using sg_rings, we can join together scatterlists returned by other subsystems, without needing to allocate an extra element for chaining. This helps the virtio_blk device which wants to prepend and append metadata to the request's scatterlist. As an added bonus, the old virtio layer used to pass

[PATCH 1/7] sg_ring: introduce sg_ring: a ring of scatterlist arrays.

2007-12-18 Thread Rusty Russell
This patch introduces 'struct sg_ring', a layer on top of scatterlist arrays. It meshes nicely with routines which expect a simple array of 'struct scatterlist' because it is easy to break down the ring into its constituent arrays. The sg_ring header also encodes the maximum number of entries, us

[PATCH 0/7] sg_ring: a ring of scatterlist arrays

2007-12-18 Thread Rusty Russell
This patch series is the start of my attempt to simplify and make explicit the chained scatterlist logic. It's not complete: my SATA box boots and seems happy, but all the other users of SCSI need to be updated and checked. But I've gotten far enough to believe it's worth persuing. Cheers, Rusty

[PATCH 1/2] scsi error: add target reset eh handler

2007-12-18 Thread michaelc
From: Mike Christie <[EMAIL PROTECTED]> Drivers like qla4xxx and bnx2i (and it looks like some fcp drivers too), want to be able to send a lun reset in the eh device handler and then a target reset in some other handler. The old linux-iscsi driver, which did the host per session like open-iscsi di

[PATCH 2/2] qla4xxx: Add target reset functionality

2007-12-18 Thread michaelc
From: Mike Christie <[EMAIL PROTECTED]> This patch adds target reset functionalty. Signed-off-by: Mike Christie <[EMAIL PROTECTED]> --- drivers/scsi/qla4xxx/ql4_fw.h |1 + drivers/scsi/qla4xxx/ql4_glbl.h |2 + drivers/scsi/qla4xxx/ql4_mbx.c | 39 drivers/scsi/ql

RFC: add target reset handler to scsi_error.c

2007-12-18 Thread michaelc
These patches add a target reset handler to scsi_error.c's error handler. It is needed because drivers like qla4xxx either have to do a target reset in the eh_device_reset_handler then do some tricks so that when that handler is called again we do not send extra resets, or the driver has to do its

Re: 2.6.24-rc5: tape drive not responding

2007-12-18 Thread Kai Makisara
On Mon, 17 Dec 2007, James Bottomley wrote: > > On Mon, 2007-12-17 at 13:43 -0800, Andrew Morton wrote: > > On Mon, 17 Dec 2007 16:02:02 -0500 > > "John Stoffel" <[EMAIL PROTECTED]> wrote: > > > > > > > > Just to confirm, the propsed patch to st.c fixes the issue with > > > 2.6.24-rc5 as well a

Re: [PATCH] MAINTAINERS: remove Adam Fritzler, update his email address in other sources

2007-12-18 Thread Joe Perches
On Tue, 2007-12-18 at 06:43 -0700, Matthew Wilcox wrote: > On Mon, Dec 17, 2007 at 08:48:03PM -0800, Joe Perches wrote: > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 9507b42..690f172 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -3758,13 +3758,6 @@ W: > > http://www.kernel.org

Re: [PATCH] MAINTAINERS: remove Adam Fritzler, update his email address in other sources

2007-12-18 Thread Arjan van de Ven
On Mon, 17 Dec 2007 20:28:00 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > > > btw, I cheerfully skipped all your spelling-fixes patches. Some will > have stuck via subsystem maintainers but I have a secret "no spelling > fixes unless they're end-user-visible" policy. That means I'll take >

RE: [PATCH] drivers/scsi/: Spelling fixes

2007-12-18 Thread Salyzyn, Mark
ACK ips line change. Sincerely -- Mark Salyzyn > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Joe Perches > Sent: Monday, December 17, 2007 2:40 PM > To: [EMAIL PROTECTED] > Cc: Andrew Morton; AACRAID; Andrew Vasquez; Brian King; > IpsLinux; Hann

[PATCH 3/3] scsi: varlen extended and vendor-specific cdbs

2007-12-18 Thread Boaz Harrosh
Add support for variable-length, extended, and vendor specific CDBs to scsi-ml. It is now possible for initiators and ULD's to issue these types of commands. LLDs need not change much. All they need is to raise the .max_cmd_len to the longest command they support (see iscsi patches).

Re: [PATCH] MAINTAINERS: remove Adam Fritzler, update his email address in other sources

2007-12-18 Thread Matthew Wilcox
On Mon, Dec 17, 2007 at 08:48:03PM -0800, Joe Perches wrote: > diff --git a/MAINTAINERS b/MAINTAINERS > index 9507b42..690f172 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3758,13 +3758,6 @@ W: > http://www.kernel.org/pub/linux/kernel/people/bunk/trivial/ > T: git kernel.org:/pub/sc

[PATCH 2/2] block layer varlen-cdb

2007-12-18 Thread Boaz Harrosh
- add varlen_cdb and varlen_cdb_len to hold a large user cdb if needed. They start as empty. Allocation of buffer must be done by user and held until request execution is done. - Since there can be either a fix_length command up to 16 bytes or a variable_length, larger then 16 byte

[PATCH 1/3] Let scsi_cmnd->cmnd use request->cmd buffer

2007-12-18 Thread Boaz Harrosh
- struct scsi_cmnd had a 16 bytes command buffer of its own. This is an unnecessary duplication and copy of request's cmd. It is probably leftovers from the time that scsi_cmnd could function without a request attached. So clean that up. - Once above is done, few places, apart fro

[PATCHSET 0/3] varlen extended and vendor-specific cdbs

2007-12-18 Thread Boaz Harrosh
Submitted is a patchset for adding support for variable-length, extended, and vendor specific CDBs. It should now cover the entire range of the SCSI standard. They are based on scsi-misc + the submitted bidi patches. Difference from last time, is at struct request. I did a smallish hack to save

Re: In which case EWOULDBLOCK is set while a write operation

2007-12-18 Thread Mulyadi Santosa
Hi.. > In which case EWOULDBLOCK / EAGAIN is set while a write operation ? i think it will happen if you use O_NONBLOCK but writing operation itself will clearly block (for numerous reasons e.g block needs to be allocated first and so on). > Can any one give detailed processing of a write operat

[PATCH] MAINTAINERS: zfcp

2007-12-18 Thread Swen Schillig
James we are planning a major rewrite of the zfcp driver, meaning that a lot of patches will hit the mailing-list in the near future. Since I can't support this additional work-load along with my other responsibilities we are shifting the maintainership to Christof Schmitt as the maintainer and

[PATCH] blktrace: Add blktrace ioctls to SCSI generic devices

2007-12-18 Thread Christof Schmitt
Since the SCSI layer uses the request queues from the block layer, blktrace can also be used to trace the requests to all SCSI devices (like SCSI tape drives), not only disks. The only missing part is the ioctl interface to start and stop tracing. This patch adds the SETUP, START, STOP and TEARDOW

Re: [rfc][patch 1/3] block: non-atomic queue_flags prep

2007-12-18 Thread Nick Piggin
On Tue, Dec 18, 2007 at 08:44:40AM +0100, Jens Axboe wrote: > On Sat, Dec 15 2007, Nick Piggin wrote: > > Hi, > > > > This is just an idea I had, which might make request processing a little > > bit cheaper depending on queue behaviour. For example if it is getting > > plugged > > unplugged frequ