Re: [patch 03/23] SCSI: early detection of medium not present, updated

2007-11-21 Thread Tejun Heo
[EMAIL PROTECTED] wrote: > From: Alan Stern <[EMAIL PROTECTED]> > > Taken from http://bugzilla.kernel.org/show_bug.cgi?id=8904 > > An updated (by Albert, I assume) version of the fourteen-month-old patch here: > > http://marc.info/?l=linux-kernel&m=115412002912837&w=2 > > Apparently fixes the b

[PATCH -mm 0/4] fix iommu segment boundary problems

2007-11-21 Thread FUJITA Tomonori
This is the latter half of my iommu work to make the IOMMUs respect LLDs restrictions. IOMMUs allocate memory areas without considering a low level driver's segment boundary limits. So we have some workarounds: splitting sg segments again in LLDs; reserving all I/O space spanning 4GB boundary in I

[PATCH -mm 3/4] swiotlb: respect the segment boundary limits

2007-11-21 Thread FUJITA Tomonori
This patch makes swiotlb not allocate a memory area spanning LLD's segment boundary. is_span_boundary() judges whether a memory area spans LLD's segment boundary. If map_single finds such a area, map_single tries to find the next available memory area. Signed-off-by: FUJITA Tomonori <[EMAIL PROTE

[PATCH -mm 1/4] add accessors for segment_boundary_mask in device_dma_parameters

2007-11-21 Thread FUJITA Tomonori
This adds new accessors for segment_boundary_mask in device_dma_parameters structure in the same way I did for max_segment_size. So we can easily change where to place struct device_dma_parameters in the future. dma_get_segment boundary returns 0x if dma_parms in struct device isn't set up

[PATCH -mm 4/4] call dma_set_seg_boundary in __scsi_alloc_queue

2007-11-21 Thread FUJITA Tomonori
This is a one-line patch to add the following to __scsi_alloc_queue(): dma_set_seg_boundary(dev, shost->dma_boundary); This is the simplest approach but the result looks odd, __scsi_alloc_queue() does: blk_queue_segment_boundary(q, shost->dma_boundary); dma_set_seg_boundary(dev, shost->dma_bound

[PATCH -mm 2/4] PCI: add dma segment boundary support

2007-11-21 Thread FUJITA Tomonori
This adds PCI's accessor for segment_boundary_mask in device_dma_parameters. The default segment_boundary is set to 0x, same to the block layer's default value (and the scsi mid layer uses the same value). Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/pci/pci.c |8

[patch] advansys: fix timestamp for 64 bit

2007-11-21 Thread Ken Witherow
Timestamp assertion compares int and unsigned long. Fails on 64 bit machines where unsigned long is 8 bytes instead of 4. Promote int (from scsi_cmnd.this_residual) to unsigned long (jiffies) so it is a proper comparison on both 32 bit and 64 bit architectures. Tested on AMD64 Signed-off-by:

[patch 17/23] advansys: fix section mismatch warning

2007-11-21 Thread akpm
From: Randy Dunlap <[EMAIL PROTECTED]> Fix section mismatch warning: WARNING: vmlinux.o(.exit.text+0x152a): Section mismatch: reference to .init.data:_asc_def_iop_base (between 'advansys_isa_remove' and 'advansys_exit') Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> Cc: Matthew Wilcox <[EMAIL

[patch 04/23] mptbase: reset ioc initiator during PCI resume

2007-11-21 Thread akpm
From: "Darrick J. Wong" <[EMAIL PROTECTED]> It appears that the LSI SAS 1064E chip needs to be reset after a suspend/resume cycle before the driver attempts further communications with the chip. Without this patch, resuming the chip results in this error message being printed repeatedly and no mo

[patch 20/23] aacraid driver fails with Dell PowerEdge Expandable RAID Controller 3/Di

2007-11-21 Thread akpm
From: "Salyzyn, Mark" <[EMAIL PROTECTED]> As reported in http://bugzilla.kernel.org/show_bug.cgi?id=3D9133 it was discovered that the PERC line of controllers lacked a key 64 bit ScatterGather capable SCSI pass-through function. The adapters are still capable of 64 bit ScatterGather I/O commands,

[patch 19/23] sym2: fix section mismatch warning

2007-11-21 Thread akpm
From: Randy Dunlap <[EMAIL PROTECTED]> Fix section mismatch warning: WARNING: vmlinux.o(.text+0x1ff3a2): Section mismatch: reference to .exit.text:sym2_remove (between 'sym2_io_error_detected' and 'sym_xpt_done') Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTEC

[patch 13/23] SCSI/gdth: kill unneeded 'irq' argument

2007-11-21 Thread akpm
From: Jeff Garzik <[EMAIL PROTECTED]> Neither gdth_get_status() nor __gdth_interrupt() need their 'irq' argument, so remove it. [EMAIL PROTECTED]: coding style fixes] Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Acked-by: Boaz Harrosh <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]>

[patch 11/23] ips: handle scsi_add_host() failure, and other err cleanups

2007-11-21 Thread akpm
From: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Acked-by: "Salyzyn, Mark" <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/ips.c | 18 +- 1 file changed, 13 inserti

[patch 14/23] SCSI/sym53c416: kill pointless irq handler loop and test

2007-11-21 Thread akpm
From: Jeff Garzik <[EMAIL PROTECTED]> - kill pointless irq handler loop to find base address, it is already passed to irq handler via Scsi_Host. - kill now-pointless !base test. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Cc: Matthew Wilcox <[EMAIL PR

[patch 16/23] SCSI/NCR5380: minor irq handler cleanups

2007-11-21 Thread akpm
From: Jeff Garzik <[EMAIL PROTECTED]> * remove unnecessary cast * remove unnecessary use of 'irq' function arg Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/NCR5380.c |7 --- 1 fi

[patch 15/23] SCSI: fix bugs and canonicalize NCR5380_intr drivers

2007-11-21 Thread akpm
From: Jeff Garzik <[EMAIL PROTECTED]> * Bug fix: Make sure request_irq() and free_irq() are called with the same dev_id pointer argument. * Bug fix: always pass 'irq' and 'dev_id' (aka 'dummy') arguments to NCE5380_intr() when calling it manully. For some drivers this doesn't matter, dep

[patch 22/23] scsi/qla2xxx/: possible cleanups

2007-11-21 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> - make the following needlessly global code static: - qla_attr.c: qla24xx_vport_delete() - qla_attr.c: qla24xx_vport_disable() - qla_mid.c: qla24xx_allocate_vp_id() - qla_mid.c: qla24xx_find_vhost_by_name() - qla_mid.c: qla2x00_do_dpc_vp() - qla_os

[patch 12/23] MegaRAID driver management char device moved to misc

2007-11-21 Thread akpm
From: Thomas Horsten <[EMAIL PROTECTED]> The MegaRAID driver's common management module (megaraid_mm.c) creates a char device used by the management tool "megarc" from LSI Logic (and possibly other management tools). In 2.6 with udev, this device doesn't get created because it is not registered i

[patch 18/23] aic94: fix section mismatches

2007-11-21 Thread akpm
From: Randy Dunlap <[EMAIL PROTECTED]> Fix section mismatch warning: WARNING: vmlinux.o(.init.text+0x23be6): Section mismatch: reference to .exit.text:asd_unmap_ha (between 'asd_pci_probe' and 'qla4xxx_module_init') + WARNING: vmlinux.o(.text+0x1ec8a8): Section mismatch: reference to .exit.text:

[patch 21/23] scsi/advansys.c: make 3 functions static

2007-11-21 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/advansys.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -puN drivers/scsi/advansys.c~scsi-advansysc-make-3-functions-stat

[patch 23/23] Dell CERC support for megaraid_mbox

2007-11-21 Thread akpm
From: Hannes Reinecke <[EMAIL PROTECTED]> Newer Dell CERC firmware (>= 6.62) implement a random deletion handling compatible with the legacy megaraid driver. The legacy handling shifted the target ID by 0x80 only for I/O commands (READ/WRITE/etc), whereas megaraid_mbox shifts the target ID always

[patch 07/23] hptiop: fix type mismatch warning

2007-11-21 Thread akpm
From: Jeff Garzik <[EMAIL PROTECTED]> drivers/scsi/hptiop.c: In function 'hptiop_host_request_callback': drivers/scsi/hptiop.c:378: warning: comparison of distinct pointer types lacks a cast drivers/scsi/hptiop.c:378: warning: comparison of distinct pointer types lacks a cast Use min_t(size_t,

[patch 05/23] initio: fix conflict when loading driver

2007-11-21 Thread akpm
From: Alan Cox <[EMAIL PROTECTED]> > I have a scanner connected to a Initio INI-950 SCSI card and I recently > upgraded from SuSE 10.2 to 10.3. The new kernel doesn't see any of my > devices. I get the following in /var/log/messages: > > ACPI: PCI Interrupt :00:0a.0[A] -> GSI 17 (level, low)

[patch 08/23] ips: remove ips_ha members that duplicate struct pci_dev members

2007-11-21 Thread akpm
From: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Acked-by: "Salyzyn, Mark" <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/ips.c | 178 --- d

[patch 09/23] ips: trim trailing whitespace

2007-11-21 Thread akpm
From: Jeff Garzik <[EMAIL PROTECTED]> [EMAIL PROTECTED]: coding style fixes] Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Acked-by: "Salyzyn, Mark" <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/ips.c | 49 +++

[patch 10/23] ips: PCI API cleanups

2007-11-21 Thread akpm
From: Jeff Garzik <[EMAIL PROTECTED]> * pass Scsi_Host to ips_remove_device() via pci_set_drvdata(), allowing us to eliminate the ips_ha[] search loop and call ips_release() directly. * call pci_{request,release}_regions() and eliminate individual request/release_[mem_]region() calls * cal

[patch 03/23] SCSI: early detection of medium not present, updated

2007-11-21 Thread akpm
From: Alan Stern <[EMAIL PROTECTED]> Taken from http://bugzilla.kernel.org/show_bug.cgi?id=8904 An updated (by Albert, I assume) version of the fourteen-month-old patch here: http://marc.info/?l=linux-kernel&m=115412002912837&w=2 Apparently fixes the bug described at http://bugzilla.kernel.org/

[patch 02/23] nsp32_restart_autoscsi(): remove error check

2007-11-21 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> The Coverity checker noted that we'll anyway Oops later when we ran into this condition - and the error check didn't prevent that. Considering that the error condition shouldn't be possible, and we are not able to handle it easily, this patch simply removes t

[patch 06/23] kill warnings in mptbase.h on parisc64

2007-11-21 Thread akpm
From: Kyle McMartin <[EMAIL PROTECTED]> Verified all the arches necessary select the CONFIG_64BIT symbol. This also kills the warning (since it was using the 32-bit case) on parisc64 and mips64. Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]> Cc: "Moore, Eric Dean" <[EMAIL PROTECTED]> Cc: James

[patch 01/23] git-scsi-misc gdth fix

2007-11-21 Thread akpm
From: James Bottomley <[EMAIL PROTECTED]> On Sun, 2007-10-14 at 12:21 -0700, Andrew Morton wrote: > On Sun, 14 Oct 2007 22:45:47 +0400 "Dave Milter" <[EMAIL PROTECTED]> wrote: > > > I build linux-2.6.23-mm1 and try to boot it using qemu, > > and it crashed with trace like this: > > do_page_fault >

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-11-21 Thread James Smart
Anil Veerabhadrappa wrote: It's a chicken & egg issue to put "port mapper" sysfs entry in scsi host attributes. Application won't see sysfs unless initiator creates an iSCSI session and driver can't create an iSCSI session without a tcp port. I was wondering if there is a better way than using I

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-11-21 Thread Anil Veerabhadrappa
> >> The sysfs bits related to the hba should be use one of the scsi sysfs > >> facilities or if they are related to iscsi bits and are generic then > >> through the iscsi hba > > > > bnx2i needs 2 sysfs entries - > > 1. QP size info - this is used to size per connection shared data > > structu

Re: [PATCH UPDATE] zfcp: add some internal zfcp adapter statistics

2007-11-21 Thread Swen Schillig
James can you give me the status of the below patch ? Is there anything missing from my side or is the patch still in review by you ? Cheers Swen On Friday 09 November 2007 14:07, Swen Schillig wrote: > Updated the statistics patch to cover the issues pointed out by Heiko. > > James, could you

Re: SCSI dynamic power management

2007-11-21 Thread Jens Axboe
On Mon, Nov 19 2007, Alan Stern wrote: > On Mon, 19 Nov 2007, Matthew Wilcox wrote: > > > On Mon, Nov 19, 2007 at 10:36:19AM -0500, Alan Stern wrote: > > > These are conflicting requirements. How can we send the START-STOP > > > UNIT commands to spin the disk up/down through the request queue wh

Re: [Bugme-new] [Bug 9405] New: iSCSI does not implement ordering guarantees required by e.g. journaling filesystems

2007-11-21 Thread Vladislav Bolkhovitin
James Bottomley wrote: if you specifically set TAS=1 you're giving up the right to know what caused the command termination. With insufficient information, it's really unsafe to simply retry, which is why the mid layer just returns TASK ABORTED as an error. If you set TAS=0 we'll get a check co