Fixes the following warnings:
CC [M] drivers/scsi/aic7xxx/aic79xx_osm_pci.o
drivers/scsi/aic7xxx/aic79xx_osm_pci.c:101: warning:
‘ahd_linux_pci_dev_suspend’ defined but not used
drivers/scsi/aic7xxx/aic79xx_osm_pci.c:121: warning: ‘ahd_linux_pci_dev_resume’
defined but not used
CC [M] driv
Frank Lichtenheld wrote:
On Thu, Nov 08, 2007 at 03:58:34PM -0800, Randy Dunlap wrote:
Hi,
The preferred method of fixing this type of warning is to
(warning, not a full patch here):
a. change the struct pci_driver not to use #ifdef CONFIG_PM/#endif;
instead, it always says:
.suspend
On Fri, 9 Nov 2007 00:03:48 +0100 Frank Lichtenheld wrote:
> Fixes the following warnings:
> CC [M] drivers/scsi/aic7xxx/aic79xx_osm_pci.o
> drivers/scsi/aic7xxx/aic79xx_osm_pci.c:101: warning:
> ‘ahd_linux_pci_dev_suspend’ defined but not used
> drivers/scsi/aic7xxx/aic79xx_osm_pci.c:121: wa
On Thu, Nov 08, 2007 at 03:58:34PM -0800, Randy Dunlap wrote:
> Hi,
> The preferred method of fixing this type of warning is to
> (warning, not a full patch here):
>
> a. change the struct pci_driver not to use #ifdef CONFIG_PM/#endif;
> instead, it always says:
>
> .suspend= ahd_l
Fixes the following warnings:
CC [M] drivers/scsi/aic7xxx/aic79xx_osm_pci.o
drivers/scsi/aic7xxx/aic79xx_osm_pci.c:101: warning:
‘ahd_linux_pci_dev_suspend’ defined but not used
drivers/scsi/aic7xxx/aic79xx_osm_pci.c:121: warning: ‘ahd_linux_pci_dev_resume’
defined but not used
CC [M] driv
On Wednesday 07 November 2007 00:47:20 James Bottomley wrote:
> On Sun, 2007-11-04 at 10:02 -0800, Randy Dunlap wrote:
> > My only concern with this ATM is its name (SCSI midlayer), but
> > chapter 2 is SCSI upper layer, chap 3 is SCSI midlayer, and
> > chap 4 is SCSI low-level interfaces.
> >
> >
(CC'ing linux-scsi on this)
On Thu, Nov 08, 2007 at 01:28:53AM +0300, Serge (gentoosiast) Koksharov wrote:
> On Wed, Nov 07, 2007 at 02:31:45PM -0500, Alan Stern wrote:
> > This suggests that the device needs a longer timeout for the INQUIRY
> > command. The default timeout is 5 seconds (the driv
On Thu, Nov 08, 2007 at 01:11:01PM -0500, Tony Battersby wrote:
> HBA is inside an embedded device sold by my company, and customers can
> attach their own SCSI devices to it. There is one type of SCSI device
> that we support which doesn't work with disconnect privilege enabled, so
> my code runn
James Bottomley wrote:
> On Wed, 2007-11-07 at 15:37 -0500, Tony Battersby wrote:
>
>> This patch fixes the sym53c8xx "setflag" user command to control
>> disconnect privilege, which has been broken for a long time.
>>
>
> The first observation is that the sym specific setflags interface i
Resounding ACK.
I just finished *exactly* the same set of changes, composed the patch
and was about to hit send when this one came over the wire from you!
There was absolutely no differences between our patches (save for the
fact I did not place the AIF ones in as they are already in the queue,
on
On Wed, 2007-11-07 at 15:37 -0500, Tony Battersby wrote:
> This patch fixes the sym53c8xx "setflag" user command to control
> disconnect privilege, which has been broken for a long time.
The first observation is that the sym specific setflags interface is
being replaced by the parallel transport
On Wed, Nov 07, 2007 at 01:51:44PM -0500, Salyzyn, Mark wrote:
> Christoph Hellwig [mailto:[EMAIL PROTECTED] sez:
> > Did anyone run the driver through sparse to see if we have
> > more issues like this?
>
> There are some warnings from sparse, none like this one. I will deal
> with the warnings
At the block level bidi request uses req->next_rq pointer for a second
bidi_read request.
At Scsi-midlayer a second scsi_data_buffer structure is used for the
bidi_read part. This bidi scsi_data_buffer is put on
request->next_rq->special. Struct scsi_cmnd is not changed.
- Define scsi
In preparation for bidi we abstract all IO members of scsi_cmnd,
that will need to duplicate, into a substructure.
- Group all IO members of scsi_cmnd into a scsi_data_buffer
structure.
- Adjust accessors to new members.
- scsi_{alloc,free}_sgtable receive a scsi_data_buffer instead
- If we export scsi_init_io()/scsi_release_buffers() instead of
scsi_{alloc,free}_sgtable() from scsi_lib than tgt code is
much more insulated from scsi_lib changes. As a bonus it will
also gain bidi capability when it comes.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
Acked-by:
if (rq_data_dir() == WRITE) else if() else chain had an extra
"else" since the if() is on a value of 1 bit.
Also with a bidi request, rq_data_dir() == WRITE
and blk_bidi_rq() == true.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/sd.c |5 +
drivers/scsi/sr.c |
On Tue, Nov 06 2007 at 20:04 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> [1]
> I propose a small change to scsi_tgt_lib.c that will make
> tgt completely neutral to the scsi_data_buffer patch. And will
> make it all that more ready for bidi, too. TOMO is this OK?
>
> (Can you do without the G
Kai Makisara wrote:
I am using the default st module options and not doing anything other than
using 'mt setblk 0'.
Is there anything I can do to get a decent, sustained read rate from these
tapes?
If your system can process the data fast enough and the tape blocks are of
the same size, you
On Thu, 08 Nov 2007 16:01:53 +0200
Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> On Thu, Nov 08 2007 at 15:04 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> > On Thu, 08 Nov 2007 10:32:56 +0200
> > Benny Halevy <[EMAIL PROTECTED]> wrote:
> >
> >> On Nov. 08, 2007, 5:13 +0200, FUJITA Tomonori <[E
On Thu, Nov 08 2007 at 15:54 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote:
> On Thu, Nov 08 2007, Boaz Harrosh wrote:
>> James, Jens please note the question below
>> It is something that bothers me about sr.c
>>
>> On Tue, Nov 06 2007 at 20:19 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
>>> I
On Thu, Nov 08 2007 at 15:04 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> On Thu, 08 Nov 2007 10:32:56 +0200
> Benny Halevy <[EMAIL PROTECTED]> wrote:
>
>> On Nov. 08, 2007, 5:13 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
>>> On Tue, 06 Nov 2007 20:16:19 +0200
>>> Boaz Harrosh <[EMAI
On Thu, Nov 08 2007, Boaz Harrosh wrote:
> James, Jens please note the question below
> It is something that bothers me about sr.c
>
> On Tue, Nov 06 2007 at 20:19 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> > In preparation for bidi we abstract all IO members of scsi_cmnd,
> > that will
On Thu, Nov 08 2007 at 15:03 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> On Thu, 08 Nov 2007 11:24:36 +0200
> Boaz Harrosh <[EMAIL PROTECTED]> wrote:
>
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 18343a6..28cf6fe 100644
--- a/drivers/scsi/sd.c
+++ b/drivers
James, Jens please note the question below
It is something that bothers me about sr.c
On Tue, Nov 06 2007 at 20:19 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> In preparation for bidi we abstract all IO members of scsi_cmnd,
> that will need to duplicate, into a substructure.
>
>
> -
On Thu, 08 Nov 2007 10:32:56 +0200
Benny Halevy <[EMAIL PROTECTED]> wrote:
> On Nov. 08, 2007, 5:13 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> > On Tue, 06 Nov 2007 20:16:19 +0200
> > Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> >
> >> - If we export scsi_init_io()/scsi_release_buffers()
On Thu, 08 Nov 2007 11:24:36 +0200
Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> >> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> >> index 18343a6..28cf6fe 100644
> >> --- a/drivers/scsi/sd.c
> >> +++ b/drivers/scsi/sd.c
> >> @@ -448,9 +448,6 @@ static int sd_prep_fn(struct request_queue *q, st
On Thu, Nov 08 2007 at 5:14 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> On Tue, 06 Nov 2007 20:19:32 +0200
> Boaz Harrosh <[EMAIL PROTECTED]> wrote:
>
>
> Hmm, checkpatch.pl complains reasonably:
>
> ./scripts/checkpatch.pl ~/Mail/kernel/scsi/28815
> ERROR: use tabs not spaces
> #177: F
On Nov. 08, 2007, 5:13 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> On Tue, 06 Nov 2007 20:16:19 +0200
> Boaz Harrosh <[EMAIL PROTECTED]> wrote:
>
>> - If we export scsi_init_io()/scsi_release_buffers() instead of
>> scsi_{alloc,free}_sgtable() from scsi_lib than tgt code is
>> mu
28 matches
Mail list logo
