Re: [PATCH] gdth: scp timeout clean up

2007-11-05 Thread Boaz Harrosh
On Tue, Nov 06 2007 at 8:54 +0200, [EMAIL PROTECTED] wrote: > gdth driver is modified NOT to use scp->eh_timeout. Now, it has > eh_timed_out (gdth_timed_out) to handle command timeouts for locked > I/O's. Have not tested as I don't have needed hardware! Patch is > against 2.6.23-mm1. > > Thank you

[PATCH] gdth: scp timeout clean up

2007-11-05 Thread malahal
gdth driver is modified NOT to use scp->eh_timeout. Now, it has eh_timed_out (gdth_timed_out) to handle command timeouts for locked I/O's. Have not tested as I don't have needed hardware! Patch is against 2.6.23-mm1. Thank you Matthew Wilcox for your input on the IRC channel. Signed-off-by: Malah

Re: [git patches] Add and use media change notification

2007-11-05 Thread Jeff Garzik
Linus Torvalds wrote: On Sun, 4 Nov 2007, Jeff Garzik wrote: The end to CD-ROM polling... newer SATA ATAPI hardware will emit 'asynchronous notification' events when media is changed. This adds support. I *really* didn't want to pull this. Not only is it after the -rc1 period, but I also t

Re: [PATCH 1/2] libsas: Convert sas_proto users to sas_protocol

2007-11-05 Thread Jeff Garzik
Darrick J. Wong wrote: sparse complains about the mixing of enums in libsas. Since the underlying numeric values of both enums are the same, combine them to get rid of the warning. Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/scsi/aic94xx/aic94xx_dev.c |6 +++--- driver

[PATCH 2/2] libsas: Fix various sparse complaints

2007-11-05 Thread Darrick J. Wong
Annotate sas_queuecommand with locking details, and clean up a few more sparse warnings about static/non-static declarations. Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/scsi/libsas/sas_scsi_host.c |6 +- include/scsi/libsas.h |4 +--- 2 files changed

[PATCH 1/2] libsas: Convert sas_proto users to sas_protocol

2007-11-05 Thread Darrick J. Wong
sparse complains about the mixing of enums in libsas. Since the underlying numeric values of both enums are the same, combine them to get rid of the warning. Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/scsi/aic94xx/aic94xx_dev.c |6 +++--- drivers/scsi/aic94xx/aic94xx_du

Re: [2.6 patch] scsi/aic94xx/: cleanups

2007-11-05 Thread Darrick J. Wong
On Mon, Nov 05, 2007 at 06:07:29PM +0100, Adrian Bunk wrote: > This patch contains the following cleanups: > - static functions in .c files shouldn't be marked inline > - make needlessly global code static > - #if 0 unused code asd_unpause_lseq can be removed; the other if 0'd functions are debug

[GIT PATCH] SCSI bug fixes for 2.6.24-rc1

2007-11-05 Thread James Bottomley
These are a fairly straightforward and small collection of fixes. The patch is available here: master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git The short changelog is: Ilpo Järvinen (1): osst: fix if (...) \n #if... cases missing semicolons when false James Bottomle

[2.6 patch] scsi/lpfc/: possible cleanups

2007-11-05 Thread Adrian Bunk
This patch contains the following possible cleanups: - make the following needlessly global functions static: - lpfc_els.c: lpfc_register_new_vport() - lpfc_els.c: lpfc_issue_els_fdisc() - lpfc_els.c: lpfc_issue_fabric_iocb() - lpfc_els.c: lpfc_fabric_abort_vport() - lpfc_hbadisc.c: lpfc_

[2.6 patch] scsi/qla2xxx/: possible cleanups

2007-11-05 Thread Adrian Bunk
This patch contains the following possible cleanups: - make the following needlessly global code static: - qla_attr.c: qla24xx_vport_delete() - qla_attr.c: qla24xx_vport_disable() - qla_mid.c: qla24xx_allocate_vp_id() - qla_mid.c: qla24xx_find_vhost_by_name() - qla_mid.c: qla2x00_do_dpc_v

[2.6 patch] scsi/aic94xx/: cleanups

2007-11-05 Thread Adrian Bunk
This patch contains the following cleanups: - static functions in .c files shouldn't be marked inline - make needlessly global code static - #if 0 unused code Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/scsi/aic94xx/aic94xx_dev.c |8 +++--- drivers/scsi/aic94xx/aic94xx_dump.

Re: [PATCH] wd7000.c - proper fix for boards without sg support

2007-11-05 Thread Boaz Harrosh
On Mon, Nov 05 2007 at 11:21 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote: > - code used to set sg_tablesize to zero for board revision > less than 6. This is no longer supported, therefore I > use sg_tablesize=1 and open code the sg handling for that case. > - Get rid of use of SG_NON

Re: [PATCH] zfcp: add some internal zfcp adapter statistics

2007-11-05 Thread Swen Schillig
On Saturday 03 November 2007 10:17, Heiko Carstens wrote: > > +static void zfcp_fsf_req_latency(struct zfcp_fsf_req *fsf_req) > > +{ > > + struct fsf_qual_latency_info *lat_inf; > > + struct zfcp_unit *unit; > > + > > + lat_inf = &fsf_req->qtcb->prefix.prot_status_qual.latency_info; > > + u

[patch 6/6] zfcp: Reduce flood on hba trace

2007-11-05 Thread swen
From: Christof Schmitt <[EMAIL PROTECTED]> Remove tracing for request with a "qualifier" field set in the response. The protocol status qualifier now contains measurement data for "good" commands, so this check would trace every response by default. The fix is to simply remove the "qual" tracing

[patch 5/6] zfcp: Fix deadlock when adding invalid LUN

2007-11-05 Thread swen
From: Christof Schmitt <[EMAIL PROTECTED]> When adding an invalid LUN, there is a deadlock between the add via scsi_scan_target and the slave_destroy handler: The handler waits for the scan to complete, but for an invalid unit, scsi_scan_target directly calls the slave_destroy handler. Fix the de

[patch 3/6] zfcp: Specify waiting times in ERP in seconds

2007-11-05 Thread swen
From: Christof Schmitt <[EMAIL PROTECTED]> It is not necessary to use jiffies or milliseconds to specify waiting times that last a couple of seconds. Signed-off-by: Christof Schmitt <[EMAIL PROTECTED]> Signed-off-by: Martin Schwidefsky <[EMAIL PROTECTED]> Signed-off-by: Swen Schillig <[EMAIL PROT

[patch 2/6] zfcp: Use also port and adapter to identify unit in messages.

2007-11-05 Thread swen
From: Christof Schmitt <[EMAIL PROTECTED]> Signed-off-by: Christof Schmitt <[EMAIL PROTECTED]> Signed-off-by: Swen Schillig <[EMAIL PROTECTED]> --- drivers/s390/scsi/zfcp_scsi.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff -urpN linux-2.6/drivers/s390/scsi/zfcp_scsi.c

[patch 4/6] zfcp: Remove SCSI devices when removing complete adapter

2007-11-05 Thread swen
From: Christof Schmitt <[EMAIL PROTECTED]> The common I/O layer can call remove a handler to inform zfcp that a device disappeared. The handler zfcp_ccw_remove then removes all unit, port and the adapter data structures. Removing the units requires that the SCSI devices are removed first. Signed-

[patch 1/6] zfcp: Remove unnecessary eh_bus_reset_handler callback

2007-11-05 Thread swen
From: Christof Schmitt <[EMAIL PROTECTED]> The callback function used by zfcp always returns success, which is an indication for the SCSI midlayer to stop error handling. Remove the bus_reset callback, since the same function will be called via the host_reset callback. Signed-off-by: Christof Sch

[patch 0/6] zfcp: updates, fixing a variety of oddities

2007-11-05 Thread swen
-- patch 1/6: Remove unnecessary eh_bus_reset_handler callsback The callback function used by zfcp always returns success, which is an indication for the SCSI midlayer to stop error handling. Remove the bus_reset callback, since the same function will be

Re: [PATCH] zfcp: add some internal zfcp adapter statistics

2007-11-05 Thread Swen Schillig
On Saturday 03 November 2007 10:40, Heiko Carstens wrote: > > > + if (!(adapter->adapter_features & FSF_FEATURE_MEASUREMENT_DATA)) { > > > + ZFCP_LOG_NORMAL("error: Enhanced measurement feature not " > > > + "supported"); > > > + return -EOPNOTSUPP; > > > + }

[PATCH] NCR5380 familly convert to accessors & !use_sg cleanup

2007-11-05 Thread Boaz Harrosh
- This patch depends on: NCR5380: Use scsi_eh API for REQUEST_SENSE invocation - convert to accessors and !use_sg cleanup - FIXME: Not sg-chain ready look for ++cmd->SCp.buffer Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/NCR5380.c | 14 +++--- dri

[PATCH] wd7000.c - proper fix for boards without sg support

2007-11-05 Thread Boaz Harrosh
- code used to set sg_tablesize to zero for board revision less than 6. This is no longer supported, therefore I use sg_tablesize=1 and open code the sg handling for that case. - Get rid of use of SG_NONE which will be removed soon. Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> ---

Re: [PATCH 2/4] block layer varlen-cdb

2007-11-05 Thread Boaz Harrosh
On Fri, Nov 02 2007 at 13:17 +0200, Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Fri, Nov 02, 2007 at 08:32:12AM +0200, Benny Halevy wrote: >> I agree this is probably the cleanest implementation but when Boaz and I >> initially discussed this approach he convinced me that LL block devices >> as

Re: Drivers accessors latest version

2007-11-05 Thread Boaz Harrosh
On Sat, Nov 03 2007 at 21:41 +0200, James Bottomley <[EMAIL PROTECTED]> wrote: > > This one has a clear merge bug: > > index 2597209..bc63349 100644 > --- a/drivers/scsi/NCR5380.c > +++ b/drivers/scsi/NCR5380.c > > So could you fix it up correctly, please (and just email the patch, I > think it