Re: [PATCH 15/15] Add Documentation/DocBook/scsi_midlayer.tmpl and add to Makefile.

2007-10-26 Thread Randy Dunlap
On Fri, 26 Oct 2007 23:18:00 -0500 Rob Landley wrote: > From: Rob Landley <[EMAIL PROTECTED]> > > Add Documentation/DocBook/scsi_midlayer.tmpl and add to Makefile. I have comments for all 15 patches here. a. You should cc: the maintainer who you want/expect to apply the patches. Alwa

[PATCH] SCSI: Remove apparently unused traces of SCSI_QLOGIC_FC content.

2007-10-26 Thread Robert P. J. Day
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- i can't find any historical evidence that the related content has been removed, but nothing in the tree seems to need this Kconfig entry (and, as randy dunlap noticed, the dependency of SCSI_QLOGIC_FC doesn't even exist, anyway). diff -

Re: single unused scsi-related CONFIG variable

2007-10-26 Thread Randy Dunlap
On Sat, 27 Oct 2007 00:28:03 -0400 (EDT) Robert P. J. Day wrote: > On Fri, 26 Oct 2007, Randy Dunlap wrote: > > > On Fri, 26 Oct 2007 14:18:05 -0400 (EDT) Robert P. J. Day wrote: > > > > > > > > drivers/scsi/Kconfig:1322:config SCSI_QLOGIC_FC_FIRMWARE > > > > config SCSI_QLOGIC_FC_FIRMWARE > >

Re: single unused scsi-related CONFIG variable

2007-10-26 Thread Robert P. J. Day
On Fri, 26 Oct 2007, Randy Dunlap wrote: > On Fri, 26 Oct 2007 14:18:05 -0400 (EDT) Robert P. J. Day wrote: > > > > > drivers/scsi/Kconfig:1322:config SCSI_QLOGIC_FC_FIRMWARE > > config SCSI_QLOGIC_FC_FIRMWARE > bool "Include loadable firmware in driver" > depends on SCSI_QLOGIC_FC > >

Re: single unused scsi-related CONFIG variable

2007-10-26 Thread Randy Dunlap
On Fri, 26 Oct 2007 14:18:05 -0400 (EDT) Robert P. J. Day wrote: > > drivers/scsi/Kconfig:1322:config SCSI_QLOGIC_FC_FIRMWARE config SCSI_QLOGIC_FC_FIRMWARE bool "Include loadable firmware in driver" depends on SCSI_QLOGIC_FC I don't find SCSI_QLOGIC_FC defined anywhere... ---

[PATCH 15/15] Add Documentation/DocBook/scsi_midlayer.tmpl and add to Makefile.

2007-10-26 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> Add Documentation/DocBook/scsi_midlayer.tmpl and add to Makefile. Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- Documentation/DocBook/Makefile |2 Documentation/DocBook/scsi_midlayer.tmpl | 409 + 2 files changed, 41

[PATCH 14/15] Update kerneldoc comments in drivers/scsi/scsi_transport_srp.c

2007-10-26 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> Update kerneldoc comments in drivers/scsi/scsi_transport_srp.c Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- drivers/scsi/scsi_transport_srp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -r a868e8217782 drivers/scsi/scsi_transport_sr

[PATCH 13/15] Update kerneldoc comments in drivers/scsi/scsi_transport_sas.c

2007-10-26 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> Update kerneldoc comments in drivers/scsi/scsi_transport_sas.c Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- drivers/scsi/scsi_transport_sas.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff -r a868e8217782 drivers/scsi/scsi_transpor

Re: Questions about proc_scsi_write() in scsi_proc.c

2007-10-26 Thread Rob Landley
On Friday 26 October 2007 5:47:57 pm James Bottomley wrote: > > > http://www.t10.org/ftp/t10/drafts/sam3/sam3r14.pdf > > > http://www.t10.org/ftp/t10/drafts/sam4/sam4r13.pdf > > > > Unfortunately those two documents are 127 pages and 148 pages, > > respectively, and I haven't had a chance to make a

[PATCH 12/15] Update kerneldoc comments in drivers/scsi/scsi_transport_iscsi.c

2007-10-26 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> Update kerneldoc comments in drivers/scsi/scsi_transport_iscsi.c Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- drivers/scsi/scsi_transport_iscsi.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -r a868e8217782 drivers/scsi/scsi_transp

[PATCH 11/15] Update kerneldoc comments in drivers/scsi/scsi_transport_fc.c

2007-10-26 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> Update kerneldoc comments in drivers/scsi/scsi_transport_fc.c Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- drivers/scsi/scsi_transport_fc.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff -r a868e8217782 drive

[PATCH 10/15] Update kerneldoc comments in drivers/scsi/scsi_scan.c

2007-10-26 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> Update kerneldoc comments in drivers/scsi/scsi_scan.c Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- drivers/scsi/scsi_scan.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff -r a868e8217782 drivers/scsi/scs

[PATCH 9/15] Update kerneldoc comments in drivers/scsi/scsi_proc.c

2007-10-26 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> Update kerneldoc comments in drivers/scsi/scsi_proc.c Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- drivers/scsi/scsi_proc.c | 110 - 1 file changed, 108 insertions(+), 2 deletions(-) diff -r a868e8217782 drivers/s

[PATCH 8/15] Update kerneldoc comments in drivers/scsi/scsi_netlink.c

2007-10-26 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> Update kerneldoc comments in drivers/scsi/scsi_netlink.c Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- drivers/scsi/scsi_netlink.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff -r a868e8217782 drivers/scsi/scsi_netl

[PATCH 6/16] Update kerneldoc comments in drivers/scsi/scsi_ioctl.c

2007-10-26 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> Update kerneldoc comments in drivers/scsi/scsi_ioctl.c Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- drivers/scsi/scsi_ioctl.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff -r a868e8217782 drivers/scsi/scsi_ioc

[PATCH 7/15] Update kerneldoc comments in drivers/scsi/scsi_lib.c

2007-10-26 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> Update kerneldoc comments in drivers/scsi/scsi_lib.c Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- drivers/scsi/scsi_lib.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff -r a868e8217782 drivers/scsi/scsi_lib.c --- a/driver

[PATCH 5/16] Update kerneldoc comments in drivers/scsi/scsi_error.c

2007-10-26 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> Update kerneldoc comments in drivers/scsi/scsi_error.c Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- drivers/scsi/scsi_error.c | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-) diff -r a868e8217782 drivers/sc

[PATCH 4/15] Update kerneldoc comments in drivers/scsi/scsi_devinfo.c

2007-10-26 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> Update kerneldoc comments in drivers/scsi/scsi_devinfo.c Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- drivers/scsi/scsi_devinfo.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deletions(-) diff -r a868e8217782 driver

[PATCH 3/15] Update kerneldoc comments in drivers/scsi/constants.c

2007-10-26 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> Update kerneldoc comments in drivers/scsi/constants.c Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- drivers/scsi/constants.c |1 - 1 file changed, 1 deletion(-) diff -r a868e8217782 drivers/scsi/constants.c --- a/drivers/scsi/constants.c Mon Oct

[PATCH 2/15] Update kerneldoc comments in drivers/scsi/scsicam.c

2007-10-26 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> Update kerneldoc comments in drivers/scsi/scsicam.c Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- drivers/scsi/scsicam.c | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-) diff -r a868e8217782 drivers/scs

[PATCH 1/15] Update kerneldoc comments in drivers/scsi/scsi.c

2007-10-26 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> Update kerneldoc comments in drivers/scsi/scsi.c Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- drivers/scsi/scsi.c | 195 +- 1 file changed, 102 insertions(+), 93 deletions(-) diff -r a868e8217782 drivers/scsi/

Re: [PATCH] Documentation/DocBook/scsi_midlayer.tmpl

2007-10-26 Thread Rob Landley
On Friday 26 October 2007 5:45:56 pm Stefan Richter wrote: > Rob Landley wrote: > > drivers/scsi/scsi.c | 181 - > > Also have a look at this: > "Fix a few misleading comments in scsi.c" > http://marc.info/?l=linux-scsi&m=119340708627893 > "scsi.c: fix some typos in co

[PATCH 2/2] SCSI/NCR5380: minor irq handler cleanups

2007-10-26 Thread Jeff Garzik
* remove unnecessary cast * remove unnecessary use of 'irq' function arg Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/scsi/NCR5380.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c index 2597209..31787d8

[PATCH 1/2] SCSI: fix bugs and canonicalize NCR5380_intr drivers

2007-10-26 Thread Jeff Garzik
* Bug fix: Make sure request_irq() and free_irq() are called with the same dev_id pointer argument. * Bug fix: always pass 'irq' and 'dev_id' (aka 'dummy') arguments to NCE5380_intr() when calling it manully. For some drivers this doesn't matter, depending on whose copy of NCR5380_intr()

Re: Questions about proc_scsi_write() in scsi_proc.c

2007-10-26 Thread Matthew Wilcox
On Fri, Oct 26, 2007 at 05:29:53PM -0500, Rob Landley wrote: > Ok, I'm unclear on what a LUN is. All the devices I have lying around give > me > a LUN of zero. I used to think that a LUN was a bit like partition, and > mostly used for CD changes. The structure "scsi_target" seems to aggregate

Re: [PATCH] Documentation/DocBook/scsi_midlayer.tmpl

2007-10-26 Thread Rob Landley
On Friday 26 October 2007 5:45:56 pm Stefan Richter wrote: > Rob Landley wrote: > > drivers/scsi/scsi.c | 181 - > > Also have a look at this: > "Fix a few misleading comments in scsi.c" > http://marc.info/?l=linux-scsi&m=119340708627893 > "scsi.c: fix some typos in co

Re: Questions about proc_scsi_write() in scsi_proc.c

2007-10-26 Thread James Bottomley
On Fri, 2007-10-26 at 17:29 -0500, Rob Landley wrote: > On Friday 26 October 2007 4:09:37 pm James Bottomley wrote: > > On Fri, 2007-10-26 at 15:07 -0500, Rob Landley wrote: > > > I don't understanding this code: > > > > > > 1) for echo "scsi add-single-device 0 1 2 3" > /proc/scsi/scsi, is this >

Re: [PATCH] Documentation/DocBook/scsi_midlayer.tmpl

2007-10-26 Thread Stefan Richter
Rob Landley wrote: > drivers/scsi/scsi.c | 181 - Also have a look at this: "Fix a few misleading comments in scsi.c" http://marc.info/?l=linux-scsi&m=119340708627893 "scsi.c: fix some typos in comments" http://marc.info/?l=linux-scsi&m=114279682717770 -- Stefan Rich

Re: Questions about proc_scsi_write() in scsi_proc.c

2007-10-26 Thread Rob Landley
On Friday 26 October 2007 4:09:37 pm James Bottomley wrote: > On Fri, 2007-10-26 at 15:07 -0500, Rob Landley wrote: > > I don't understanding this code: > > > > 1) for echo "scsi add-single-device 0 1 2 3" > /proc/scsi/scsi, is this > > only for parallel scsi? > > No. > > > I thought most modern b

Re: [PATCH] Remove pointless casts from void pointers,

2007-10-26 Thread Lennert Buytenhek
On Fri, Oct 26, 2007 at 05:40:22AM -0400, Jeff Garzik wrote: > arch/arm/mach-pxa/ssp.c|2 +- > arch/arm/mach-s3c2410/usb-simtec.c |2 +- > arch/arm/plat-omap/mailbox.c |2 +- FWIW Acked-by: Lennert Buytenhek <[EMAIL PROTECTED]> - To unsubscri

Re: Questions about proc_scsi_write() in scsi_proc.c

2007-10-26 Thread James Bottomley
On Fri, 2007-10-26 at 15:07 -0500, Rob Landley wrote: > I don't understanding this code: > > 1) for echo "scsi add-single-device 0 1 2 3" > /proc/scsi/scsi, is this only > for parallel scsi? No. > I thought most modern busses (usb, sata, FC, firewire, > etc) dynamically assign these numbers

single unused scsi-related CONFIG variable

2007-10-26 Thread Robert P. J. Day
drivers/scsi/Kconfig:1322:config SCSI_QLOGIC_FC_FIRMWARE rday -- Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca ===

Questions about proc_scsi_write() in scsi_proc.c

2007-10-26 Thread Rob Landley
I don't understanding this code: 1) for echo "scsi add-single-device 0 1 2 3" > /proc/scsi/scsi, is this only for parallel scsi? I thought most modern busses (usb, sata, FC, firewire, etc) dynamically assign these numbers and just use them as a unique identifier ala kdev_t. How would this wor

Re: [patch 1/1] scsi: fix a few misleading comments in scsi.c

2007-10-26 Thread Stefan Richter
> On Fri, Oct 26, 2007 at 08:42:17AM -0500, [EMAIL PROTECTED] wrote: >> - * needs to be release with scsi_host_put once you're done with it. >> + * needs to be release with scsi_device_put once you're done with it. Well, hopefully this fix goes finally in now. :-) http://marc.info/?l=linux-scsi&m=

Re: [PATCH] Remove pointless casts from void pointers,

2007-10-26 Thread Holger Schurig
> drivers/net/wireless/libertas/if_cs.c |2 +- ACK - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Remove pointless casts from void pointers,

2007-10-26 Thread Josh Boyer
On Fri, 26 Oct 2007 05:40:22 -0400 (EDT) Jeff Garzik <[EMAIL PROTECTED]> wrote: > mostly in and around irq handlers. > > Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> > --- > drivers/serial/uartlite.c |2 +- Acked-by: Josh Boyer <[EMAIL PROTECTED] - To unsubscribe from thi

Re: What layer are "transport classes" in?

2007-10-26 Thread Stefan Richter
James Bottomley wrote: > On Thu, 2007-10-25 at 17:13 -0500, Rob Landley wrote: >> Looking at the scsi_transport_*.c files... Are these part of the lower >> layer >> or the midlayer? I _think_ these exist primarily to expose information >> about >> the lower layers through sysfs, but I'm very

Re: [patch 1/1] scsi: fix a few misleading comments in scsi.c

2007-10-26 Thread Matthew Wilcox
On Fri, Oct 26, 2007 at 08:42:17AM -0500, [EMAIL PROTECTED] wrote: > - * needs to be release with scsi_host_put once you're done with it. > + * needs to be release with scsi_device_put once you're done with it. s/release/released/ as well? > - * needs to be release with scsi_host_put once you're

[patch 1/1] scsi: fix a few misleading comments in scsi.c

2007-10-26 Thread scameron
Fix a few misleading comments in scsi.c Signed-off-by: Stephen M. Cameron <[EMAIL PROTECTED]> --- diff -puN linux-2.6.24-rc1/drivers/scsi/scsi.c~fix_scsi_comments linux-2.6.24-rc1/drivers/scsi/scsi.c --- dynamic_scsi/linux-2.6.24-rc1/drivers/scsi/scsi.c~fix_scsi_comments 2007-10-25 08:52:01.

Re: [PATCH] Remove pointless casts from void pointers,

2007-10-26 Thread Dmitry Torokhov
On 10/26/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > drivers/input/touchscreen/h3600_ts_input.c |4 ++-- Acked-by: Dmitry Torokhov <[EMAIL PROTECTED]> -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordo

Re: [PATCH] Remove pointless casts from void pointers,

2007-10-26 Thread John W. Linville
On Fri, Oct 26, 2007 at 05:40:22AM -0400, Jeff Garzik wrote: > mostly in and around irq handlers. > > Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> > --- > drivers/net/wireless/airo.c|5 +++-- > drivers/net/wireless/hostap/hostap_hw.c|2 +- > drivers/net/wireless/lib

[PATCH] Add missing $(obj) to aic7xxx makefile

2007-10-26 Thread Vegard Nossum
Hi, This patch adds the proper $(obj) and $(src) prefixes to dependency rules in aic7xxx makefile. Without this patch, there is a remote possibility that parallel make with a different output directory can fail. Also changed the deprecated EXTRA_CFLAGS construct to ccflags-y syntax. Signed-off-

Re: Disk spindown on rmmod sd_mod

2007-10-26 Thread Tejun Heo
Jan Engelhardt wrote: > I am using 2.6.23-rc9 with pata_sis. `modprobe -r sd_mod`, which I ran > from initramfs, caused all my disks to spindown - sd even told me so. > > I recall there has been talk a while back about whether to spin down > disks on shutdown or not, but I do not think it touche

[PATCH] SCSI/sym53c416: kill pointless irq handler loop and test

2007-10-26 Thread Jeff Garzik
- kill pointless irq handler loop to find base address, it is already passed to irq handler via Scsi_Host. - kill now-pointless !base test. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/scsi/sym53c416.c | 16 +--- 1 files changed, 1 insertions(+), 15 deletions(-) di

[PATCH] SCSI/gdth: kill unneeded 'irq' argument

2007-10-26 Thread Jeff Garzik
Neither gdth_get_status() nor __gdth_interrupt() need their 'irq' argument, so remove it. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/scsi/gdth.c | 21 + 1 files changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c

[PATCH] Remove pointless casts from void pointers,

2007-10-26 Thread Jeff Garzik
mostly in and around irq handlers. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- arch/arm/mach-pxa/ssp.c|2 +- arch/arm/mach-s3c2410/usb-simtec.c |2 +- arch/arm/plat-omap/mailbox.c |2 +- arch/ia64/sn/pci/pcibr/pcibr_provider.c|6