Robert Hancock wrote:
This doesn't seem a very reliable way to identify an IDE device, as all
that 0 means is that the device does not claim conformance to any
standard. I would think it would be legitimate for an IDE device to put
a value like 5 in there as well, if it complies with SPC-4..
Vi
On Wed, Oct 17, 2007 at 08:21:15PM +0200, Boaz Harrosh wrote:
> - Group all IO members of scsi_cmnd into a scsi_data_buffer
> structure.
> +struct scsi_data_buffer {
> + unsigned length;
> + int resid;
> + unsigned short sg_count;
> + unsigned short alloc_sg_count;
> + st
On Wed, 17 Oct 2007 19:14:46 +0200
Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> This is a resend of all the remaining drivers rebased
> to latest code. And once the entire tree is converted,
> move to scsi_data_buffer in scsi_cmnd.
>
> The work is on top of Jens's for-linus branch which
> is effecti
On Wed, 17 Oct 2007 20:21:15 +0200
Boaz Harrosh <[EMAIL PROTECTED]> wrote:
>
> In preparation for bidi we abstract all IO members of scsi_cmnd,
> that will need to duplicate, into a substructure.
>
> - Group all IO members of scsi_cmnd into a scsi_data_buffer
> structure.
> - Adjust
Jeff Garzik wrote:
But again, please remember that these USB devices are really SCSI
devices. Same for SATA devices. There is a reason they are using the
SCSI layer, and it isn't just because the developers felt like it :)
/somewhat/ true I'm afraid: libata uses the SCSI layer for ATAPI
de
On Wed, 17 Oct 2007 10:27:54 -0400
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Where can one find patches/code that illustrates target mode support?
I think that the srp class and ibmvstgt (drivers/ibmvscsi/ibmvstgt)
are useful.
The fc class and qla2xxx are useful too but more complicated than
ibmv
On Wed, 17 Oct 2007 20:37:58 +0900
FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> On Wed, 17 Oct 2007 13:01:42 +0200
> Jens Axboe <[EMAIL PROTECTED]> wrote:
>
> > On Wed, Oct 17 2007, Jens Axboe wrote:
> > > On Wed, Oct 17 2007, David Miller wrote:
> > > > From: Jens Axboe <[EMAIL PROTECTED]>
> > >
On Wed, Oct 17, 2007 at 08:10:09PM +0200, Boaz Harrosh wrote:
>
> - Indentation fix of last patch. Don't be fooled by diff,
> all I did was back-indent from open-bracket to close-bracket,
> and remove the brackets.
Applying 'qla1280: Indentation fix'
Adds trailing whitespace.
.dotest/p
On Wed, 17 Oct 2007, Gabor Gombas wrote:
On Tue, Oct 16, 2007 at 01:55:07PM -0700, [EMAIL PROTECTED] wrote:
why is this any different from the external enclosures? they have always
appeared as the type of device that connects them to the motherboard, (and
even with SCSI, there are some control
On Wed, Oct 17, 2007 at 08:46:48PM +0200, Willy Tarreau wrote:
> Sincere thanks for your help and review. I'll apply this patch in
> 2.4.36-pre2 and in next 2.4.35.X. An ugly fix is clearly better than
> a massive change at this stage.
You're most welcome. I have no desire to act as maintainer fo
On Wed, Oct 17, 2007 at 10:27:47AM -0600, Matthew Wilcox wrote:
> On Wed, Oct 17, 2007 at 10:53:06AM -0400, Tony Battersby wrote:
> > After looking at it carefully, this is true of pci_map_mem, but not
> > pci_unmap_mem. pci_unmap_mem can be called from both ->detect and
> > ->release. io_request
- This driver still bags on scsi_cmnd IO members, so need changing
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/usb/storage/isd200.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/storage/isd200.c b/drivers/usb/storage/isd200.c
index
From: FUJITA Tomonori <[EMAIL PROTECTED]>
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/scsi/ibmvscsi/ibmvstgt.c |2 +-
drivers/scsi/libsrp.c| 27 ++-
2 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/
From: FUJITA Tomonori <[EMAIL PROTECTED]>
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_tgt_if.c |2 +-
drivers/scsi/scsi_tgt_lib.c | 43 ---
2 files changed, 13 insertions(+)
- sd and sr would adjust IO size to align on device's block
size so code needs to change once we move to scsi_data_buff
implementation.
- Convert code to use scsi_for_each_sg
- Use data accessors where appropriate.
- Remove dead code (req_data_dir() != READ && != WRITE)
Signed-of
- Changed needed members of struct scsi_eh_save.
- Careful considerations in scsi_eh_prep/restore_cmnd.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_error.c | 28 ++--
include/scsi/scsi_eh.h|6 +-
2 files changed, 11 insertions(+)
In preparation for bidi we abstract all IO members of scsi_cmnd,
that will need to duplicate, into a substructure.
- Group all IO members of scsi_cmnd into a scsi_data_buffer
structure.
- Adjust accessors to new members.
- scsi_{alloc,free}_sgtable receive a scsi_data_buffer instead
- Apparently no one wonts this driver, and no one
is willing to fix it for future changes to SCSI.
So remove it, and if someone wants it in the future
He can revive it with the needed fixes.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/Kconfig | 15 -
driver
The psi240i driver is still written for cmnd->request_buffer
as a char pointer to actual data. There was never any attempt
to use the scatterlist option.
- remove all source files (3) from drivers/scsi
- Remove from Makefile and Kconfig
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
-
- code used to set sg_tablesize to zero for board revision
less than 6. This is no longer supported, therefore I
use sg_tablesize=1 and open code the sg handling for that case.
- Get rid of use of SG_NONE which will be removed soon.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
- remove the unnecessary map_single path.
- convert to use the new accessors for the sg lists and the
parameters.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
Signed-off-by: Douglas Gilbert <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_de
- Indentation fix of last patch. Don't be fooled by diff,
all I did was back-indent from open-bracket to close-bracket,
and remove the brackets.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/qla1280.c | 290
1 files c
From: FUJITA Tomonori <[EMAIL PROTECTED]>
- remove the unnecessary map_single path.
- convert to use the new accessors for the sg lists and the parameters.
- NOTE: Indentation fix is in next patch. Otherwise this patch
becomes totally impossible to read (and easily breakable)
Signed-off
- convert to accessors and !use_sg cleanup
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/in2000.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/in2000.c b/drivers/scsi/in2000.c
index ab7cbf3..ced38de 100644
--- a/drivers/scsi/i
- convert to accessors and !use_sg cleanup
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/wd33c93.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/wd33c93.c b/drivers/scsi/wd33c93.c
index 0e8e642..1a772b8 100644
--- a/drivers/scs
- convert to accessors and !use_sg cleanup
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/qlogicpti.c | 29 +++--
1 files changed, 7 insertions(+), 22 deletions(-)
diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c
index 7a2e798..5bc883
[PATCH 17/32] ppa.c: convert to accessors and !use_sg cleanup
- convert to accessors and !use_sg cleanup
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/ppa.c | 12 +---
1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/ppa.c b/drivers/scsi/p
- convert to accessors and !use_sg cleanup
- Not ready for sg-chaining
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/imm.c | 13 +
1 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/imm.c b/drivers/scsi/imm.c
index 74cdc1f..84bcc1d 1006
- convert to accessors and !use_sg cleanup
- Not ready for sg-chaining
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/fd_mcs.c | 36 +++-
1 files changed, 11 insertions(+), 25 deletions(-)
diff --git a/drivers/scsi/fd_mcs.c b/drivers/scsi/fd
- convert to accessors and !use_sg cleanup
- Probably not ready for sg-chaining
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/atp870u.c | 102
1 files changed, 17 insertions(+), 85 deletions(-)
diff --git a/drivers/scsi/atp8
- convert to accessors and !use_sg cleanup
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/aha1542.c | 46 ++
1 files changed, 10 insertions(+), 36 deletions(-)
diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c
index 961
- convert to accessors and !use_sg cleanup
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/a3000.c | 15 +++
1 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi/a3000.c b/drivers/scsi/a3000.c
index 796f1c4..d7255c8 100644
--- a/drivers/scs
- convert to accessors and !use_sg cleanup
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/a2091.c | 36 +---
1 files changed, 5 insertions(+), 31 deletions(-)
diff --git a/drivers/scsi/a2091.c b/drivers/scsi/a2091.c
index b7c5385..23f27c9 100
- convert to accessors and !use_sg cleanup
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/eata_pio.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/eata_pio.c b/drivers/scsi/eata_pio.c
index 96180bb..e6d5138 100644
--- a/driver
[PATCH 9/32] nsp_cs.c convert to data accessors and !use_sg cleanup
- use scsi data accessors
- cleanup !use_sg code paths
- TODO: use next_sg() for Jens's sglist branch. Look for 2
places with "SCp.buffer++"
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/pcmcia/nsp_
- convert to accessors and !use_sg cleanup
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/arm/acornscsi.c | 14 +++---
drivers/scsi/arm/scsi.h | 34 +++---
2 files changed, 18 insertions(+), 30 deletions(-)
diff --git a/drivers/scs
- convert to accessors and !use_sg cleanup
- FIXME: Not sg-chain ready look for ++cmd->SCp.buffer
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/NCR5380.c | 14 +++---
drivers/scsi/atari_NCR5380.c | 22 +++---
drivers/scsi/sun3_NCR5380.c |
- Use scsi data accessors and remove of !use_sg code path
- This patch is dependent on cleanup patch to usb transport.c/h
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/usb/storage/freecom.c | 14 ++
drivers/usb/storage/sddr09.c |9 +++--
2 files changed, 9
- functions that received char* but where passed scatterlist* mostly
were changed to receive void*
- Use scsi data accessors and remove of !use_sg code path
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/usb/storage/shuttle_usbat.c | 68 +-
1 f
- Use scsi data accessors and remove of !use_sg code path
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/usb/storage/protocol.c | 126 +---
1 files changed, 53 insertions(+), 73 deletions(-)
diff --git a/drivers/usb/storage/protocol.c b/drivers
- Use scsi data accessors and remove of !use_sg code path.
- New usb_stor_bulk_srb() for use by drivers
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/usb/storage/transport.c | 44 +++---
drivers/usb/storage/transport.h |2 +
2 files changed
Gabor Gombas wrote:
> On Tue, Oct 16, 2007 at 01:55:07PM -0700, [EMAIL PROTECTED] wrote:
>> why is this any different from the external enclosures? they have always
>> appeared as the type of device that connects them to the motherboard, (and
>> even with SCSI, there are some controllers that don
- This patch should be commited before:
usb: transport - convert to accessors and !use_sg code path removal
- isd200_action() was still using direct liniar pointers in issuing
commands to the USB transport level. This is no longer supported,
use one-element scatterlist instead.
- Use new scsi_eh_prep/restor_cmnd() for synchronous
REQUEST_SENSE invocation.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/arm/fas216.c | 16 +++-
drivers/scsi/arm/fas216.h |3 +++
2 files changed, 6 insertions(+), 13 deletions(-)
diff --git a/driver
This is a resend of all the remaining drivers rebased
to latest code. And once the entire tree is converted,
move to scsi_data_buffer in scsi_cmnd.
The work is on top of Jens's for-linus branch which
is effectively sglist-arch (+ last minute fixes)
This is because sglist-arch was already rebased t
On Tue, 16 Oct 2007, [EMAIL PROTECTED] wrote:
> From: Andrew Morton <[EMAIL PROTECTED]>
>
> drivers/scsi/qla2xxx/qla_sup.c: In function 'qla24xx_write_flash_data':
> drivers/scsi/qla2xxx/qla_sup.c:655: warning: format '%llx' expects type 'long
> long unsigned int', but argument 6 has type 'dma_a
On Wed, Oct 17, 2007 at 10:53:06AM -0400, Tony Battersby wrote:
> After looking at it carefully, this is true of pci_map_mem, but not
> pci_unmap_mem. pci_unmap_mem can be called from both ->detect and
> ->release. io_request_lock is held in ->detect but not in ->release.
> So, your patch locks u
Verified all the arches necessary select the CONFIG_64BIT symbol. This
also kills the warning (since it was using the 32-bit case) on parisc64
and mips64.
Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]>
---
Index: linux-2.6/drivers/message/fusion/mptbase.h
===
This patch fixes two problems with sym53c8xx_2.o in 2.4.x kernels:
1) A system hang when loading sym53c8xx_2.o on a SMP system with two
dual-channel LSI HBAs (http://bugzilla.kernel.org/show_bug.cgi?id=3680)
2) A function improperly marked __init.
Signed-off-by: Tony Battersby <[EMAIL PROTECTED]
On Wed, Oct 17, 2007 at 11:44:08AM -0400, Tony Battersby wrote:
> In 2.4, include/linux/init.h has the following:
>
> #ifndef MODULE
> #define __init __attribute__ ((__section__ (".text.init")))
> #else
> #define __init
> #endif
>
> So __init has an effect only if it is built-in.
Ah yes
On Wed, Oct 17, 2007 at 10:53:06AM -0400, Tony Battersby wrote:
> > So we should unconditionally drop the lock (and re-enable
> > interrupts) and re-acquire it.
>
> After looking at it carefully, this is true of pci_map_mem, but not
> pci_unmap_mem. pci_unmap_mem can be called from both ->detect
Willy Tarreau wrote:
> On Wed, Oct 17, 2007 at 10:53:06AM -0400, Tony Battersby wrote:
>
>>> So we should unconditionally drop the lock (and re-enable
>>> interrupts) and re-acquire it.
>>>
>> After looking at it carefully, this is true of pci_map_mem, but not
>> pci_unmap_mem. pci_unmap
> So we should unconditionally drop the lock (and re-enable
> interrupts) and re-acquire it.
After looking at it carefully, this is true of pci_map_mem, but not
pci_unmap_mem. pci_unmap_mem can be called from both ->detect and
->release. io_request_lock is held in ->detect but not in ->release.
Hannes Reinecke wrote:
Hi James,
due to popular demand I've clobbered together a patch for
suspend/resume support in aic79xx/aic7xxx.
Looks reasonable enough, boots, but now I'd need someone
to actually test it :-)
As usual, comments, results, fixes, etc. welcome.
Looks good to me... nice w
On Wed, Oct 17 2007, Jens Axboe wrote:
> On Wed, Oct 17 2007, Hannes Reinecke wrote:
> > Hi James,
> >
> > due to popular demand I've clobbered together a patch for
> > suspend/resume support in aic79xx/aic7xxx.
> >
> > Looks reasonable enough, boots, but now I'd need someone
> > to actually test
On Wed, Oct 17 2007, Hannes Reinecke wrote:
> Hi James,
>
> due to popular demand I've clobbered together a patch for
> suspend/resume support in aic79xx/aic7xxx.
>
> Looks reasonable enough, boots, but now I'd need someone
> to actually test it :-)
>
> As usual, comments, results, fixes, etc. w
On Wed, Oct 17 2007, FUJITA Tomonori wrote:
> > I think that it would be better that IOMMU code handles uninitialized
> > sg entries (sg list can be pretty large). Execpt for sparc64, the
> > IOMMU code can do, I think.
>
> And I think that with this patch, sparc64 can handle it:
>
> http://marc.
Where can one find patches/code that illustrates target mode support?
Marvell 6440 ("mvsas") supports target mode for both SAS and SATA, and I
would like to prepare the driver as best I can for target mode.
Thanks,
Jeff
-
To unsubscribe from this list: send the line "unsubscribe lin
Hi James,
due to popular demand I've clobbered together a patch for
suspend/resume support in aic79xx/aic7xxx.
Looks reasonable enough, boots, but now I'd need someone
to actually test it :-)
As usual, comments, results, fixes, etc. welcome.
Cheers,
Hannes
--
Dr. Hannes Reinecke
Any chance to send this for 2.6.24?
This is a data buffer accessor cleanup dependent on sg chaining. Now
it can cleanly applied to the latest Linus tree.
qla1280: convert to use the data buffer accessors
- remove the unnecessary map_single path.
- convert to use the new accessors for the sg li
On Tue, 2007-10-16 at 14:28 -0700, [EMAIL PROTECTED] wrote:
> From: James Bottomley <[EMAIL PROTECTED]>
>
> On Sun, 2007-10-14 at 12:21 -0700, Andrew Morton wrote:
> > On Sun, 14 Oct 2007 22:45:47 +0400 "Dave Milter" <[EMAIL PROTECTED]> wrote:
> >
> > > I build linux-2.6.23-mm1 and try to boot it
On Wed, 2007-10-17 at 13:20 +0900, FUJITA Tomonori wrote:
> On Mon, 15 Oct 2007 00:09:41 -0400
> James Bottomley <[EMAIL PROTECTED]> wrote:
>
> > This is the accumulated updates queued for 2.6.24. It contains the
> > usual slew of driver updates, plus some gdth and advansys rewrites. We
> > stil
On Wed, 17 Oct 2007 20:57:17 +0900
FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> On Wed, 17 Oct 2007 13:41:17 +0200
> Jens Axboe <[EMAIL PROTECTED]> wrote:
>
> > On Wed, Oct 17 2007, FUJITA Tomonori wrote:
> > > On Wed, 17 Oct 2007 13:01:42 +0200
> > > Jens Axboe <[EMAIL PROTECTED]> wrote:
> > >
On Wed, 17 Oct 2007 13:41:17 +0200
Jens Axboe <[EMAIL PROTECTED]> wrote:
> On Wed, Oct 17 2007, FUJITA Tomonori wrote:
> > On Wed, 17 Oct 2007 13:01:42 +0200
> > Jens Axboe <[EMAIL PROTECTED]> wrote:
> >
> > > On Wed, Oct 17 2007, Jens Axboe wrote:
> > > > On Wed, Oct 17 2007, David Miller wrote:
On Wed, Oct 17 2007, FUJITA Tomonori wrote:
> On Wed, 17 Oct 2007 13:01:42 +0200
> Jens Axboe <[EMAIL PROTECTED]> wrote:
>
> > On Wed, Oct 17 2007, Jens Axboe wrote:
> > > On Wed, Oct 17 2007, David Miller wrote:
> > > > From: Jens Axboe <[EMAIL PROTECTED]>
> > > > Date: Wed, 17 Oct 2007 11:16:29
On Wed, 17 Oct 2007 13:01:42 +0200
Jens Axboe <[EMAIL PROTECTED]> wrote:
> On Wed, Oct 17 2007, Jens Axboe wrote:
> > On Wed, Oct 17 2007, David Miller wrote:
> > > From: Jens Axboe <[EMAIL PROTECTED]>
> > > Date: Wed, 17 Oct 2007 11:16:29 +0200
> > >
> > > > On Wed, Oct 17 2007, David Miller wro
On Wed, Oct 17 2007, David Miller wrote:
> From: Jens Axboe <[EMAIL PROTECTED]>
> Date: Wed, 17 Oct 2007 13:11:46 +0200
>
> > On Wed, Oct 17 2007, David Miller wrote:
> > > Jens, please also add the following on top of Fujita-san's most recent
> > > sparc64 patch and we should be good to go.
> >
From: Jens Axboe <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 13:11:46 +0200
> On Wed, Oct 17 2007, David Miller wrote:
> > Jens, please also add the following on top of Fujita-san's most recent
> > sparc64 patch and we should be good to go.
>
> Awesome, thanks. And sorry for messing up sparc64.
D
On Wed, Oct 17 2007, Jens Axboe wrote:
> On Wed, Oct 17 2007, FUJITA Tomonori wrote:
> > On Wed, 17 Oct 2007 02:45:47 -0700 (PDT)
> > David Miller <[EMAIL PROTECTED]> wrote:
> >
> > > From: FUJITA Tomonori <[EMAIL PROTECTED]>
> > > Date: Wed, 17 Oct 2007 18:24:01 +0900
> > >
> > > > On Wed, 17 Oc
On Wed, Oct 17 2007, FUJITA Tomonori wrote:
> On Wed, 17 Oct 2007 02:45:47 -0700 (PDT)
> David Miller <[EMAIL PROTECTED]> wrote:
>
> > From: FUJITA Tomonori <[EMAIL PROTECTED]>
> > Date: Wed, 17 Oct 2007 18:24:01 +0900
> >
> > > On Wed, 17 Oct 2007 11:16:29 +0200
> > > Jens Axboe <[EMAIL PROTECTE
On Wed, Oct 17 2007, David Miller wrote:
> From: Jens Axboe <[EMAIL PROTECTED]>
> Date: Wed, 17 Oct 2007 13:01:42 +0200
>
> > Actually, just clearing AFTER sg_next() would be fine, since we know
> > that is not a link entry. Duh...
>
> Yes and I'm running a kernel successfully with this fix.
Gre
From: Jens Axboe <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 13:01:42 +0200
> Actually, just clearing AFTER sg_next() would be fine, since we know
> that is not a link entry. Duh...
Yes and I'm running a kernel successfully with this fix.
Jens, please also add the following on top of Fujita-san's
On Wed, 17 Oct 2007 02:45:47 -0700 (PDT)
David Miller <[EMAIL PROTECTED]> wrote:
> From: FUJITA Tomonori <[EMAIL PROTECTED]>
> Date: Wed, 17 Oct 2007 18:24:01 +0900
>
> > On Wed, 17 Oct 2007 11:16:29 +0200
> > Jens Axboe <[EMAIL PROTECTED]> wrote:
> >
> > > On Wed, Oct 17 2007, David Miller wrot
On Wed, 17 Oct 2007 12:58:40 +0200
Jens Axboe <[EMAIL PROTECTED]> wrote:
> On Wed, Oct 17 2007, David Miller wrote:
> > From: Jens Axboe <[EMAIL PROTECTED]>
> > Date: Wed, 17 Oct 2007 11:16:29 +0200
> >
> > > On Wed, Oct 17 2007, David Miller wrote:
> > > > From: Jens Axboe <[EMAIL PROTECTED]>
>
From: Jens Axboe <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 12:58:40 +0200
> The problem is that you cannot zero the entire sg entry, because then
> you'd potentially overwrite the chain pointer.
>
> I'd propose just adding a
>
> sg_dma_address(sg) = 0;
> sg_dma_len(sg) = 0;
>
>
On Wed, Oct 17 2007, David Miller wrote:
> From: Jens Axboe <[EMAIL PROTECTED]>
> Date: Wed, 17 Oct 2007 12:58:40 +0200
>
> > The problem is that you cannot zero the entire sg entry, because then
> > you'd potentially overwrite the chain pointer.
> >
> > I'd propose just adding a
> >
> >
On Wed, Oct 17 2007, Jens Axboe wrote:
> On Wed, Oct 17 2007, David Miller wrote:
> > From: Jens Axboe <[EMAIL PROTECTED]>
> > Date: Wed, 17 Oct 2007 11:16:29 +0200
> >
> > > On Wed, Oct 17 2007, David Miller wrote:
> > > > From: Jens Axboe <[EMAIL PROTECTED]>
> > > > Date: Wed, 17 Oct 2007 10:45:
On Wed, Oct 17 2007, David Miller wrote:
> From: Jens Axboe <[EMAIL PROTECTED]>
> Date: Wed, 17 Oct 2007 11:16:29 +0200
>
> > On Wed, Oct 17 2007, David Miller wrote:
> > > From: Jens Axboe <[EMAIL PROTECTED]>
> > > Date: Wed, 17 Oct 2007 10:45:28 +0200
> > >
> > > > Righto, it's invalid to call
From: Jens Axboe <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 11:16:29 +0200
> On Wed, Oct 17 2007, David Miller wrote:
> > From: Jens Axboe <[EMAIL PROTECTED]>
> > Date: Wed, 17 Oct 2007 10:45:28 +0200
> >
> > > Righto, it's invalid to call sg_next() on the last entry!
> >
> > Unfortunately, that
On Tue, Oct 16, 2007 at 01:55:07PM -0700, [EMAIL PROTECTED] wrote:
> why is this any different from the external enclosures? they have always
> appeared as the type of device that connects them to the motherboard, (and
> even with SCSI, there are some controllers that don't generate sdX devices)
From: FUJITA Tomonori <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 18:24:01 +0900
> On Wed, 17 Oct 2007 11:16:29 +0200
> Jens Axboe <[EMAIL PROTECTED]> wrote:
>
> > On Wed, Oct 17 2007, David Miller wrote:
> > > I would suggest that other sg_last() uses be audited for the same bug.
> >
> > Agree.
On Wed, Oct 17 2007, FUJITA Tomonori wrote:
> On Wed, 17 Oct 2007 11:16:29 +0200
> Jens Axboe <[EMAIL PROTECTED]> wrote:
>
> > On Wed, Oct 17 2007, David Miller wrote:
> > > From: Jens Axboe <[EMAIL PROTECTED]>
> > > Date: Wed, 17 Oct 2007 10:45:28 +0200
> > >
> > > > Righto, it's invalid to call
On Wed, 17 Oct 2007 11:16:29 +0200
Jens Axboe <[EMAIL PROTECTED]> wrote:
> On Wed, Oct 17 2007, David Miller wrote:
> > From: Jens Axboe <[EMAIL PROTECTED]>
> > Date: Wed, 17 Oct 2007 10:45:28 +0200
> >
> > > Righto, it's invalid to call sg_next() on the last entry!
> >
> > Unfortunately, that's
On Wed, Oct 17 2007, David Miller wrote:
> From: Jens Axboe <[EMAIL PROTECTED]>
> Date: Wed, 17 Oct 2007 10:45:28 +0200
>
> > Righto, it's invalid to call sg_next() on the last entry!
>
> Unfortunately, that's what the sparc64 code wanted to do, this
> transformation in the sparc64 sg chaining pa
From: Jens Axboe <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 10:45:28 +0200
> Righto, it's invalid to call sg_next() on the last entry!
Unfortunately, that's what the sparc64 code wanted to do, this
transformation in the sparc64 sg chaining patch is not equilavent:
- struct scatterlist *sg_
On Wed, Oct 17 2007, FUJITA Tomonori wrote:
> sg list elements might not be continuous.
Thanks, applied.
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-i
sg list elements might not be continuous.
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
arch/ia64/hp/common/sba_iommu.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/ia64/hp/common/sba_iommu.c b/arch/ia64/hp/common/sba_iommu.c
index 4338f41..3c95f41 100
On Wed, Oct 17 2007, David Miller wrote:
> From: David Miller <[EMAIL PROTECTED]>
> Date: Wed, 17 Oct 2007 01:33:25 -0700 (PDT)
>
> > sg_next() gives you a NULL after the last entry, but tests have been
> > changed to compare against sg_last() which is likely not what we
> > want for those checks.
From: David Miller <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 01:33:25 -0700 (PDT)
> sg_next() gives you a NULL after the last entry, but tests have been
> changed to compare against sg_last() which is likely not what we
> want for those checks.
This of course isn't true, ignore me as I'm still l
From: Jens Axboe <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 09:21:49 +0200
> On Wed, Oct 17 2007, FUJITA Tomonori wrote:
> > Commit 2c941a204070ab32d92d40318a3196a7fb994c00 looks incomplete. The
> > helper functions like prepare_sg() need to support sg chaining too.
>
> Thanks Tomo, applied. I'll
On Wed, Oct 17 2007, FUJITA Tomonori wrote:
> sg list elements might not be continuous.
>
> Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
> ---
> lib/swiotlb.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/swiotlb.c b/lib/swiotlb.c
> index c419ecf..752fd
sg list elements might not be continuous.
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
lib/swiotlb.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/swiotlb.c b/lib/swiotlb.c
index c419ecf..752fd95 100644
--- a/lib/swiotlb.c
+++ b/lib/swiotlb.c
@@ -696,7 +6
On Wed, Oct 17 2007, FUJITA Tomonori wrote:
> Commit 2c941a204070ab32d92d40318a3196a7fb994c00 looks incomplete. The
> helper functions like prepare_sg() need to support sg chaining too.
Thanks Tomo, applied. I'll get this pushed out later today with any
other sg chaining fallout we may see.
--
J
93 matches
Mail list logo
