From: Rob Landley <[EMAIL PROTECTED]>
Update Documentation/scsi/00-INDEX to match current files.
Signed-off-by: Rob Landley <[EMAIL PROTECTED]>
---
Documentation/scsi/00-INDEX | 34 +++---
1 file changed, 31 insertions(+), 3 deletions(-)
diff -r f4ca99897c12 Docum
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Sun, 30 Sep 2007 20:52:45 -0400
> David Miller wrote:
> > It compiles :-) You deleted the only uses of scsi_rbuf_{get,put}()
> > so you can kill those off too.
>
>
> Seeing as how they are exact duplicates of libata's
> ata_scsi_rbuf_{get,put}, I won
David Miller wrote:
It compiles :-) You deleted the only uses of scsi_rbuf_{get,put}()
so you can kill those off too.
Seeing as how they are exact duplicates of libata's
ata_scsi_rbuf_{get,put}, I wonder how they got there in the first place
(rather than becoming common code), and I wonder
From: Matthew Wilcox <[EMAIL PROTECTED]>
Date: Wed, 19 Sep 2007 06:46:37 -0600
>
> I haven't even compile-tested this. But look how much ugly code it
> deletes if it works!
It compiles :-) You deleted the only uses of scsi_rbuf_{get,put}()
so you can kill those off too.
I don't have the time
On Sun, Sep 30, 2007 at 10:28:13PM +0100, Christoph Hellwig wrote:
> I think it would be better if your whole patch series goes ontop of
> willy's ->done removal series instead. I really hope we can get that
> one into scsi-misc ASAP.
Actually, I think if Boaz simply flips this patch to be after
The patchset looks pretty good to me, overall.
Thanks for pulling all this stuff together!
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Christoph Hellwig wrote:
The big problem with the pci_driver conversion is that lack of device
ids in the driver. A few years ago I sent Achim a mail to ask if there's
a definitive list of used PCI ids, but didn't get an answer - maybe
the mail bounced. If we can't get this list we'd have to ad
On Sun, Sep 30, 2007 at 05:07:53PM -0400, Jeff Garzik wrote:
> The driver needs to be converted to the "new" hotplug APIs.
>
> The main pre-reqs are accomplished by your patches: the driver is using
> the modern scsi hotplug API, and uses pointers for the adapter struct
> rather than indices.
>
On Sun, Sep 30, 2007 at 09:44:12PM +0200, Boaz Harrosh wrote:
> Some short explanations:
> [1/16] gdth: split out isa probing - Christoph Hellwig
> [2/16] gdth: split out eisa probing - Christoph Hellwig
> [3/16] gdth: split out pci probing - Christoph Hellwig
> These three are from Christoph and
BTW, when reposting the patches of others, its nice to add a From:
header to the very first line of the email body. Andrew does that a
lot, and the git tools are aware of this convention.
Also, hey, if you like our patches, I think you should add your own
Signed-off-by line (assuming/hoping y
On Sun, Sep 30, 2007 at 10:13:27PM +0200, Boaz Harrosh wrote:
>
> Rather than having internal commands abuse scsi_done to call
> gdth_scsi_done, have all the places that use to call scsi_done directly
> call gdth_scsi_done, which now checks whether the command was internal,
> and calls scs
On Sun, Sep 30, 2007 at 10:09:20PM +0200, Boaz Harrosh wrote:
>
> - Return the interrupting host and not it's index.
> NULL if intr is not by gdth.
> - fix calling site
>
> FIXME:
>Why are we looping on all cards? the passed dev_id
>can be used for pinpointing the exact interrup
On Sun, Sep 30, 2007 at 10:06:39PM +0200, Boaz Harrosh wrote:
>
> - Get rid of all the indirection in the Scsi_Host private data and always
> put the gdth_ha_str directly into it.
>
> - Change all internal functions prototype to recieve an "gdth_ha_str *ha"
> pointer directlly and kil
On Sun, Sep 30, 2007 at 10:01:56PM +0200, Boaz Harrosh wrote:
>
> * New function gdth_register_virt() replaces the three
> basically-duplicate copies of virtual controller registration.
I think we can just kill this one if 8/16 goes in..
-
To unsubscribe from this list: send the line "unsu
Boaz Harrosh wrote:
[11/16] gdth: switch to modern scsi host registration - Christoph
Christoph what is missing from here is the remove of the deprecated
pci_find_device() call. Can I Just use pci_get_device() of the same signature
or do I need to call some other pci_ members after that?
Boaz Harrosh wrote:
[8/16] gdth: Remove virt hosts - Christoph && Boaz
Here we need an executive decision! The issue is as stated by Christoph:
"The virt_ctr option allows to register a new scsi_host for each bus
on the raid controller. This non-default option makes no sense with
gdth_execute() will issue an internal, none scsi-standard commands
onto __gdth_queuecommand(). Since it is not recommended to set
struct scsi_cmnd IO members in llds, gdth now uses internal IO
members for IO. In the case of gdth_execute() these members will be
set properly. In case the c
- Cleanup the rest of the scsi_cmnd-SCp members and move them
to gdth_cmndinfo:
SCp.this_residual=> priority
SCp.buffers_residual => timeout
SCp.Status => status and dma_dir
SCp.Message => info
SCp.have_data_in => volatile wait_for_completion
- scsi_cmnd and specifically ->SCp of, where heavily abused
with internal meaning members and flags. So introduce a new
struct gdth_cmndinfo, put it on ->host_scribble and define a
gdth_cmnd_priv() accessor to retrieve it from a scsi_cmnd.
- The structure now holds two members:
Rather than having internal commands abuse scsi_done to call
gdth_scsi_done, have all the places that use to call scsi_done directly
call gdth_scsi_done, which now checks whether the command was internal,
and calls scsi_done if not.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
Signed
- Places like Initialization and Reset that Just loop on all devices can
use the link list with the list_for_each_entry macro.
But the io_ctrl from user mode now suffers performance-wise because
code has to do a sequential search for the requested host number.
I have isolated thi
- Use scsi_add_host and friends and track instances ourselves. And
generally modernize the driver's structure.
- TODO: Next we can remove the controller table
- TODO: Fix use of deprecated pci_find_device()
Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
Signed-off-by: Boaz Harros
- Return the interrupting host and not it's index.
NULL if intr is not by gdth.
- fix calling site
FIXME:
Why are we looping on all cards? the passed dev_id
can be used for pinpointing the exact interrupting
card. The kernel is already looping on all sharing
cards so this co
The virt_ctr option allows to register a new scsi_host for each bus
on the raid controller. This non-default option makes no sense with
the current scsi code and prevents cleaning up the host registration,
so remove it.
Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
Signed-off-by: Boaz Har
* New function gdth_register_virt() replaces the three
basically-duplicate copies of virtual controller registration.
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/gdth.c | 80 ++
* shuffle scsi_host_template members such that they appear in the
order in which they are defined in the header. this makes is easier
to verify when initializers are missing members.
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
* Remove in-source changelog. It's archived permanently in git and
various kernel archives, and changelogs should exist purely in git.
* Remove 2.4.x kernel support. It is an active obstacle to
modernizing this driver, at this point. This includes killing
gdth_kcompat.h which i
They are direct equivalents to {read,write}[bwl].
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
---
drivers/scsi/gdth.c | 313 +--
1 files changed, 153 insertions(+), 160 deletions(-)
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
inde
Split out per-device pci probing and put it under proper CONFIG_PCI.
Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
---
drivers/scsi/gdth.c | 287 +++---
1 files changed, 155 insertions(+), 132 deletions(-)
diff --git a/drivers/scsi/gdth.c b/dr
Split eisa probing into it's own helper, and do proper error unwinding.
Protect EISA probind by the proper CONFIG_EISA symbol.
Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
---
drivers/scsi/gdth.c | 270 ---
1 files changed, 150 insertions(
(note: this is ontop of Jeff's pci cleanup patch)
Split out isa probing into a helper of it's own. Error handling is
cleaned up, but errors are not propagated yet. Also enclose the isa
probe under the proper CONFIG_ISA symbol instead of the !IA64 hack.
Signed-off-by: Christoph Hellwig <[EMAIL
Hi!
following is an attempted at unified patchset for the gdth driver.
They try to incorporate floating patches to gdth from:
Christoph Hellwig
Jeff Garzik
Matthew Wilcox
and Me Boaz Harrosh
They are done in the mindset of "likelihood of inducing breakage",
hence the need for testers. Christoph
On Sun, 2007-09-30 at 13:44 -0400, Jeff Garzik wrote:
> James Bottomley wrote:
> > On Thu, 2007-09-27 at 21:01 -0400, Jeff Garzik wrote:
> >> James Bottomley wrote:
> >>> On Wed, 2007-09-26 at 03:35 -0400, Jeff Garzik wrote:
> sas_hash_addr() is the spec-defined standard hashing function. Mak
Jeff Garzik wrote:
James Bottomley wrote:
On Thu, 2007-09-27 at 21:01 -0400, Jeff Garzik wrote:
James Bottomley wrote:
On Wed, 2007-09-26 at 03:35 -0400, Jeff Garzik wrote:
sas_hash_addr() is the spec-defined standard hashing function.
Make it
available to drivers that need it.
I'm not opp
James Bottomley wrote:
On Thu, 2007-09-27 at 21:01 -0400, Jeff Garzik wrote:
James Bottomley wrote:
On Wed, 2007-09-26 at 03:35 -0400, Jeff Garzik wrote:
sas_hash_addr() is the spec-defined standard hashing function. Make it
available to drivers that need it.
I'm not opposed in principle to
On Thu, 2007-09-27 at 21:01 -0400, Jeff Garzik wrote:
> James Bottomley wrote:
> > On Wed, 2007-09-26 at 03:35 -0400, Jeff Garzik wrote:
> >> sas_hash_addr() is the spec-defined standard hashing function. Make it
> >> available to drivers that need it.
> >
> > I'm not opposed in principle to expo
The SSP response DPRINTK in asd_get_response_tasklet() was printing
a hardcoded status result, rather than the status from the SSP
response IU.
Arguably, this should not be a DPRINTK either, since the admin might
want to know about this.
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
---
driver
On Sep 27, 2007, 18:46 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> On Fri, 28 Sep 2007 01:38:27 +0900
> FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
>
>> This patch is for Jens' block tree (sg chaining branch).
>>
>> I don't have the hardware but this looks like a bug.
>>
>> ---
>> From: FUJ
On Sun, 30 Sep 2007 03:57:07 -0700
Seokmann Ju <[EMAIL PROTECTED]> wrote:
> FUJITA Tomonori wrote:
> > On Thu, 27 Sep 2007 07:34:52 -0700
> > Seokmann Ju <[EMAIL PROTECTED]> wrote:
> >
> >> FUJITA Tomonori wrote:
> >>> On Fri, 21 Sep 2007 07:34:18 -0700
> >>> Seokmann Ju <[EMAIL PROTECTED]> wrote
FUJITA Tomonori wrote:
> On Thu, 27 Sep 2007 07:34:52 -0700
> Seokmann Ju <[EMAIL PROTECTED]> wrote:
>
>> FUJITA Tomonori wrote:
>>> On Fri, 21 Sep 2007 07:34:18 -0700
>>> Seokmann Ju <[EMAIL PROTECTED]> wrote:
>>>
Andrew Vasquez wrote:
> On Sat, 01 Sep 2007, FUJITA Tomonori wrote:
>
On Sun, Sep 30, 2007 at 12:13:55AM -0700, Darrick J. Wong wrote:
> Actually, SMP commands are used during device discovery to find
> things attached to expanders, so it seems likely that "it blows up
> almost immediately after loading the module" symptoms are a result
> of this bug.
>
> That said
On Sat, Sep 29, 2007 at 02:25:33AM -0400, Jeff Garzik wrote:
> Muli Ben-Yehuda wrote:
>> On Fri, Sep 28, 2007 at 04:55:34PM -0700, Darrick J. Wong wrote:
>>> On Thu, Sep 27, 2007 at 10:33:41PM -0400, Jeff Garzik wrote:
Unless I'm missing something, the SMP request goes /to/ the PCI device
>>>
42 matches
Mail list logo
