Re: mptsas related problem [2.6.22], LSI SAS1064ET PCI-E

2007-09-17 Thread Arkadiusz Miskiewicz
On Monday 10 of September 2007, Arkadiusz Miskiewicz wrote: > Hello, > > SR2520SAXS platform (S5000VSA mainboard in 2U SR2520 chassis) with > > 08:00.0 SCSI storage controller: LSI Logic / Symbios Logic SAS1064ET > PCI-Express Fusion-MPT SAS (rev 02) > > onboard (well afaik on backplane) and four S

RE: [PATCH] aic94xx: fix smartctl utility problem

2007-09-17 Thread James Bottomley
On Mon, 2007-09-17 at 18:43 -0700, Wu, Gilbert wrote: > ata_task_return code=0 > ** cmd success then the no ATA > output register return. > scsi 2:0:0:0: CD-ROMPLEXTOR DVDR PX-755A 1.02 PQ: 0 > ANSI: 5 > scsi 2:0:0:0: Attached scsi generic sg2 type 5 > ata command=a0 >

[PATCH 9/9] mpt fusion: error recovery improvements, and synchronizing internal commands

2007-09-17 Thread Eric Moore
1) move mptscsih_quiesce_raid over to mptscsih.c 2) cleanup ioc_reset callback handlers, introducing wrappers for synchronizing error recovery (mpt_set_taskmgmt_in_progress_flag, mpt_clear_taskmgmt_in_progress_flag), as the fusion firmware only handles one task management request at a time. Si

[PATCH 7/9] mpt fusion: error recovery improvements, and synchronizing internal commands

2007-09-17 Thread Eric Moore
1) cleanup ioc_reset callback handlers, introducing wrappers for synronizing error recovery (mpt_set_taskmgmt_in_progress_flag, mpt_clear_taskmgmt_in_progress_flag), as the fusion firmware only handles one task management request at a time. 2) rewrite of all internal generated functions that iss

[PATCH 6/9] mpt fusion: error recovery improvements, and synchronizing internal commands

2007-09-17 Thread Eric Moore
1) cleanup ioc_reset callback handlers, introducing wrappers for synronizing error recovery (mpt_set_taskmgmt_in_progress_flag, mpt_clear_taskmgmt_in_progress_flag), as the fusion firmware only handles one task management request at a time. 2) set vtarget->deleted flag when devices have been rem

[PATCH 5/9] mpt fusion: error recovery improvements, and synchronizing internal commands

2007-09-17 Thread Eric Moore
1) rewrite of ioctl_cmds internal generated function that issue commands to firmware, porting them to be single threaded using the generic MPT_MGMT struct. 2) added seperate callback handler for ioctl task managment (mptctl_taskmgmt_reply), to handle command that timeout 3) rewrite mptctl_bus_res

[PATCH 3/9] mpt fusion: locking down ScsiLookup

2007-09-17 Thread Eric Moore
ScsiLookup is an array of pending scmd pointers that the scsi lld maintains. This array is touched from queuecommand, eh threads, and interrupt context. This array should put under locks, hence this patch to synchronize its access. I've added some nice little function wrappers for this, and mov

[PATCH 2/9] mpt fusion: Fixing sparse warnings

2007-09-17 Thread Eric Moore
List below is output from C=2 sparse compilation, which are fixed with this patch. 1) mptspi: pg0 is defined in x86 version of include/asm/pgtable.h 2) mptsas: context imbalance in 'mptsas_probe' different lock contexts for basic block 3) mptbase: from mpt_attach - cast adds address space to exp

[PATCH 1/9] mpt fusion: adding usage of shost_priv and removing all the typecasting

2007-09-17 Thread Eric Moore
The driver is currently typecasting to obtain the shost hostdata. The driver is updated to use the shost_priv macro. Signed-off-by: Eric Moore <[EMAIL PROTECTED]> diff -uarpN b/drivers/message/fusion/mptctl.c a/drivers/message/fusion/mptctl.c --- b/drivers/message/fusion/mptctl.c 2007-09-17 10

[PATCH 0/9] mpt fusion

2007-09-17 Thread Eric Moore
These set of patchs are for scsi-misc git, hence post 2.6.23 kernels. 1) adding usage of shost_priv and removing all the typecasting 2) Fixing sparse warnings 3) locking down ScsiLookup 4-9) error recovery improvements, and synchronizing internal commands (6 seperate patchs) - To unsubscribe from

RE: [PATCH] aic94xx: fix smartctl utility problem

2007-09-17 Thread Wu, Gilbert
Hi James, The ATA PACKET COMMAND should return with good status and ATA output register if the CSMI_TASK is set. But you debug message shown the ATA PACKET COMMAND got command timeout. Not sure the firmware fails to deliver ATA PACKET command or output ATA register. Only the SAS trace can help so

RE: [PATCH] aic94xx: fix smartctl utility problem

2007-09-17 Thread James Bottomley
On Mon, 2007-09-17 at 13:53 -0700, Wu, Gilbert wrote: >I tested the SATA DVD Plextor model 716SA and 755SA with direct > attached. Both failed in my tested system and it end up with System > Panic even without my patch. Actually, because of the difficulty of wiring it up, I've not tried direct

[PATCH -mm][resend] mpt fusion: Shut up uninitialized variable warnings

2007-09-17 Thread Satyam Sharma
drivers/message/fusion/mptctl.c: In function ‘mptctl_mpt_command’: drivers/message/fusion/mptctl.c:1764: warning: ‘bufIn.len’ may be used uninitialized in this function drivers/message/fusion/mptctl.c:1765: warning: ‘bufOut.len’ may be used uninitialized in this function come because gcc gets c

[PATCH 1/1] stale residual returned on write following BUSY retry

2007-09-17 Thread Michael Reed
A BUSY status returned on a write request results in a stale residual being returned when the write ultimately successfully completes. This can be reproduced as follows: 1) issue immediate mode rewind to scsi tape drive 2) issue write request The tape drive returns busy. The low level driver de

Re: [patchset 0/24] Lots of the Accessors patches and !use_sg cleanup

2007-09-17 Thread Jeff Garzik
James Bottomley wrote: On Mon, 2007-09-17 at 16:57 -0400, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: On Monday 17 September 2007, James Bottomley wrote: Realistically (and I hate myself for saying this) libata-pata does provide a much better alternative for the ATAPI devices. Is it j

Re: [patchset 0/24] Lots of the Accessors patches and !use_sg cleanup

2007-09-17 Thread James Bottomley
On Mon, 2007-09-17 at 16:57 -0400, Jeff Garzik wrote: > Bartlomiej Zolnierkiewicz wrote: > > On Monday 17 September 2007, James Bottomley wrote: > >> Realistically (and I hate myself for saying this) libata-pata does > >> provide a much better alternative for the ATAPI devices. Is it just > >> tim

Re: [patchset 0/24] Lots of the Accessors patches and !use_sg cleanup

2007-09-17 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: On Monday 17 September 2007, James Bottomley wrote: Realistically (and I hate myself for saying this) libata-pata does provide a much better alternative for the ATAPI devices. Is it just time to recognise the inevitable and kill ide-scsi? Agreed, libata-pata i

RE: [PATCH] aic94xx: fix smartctl utility problem

2007-09-17 Thread Wu, Gilbert
Hi All, I tested the SATA DVD Plextor model 716SA and 755SA with direct attached. Both failed in my tested system and it end up with System Panic even without my patch. The CSMI_TASK should not make any difference between ATA and ATAPI device. I am digging into it for root cause. Thanks! Gilbe

Re: command failing at iSCSI disconnect

2007-09-17 Thread Mike Christie
FUJITA Tomonori wrote: On Fri, 14 Sep 2007 14:43:43 -0700 Dave Jiang <[EMAIL PROTECTED]> wrote: I'm using the latest linus git tree. This is in fileio mode with IOMode=wb. It seems that if I do I/O and then immediately disconnect then the cache sync commands fail. Is this expected behavior or s

Re: [patchset 0/24] Lots of the Accessors patches and !use_sg cleanup

2007-09-17 Thread Bartlomiej Zolnierkiewicz
On Monday 17 September 2007, James Bottomley wrote: > On Mon, 2007-09-17 at 12:46 +0200, Bartlomiej Zolnierkiewicz wrote: > > 0024 drivers/scsi/ide-scsi.c - Bartlomiej Zolnierkiewicz > > <[EMAIL PROTECTED]> > > > > This reminds me that ide-scsi needs a real Maintainer, I don't have a > > time to

Re: CONFIG_BLK_DEV_BSG=n

2007-09-17 Thread David Howells
James Bottomley <[EMAIL PROTECTED]> wrote: > > Which solution would you be more comfortable with? > > The one which is currently in -mm is this one: > > http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=49892223f7d3a2333ef9e6cbdd526676e1fc517a In my opinion, this is t

Re: [RFC PATCH] SCSI: split Kconfig menu into two

2007-09-17 Thread Stefan Richter
Maciej W. Rozycki wrote: > SCSI is a generic peripheral bus No, not anymore. http://www.t10.org/scsi-3.htm > (recall the expansion of the acronym). The expansion of the acronym doesn't fit anymore to what SCSI is today, or even to what it became already circa 10 years ago. > Even though proba

Re: 2.6.23-rc4-mm1

2007-09-17 Thread FUJITA Tomonori
On Mon, 17 Sep 2007 15:28:19 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > On Sat, Sep 15 2007, FUJITA Tomonori wrote: > > On Fri, 14 Sep 2007 21:16:35 -0700 > > Paul Jackson <[EMAIL PROTECTED]> wrote: > > > > > FUJITA Tomonori wrote: > > > > Can you try this patch (against 2.6.23-rc4-mm1)? > > >

Re: [patchset 0/24] Lots of the Accessors patches and !use_sg cleanup

2007-09-17 Thread James Bottomley
On Mon, 2007-09-17 at 12:46 +0200, Bartlomiej Zolnierkiewicz wrote: > 0024 drivers/scsi/ide-scsi.c - Bartlomiej Zolnierkiewicz > <[EMAIL PROTECTED]> > > This reminds me that ide-scsi needs a real Maintainer, I don't have a > time to > closely follow-up SCSI changes... Er, well, I thought it had

Re: 2.6.23-rc4-mm1

2007-09-17 Thread Jens Axboe
On Sat, Sep 15 2007, FUJITA Tomonori wrote: > On Fri, 14 Sep 2007 21:16:35 -0700 > Paul Jackson <[EMAIL PROTECTED]> wrote: > > > FUJITA Tomonori wrote: > > > Can you try this patch (against 2.6.23-rc4-mm1)? > > > > > > >From 592bd2049cb3e6e1f1dde7cf631879f26ddffeaa Mon Sep 17 00:00:00 2001 > > >

Re: [PATCH 16/22] advansys: Eliminate prototypes

2007-09-17 Thread Matthew Wilcox
On Mon, Sep 17, 2007 at 08:17:21AM +0900, FUJITA Tomonori wrote: > I updated the previous patch for your latest patchset. I removed the > sg chaining support so you can send it to scsi-misc now. > > Just a one-line patch is necessary for the sg chaining support. It'll > be push to mainline via Jen

Re: [patchset 0/24] Lots of the Accessors patches and !use_sg cleanup

2007-09-17 Thread Boaz Harrosh
On Mon, Sep 17 2007 at 12:46 +0200, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > On Tuesday 11 September 2007, Boaz Harrosh wrote: >> Here are more accessors patches. I have tried >> to find Maintainers of drivers but please help me if >> I missed any. > > [ ... ] > >> 0010 dri

Re: [RFC PATCH] SCSI: split Kconfig menu into two

2007-09-17 Thread Maciej W. Rozycki
On Sat, 15 Sep 2007, Stefan Richter wrote: > >> +menu "Storage (core and SCSI commands)" > >> > >> config SCSI > >> - tristate "SCSI device support" > >> + tristate "Storage support (core and SCSI commands)" > >>depends on BLOCK > >>select SCSI_DMA if HAS_DMA > >>---help--- > >> .

Re: [PATCH 24/24] ide-scsi.c: convert to data accessors and !use_sg cleanup

2007-09-17 Thread Bartlomiej Zolnierkiewicz
On Wednesday 12 September 2007, Boaz Harrosh wrote: > > - Convert ide-scsi to the new data accessors and cleanup >the !use_sg code paths. > > Inspecting old code I can see places that still assume > scsi_cmnd->request_buffer is a linear char pointer. Though I > admit this assumption is

Re: [patchset 0/24] Lots of the Accessors patches and !use_sg cleanup

2007-09-17 Thread Bartlomiej Zolnierkiewicz
On Tuesday 11 September 2007, Boaz Harrosh wrote: > Here are more accessors patches. I have tried > to find Maintainers of drivers but please help me if > I missed any. [ ... ] > 0010 drivers/scsi/eata_pio.c - Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> > ? not me, according to MAINTAINTERS