On Sun, 2007-09-16 at 19:01 -0400, Douglas Gilbert wrote:
> James Bottomley wrote:
> > On Sat, 2007-09-15 at 12:05 -0500, James Bottomley wrote:
> >> On Fri, 2007-09-14 at 10:58 -0700, Gilbert Wu wrote:
> >>> Fixed the problem that "smartctl -a /dev/some_sata_disk -d ata" does
> >>> not work on SA
On Sun, 16 Sep 2007 17:03:50 -0600
Matthew Wilcox <[EMAIL PROTECTED]> wrote:
> On Mon, Sep 17, 2007 at 07:41:06AM +0900, FUJITA Tomonori wrote:
> > On Sun, 16 Sep 2007 09:31:34 -0600
> > Matthew Wilcox <[EMAIL PROTECTED]> wrote:
> >
> > > On Sat, Sep 15, 2007 at 09:39:05AM -0500, James Bottomley
On Mon, Sep 17, 2007 at 07:41:06AM +0900, FUJITA Tomonori wrote:
> On Sun, 16 Sep 2007 09:31:34 -0600
> Matthew Wilcox <[EMAIL PROTECTED]> wrote:
>
> > On Sat, Sep 15, 2007 at 09:39:05AM -0500, James Bottomley wrote:
> > > I get a compile failure at this point in your patch sequence:
> >
> > Than
James Bottomley wrote:
> On Sat, 2007-09-15 at 12:05 -0500, James Bottomley wrote:
>> On Fri, 2007-09-14 at 10:58 -0700, Gilbert Wu wrote:
>>> Fixed the problem that "smartctl -a /dev/some_sata_disk -d ata" does
>>> not work on SATA device. ( The smartctl v5.38 does need "-d ata"
>>> option.)
>>>
On Sat, Sep 15, 2007 at 06:23:13PM +0200, Adrian Bunk wrote:
>
> @Greg:
> Do you have any numbers regarding how your "Linux Kernel in a Nutshell"
> is selling?
It is selling reasonably well for an O'Reilly book from what I have been
told. But I have not seen any real numbers yet.
> Even downlo
On Sun, 16 Sep 2007 09:31:34 -0600
Matthew Wilcox <[EMAIL PROTECTED]> wrote:
> On Sat, Sep 15, 2007 at 09:39:05AM -0500, James Bottomley wrote:
> > I get a compile failure at this point in your patch sequence:
>
> Thanks. I'd been compiling with CONFIG_ISA=n, so hadn't spotted these
> two proble
asc_board_t was simply a typedef for struct asc_board. ASC_BOARDP()
can be replaced by shost_priv() except in the ASC_STATS* macros which
rely on the cast; add an explicit cast there.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c | 132 ++-
James Bottomley wrote:
On Sat, 2007-09-15 at 12:05 -0500, James Bottomley wrote:
On Fri, 2007-09-14 at 10:58 -0700, Gilbert Wu wrote:
Fixed the problem that "smartctl -a /dev/some_sata_disk -d ata" does
not work on SATA device. ( The smartctl v5.38 does need "-d ata"
option.)
The aic94xx nee
On Sat, 2007-09-15 at 12:05 -0500, James Bottomley wrote:
> On Fri, 2007-09-14 at 10:58 -0700, Gilbert Wu wrote:
> > Fixed the problem that "smartctl -a /dev/some_sata_disk -d ata" does
> > not work on SATA device. ( The smartctl v5.38 does need "-d ata"
> > option.)
> > The aic94xx need to retu
On Sun, Sep 16, 2007 at 09:37:41AM -0600, Matthew Wilcox wrote:
> @@ -2475,7 +2469,7 @@ typedef struct adv_req {
> * of the 'Scsi_Host' structure starting at the 'hostdata'
> * field. It is guaranteed to be allocated from DMA-able memory.
> */
> -typedef struct asc_board {
> +struct asc_board
Cleanup a few typos in megaraid
Signed-off-by: dann frazier <[EMAIL PROTECTED]>
diff --git a/drivers/scsi/megaraid/megaraid_mbox.c
b/drivers/scsi/megaraid/megaraid_mbox.c
index c6a53dc..4963b96 100644
--- a/drivers/scsi/megaraid/megaraid_mbox.c
+++ b/drivers/scsi/megaraid/megaraid_mbox.c
@@ -500
The board lock was essentially identical with the host lock.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c | 21 +
1 files changed, 5 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 95df291.
Replace ASC_DBG{,1,2,3,4,5} with a single variadic macro ASC_DBG. As
suggested by Jeff Garzik, include DRV_NAME and __FUNCTION__ in the output.
Change all callers to no longer include the function name in the string.
Enabling ADVANSYS_DEBUG to test this feature shows a lot of other problems
that
The interrupt number was being stored in 4-5 different places, each with
its own type, rules and usage. Fix this by keeping an unsigned int in
the struct asc_board, and filling it in from the bus probe functions
(since it's different for each of the four bus types). In order to do
this, we have t
With the ASC and ADV libraries merged into the driver, there really is
no point in reporting their version numbers, or even trying to maintain
them.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c | 60 +++---
1 files changed
It's somewhat neater to make this a pointer to one of two tables
than initialising an array in the driver. Also delete the unused
AscSynIndexToPeriod and rename host_init_sdtr_index to min_sdtr_index
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c | 90 +++
It's always a mistake to have your own index of boards; just use the
scsi host number.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c | 236 ---
1 files changed, 100 insertions(+), 136 deletions(-)
diff --git a/drivers/s
There were two blocks of ASC_IERR definitions; one for narrow and one for
wide boards. Some of the same names were used (with the same values),
and some of the same values were used with different names. This could
only lead to confusion, so I unified them in one block of definitions
with no over
This rather complex function boiled down to calling virt_to_bus().
Also get rid of some obsolete defines and variables that could never vary.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c | 73 ++-
1 files changed, 3 in
board->carrp is a duplicate of asc_dvc->carrier_buf, so cut out the
middle-man and assign directly to carrier_buf. Move orig_reqp to adv_dvc
too, since it's wide-board specific. Also eliminate an unnecessary BUG_ON
(we'll never get there with a NULL carrier_buf, and will crash if we do).
The bulk
asc_board_t was simply a typedef for struct asc_board. ASC_BOARDP()
can be replaced by shost_priv() except in the ASC_STATS* macros which
rely on the cast; add an explicit cast there.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c | 132 ++-
The narrow board used two global structures to set up a command;
unfortunately they weren't locked, so with two boards in the machine,
one call to queuecommand could corrupt the data being used by the other
call to queuecommand.
Fix this by allocating asc_scsi_q on the stack (64 bytes) and using k
- Don't need to set ASC_HOST_IN_RESET any more
- Don't need to test scp->device->host for NULL -- if it's NULL, we
couldn't've been called.
- Use scmd_printk instead of ASC_PRINT
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c | 83 ---
The wide and narrow boards share identical handling of the return value,
except for some trivial error messages. Move the handling to the common
end of the function. Also move variable declarations to the arms of
the `if' that they're used in and delete some pointless comments.
Signed-off-by: Ma
The driver was saving a scsi_device for each target, but wasn't doing
anything useful with them. Just delete the array.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c | 10 --
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/drivers/scsi/ad
It was only ever set; never tested, nor cleared.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 52ea41d..5e6bcf2 100644
--- a/drivers/sc
Replace it with !ASC_NARROW_BOARD
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 5e6bcf2..a5bb4e4 100644
--- a/drivers/scsi/advansys.
On Sat, Sep 15, 2007 at 09:39:05AM -0500, James Bottomley wrote:
> I get a compile failure at this point in your patch sequence:
Thanks. I'd been compiling with CONFIG_ISA=n, so hadn't spotted these
two problems. I've set it back to Y now.
> I've put 1-15 in .. could you rebase against scsi-mis
28 matches
Mail list logo
