Re: [PATCH] Fix race with shared tag queue maps

2007-09-13 Thread Arkadiusz Miskiewicz
On Thursday 13 of September 2007, Jens Axboe wrote: > Hi, > > There's a race condition in blk_queue_end_tag() for shared tag maps, > users include stex (promise supertrak thingy) and qla2xxx. [...] > I'm cc'ing users that reported stex > problems, hopefully they can test this patch and report back

Re: switch sdev sysfs attributes to default attributes

2007-09-13 Thread Kay Sievers
On Thu, 2007-09-13 at 14:29 +0100, Christoph Hellwig wrote: > On Tue, Sep 11, 2007 at 05:00:14PM +0200, Kay Sievers wrote: > > From: Kay Sievers <[EMAIL PROTECTED]> > > Subject: [SCSI] switch sdev sysfs attributes to default attributes > > > > This removes the unused sysfs attribute overwriting lo

Re: 2.6.23-rc4-mm1

2007-09-13 Thread Andy Whitcroft
On Tue, Sep 11, 2007 at 04:10:47AM +0900, FUJITA Tomonori wrote: > > The only patch which touches qla1280 is git-block.patch. From a quick > > squizz the change looks OK, although it's tricky and something might have > > broken. > > Can you try this patch (against 2.6.23-rc4-mm1)? Yep this patc

[PATCH 4/4] scsi: megaraid_sas - update version and Changelog

2007-09-13 Thread linux-box
Update version and Changelog Signed-off-by: Bo Yang <[EMAIL PROTECTED]> --- Re-submitting Documentation/scsi/ChangeLog.megaraid_sas | 211 drivers/scsi/megaraid/megaraid_sas.c |2 drivers/scsi/megaraid/megaraid_sas.h |6 3 files changed, 215 insertions(+)

[PATCH 3/4] scsi: megaraid_sas - add module param max_sectors, cmd_per_lun

2007-09-13 Thread linux-box
Adding module parameters to configure max sectors per request & # of cmds for each lun. Signed-off-by: Bo Yang <[EMAIL PROTECTED]> --- Re-submitting drivers/scsi/megaraid/megaraid_sas.c | 93 - drivers/scsi/megaraid/megaraid_sas.h |2 2 files changed, 93 insertion

PATCH 2/4] scsi: megaraid_sas -- add module param fast_load

2007-09-13 Thread linux-box
Driver will skip physical devices scan for the first time if the fast_load is set Signed-off-by: Bo Yang <[EMAIL PROTECTED]> --- drivers/scsi/megaraid/megaraid_sas.c | 69 +++-- 1 files changed, 55 insertions(+), 14 deletions(-) diff -rupN linux-2.6.22_orig/drivers/scsi/m

[PATCH 1/4] scsi: megaraid_sas -- add hibernation support

2007-09-13 Thread linux-box
The megaraid_sas driver doesn't support the hibernation, the suspend/resume routine implemented to support the hibernation. Signed-off-by: Bo Yang <[EMAIL PROTECTED]> --- drivers/scsi/megaraid/megaraid_sas.c | 309 +++-- drivers/scsi/megaraid/megaraid_sas.h |1 2 file

Re: [PATCH] Fix race with shared tag queue maps

2007-09-13 Thread Linus Torvalds
On Thu, 13 Sep 2007, Jens Axboe wrote: > > My bad, I think I added the smp_mb__before_clear_bit() when it was > __test_and_set_bit() like in the first hunk. Ahh, that wouldn't work at all. The "__test_and_set_bit()" thing isn't atomic at all, and no amount of memory barriers around it would he

Re: [PATCH] Fix race with shared tag queue maps

2007-09-13 Thread Jens Axboe
On Thu, Sep 13 2007, Linus Torvalds wrote: > > > On Thu, 13 Sep 2007, Jens Axboe wrote: > > + > > + /* > > +* Ensure ordering with tag section > > +*/ > > + smp_mb__before_clear_bit(); > > + > > + if (unlikely(!test_and_clear_bit(tag, bqt->tag_map))) { > > You don't need the "smp_m

Re: [linux-usb-devel] Problems with USB disk [solved]

2007-09-13 Thread Mark Lord
Alan Stern wrote: On Thu, 13 Sep 2007, Mark Lord wrote: .. What happens is, there's a nice little LED on the Cruzer stick, that is "lit" when the stick itself is not in a "power suspend" state (or whatever you USB folks call it). We call it "suspended". (Wasn't there an episode of Classic Tr

Re: [PATCH] Fix race with shared tag queue maps

2007-09-13 Thread Linus Torvalds
On Thu, 13 Sep 2007, Jens Axboe wrote: > + > + /* > + * Ensure ordering with tag section > + */ > + smp_mb__before_clear_bit(); > + > + if (unlikely(!test_and_clear_bit(tag, bqt->tag_map))) { You don't need the "smp_mb__before_clear_bit()" there. The regular "clear_bit()"

Re: [linux-usb-devel] Problems with USB disk [solved]

2007-09-13 Thread Alan Stern
On Thu, 13 Sep 2007, Mark Lord wrote: > Alan Stern wrote: > > On Wed, 12 Sep 2007, Mark Lord wrote: > > > >> Chuck Ebbert wrote: > .. > >>> Oh, nice. The usb-storage (SCSI) disk spins itself down and we can't > >>> handle that. > >>> Should we be disabling auto-spindown when we connect the devic

Re: [1/4] 2.6.23-rc6: known regressions

2007-09-13 Thread James Bottomley
On Thu, 2007-09-13 at 07:41 -0700, Greg KH wrote: > On Thu, Sep 13, 2007 at 10:19:48AM -0400, Alan Stern wrote: > > On Thu, 13 Sep 2007, Greg KH wrote: > > > > > Ok, after conferring with Oliver this morning, I think the best solution > > > here is to both revert the usb-storage suspend patch as i

Re: [1/4] 2.6.23-rc6: known regressions

2007-09-13 Thread Greg KH
On Thu, Sep 13, 2007 at 10:19:48AM -0400, Alan Stern wrote: > On Thu, 13 Sep 2007, Greg KH wrote: > > > Ok, after conferring with Oliver this morning, I think the best solution > > here is to both revert the usb-storage suspend patch as it has some > > basic problems that can cause data loss, _and

Re: [linux-usb-devel] Problems with USB disk [solved]

2007-09-13 Thread Mark Lord
Alan Stern wrote: On Wed, 12 Sep 2007, Mark Lord wrote: Chuck Ebbert wrote: .. Oh, nice. The usb-storage (SCSI) disk spins itself down and we can't handle that. Should we be disabling auto-spindown when we connect the device, or be able to handle this by sending the start command when needed

Re: [1/4] 2.6.23-rc6: known regressions

2007-09-13 Thread Alan Stern
On Thu, 13 Sep 2007, Greg KH wrote: > Ok, after conferring with Oliver this morning, I think the best solution > here is to both revert the usb-storage suspend patch as it has some > basic problems that can cause data loss, _and_ add the change to the > kernel that by default disables autosuspend

Re: [linux-usb-devel] Problems with USB disk [solved]

2007-09-13 Thread Alan Stern
On Wed, 12 Sep 2007, Mark Lord wrote: > Chuck Ebbert wrote: > >>> = > >>> sd 1:0:0:0: Device not ready: <6>: Current: sense key=0x2 > >>> ASC=0x4 ASCQ=0x2 > >>> end_request: I/O error, dev sda, sector 126693711 > >>> sd 1:0:0:0: Device not ready: <6>: Current: sense key=0x2 > >>>

Re: switch sdev sysfs attributes to default attributes

2007-09-13 Thread Christoph Hellwig
On Tue, Sep 11, 2007 at 05:00:14PM +0200, Kay Sievers wrote: > From: Kay Sievers <[EMAIL PROTECTED]> > Subject: [SCSI] switch sdev sysfs attributes to default attributes > > This removes the unused sysfs attribute overwriting logic for most of > the attributes, and plugs them into the driver core

[PATCH] Fix race with shared tag queue maps

2007-09-13 Thread Jens Axboe
Hi, There's a race condition in blk_queue_end_tag() for shared tag maps, users include stex (promise supertrak thingy) and qla2xxx. The former at least has reported bugs in this area, not sure why we haven't seen any for the latter. It could be because the window is narrow and that other condition