On Mon, Sep 10, 2007 at 10:35:25PM +0300, Boaz Harrosh wrote:
> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> index 20a72aa..a02400c 100644
> --- a/drivers/scsi/scsi_error.c
> +++ b/drivers/scsi/scsi_error.c
> @@ -590,42 +590,23 @@ static void scsi_abort_eh_cmnd(struct scsi_c
On 9/10/07, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> On Mon, 10 Sep 2007 12:20:38 -0700
> Andrew Morton <[EMAIL PROTECTED]> wrote:
>
> > On Mon, 10 Sep 2007 20:59:49 +0200 "Torsten Kaiser" <[EMAIL PROTECTED]>
> > wrote:
> > > The system boots, reads the partition tables, starts the RAID and th
On Sun, 9 Sep 2007 08:53:58 -0600
Matthew Wilcox <[EMAIL PROTECTED]> wrote:
> Here's another mammoth patch series for the advansys driver against
> scsi-misc. I've tested that it compiles at each stage and that the
> final result works.
>
> Some important parts to note:
>
> 1/22 Essential bugfi
On Mon, 10 Sep 2007 12:20:38 -0700
Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Mon, 10 Sep 2007 20:59:49 +0200 "Torsten Kaiser" <[EMAIL PROTECTED]> wrote:
>
> > On 9/10/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
> > > On Mon, 10 Sep 2007 18:49:26 +0100 Andy Whitcroft <[EMAIL PROTECTED]>
> >
- Use new scsi_eh_prep/restor_cmnd() for synchronous
REQUEST_SENSE invocation.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/arm/fas216.c | 16 +++-
drivers/scsi/arm/fas216.h |3 +++
2 files changed, 6 insertions(+), 13 deletions(-)
diff --git a/driver
On 9/10/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Mon, 10 Sep 2007 20:59:49 +0200 "Torsten Kaiser" <[EMAIL PROTECTED]> wrote:
>
> > On 9/10/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
> > > On Mon, 10 Sep 2007 18:49:26 +0100 Andy Whitcroft <[EMAIL PROTECTED]>
> > > wrote:
> > I reported a
- Use new scsi_eh_prep/restor_cmnd() for synchronous
REQUEST_SENSE invocation.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/NCR5380.c | 23 +--
drivers/scsi/NCR5380.h |7 +++
drivers/scsi/atari_NCR5380.c | 23 -
- Use new scsi_eh_prep/restor_cmnd() for synchronous
REQUEST_SENSE invocation.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/usb/storage/transport.c | 46 +++---
1 files changed, 4 insertions(+), 42 deletions(-)
diff --git a/drivers/usb/stor
- Drivers/transports that want to send a synchronous REQUEST_SENSE command
as part of their .queuecommand sequence, have 2 new API's that facilitate
in doing so and abstract them from scsi-ml internals.
void scsi_eh_prep_cmnd(struct scsi_cmnd *scmd,
struct scsi_eh_save *sesci, u
- regrouped variables for easier reviewing of next patch
- Support of cmnd==NULL in call to scsi_send_eh_cmnd()
- In the copy_sense case set transfer size to the minimum
size of sense_buffer and passed copy_sense. cmnd[4] is
set accordingly.
- REQUEST_SENSE is set into cmnd[0] so i
On Mon, 10 Sep 2007 11:19:26 -0700
Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Mon, 10 Sep 2007 18:49:26 +0100 Andy Whitcroft <[EMAIL PROTECTED]> wrote:
>
> > I have a couple of old NUMA-Q systems which are unable to read their
> > boot disks with 2.6.23-rc4-mm1. The disks appear to be recogni
On Mon, 10 Sep 2007 20:59:49 +0200 "Torsten Kaiser" <[EMAIL PROTECTED]> wrote:
> On 9/10/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
> > On Mon, 10 Sep 2007 18:49:26 +0100 Andy Whitcroft <[EMAIL PROTECTED]> wrote:
> >
> > > I have a couple of old NUMA-Q systems which are unable to read their
> >
Thank you Christoph, Randy, Alen for your comments.
Here is ver 2 incorporating all your suggestions.
On Mon, Sep 10 2007 at 18:12 +0300, Christoph Hellwig <[EMAIL PROTECTED]> wrote:
> I think just struct "struct scsi_eh_save *save" is descriptive enough and
> almost fits on a line as well.. Also
On Mon, 10 Sep 2007 11:19:26 -0700
Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Mon, 10 Sep 2007 18:49:26 +0100 Andy Whitcroft <[EMAIL PROTECTED]> wrote:
>
> > I have a couple of old NUMA-Q systems which are unable to read their
> > boot disks with 2.6.23-rc4-mm1. The disks appear to be recogni
On 9/10/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Mon, 10 Sep 2007 18:49:26 +0100 Andy Whitcroft <[EMAIL PROTECTED]> wrote:
>
> > I have a couple of old NUMA-Q systems which are unable to read their
> > boot disks with 2.6.23-rc4-mm1. The disks appear to be recognised and
> > even the part
On Mon, 10 Sep 2007 18:49:26 +0100 Andy Whitcroft <[EMAIL PROTECTED]> wrote:
> I have a couple of old NUMA-Q systems which are unable to read their
> boot disks with 2.6.23-rc4-mm1. The disks appear to be recognised and
> even the partition tables read correctly, and then they go pop:
>
> qla1
Hello,
SR2520SAXS platform (S5000VSA mainboard in 2U SR2520 chassis) with
08:00.0 SCSI storage controller: LSI Logic / Symbios Logic SAS1064ET
PCI-Express Fusion-MPT SAS (rev 02)
onboard (well afaik on backplane) and four SATA discs in various software
raids level (1, 5 and 10) per partition.
On Mon, 2007-09-10 at 10:03 -0700, Matthew Dharm wrote:
> On Mon, Sep 10, 2007 at 05:11:23PM +0300, Boaz Harrosh wrote:
> >
> > In motivation to abstract scsi_cmnd members and insulate
> > drivers/transports from scsi_cmnd internals. The last
> > place left was the REQUEST_SENSE sequence when done
On Mon, Sep 10, 2007 at 05:11:23PM +0300, Boaz Harrosh wrote:
>
> In motivation to abstract scsi_cmnd members and insulate
> drivers/transports from scsi_cmnd internals. The last
> place left was the REQUEST_SENSE sequence when done
> synchronous, by drivers.
This probably isn't serious, but I no
On Mon, 10 Sep 2007, Boaz Harrosh wrote:
> In motivation to abstract scsi_cmnd members and insulate
> drivers/transports from scsi_cmnd internals. The last
> place left was the REQUEST_SENSE sequence when done
> synchronous, by drivers.
>
> Also all these drivers would do a use_sg==0 command
> in
On Mon, 10 Sep 2007 17:23:52 +0300 Boaz Harrosh wrote:
Hi Boaz,
Just a small nit: several of the kernel-doc lines need ':' added.
See below.
> Sign-off-by Boaz Harrosh <[EMAIL PROTECTED]>
> ---
> drivers/scsi/scsi_error.c | 133
> +++--
> include/scsi
> +void scsi_eh_prep_cmnd(struct scsi_cmnd *scmd,
> + struct scsi_eh_save_cmnd_info *sesci, unsigned char *cmnd,
> + int cmnd_size, int copy_sense)
I think just struct "struct scsi_eh_save *save" is descriptive enough and
almost fits on a line as well.. Also continuation of the prototype
- Use new scsi_eh_prep/restor_cmnd() for synchronous
REQUEST_SENSE invocation.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/arm/fas216.c |5 ++---
drivers/scsi/arm/fas216.h |3 +++
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/arm/f
- Use new scsi_eh_prep/restor_cmnd() for synchronous
REQUEST_SENSE invocation.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/NCR5380.c | 25 +++--
drivers/scsi/NCR5380.h |7 +++
drivers/scsi/atari_NCR5380.c | 25 ++-
- Use new scsi_eh_prep/restor_cmnd() for synchronous
REQUEST_SENSE invocation.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/usb/storage/transport.c | 51 ++
1 files changed, 8 insertions(+), 43 deletions(-)
diff --git a/drivers/usb/stor
- Drivers/transports that want to send a synchronous REQUEST_SENSE command
as part of their .queuecommand sequence, have 2 new API's that facilitate
in doing so and abstract them from scsi-ml internals.
void scsi_eh_prep_cmnd(struct scsi_cmnd *scmd,
struct scsi_eh_save_cmnd_info
- regrouped variables for easier reviewing of next patch
- Support of cmnd==NULL in call to scsi_send_eh_cmnd()
- In the REQUEST_SENSE case set cmnd[4] to the size of
sense_buffer. It was previously set by caller but needed
to be in sync with sense_buffer size.
- Also save/restore
In motivation to abstract scsi_cmnd members and insulate
drivers/transports from scsi_cmnd internals. The last
place left was the REQUEST_SENSE sequence when done
synchronous, by drivers.
Also all these drivers would do a use_sg==0 command
invocation, preventing from doing cleanups on these
drive
On 09/10/2007 08:38 AM, Stefan Richter wrote:
Nevertheless we should try to arrange the menus in a way that makes
sense to as many people as possible. The difficulty is, different
environments call for different menu layouts, as your previous example
of SATA DVD-only boxes demonstrates.
Howeve
On Thu, 30 Aug 2007 13:29:37 +0200 Arkadiusz Miskiewicz <[EMAIL PROTECTED]>
wrote:
> On Wednesday 29 of August 2007, Jens Axboe wrote:
> > On Wed, Aug 29 2007, Arkadiusz Miskiewicz wrote:
> > > On Wednesday 29 of August 2007, Jens Axboe wrote:
> > > > On Wed, Aug 29 2007, Arkadiusz Miskiewicz wro
30 matches
Mail list logo
