Re: [PATCH] ppc sg chaining support fixes

2007-08-15 Thread Jens Axboe
On Thu, Aug 16 2007, FUJITA Tomonori wrote: > This is for the sglist branch in Jens' block git tree. > > --- > From 445923d1a8ff272293af3aadb6e58f82e6439e98 Mon Sep 17 00:00:00 2001 > From: FUJITA Tomonori <[EMAIL PROTECTED]> > Date: Thu, 16 Aug 2007 02:25:32 +0900 > Subject: [PATCH] ppc sg chaini

Re: [patch 0/4] aha152x.c - Cleanup, need help in testing and auditing

2007-08-15 Thread Randy Dunlap
On Thu, 19 Jul 2007 10:49:30 -0700 Randy Dunlap wrote: > On Thu, 19 Jul 2007 18:57:50 +0300 Boaz Harrosh wrote: > > > Randy Dunlap wrote: > > > > > > Yes, this problem has been around forever AFAIK. You didn't add > > > to it. > > Do we need to file a bug report in Bugzilla or something, so peo

RE: [patch 2/4] scsi: expose AN support to user space

2007-08-15 Thread Moore, Eric
On Wednesday, August 15, 2007 8:02 AM, James Bottomley wrote: > Actually, we just got a second potential consumer ... although I'll > reprod to have the reporter send it to the list. It's a device that > needs notice of report luns data changing. The proposed > mechanism looks > a bit narrow no

[PATCH] ppc sg chaining support fixes

2007-08-15 Thread FUJITA Tomonori
This is for the sglist branch in Jens' block git tree. --- >From 445923d1a8ff272293af3aadb6e58f82e6439e98 Mon Sep 17 00:00:00 2001 From: FUJITA Tomonori <[EMAIL PROTECTED]> Date: Thu, 16 Aug 2007 02:25:32 +0900 Subject: [PATCH] ppc sg chaining support fixes Signed-off-by: FUJITA Tomonori <[EMAIL

Re: An MCA ESP driver

2007-08-15 Thread David Miller
From: Matthew Wilcox <[EMAIL PROTECTED]> Date: Wed, 15 Aug 2007 11:26:00 -0600 > On Tue, Aug 07, 2007 at 12:26:04AM -0700, David Miller wrote: > > > - struct sbus_dma *dma; > > > + union { > > > + struct sbus_dma *sbus_dma; > > > + unsigned intx86_dma; > > > + }; > > >

[PATCH] Manage scsi_host correctly in 53c700-based drivers

2007-08-15 Thread Matthew Wilcox
Restructure the 53c700-based drivers so that: - They call scsi_host_alloc themselves rather than leaving it to NCR_700_detect. - NCR_700_detect now returns an int error rather than NULL, allowing drivers to do better error handling - hostdata is now allocated with the Scsi_Host rather th

[PATCH 2/3] iscsi tcp queue bidi

2007-08-15 Thread Pete Wyckoff
Mark queue_flags that bidirectional is acceptable for iscsi_tcp, as BSG will check to make sure this bit is set. Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]> --- drivers/scsi/iscsi_tcp.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/iscsi_tcp.c b/d

[PATCH 3/3] varlen bsg submit

2007-08-15 Thread Pete Wyckoff
Accept variable length SCSI commands through BSG. Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]> --- block/bsg.c | 19 +++ 1 files changed, 15 insertions(+), 4 deletions(-) diff --git a/block/bsg.c b/block/bsg.c index eb0aaf4..c72b4f9 100644 --- a/block/bsg.c +++ b/block/bsg.c

[PATCH 1/3] bsg bidi block pc

2007-08-15 Thread Pete Wyckoff
Set cmd_type on rq->next_rq to BLOCK_PC so that scsi_init_sgtable knows to look at req->data_len rather than nr_sectors. Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]> --- block/bsg.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/block/bsg.c b/block/bsg.c index ba4353a

[PATCH 0/3] bsg bidirectional and variable length commands

2007-08-15 Thread Pete Wyckoff
There are three patches here to enable using BSG to send SCSI commands across iscsi TCP that are bidirectional and/or use variable length CDBs. They sit on top of 2.6.23-rc2 plus Mike's iscsi git plus the 12 core patches that Boaz has for bidirectional support. They apply to stock 2.6.23-rc2 but

[PATCH] ide-scsi: Close narrow race in release

2007-08-15 Thread Matthew Wilcox
We were releasing the block devices before removing the host, so commands could still be coming in which would cause a panic. Just remove the host before releasing the block devices to close this race. Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> --- drivers/scsi/ide-scsi.c |2 +- 1 fil

[PATCH] ncr53c8xx: Call scsi_host_put in release

2007-08-15 Thread Matthew Wilcox
Since ncr53c8xx_attach() calls scsi_host_put(), make ncr53c8xx_release() call scsi_host_put() too, for symmetry. Both callers already expect it to put the host for them, so that works out nicely. While the zalon driver does 'use' the host pointer afterwards, it only compares it for equality and d

[PATCH] aha152x: Close narrow race in release

2007-08-15 Thread Matthew Wilcox
We were releasing the IRQ before removing the host, so commands could still be coming in which would never be seen by the interrupt handler. Just remove the host before releasing the IRQ to close this race. Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> --- drivers/scsi/aha152x.c |4 ++--

[PATCH] qlogicfas: Close narrow race in release

2007-08-15 Thread Matthew Wilcox
We were releasing the IRQ before removing the host, so commands could still be coming in which would never be seen by the interrupt handler. Just remove the host before releasing the IRQ to close this race. Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> --- drivers/scsi/qlogicfas.c |2 +-

[PATCH] simscsi: Free scsi host on error

2007-08-15 Thread Matthew Wilcox
If scsi_add_host returned an error, the host would never be freed. We need to call scsi_host_put() if an error happens. Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> --- arch/ia64/hp/sim/simscsi.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/ia64/hp/si

[PATCH] ibmmca: Stop leaking scsi_hosts on exit

2007-08-15 Thread Matthew Wilcox
There was a missing call to scsi_host_put() causing us to leak a scsi host every time this module was unloaded. Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> --- drivers/scsi/ibmmca.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/ibmmca.c b/drivers/scsi

[PATCH] aic94xx: Free scsi host on error

2007-08-15 Thread Matthew Wilcox
If an error occurred during initialisation, we would sometimes fail to call scsi_host_put() and thus end up with a leaked scsi_host. It was also possible to miss calling scsi_remove_host(). Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> --- drivers/scsi/aic94xx/aic94xx_init.c | 17 +

[PATCH] ips: Close narrow race in release

2007-08-15 Thread Matthew Wilcox
We were releasing the IRQ before removing the host, so commands could still be coming in which would never be seen by the interrupt handler. Just remove the host before releasing the IRQ to close this race. Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> --- drivers/scsi/ips.c |3 ++- 1 fil

Re: [patch 12/30] Fix drivers/scsi/fdomain.c CONFIG_PCI=n warnings

2007-08-15 Thread James Bottomley
On Wed, 2007-08-15 at 10:39 -0700, Andrew Morton wrote: > On Wed, 15 Aug 2007 11:35:49 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > > > On Fri, 2007-08-10 at 14:50 -0700, [EMAIL PROTECTED] wrote: > > > From: Gabriel C <[EMAIL PROTECTED]> > > > > > > I get this warnings on current git when C

Re: [patch 12/30] Fix drivers/scsi/fdomain.c CONFIG_PCI=n warnings

2007-08-15 Thread Andrew Morton
On Wed, 15 Aug 2007 11:35:49 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > On Fri, 2007-08-10 at 14:50 -0700, [EMAIL PROTECTED] wrote: > > From: Gabriel C <[EMAIL PROTECTED]> > > > > I get this warnings on current git when CONFIG_PCI is not set : > > > > drivers/scsi/fdomain.c:390: warning:

Re: An MCA ESP driver

2007-08-15 Thread Matthew Wilcox
On Tue, Aug 07, 2007 at 12:26:04AM -0700, David Miller wrote: > > - struct sbus_dma *dma; > > + union { > > + struct sbus_dma *sbus_dma; > > + unsigned intx86_dma; > > + }; > > }; > > Feel free to make this a "void *dma_cookie" or similar. > It's private to t

Re: [patch 12/30] Fix drivers/scsi/fdomain.c CONFIG_PCI=n warnings

2007-08-15 Thread James Bottomley
On Fri, 2007-08-10 at 14:50 -0700, [EMAIL PROTECTED] wrote: > From: Gabriel C <[EMAIL PROTECTED]> > > I get this warnings on current git when CONFIG_PCI is not set : > > drivers/scsi/fdomain.c:390: warning: 'PCI_dev' defined but not used > drivers/scsi/fdomain.c:1768: warning: 'fdomain_pci_tbl' d

Re: [patch 2/4] scsi: expose AN support to user space

2007-08-15 Thread Kristen Carlson Accardi
On Wed, 15 Aug 2007 09:01:49 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > On Wed, 2007-08-15 at 04:13 -0400, Jeff Garzik wrote: > > Kristen Carlson Accardi wrote: > > > If a scsi_device supports async notification for media change, then > > > let user space know this capability exists by cre

Re: [patch 1/4] libata: check for AN support

2007-08-15 Thread Kristen Carlson Accardi
On Wed, 15 Aug 2007 03:59:10 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Since I wanted to get in Tejun's ata_link changes before this, this will > require a rediff. > > But more importantly, as I was going to apply it I noticed another > problem: we need to verify that SiS and NVIDIA both

Re: [PATCH] make attribute_container_unregister() unconditionally wait for list empty

2007-08-15 Thread James Bottomley
On Wed, 2007-08-15 at 11:40 -0400, James Smart wrote: > James, > > >> > > Isn't a better way to handle it simply to give > >> > > transport_container_unregister() the semantics everyone is expecting > >> > > (i.e. to wait for everything to be tidied up and gone)? That way none > >> > > of the tra

[PATCH] make attribute_container_unregister() unconditionally wait for list empty

2007-08-15 Thread James Smart
James, >> > > Isn't a better way to handle it simply to give >> > > transport_container_unregister() the semantics everyone is expecting >> > > (i.e. to wait for everything to be tidied up and gone)? That way none >> > > of the transport classes needs updating, and we don't have to handle the >>

Retry counters in sd.c

2007-08-15 Thread Alan Stern
James (or anyone else who can answer): The retry counters in sd.c seem to be out of whack. For example, consider sd_read_capacity(). There's an explicit retry loop that runs 3 times, and inside it is a call to scsi_execute_req() with SD_MAX_RETRIES (= 5) as an argument. If for any reason the de

Re: Linux 2.6.23-rc3

2007-08-15 Thread Matthew Wilcox
On Wed, Aug 15, 2007 at 10:08:17AM -0400, Igor A. Nesterov wrote: > So would it be true to say that the fix for -EEXIST problem still has > not found its way to mainline kernel? I've been hit by this problem > after switching to Fedora 7, and currently running on Fedora > 2.6.21-1.3228 kernel patch

Re: [patch 2/4] scsi: expose AN support to user space

2007-08-15 Thread James Bottomley
On Wed, 2007-08-15 at 04:13 -0400, Jeff Garzik wrote: > Kristen Carlson Accardi wrote: > > If a scsi_device supports async notification for media change, then > > let user space know this capability exists by creating a new sysfs > > entry "media_change_notify", which will be 1 if it is supported,

Re: Linux 2.6.23-rc3

2007-08-15 Thread Tore Anderson
* Tore Anderson > I can confirm that this patch solves my problem without any side > effects (as far as I can tell). I'm sorry I have to retract this statement. When I did some changes on my storage array, it generated RSCNs and therefore I/O briefly failed, causing timeouts and path failov

[patch 09/10] m68k: Fix a few hickups in drivers/scsi/Kconfig

2007-08-15 Thread Geert Uytterhoeven
m68k: Fix a few hickups in drivers/scsi/Kconfig Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> --- drivers/scsi/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -1561,7 +1561,7 @@ config A3000_SCSI buil

Re: [patch 2/4] scsi: expose AN support to user space

2007-08-15 Thread Jeff Garzik
Kristen Carlson Accardi wrote: If a scsi_device supports async notification for media change, then let user space know this capability exists by creating a new sysfs entry "media_change_notify", which will be 1 if it is supported, and 0 if not supported. Create a routine which allows scsi device

Re: [patch 4/4] libata: send event when AN received

2007-08-15 Thread Jeff Garzik
applied the attached slightly modified patch. main changes: * SCSI stuff has not been applied yet, so libata's notify is a no-op for now * fixed endian bug in SDB FIS handling diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 757369e..c41bd2c 100644 --- a/drivers/ata/ahci.c +++ b/dri

Re: [patch 1/4] libata: check for AN support

2007-08-15 Thread Jeff Garzik
Kristen Carlson Accardi wrote: Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/libata-core.c === --- 2.6-gi