Re: [PATCH] do not export /usr/include/scsi in make headers_install

2007-08-10 Thread David Woodhouse
On Mon, 2007-08-06 at 15:02 +0200, Olaf Hering wrote: > On Mon, Aug 06, Christoph Hellwig wrote: > > > On Mon, Aug 06, 2007 at 02:45:46PM +0200, Olaf Hering wrote: > > > > > > glibc and make headers_install_all provide /usr/include/scsi > > > One of them has to go. > > > > > > A quick diff shows

Re: [patch 13/30] nsp32_restart_autoscsi(): remove error check

2007-08-10 Thread Adrian Bunk
On Fri, Aug 10, 2007 at 09:03:52PM -0400, James Bottomley wrote: > On Fri, 2007-08-10 at 14:50 -0700, [EMAIL PROTECTED] wrote: > > From: Adrian Bunk <[EMAIL PROTECTED]> > > > > The Coverity checker noted that we'll anyway Oops later when we ran into > > this condition - and the error check didn't

Re: [patch 05/30] drivers/scsi/pcmcia/nsp_cs.c: remove kernel 2.4 code

2007-08-10 Thread Adrian Bunk
On Fri, Aug 10, 2007 at 09:01:59PM -0400, James Bottomley wrote: > On Fri, 2007-08-10 at 14:50 -0700, [EMAIL PROTECTED] wrote: > > From: Adrian Bunk <[EMAIL PROTECTED]> > > You're not just removing the 2.4 code ... you're also removing the rcs > tags ... that's OK if the maintainer is fine with th

Re: [patch 10/30] megaraid: add CERC_ATA100 support

2007-08-10 Thread James Bottomley
On Fri, 2007-08-10 at 15:36 -0700, Andrew Morton wrote: > On Fri, 10 Aug 2007 16:20:54 -0600 > "Patro, Sumant" <[EMAIL PROTECTED]> wrote: > > > ID being added is already supported in megaraid_mbox driver. > > umm, why should that cause us to avoid supporting it in the old driver? Because we'll h

Re: [patch 13/30] nsp32_restart_autoscsi(): remove error check

2007-08-10 Thread James Bottomley
On Fri, 2007-08-10 at 14:50 -0700, [EMAIL PROTECTED] wrote: > From: Adrian Bunk <[EMAIL PROTECTED]> > > The Coverity checker noted that we'll anyway Oops later when we ran into > this condition - and the error check didn't prevent that. > > Considering that the error condition shouldn't be possib

Re: [patch 05/30] drivers/scsi/pcmcia/nsp_cs.c: remove kernel 2.4 code

2007-08-10 Thread James Bottomley
On Fri, 2007-08-10 at 14:50 -0700, [EMAIL PROTECTED] wrote: > From: Adrian Bunk <[EMAIL PROTECTED]> You're not just removing the 2.4 code ... you're also removing the rcs tags ... that's OK if the maintainer is fine with this, but it would help to say this in the change log. James - To unsubscr

Re: [patch 20/30] drivers/scsi/gdth.c: kmalloc + memset conversion to kzalloc

2007-08-10 Thread James Bottomley
On Fri, 2007-08-10 at 14:50 -0700, [EMAIL PROTECTED] wrote: > From: Mariusz Kozlowski <[EMAIL PROTECTED]> > > drivers/scsi/gdth.c | 189401 -> 189342 (-59 bytes) > drivers/scsi/gdth.o | 331028 -> 330324 (-704 bytes) For the second time of asking, could I just have a single patch doing this globa

RE: [patch 10/30] megaraid: add CERC_ATA100 support

2007-08-10 Thread Patro, Sumant
> -Original Message- > From: Andrew Morton [mailto:[EMAIL PROTECTED] > Sent: Friday, August 10, 2007 3:36 PM > To: Patro, Sumant > Cc: [EMAIL PROTECTED]; linux-scsi@vger.kernel.org; > [EMAIL PROTECTED]; [EMAIL PROTECTED]; > Kolli, Neela; Yang, Bo > Subject: Re: [patch 10/30] megaraid:

Re: Partition information lost on reboot.

2007-08-10 Thread Rene Herman
On 08/10/2007 02:30 PM, Michal Piotrowski wrote: [Adding linux-scsi and Adaptec support to CC] On 10/08/07, Jegadeesh <[EMAIL PROTECTED]> wrote: Hi, I have a scsi disk on Adaptec ASC-29320 U320. I have created a linux partition and ext3 filesystem over it. Now the problem is, whenever the mac

Re: [patch 10/30] megaraid: add CERC_ATA100 support

2007-08-10 Thread Andrew Morton
On Fri, 10 Aug 2007 16:20:54 -0600 "Patro, Sumant" <[EMAIL PROTECTED]> wrote: > ID being added is already supported in megaraid_mbox driver. umm, why should that cause us to avoid supporting it in the old driver? - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body

RE: [patch 10/30] megaraid: add CERC_ATA100 support

2007-08-10 Thread Patro, Sumant
NACK. ID being added is already supported in megaraid_mbox driver. --Sumant -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of [EMAIL PROTECTED] Sent: Friday, August 10, 2007 2:51 PM To: [EMAIL PROTECTED] Cc: linux-scsi@vger.kernel.org; [EMAIL PROTECTED];

RE: [patch 24/30] drivers/scsi/megaraid.c: kmalloc + memset conversion to kzalloc

2007-08-10 Thread Patro, Sumant
ACK. --Sumant -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of [EMAIL PROTECTED] Sent: Friday, August 10, 2007 2:51 PM To: [EMAIL PROTECTED] Cc: linux-scsi@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: [patch 24/30] drivers/scsi/megaraid

[patch 17/30] Use mutex instead of semaphore in the OnStream SCSI Tape driver

2007-08-10 Thread akpm
From: Matthias Kaehlcke <[EMAIL PROTECTED]> The OnStream SCSI Tape driver uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]> Reviewed-by: Satyam Sharma <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTE

[patch 25/30] drivers/scsi/dpt_i2o.c: kmalloc + memset conversion to kzalloc

2007-08-10 Thread akpm
From: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/dpt_i2o.c | 87632 -> 87457 (-175 bytes) drivers/scsi/dpt_i2o.o | 213064 -> 212324 (-740 bytes) Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Acked-by: "Salyzyn, Mark" <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECT

[patch 26/30] drivers/message/fusion/mptctl.c: mostly kmalloc + memset conversion to kzalloc

2007-08-10 Thread akpm
From: Mariusz Kozlowski <[EMAIL PROTECTED]> This patch does kmalloc + memset conversion to kzalloc anSigned-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> d simplifies mptctl_probe(). drivers/message/fusion/mptctl.c | 82092 -> 81884 (-208 bytes) drivers/message/fusion/mptctl.o | 201784 -> 20064

[patch 14/30] dtc: clean up indent damage and add printk levels

2007-08-10 Thread akpm
From: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/dtc.c | 16 +++- 1 files changed, 7 insertions(+), 9 deletions(-) diff -puN drivers/scsi/dtc.c~dtc-clean-up-indent-damage-and-add-printk

[patch 27/30] mpt-fusion: fix two potential mem leaks

2007-08-10 Thread akpm
From: Jesper Juhl <[EMAIL PROTECTED]> The Coverity checker spotted two potential memory leaks in drivers/message/fusion/mptbase.c::mpt_attach(). There are two returns that may leak the storage allocated for 'ioc' (sizeof(MPT_ADAPTER) bytes). A simple fix would be to simply add two kfree() calls

[patch 13/30] nsp32_restart_autoscsi(): remove error check

2007-08-10 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> The Coverity checker noted that we'll anyway Oops later when we ran into this condition - and the error check didn't prevent that. Considering that the error condition shouldn't be possible, and we are not able to handle it easily, this patch simply removes t

[patch 10/30] megaraid: add CERC_ATA100 support

2007-08-10 Thread akpm
From: Torsten Krah <[EMAIL PROTECTED]> Taken from http://bugzilla.kernel.org/show_bug.cgi?id=6695 Add support for this device to the old megaraid driver. Cc: Natalie Protasevich <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/megaraid.c |2 ++ drivers/

[patch 30/30] message/fusion: remove redundant memset

2007-08-10 Thread akpm
From: Mariusz Kozlowski <[EMAIL PROTECTED]> alloc_fcdev() calls alloc_netdev() which uses kzalloc to alloc all the memory together with dev->priv region hence no zeroing of structs inside struct mpt_lan_priv needed. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Cc: "Moore, Eric Dean" <[EMA

[patch 23/30] drivers/scsi/lpfc/lpfc_scsi.c: kmalloc + memset conversion to kzalloc

2007-08-10 Thread akpm
From: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/lpfc/lpfc_scsi.c | 42769 -> 42721 (-48 bytes) drivers/scsi/lpfc/lpfc_scsi.o | 191332 -> 191240 (-92 bytes) Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Acked-by: James Smart <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL

[patch 21/30] drivers/scsi/lpfc/lpfc_debugfs.c: kmalloc + memset conversion to kcalloc

2007-08-10 Thread akpm
From: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/lpfc/lpfc_debugfs.c | 13809 -> 13716 (-93 bytes) drivers/scsi/lpfc/lpfc_debugfs.o | 146124 -> 146124 (0 bytes) Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Acked-by: James Smart <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[E

[patch 22/30] drivers/scsi/lpfc/lpfc_init.c: kmalloc + memset conversion to kcalloc

2007-08-10 Thread akpm
From: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/lpfc/lpfc_init.c | 65932 -> 65881 (-51 bytes) drivers/scsi/lpfc/lpfc_init.o | 219760 -> 219616 (-144 bytes) Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Acked-by: James Smart <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAI

[patch 19/30] drivers/scsi/bvme6000_scsi.c: kmalloc + memset conversion to kzalloc

2007-08-10 Thread akpm
From: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/bvme6000_scsi.c | 3330 -> 3253 (-77 bytes) Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/bvme6000_scsi.c |7 +++ 1 files changed, 3 insertions(+), 4 deletio

[patch 18/30] drivers/scsi/a4000t.c: kmalloc + memset conversion to kzalloc

2007-08-10 Thread akpm
From: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/a4000t.c | 3534 -> 3457 (-77 bytes) Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/a4000t.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff -p

[patch 12/30] Fix drivers/scsi/fdomain.c CONFIG_PCI=n warnings

2007-08-10 Thread akpm
From: Gabriel C <[EMAIL PROTECTED]> I get this warnings on current git when CONFIG_PCI is not set : drivers/scsi/fdomain.c:390: warning: 'PCI_dev' defined but not used drivers/scsi/fdomain.c:1768: warning: 'fdomain_pci_tbl' defined but not used Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTE

[patch 28/30] Fix a potential NULL pointer deref in the aic7xxx, ahc_print_register() function

2007-08-10 Thread akpm
From: Jesper Juhl <[EMAIL PROTECTED]> The Coverity checker noticed that we have a potential NULL pointer deref in drivers/scsi/aic7xxx/aic7xxx_core.c::ahc_print_register(). This patch handles it by adding the same test against NULL that is used elsewhere in the same function. Signed-off-by: Jespe

[patch 24/30] drivers/scsi/megaraid.c: kmalloc + memset conversion to kzalloc

2007-08-10 Thread akpm
From: Mariusz Kozlowski <[EMAIL PROTECTED]> This patch does kmalloc + memset conversion to kzalloc and adds missing check for kzalloc return value. drivers/scsi/megaraid.c | 116109 -> 116094 (-15 bytes) drivers/scsi/megaraid.o | 257872 -> 257772 (-100 bytes) Signed-off-by: Mariusz Kozlowski <[

[patch 20/30] drivers/scsi/gdth.c: kmalloc + memset conversion to kzalloc

2007-08-10 Thread akpm
From: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/gdth.c | 189401 -> 189342 (-59 bytes) drivers/scsi/gdth.o | 331028 -> 330324 (-704 bytes) Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/gdth.c |4 ++-- 1 files

[patch 16/30] drivers/scsi/constants.c: make 2 functions static

2007-08-10 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> This patch makes two needlessly global functions static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/constants.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN d

[patch 11/30] drivers/scsi/g_NCR5380.c: "NCR53C400_PSEUDO_DMA" is not defined

2007-08-10 Thread akpm
From: Gabriel C <[EMAIL PROTECTED]> Got this warning with current git: ... In file included from drivers/scsi/g_NCR5380_mmio.c:9: drivers/scsi/g_NCR5380.c:559:5: warning: "NCR53C400_PSEUDO_DMA" is not defined ... Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTED]> Signed-off-by: Andrew Mort

[patch 15/30] drivers/scsi/scsi_error.c should #include "scsi_transport_api.h"

2007-08-10 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> Every file should #include the headers containing the prototypes for its global functions (in this case for scsi_schedule_eh()). Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/scsi_error.c |

[patch 29/30] scsi: ipsc warning fix

2007-08-10 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> drivers/scsi/ips.c: In function 'ips_insert_device': drivers/scsi/ips.c:6957: warning: 'index' may be used uninitialized in this function Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/ips.c |2 +- 1 files changed, 1 insertion(+),

[patch 03/30] PCI Error Recovery: Symbios SCSI base support

2007-08-10 Thread akpm
From: Linas Vepstas <[EMAIL PROTECTED]> Various PCI bus errors can be signaled by newer PCI controllers. This patch adds the PCI error recovery callbacks to the Symbios SCSI device driver. The patch has been tested, and appears to work well. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc:

[patch 04/30] PCI Error Recovery: Symbios SCSI First Failure

2007-08-10 Thread akpm
From: Linas Vepstas <[EMAIL PROTECTED]> Implement the so-called "first failure data capture" (FFDC) for the symbios PCI error recovery. After a PCI error event is reported, the driver requests that MMIO be enabled. Once enabled, it then reads and dumps assorted status registers, and concludes by

[patch 09/30] Clean up duplicate includes in drivers/scsi/

2007-08-10 Thread akpm
From: Jesper Juhl <[EMAIL PROTECTED]> This patch cleans up duplicate includes in drivers/scsi/ Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> Acked-by: James Smart <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/NCR_D700.c |1 - drivers

[patch 08/30] Use menuconfig objects: Fusion

2007-08-10 Thread akpm
From: Jan Engelhardt <[EMAIL PROTECTED]> Change Kconfig objects from "menu, config" into "menuconfig" so that the user can disable the whole feature without having to enter the menu first. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> Cc: "Moore, Eric Dean" <[EMAIL PROTECTED]> Signed-off-by:

[patch 06/30] Remove dead references to MODULE_PARM macro

2007-08-10 Thread akpm
From: "Robert P. J. Day" <[EMAIL PROTECTED]> Remove the useless references to the obsolete MODULE_PARM macro. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/ibmmca.c |7 --- 1 files changed, 7 deletions(-) diff -puN

[patch 07/30] Incorrect SCSI transfer length computation from odd sized scsi_execute_async() transfers.

2007-08-10 Thread akpm
From: Jeremy Linton <[EMAIL PROTECTED]> Any function which use scsi_execute_async() and transfers "odd" sized data that doesn't align correctly with the segment sizes may have its transfer length padded out to the closest segment size. For writes, this results in unnecessary data being transfered

[patch 05/30] drivers/scsi/pcmcia/nsp_cs.c: remove kernel 2.4 code

2007-08-10 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/pcmcia/nsp_cs.c | 159 + drivers/scsi/pcmcia/nsp_cs.h |8 - 2 files changed, 5 insertions(+), 162 deletions(

[patch 02/30] aacraid: rename check_reset

2007-08-10 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> Too generic, clashes with ISDN. Acked-by: Mark Salyzyn <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/aacraid/aachba.c |8 drivers/scsi/aacraid/aacraid.h |2 +

[patch 01/30] bsg: declare request_queue

2007-08-10 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> include/linux/bsg.h:67: warning: 'struct request_queue' declared inside parameter list include/linux/bsg.h:67: warning: its scope is only this definition or declaration, which is probably not what you want include/linux/bsg.h:71: warning: 'struct request_q

Re: [PATCH] [MEGARAID_SAS]: Use pr_info

2007-08-10 Thread Brian King
Patro, Sumant wrote: > Hello Arnaldo, > > Throughout the megaraid_sas driver code there are printk's with > appropriate flags (that includes KERN_INFO). What is the incentive to > change printk with KERN_INFO to pr_info? And why not change most of these to dev_printk and friends? -Br

RE: [PATCH] [MEGARAID_SAS]: Use pr_info

2007-08-10 Thread Patro, Sumant
Hello Arnaldo, Throughout the megaraid_sas driver code there are printk's with appropriate flags (that includes KERN_INFO). What is the incentive to change printk with KERN_INFO to pr_info? Regards, Sumant -Original Message- From: Arnaldo Carvalho de Melo [mailto:[EMAI

Re: 2.6.23-rc2-mm2

2007-08-10 Thread Andrew Morton
On Fri, 10 Aug 2007 14:35:01 +0200 Gabriel C <[EMAIL PROTECTED]> wrote: > In file included from include/linux/blkdev.h:17, > from kernel/sched.c:45: > include/linux/bsg.h:67: warning: 'struct request_queue' declared inside > parameter list > include/linux/bsg.h:67: warning: its s

Re: 2.6.23-rc2-mm2

2007-08-10 Thread Gabriel C
Some new warnings here : ... In file included from include/linux/blkdev.h:17, from kernel/sched.c:45: include/linux/bsg.h:67: warning: 'struct request_queue' declared inside parameter list include/linux/bsg.h:67: warning: its scope is only this definition or declaration, which

Re: Partition information lost on reboot.

2007-08-10 Thread Michal Piotrowski
[Adding linux-scsi and Adaptec support to CC] On 10/08/07, Jegadeesh <[EMAIL PROTECTED]> wrote: > Hi, > > I have a scsi disk on Adaptec ASC-29320 U320. I have created a linux > partition and ext3 filesystem over it. > Now the problem is, whenever the machine is rebooted, the partition > informatio

[PATCH][Take2] PCI legacy I/O port free driver - Making Emulex lpfc driver legacy I/O port free

2007-08-10 Thread Tomohiro Kusumi
Hi This patch makes Emulex lpfc driver legacy I/O port free. It has already been acked quite long time ago. So I resubmit the patch. http://lkml.org/lkml/2006/11/22/28 Current lpfc driver is already using pci_select_bars() and pci_enable_device_bars() when the PCI bus has been reset. So I think t