Kristen Carlson Accardi wrote:
> On Wed, 01 Aug 2007 17:27:39 +0900
> Tejun Heo <[EMAIL PROTECTED]> wrote:
>
>> Kristen Carlson Accardi wrote:
>
>> Is it safe to use ALPM on a device which only claims to support DIPM?
>
> Yes - I doubled checked this with the AHCI people - and of course you
> ha
On Wed, 1 Aug 2007 21:03:50 -0600 Matthew Wilcox <[EMAIL PROTECTED]> wrote:
> On Wed, Aug 01, 2007 at 05:26:53PM -0700, Andrew Morton wrote:
> > Why on earth is that using GFP_ATOMIC? This function later goes on to
> > create procfs files and such things.
>
> Seems fairly common in driver initia
From: Mark Fortescue <[EMAIL PROTECTED]>
Date: Tue, 31 Jul 2007 20:10:45 +0100 (BST)
> From: Mark Fortescue <[EMAIL PROTECTED]>
>
> Change a printk sequencing issue where <6> ... was coming up in the middle
> of a line when scsi_add_host was being called.
> Reduce the length of some printk messag
On Wed, Aug 01, 2007 at 05:26:53PM -0700, Andrew Morton wrote:
> Why on earth is that using GFP_ATOMIC? This function later goes on to
> create procfs files and such things.
Seems fairly common in driver initialisation code. I removed three
instances of this in the advansys driver.
> y'know, we
> IA64
>
> Subject : Regression in serial console on ia64 after 2.6.22
> References : http://marc.info/?l=linux-ia64&m=118483645914066&w=2
> Last known good : ?
> Submitter : Horms <[EMAIL PROTECTED]>
> Caused-By : Yinghai Lu <[EMAIL PROTECTED]>
> commit
On Thu, 2 Aug 2007 01:55:33 +0200
Jesper Juhl <[EMAIL PROTECTED]> wrote:
> Greetings & Salutations,
>
> The Coverity checker spotted two potential memory leaks in
> drivers/message/fusion/mptbase.c::mpt_attach().
>
> There are two returns that may leak the storage allocated for
> 'ioc' (sizeof
Greetings & Salutations,
The Coverity checker spotted two potential memory leaks in
drivers/message/fusion/mptbase.c::mpt_attach().
There are two returns that may leak the storage allocated for
'ioc' (sizeof(MPT_ADAPTER) bytes).
A simple fix would be to simply add two kfree() calls before
the
On Tue, 31 Jul 2007 15:41:34 -0700
Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Tue, 31 Jul 2007 17:30:52 -0500
> James Bottomley <[EMAIL PROTECTED]> wrote:
>
> > On Tue, 2007-07-31 at 15:27 -0700, Andrew Morton wrote:
> > > ERROR: "scsi_tgt_it_nexus_create" [drivers/scsi/scsi_transport_srp.ko]
On Tue, 31 Jul 2007 12:40:41 -0600
"Moore, Eric" <[EMAIL PROTECTED]> wrote:
> On Monday, July 30, 2007 4:32 PM, FUJITA Tomonori wrote:
> > > On another note, while unloading the driver, and I get an
> > following opps
> > > from bsg in the context of scsi_remove_host. This is w/o the "SMP
> >
This patch will set the correct bits to turn on Aggressive
Link Power Management (ALPM) for the ahci driver. This
will cause the controller and disk to negotiate a lower
power state for the link when there is no activity (see
the AHCI 1.x spec for details). This feature is mutually
exclusive with
libata drivers can define a function (enable_pm) that will
perform hardware specific actions to enable whatever power
management policy the user set up from the scsi sysfs
interface if the driver supports it. This power management
policy will be activated after all disks have been
enumerated an
Use a stored value for which interrupts to enable. Changing this allows
us to selectively turn off certain interrupts later and have them
stay off.
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
Index: 2.6-git/drivers/ata/ahci.c
=
Hi,
This is an updated series of ALPM patches. I moved all link power management
stuff out of scsi sysfs and just use the shost_addr pointer in the host
template to create the sysfs files. This provides the same interface
as before, without requiring any scsi changes. I also fixed a bug in
the h
Store interrupt value
Use a stored value for which interrupts to enable. Changing this allows
us to selectively turn off certain interrupts later and have them
stay off.
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
Index: 2.6-git/drivers/ata/ahci.c
==
I was able to duplicate Tejun's problem on an ATAPI device I had here.
this updated patch fixed my problem. These devices are just setting
PhyReady (N) and CommWake (W) in Serror on power state changes, ignoring
them seems to be fine, and fixed the problem for me.
Enable Aggressive Link Power m
On Wed, 01 Aug 2007 17:27:39 +0900
Tejun Heo <[EMAIL PROTECTED]> wrote:
> Kristen Carlson Accardi wrote:
> Is it safe to use ALPM on a device which only claims to support DIPM?
Yes - I doubled checked this with the AHCI people - and of course you
have Edvin's testing to prove it does fine.
> I
On Wed, 01 Aug 2007 12:24:44 +0900
Tejun Heo <[EMAIL PROTECTED]> wrote:
> Kristen Carlson Accardi wrote:
> >> I don't think the interface you're suggesting is a good one. Do you?
> >
> > I think if it's applicable to SCSI at all it is fine. If it is not, then
> > I think we need to make do with
On Tuesday 31 July 2007, Mariusz Kozlowski wrote:
> Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]>
>
> drivers/scsi/ide-scsi.c | 34642 -> 34536 (-106 bytes)
> drivers/scsi/ide-scsi.o | 171728 -> 171524 (-204 bytes)
>
> drivers/scsi/ide-scsi.c | 10 --
> 1 file changed, 4 insert
--- Linas Vepstas <[EMAIL PROTECTED]> wrote:
> On Mon, Jul 30, 2007 at 03:47:05PM -0700, Doug Thompson wrote:
> >
> > --- Linas Vepstas <[EMAIL PROTECTED]> wrote:
> > > Also: please note that the linux kernel has a pci error recovery
> > > mechanism built in; its used by pseries and PCI-E. I'm n
Doug Chapman wrote:
> I am seeing a panic on the latest git trees on my ia64 servers with
> qlogic cards installed. The latest this was known to work OK was
> v2.6.23-rc1. I am currently working on a git bisect to narrow down what
> introduced this but due to other unrelated problems that is not
On Mon, Jul 30, 2007 at 03:47:05PM -0700, Doug Thompson wrote:
>
> --- Linas Vepstas <[EMAIL PROTECTED]> wrote:
> > Also: please note that the linux kernel has a pci error recovery
> > mechanism built in; its used by pseries and PCI-E. I'm not clear
> > on what any of this has to do with EDAC, whi
On Wed, Aug 01, 2007 at 03:38:49PM -0400, Doug Chapman wrote:
> I am seeing a panic on the latest git trees on my ia64 servers with
> qlogic cards installed. The latest this was known to work OK was
> v2.6.23-rc1. I am currently working on a git bisect to narrow down what
> introduced this but du
I am seeing a panic on the latest git trees on my ia64 servers with
qlogic cards installed. The latest this was known to work OK was
v2.6.23-rc1. I am currently working on a git bisect to narrow down what
introduced this but due to other unrelated problems that is not going
smoothly. Let me know
On Wed, 2007-08-01 at 10:53 -0600, Matthew Wilcox wrote:
> On Tue, Jul 31, 2007 at 09:18:08AM -0500, James Bottomley wrote:
> > The other comment is that power saving seems to be a property of the
> > transport rather than the host. If you do it in the transport classes,
> > then you can expose al
On Tue, Jul 31, 2007 at 09:18:08AM -0500, James Bottomley wrote:
> The other comment is that power saving seems to be a property of the
> transport rather than the host. If you do it in the transport classes,
> then you can expose all the knobs the actual transport possesses (which
> is, unfortuna
On Wed, 01 Aug 2007 11:20:04 -0500 James Bottomley wrote:
> On Thu, 2007-08-02 at 00:20 +0900, FUJITA Tomonori wrote:
> > Hopefully, this works. Is there an easier way to remove tgt
> > dependencies in scsi_transport_srp?
> [...]
> > + depends on SCSI_SRP_ATTRS
> > + depends on SCSI_TGT = y ||
On Wed, 01 Aug 2007 18:23:21 +0900
Tejun Heo <[EMAIL PROTECTED]> wrote:
> Tejun Heo wrote:
> > Arjan van de Ven wrote:
> >>> They were hardware problems. I don't think any amount of proper
> >>> implementation can fix them. I have one DVD RAM somewhere in my pile of
> >>> hardware which locks up
On Wed, 01 Aug 2007 08:51:14 -0500 James Bottomley wrote:
> On Tue, 2007-07-31 at 11:40 -0700, Randy Dunlap wrote:
> > On Tue, 31 Jul 2007 10:59:51 +0300 Boaz Harrosh wrote:
> >
> > > Randy Dunlap wrote:
> > > >
> > > > Since you grok all of that (above), maybe you can help here:
> > > >
> > >
On Thu, 2007-08-02 at 00:20 +0900, FUJITA Tomonori wrote:
> Hopefully, this works. Is there an easier way to remove tgt
> dependencies in scsi_transport_srp?
[...]
> + depends on SCSI_SRP_ATTRS
> + depends on SCSI_TGT = y || SCSI_TGT = SCSI_SRP_ATTRS
I asked the same thing for the same pro
On Wed, 2007-08-01 at 00:21 +0200, Mariusz Kozlowski wrote:
> [PATCH 82] ...
Please no. This should be a simple mechanical substitution. I don't
need to collect acks from everyone. This is a nice point to do a
conversion like this, so I'll sort out the mismerges.
Please assure me you have a go
On Wed, 01 Aug 2007 12:24:44 +0900
Tejun Heo <[EMAIL PROTECTED]> wrote:
> It would be *really* great if we can find more about how they do it.
> How and when it's enabled and on which systems. Is it possible to find
> this out?
No - it's really not a good idea for us to go and ask other OS's how
Hi,
"There is no reason at all for a scsi driver to include stat.h"
-- Christoph Hellwig
Regards,
Michal
--
LOG
http://www.stardust.webpages.pl/log/
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]>
--- linux-mm-clean/drivers/scsi/gvp11.c 2007-07-09 01:32:17.0 +0200
+++ linux-mm/dri
Hi,
"There is no reason at all for a scsi driver to include stat.h"
-- Christoph Hellwig
Regards,
Michal
--
LOG
http://www.stardust.webpages.pl/log/
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]>
--- linux-mm-clean/drivers/scsi/a3000.c 2007-07-09 01:32:17.0 +0200
+++ linux-mm/dri
Hi,
"There is no reason at all for a scsi driver to include stat.h"
-- Christoph Hellwig
Regards,
Michal
--
LOG
http://www.stardust.webpages.pl/log/
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]>
--- linux-mm-clean/drivers/scsi/a2091.c 2007-07-09 01:32:17.0 +0200
+++ linux-mm/dri
Michal Piotrowski pisze:
> Hi,
>
> Coding style fix
>
Christoph Hellwig:
"There is no reason at all for a scsi driver to include stat.h"
Regards,
Michal
--
LOG
http://www.stardust.webpages.pl/log/
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]>
--- linux-mm-clean/drivers/scsi/mvme147.c
Christoph Hellwig pisze:
> On Wed, Aug 01, 2007 at 05:13:14PM +0200, Michal Piotrowski wrote:
>> Hi,
>>
>> Coding style fix
>>
>> Regards,
>> Michal
>>
>
> I think that include should just go. There is no reason at all for
> a scsi driver to include stat.h
>
>
As you wish
Regards,
Michal
--
Hopefully, this works. Is there an easier way to remove tgt
dependencies in scsi_transport_srp?
---
>From 00924b31df30e4ddcf9ba9b5082171e5e46b9eb0 Mon Sep 17 00:00:00 2001
From: FUJITA Tomonori <[EMAIL PROTECTED]>
Date: Thu, 2 Aug 2007 00:03:11 +0900
Subject: [PATCH] scsi_transport_srp: remove tgt
On Wed, Aug 01, 2007 at 05:17:15PM +0200, Michal Piotrowski wrote:
> -#include
> +#include
Why does this driver need stat.h at all?
--
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
On Wed, Aug 01, 2007 at 05:13:14PM +0200, Michal Piotrowski wrote:
> Hi,
>
> Coding style fix
>
> Regards,
> Michal
>
I think that include should just go. There is no reason at all for
a scsi driver to include stat.h
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
th
Hi,
Coding style fix
Regards,
Michal
--
LOG
http://www.stardust.webpages.pl/log/
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]>
--- linux-mm-clean/drivers/scsi/mvme147.c 2007-07-09 01:32:17.0
+0200
+++ linux-mm/drivers/scsi/mvme147.c 2007-08-01 17:14:39.0 +0200
Hi,
Coding style fix
Regards,
Michal
--
LOG
http://www.stardust.webpages.pl/log/
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]>
--- linux-mm-clean/drivers/scsi/aha1542.c 2007-07-09 01:32:17.0
+0200
+++ linux-mm/drivers/scsi/aha1542.c 2007-08-01 17:09:40.0 +0200
Matthew Wilcox wrote:
> On Wed, Aug 01, 2007 at 04:27:15PM +0200, Gabriel C wrote:
>> Matthew Wilcox wrote:
>>> I'd be interested in seeing the results of the randconfig trials on the
>>> driver with those 23 patches applied, but not particularly interested in
>>> the intermediate result.
>> I can
On Wed, Aug 01, 2007 at 04:27:15PM +0200, Gabriel C wrote:
> Matthew Wilcox wrote:
> > I'd be interested in seeing the results of the randconfig trials on the
> > driver with those 23 patches applied, but not particularly interested in
> > the intermediate result.
>
> I can do that on weekend.
Th
Matthew Wilcox wrote:
> On Wed, Aug 01, 2007 at 09:39:12PM +0800, Eugene Teo wrote:
>> This patch fixes the following compile error:
>>
>> drivers/scsi/advansys.c: In function 'advansys_board_found':
>> drivers/scsi/advansys.c:17781: error: implicit declaration of function
>> 'to_pci_dev'
>
> Or j
Kristen Carlson Accardi wrote:
Use a stored value for which interrupts to enable. Changing this allows
us to selectively turn off certain interrupts later and have them
stay off.
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
ACK. Regenerate against current kernel and I'll app
Eugene Teo wrote:
> Hi Gabriel,
Hi Eugene,
> Hope the following trivial patch helps.
Yes it does , thx.
>
>
>> Getting this with a randconfig (
>> http://194.231.229.228/MM/randconfig-auto-10 )
>>
> [...]
>> drivers/scsi/advansys.c:794:2: warning: #warning this driver is still not
>> prope
On Wed, Aug 01, 2007 at 09:39:12PM +0800, Eugene Teo wrote:
> This patch fixes the following compile error:
>
> drivers/scsi/advansys.c: In function 'advansys_board_found':
> drivers/scsi/advansys.c:17781: error: implicit declaration of function
> 'to_pci_dev'
Or just remove the ifdefs around the
On Tue, 2007-07-31 at 11:40 -0700, Randy Dunlap wrote:
> On Tue, 31 Jul 2007 10:59:51 +0300 Boaz Harrosh wrote:
>
> > Randy Dunlap wrote:
> > >
> > > Since you grok all of that (above), maybe you can help here:
> > >
> > > With these 6 patches applied, I do the following:
> > >
> > > 1. insert
Hi Gabriel,
Hope the following trivial patch helps.
> Getting this with a randconfig ( http://194.231.229.228/MM/randconfig-auto-10
> )
>
[...]
> drivers/scsi/advansys.c:794:2: warning: #warning this driver is still not
> properly converted to the DMA API
> drivers/scsi/advansys.c: In functio
Getting this with a randconfig ( http://194.231.229.228/MM/randconfig-auto-10 )
...
drivers/scsi/advansys.c:794:2: warning: #warning this driver is still not
properly converted to the DMA API
drivers/scsi/advansys.c: In function 'advansys_board_found':
drivers/scsi/advansys.c:17781: error: impli
On 8/1/07, Tejun Heo <[EMAIL PROTECTED]> wrote:
> >
> > + if (ata_id_has_hipm(dev->id) || ata_id_has_dipm(dev->id))
> > + dev->flags |= ATA_DFLAG_IPM;
>
> Is it safe to use ALPM on a device which only claims to support DIPM?
I have tested on a Dell Inspiron 6400, it has ICH7-M (82801GB
Tejun Heo wrote:
> Arjan van de Ven wrote:
>>> They were hardware problems. I don't think any amount of proper
>>> implementation can fix them. I have one DVD RAM somewhere in my pile of
>>> hardware which locks up solidly if any link PS mode is used and had a
>> and the AHCI ALPM code decides to
Kristen Carlson Accardi wrote:
> libata drivers can define a function (enable_pm) that will
> perform hardware specific actions to enable whatever power
> management policy the user set up from the scsi sysfs
> interface if the driver supports it. This power management
> policy will be activated
Kristen Carlson Accardi wrote:
> Use a stored value for which interrupts to enable. Changing this allows
> us to selectively turn off certain interrupts later and have them
> stay off.
>
> Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
Acked-by: Tejun Heo <[EMAIL PROTECTED]>
--
t
54 matches
Mail list logo
