[PATCH] unexport sg v3 helper functions

2007-07-21 Thread FUJITA Tomonori
blk_fill_sghdr_rq, blk_unmap_sghdr_rq, and blk_complete_sghdr_rq were exported for bsg, however bsg was changed to support only sg v4. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- block/scsi_ioctl.c | 13 + include/linux/blkdev.h |5 - 2 files changed, 5 insert

Re: [PATCH 1/4] gdth: Split out EISA and ISA register code

2007-07-21 Thread Andi Kleen
Jeff Garzik <[EMAIL PROTECTED]> writes: > No code changes, only indentation and blank line additions, plus code to > call the new split-out functions. Could you put the ISA code into #ifdef CONFIG_ISA while you're on it? That would allow dropping it on x86-64 -Andi - To unsubscribe from this

Re: [PATCH 0/4] more gdth patches for your amusement

2007-07-21 Thread Jeff Garzik
Jeff Garzik wrote: This is the rest of the stuff checked into the 'gdth' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git As noted before, I'm fine with Christoph's gdth work superceding mine, or whatever. This was just me poking around. Hopefully the patches are us

[PATCH 4/4] gdth: convert to modern SCSI host alloc/scan

2007-07-21 Thread Jeff Garzik
commit 3a8d6339b89cee3c3dbffdde8ca5dfd8184fdb07 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Sat Jul 21 06:22:20 2007 -0400 [SCSI] gdth: convert to modern SCSI host alloc/scan Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> drivers/scsi/gdth.c | 131 +

[PATCH 3/4] gdth: make some virt ctrlr code common; shuffle SHT members

2007-07-21 Thread Jeff Garzik
commit 7b45cff696331f7655b4b819c1ef5a9ac6387ac6 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Sat Jul 21 05:47:21 2007 -0400 [SCSI] gdth: make some virt ctrlr code common; shuffle SHT members * New function gdth_register_virt() replaces the three basically-duplicate copies of

[PATCH 2/4] gdth: Move probe-time error handling code to end of each function

2007-07-21 Thread Jeff Garzik
commit 0a65f8353367d22c549652f7b8b9383950e82a46 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Sat Jul 21 15:38:05 2007 -0400 [SCSI] gdth: Move probe-time error handling code to end of each function Use standard laddered-goto error handling approach in three probe-time functions

[PATCH 1/4] gdth: kill gdth_{read,write}[bwl] wrappers

2007-07-21 Thread Jeff Garzik
commit 411b270459eef219c41674e454b111dab610113f Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri Jul 20 23:24:13 2007 -0400 [SCSI] gdth: kill gdth_{read,write}[bwl] wrappers They are direct equivalents to {read,write}[bwl]. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>

[PATCH 0/4] more gdth patches for your amusement

2007-07-21 Thread Jeff Garzik
This is the rest of the stuff checked into the 'gdth' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git As noted before, I'm fine with Christoph's gdth work superceding mine, or whatever. This was just me poking around. Hopefully the patches are useful for illustratio

Re: [PATCH 7/7] gdth: switch to modern scsi host registration

2007-07-21 Thread Jeff Garzik
in general, is sane. three problems... Christoph Hellwig wrote: + /* As default we do not probe for EISA or ISA controllers */ + if (probe_eisa_isa) { + /* scanning for controllers, at first: ISA controller */ +#ifdef CONFIG_ISA + for (isa_bios = 0xc800

Re: [PATCH 5/7] gdth: kill virt_ctr option

2007-07-21 Thread Jeff Garzik
Christoph Hellwig wrote: The virt_ctr option allows to register a new scsi_host for each bus on the raid controller. This non-default option makes no sense with the current scsi code and prevents cleaning up the host registration, so remove it. Signed-off-by: Christoph Hellwig <[EMAIL PROTECTE

Re: [PATCH 3/7] gdth: split out pci probing

2007-07-21 Thread Jeff Garzik
Christoph Hellwig wrote: Split out per-device pci probing and put it under proper CONFIG_PCI. Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> ACK patches 1-3 My approach went for bug-for-bug compatibility, with the cleanups and fixes later. Your approach improves error handling and fo

Re: [PATCH 6/7] gdth: clean up host private data

2007-07-21 Thread Jeff Garzik
Christoph Hellwig wrote: Get rid of all the indirection in the Scsi_Host private data and always but the gdth_ha_str directly into it. Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> @@ -678,7 +676,7 @@ static char *gdth_ioctl_alloc(int hanum, if (size == 0) return NULL;

[PATCH 5/7] gdth: kill virt_ctr option

2007-07-21 Thread Christoph Hellwig
The virt_ctr option allows to register a new scsi_host for each bus on the raid controller. This non-default option makes no sense with the current scsi code and prevents cleaning up the host registration, so remove it. Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Index: linux-2.6/drive

[PATCH 6/7] gdth: clean up host private data

2007-07-21 Thread Christoph Hellwig
Get rid of all the indirection in the Scsi_Host private data and always but the gdth_ha_str directly into it. Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Index: linux-2.6/drivers/scsi/gdth.h === --- linux-2.6.orig/drivers/s

[PATCH 7/7] gdth: switch to modern scsi host registration

2007-07-21 Thread Christoph Hellwig
Use scsi_add_host and friends and track instances ourselves. This is the second to last step tovards proper PCI API useage. Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Index: linux-2.6/drivers/scsi/gdth.c === --- linux-2.6

[PATCH 1/7] gdth: split out isa probing

2007-07-21 Thread Christoph Hellwig
(note: this is ontop of Jeff's pci cleanup patch) Split out isa probing into a helper of it's own. Error handling is cleaned up, but errors are not propagated yet. Also enclose the isa probe under the proper CONFIG_ISA symbol instead of the !IA64 hack. Signed-off-by: Christoph Hellwig <[EMAIL

[PATCH 4/7] gdth: Remove 2.4.x support, in-kernel changelog

2007-07-21 Thread Christoph Hellwig
This is Jeff's compat removal patch adjusted to apply after my previous patches: commit 095089554011aef3834fd7b7e35ce0c84349d9a9 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri Jul 20 21:17:45 2007 -0400 [SCSI] gdth: Remove 2.4.x support, in-kernel changelog * Remove in-source ch

[PATCH 2/7] gdth: split out eisa probing

2007-07-21 Thread Christoph Hellwig
Split eisa probing into it's own helper, and do proper error unwinding. Protect EISA probind by the proper CONFIG_EISA symbol. Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Index: linux-2.6/drivers/scsi/gdth.c === --- linux-2

[PATCH 3/7] gdth: split out pci probing

2007-07-21 Thread Christoph Hellwig
Split out per-device pci probing and put it under proper CONFIG_PCI. Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Index: linux-2.6/drivers/scsi/gdth.c === --- linux-2.6.orig/drivers/scsi/gdth.c 2007-07-21 12:17:57.0

[PATCH][13/37] Clean up duplicate includes in drivers/scsi/

2007-07-21 Thread Jesper Juhl
Hi, This patch cleans up duplicate includes in drivers/scsi/ Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/NCR_D700.c b/drivers/scsi/NCR_D700.c index 3a80897..e0f1991 100644 --- a/drivers/scsi/NCR_D700.c +++ b/drivers/scsi/NCR_D700.c @@ -97,7 +97,6 @@ #in

Re: [PATCH 4/4] gdth: Isolate driver-global variables using helpers

2007-07-21 Thread Christoph Hellwig
On Fri, Jul 20, 2007 at 10:23:03PM -0400, Jeff Garzik wrote: > [SCSI] gdth: Isolate driver-global variables using helpers > > Sanitizes access to some driver-global variables, in preparation for > making them dynamic rather than statically-sized. > > This equivalent-transf

Re: [PATCH 1/4] gdth: Split out EISA and ISA register code

2007-07-21 Thread Christoph Hellwig
On Fri, Jul 20, 2007 at 10:20:32PM -0400, Jeff Garzik wrote: > > No code changes, only indentation and blank line additions, plus code to > call the new split-out functions. I have patches that do this and do a few things better (e.g. proper CONFIG_ISA ifdefs instead of the ia64 hacks). I'll sen