Re: PS3: sg chaining support

2007-07-17 Thread Jens Axboe
On Tue, Jul 17 2007, Geoff Levand wrote: > Hi Jens. > > Geert Uytterhoeven wrote: > > -- Forwarded message -- > > Date: Mon, 16 Jul 2007 11:47:26 +0200 > > From: Jens Axboe <[EMAIL PROTECTED]> > > To: [EMAIL PROTECTED], linux-scsi@vger.kernel.org > > Cc: Jens Axboe <[EMAIL PROTECTE

Re: block/bsg.c

2007-07-17 Thread Bartlomiej Zolnierkiewicz
[ James, please remeber to cc: linux-ide on IDE patches, thanks. ] On Wednesday 18 July 2007, Jeff Garzik wrote: > James Bottomley wrote: > > @@ -1052,9 +1054,10 @@ int generic_ide_ioctl(ide_drive_t *drive, struct > > file *file, struct block_device > > int err, (*setfunc)(ide_drive_t *, int

Re: block/bsg.c

2007-07-17 Thread FUJITA Tomonori
From: James Bottomley <[EMAIL PROTECTED]> Subject: Re: block/bsg.c Date: Tue, 17 Jul 2007 13:53:54 -0500 > On Tue, 2007-07-17 at 12:19 +0200, Jens Axboe wrote: > > > > Since Linus is happily snoring by now, could you test and see if the > > > > tree works for you? > > > > > > It works for me. I'l

Re: [patch 0/4] aha152x.c - Cleanup, need help in testing and auditing

2007-07-17 Thread Randy Dunlap
On Mon, 16 Jul 2007 12:22:20 +0300 Boaz Harrosh wrote: > If you could do some testing it is grate. The first 3 patches do not > need scsi-misc specifically. Any post 2.6.20 tree will do. The last patch > could be done together with attached patch on any 2.6.22 tree. > (Apply attached patch anywher

Re: block/bsg.c

2007-07-17 Thread Jeff Garzik
James Bottomley wrote: @@ -1052,9 +1054,10 @@ int generic_ide_ioctl(ide_drive_t *drive, struct file *file, struct block_device int err, (*setfunc)(ide_drive_t *, int); u8 *val; - err = scsi_cmd_ioctl(file, bdev->bd_disk->queue, bdev->bd_disk, cmd, p); - if (err != -ENOTT

Re: block/bsg.c

2007-07-17 Thread Bartlomiej Zolnierkiewicz
On Tuesday 17 July 2007, Andrew Morton wrote: > On Tue, 17 Jul 2007 22:52:25 +0200 > Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > > > ide-{disk,scsi,tape} don't support REQ_TYPE_BLOCK_PC requests et all > > (so attempts to use SG_IO, CDROM_SEND_PACKET and SCSI_IOCTL_SEND_COMMAND > > will

Re: block/bsg.c

2007-07-17 Thread James Bottomley
On Tue, 2007-07-17 at 15:54 -0700, Andrew Morton wrote: > On Tue, 17 Jul 2007 17:19:15 -0500 > James Bottomley <[EMAIL PROTECTED]> wrote: > > > > Adding 1020116k swap on /dev/hdc3. Priority:-1 extents:1 across:1020116k > > > generic_ide_ioctl: cmd=21382 > > > generic_ide_ioctl: err=0 > > > generi

Re: block/bsg.c

2007-07-17 Thread Andrew Morton
On Tue, 17 Jul 2007 17:19:15 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > > Adding 1020116k swap on /dev/hdc3. Priority:-1 extents:1 across:1020116k > > generic_ide_ioctl: cmd=21382 > > generic_ide_ioctl: err=0 > > generic_ide_ioctl: cmd=1 > > program scsi_unique_id is using a deprecated SC

Re: block/bsg.c

2007-07-17 Thread FUJITA Tomonori
From: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Subject: Re: block/bsg.c Date: Tue, 17 Jul 2007 22:52:25 +0200 > /* > * TODO > * - Should this get merged, block/scsi_ioctl.c will be migrated into > *this file. To keep maintenance down, it's easier to have them > *seper

Re: block/bsg.c

2007-07-17 Thread James Bottomley
On Tue, 2007-07-17 at 13:22 -0700, Andrew Morton wrote: > On Tue, 17 Jul 2007 12:18:21 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > > > On Tue, 17 Jul 2007 08:38:11 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > > > In terms of presentation: this code hit the tree as base patch plus what

Re: block/bsg.c

2007-07-17 Thread Andrew Morton
On Tue, 17 Jul 2007 22:52:25 +0200 Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > ide-{disk,scsi,tape} don't support REQ_TYPE_BLOCK_PC requests et all > (so attempts to use SG_IO, CDROM_SEND_PACKET and SCSI_IOCTL_SEND_COMMAND > will result in requests being failed and error messages in the

PS3: sg chaining support

2007-07-17 Thread Geoff Levand
Hi Jens. Geert Uytterhoeven wrote: > -- Forwarded message -- > Date: Mon, 16 Jul 2007 11:47:26 +0200 > From: Jens Axboe <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED], linux-scsi@vger.kernel.org > Cc: Jens Axboe <[EMAIL PROTECTED]>, [EMAIL PROTECTED] > Subject: [PATCH 12/33] PPC: sg c

[PATCH] dm-mpath-rdac: don't stomp on a request's transfer bit.

2007-07-17 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- On Thu, 12 Jul 2007, Mike Anderson wrote: > Copying this mail to linux-scsi and Ccing Andrew Vasquez to possibly > provide input on the Qlogic behavior. ... > > > Jul 12 17:11:15 jimbo kernel: qla2xxx 0

Re: aic7xxx: tape always rewinds since linux-2.6.15

2007-07-17 Thread Frank Hempel
Kai Makisara schrieb: The device /dev/st0 is usually the auto-rewind device and, by definition, the tape is rewound after the device is closed. You should use /dev/nst0 if you don't want the tape to be rewound after close. To use /dev/st0 instead of /dev/nst0 was the stupidity. Sorry then fo

Re: block/bsg.c

2007-07-17 Thread Bartlomiej Zolnierkiewicz
Hi, Some more bsg findings... block/Kconfig: endif # BLOCK Shouldn't BLK_DEV_BSG depend on BLOCK? config BLK_DEV_BSG bool "Block layer SG support" depends on (SCSI=y) && EXPERIMENTAL default y ---help--- Saying Y here will enable generic SG (SCSI gener

Re: block/bsg.c

2007-07-17 Thread Andrew Morton
On Tue, 17 Jul 2007 12:18:21 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Tue, 17 Jul 2007 08:38:11 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > In terms of presentation: this code hit the tree as base patch plus what > > > appear to be 20 bugfixes, none of which are really interest

Re: advansys cleanup

2007-07-17 Thread Ken Witherow
On Tue, 17 Jul 2007, Matthew Wilcox wrote: I'd be glad to attempt the patches again. It would be easier for me if you sent me the raw patches, if possible. How about I send you a patch on top of the advansys.c you got from that git tree? Certainly... whatever works for you. I'm glad just to

Re: block/bsg.c

2007-07-17 Thread James Bottomley
On Tue, 2007-07-17 at 12:48 -0700, Andrew Morton wrote: > On Tue, 17 Jul 2007 13:53:54 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > > > On Tue, 2007-07-17 at 12:19 +0200, Jens Axboe wrote: > > > > > Since Linus is happily snoring by now, could you test and see if the > > > > > tree works for

Re: block/bsg.c

2007-07-17 Thread Andrew Morton
On Tue, 17 Jul 2007 13:53:54 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2007-07-17 at 12:19 +0200, Jens Axboe wrote: > > > > Since Linus is happily snoring by now, could you test and see if the > > > > tree works for you? > > > > > > It works for me. I'll submit some minor patches

Re: sim710_device_remove seems buggy

2007-07-17 Thread Matthew Wilcox
On Tue, Jul 17, 2007 at 01:57:48PM -0500, James Bottomley wrote: > That's certainly the way lasi700 does it ... so it makes sense that this > driver should as well. OK. Here's a patch to fix all the other drivers that had copied this one: Fix drivers misusing dev_to_shost Some drivers were usin

Re: block/bsg.c

2007-07-17 Thread Andrew Morton
On Tue, 17 Jul 2007 08:38:11 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > > In terms of presentation: this code hit the tree as base patch plus what > > appear to be 20 bugfixes, none of which are really interesting or relevant > > to mainline. Personally I think it would be nicer if all that ou

Re: aic7xxx: tape always rewinds since linux-2.6.15

2007-07-17 Thread Kai Makisara
On Tue, 17 Jul 2007, Frank Hempel wrote: > Hello, > > I have expierenced a problem with the aic7xxx driver or the scsi tape support > in the linux kernel. > > [Problem Description] > Under linux kernels since 2.6.15 every "action" I issue to the tape drive (I > mainly do this via from the cpio

Re: [PATCH] gdth: remove redundant PCI stuff

2007-07-17 Thread Christoph Hellwig
On Tue, Jul 17, 2007 at 05:25:17AM -0400, Jeff Garzik wrote: > This patch > > * removes struct members that duplicate pci_dev members > * replaces ha->stype usage with ha->pdev->device usage where feasible These two bits look nice. > * removes PCI IDs that are already in include/linux/pci_ids.h

Re: sim710_device_remove seems buggy

2007-07-17 Thread James Bottomley
On Tue, 2007-07-17 at 12:52 -0600, Matthew Wilcox wrote: > On Tue, Jul 17, 2007 at 10:55:21AM -0600, Matthew Wilcox wrote: > > Unfortunately, I don't have a good idea about how to solve this. The > > least lame perhaps is to have separate routines for EISA and MCA > > devices, each of which passes

Re: block/bsg.c

2007-07-17 Thread James Bottomley
On Tue, 2007-07-17 at 12:19 +0200, Jens Axboe wrote: > > > Since Linus is happily snoring by now, could you test and see if the > > > tree works for you? > > > > It works for me. I'll submit some minor patches against your bsg > > branch to scsi-ml. Can you push them together? > > Certainly, I'll

Re: sim710_device_remove seems buggy

2007-07-17 Thread Matthew Wilcox
On Tue, Jul 17, 2007 at 10:55:21AM -0600, Matthew Wilcox wrote: > Unfortunately, I don't have a good idea about how to solve this. The > least lame perhaps is to have separate routines for EISA and MCA > devices, each of which passes the shost to this routine. I had an idea. How does this look?

RE: [PATCH] aacraid: add vpd to inquiry (take 2)

2007-07-17 Thread Salyzyn, Mark
It was reported to me that the 'ADPT' leading the serial number was bad form, that the inquiry vendor field was enough to differentiate the storage uniquely. Subsequent search found that another Adaptec AAC based driver reported the 8 hex serial number only without such adornments, so dropped ADPT

aic7xxx: tape always rewinds since linux-2.6.15

2007-07-17 Thread Frank Hempel
Hello, I have expierenced a problem with the aic7xxx driver or the scsi tape support in the linux kernel. [Problem Description] Under linux kernels since 2.6.15 every "action" I issue to the tape drive (I mainly do this via from the cpio package) is done but additionaly to every mt call a t

RE: [PATCH] mpt fusion: add sysfs attributes to display IOC parameters

2007-07-17 Thread Moore, Eric
On Tuesday, July 17, 2007 3:09 AM, Prakash, Sathya wrote: > Reposting as this patch is not visible in the list yet. > > Resubmitting with the following change suggested by Brian King: > The driver version from scsi_host attribute is redundant as > it is already > available in sysfs: /sys/module

sim710_device_remove seems buggy

2007-07-17 Thread Matthew Wilcox
Hi Richard, I was looking for inspiration in sim710 when I found what appears to me to be a bug. Your implementation of sim710_device_remove does: sim710_device_remove(struct device *dev) { struct Scsi_Host *host = dev_to_shost(dev); Now, this is going to be called with the struct devi

RE: [PATCH] mpt fusion: add support for Brocade branded LSI FC HBA

2007-07-17 Thread Moore, Eric
On Tuesday, July 17, 2007 2:49 AM, Prakash, Sathya wrote: > > Resubmitting with Eric Moore suggested modifications: > --- > Add support for Brocade 410/420 4Gbit FC HBAs. > They are re-branded LSI HBAs [LSI7104EP-LC/LSI7204EP-LC] > > This patch should be applied over the following patches: > 1

Re: PS3 Storage Driver O_DIRECT issue

2007-07-17 Thread Geoff Levand
Geert Uytterhoeven wrote: > On Fri, 13 Jul 2007, Olaf Hering wrote: >> This driver (or the generic PS3 code) has appearently problems with >> O_DIRECT. >> glibc aborts parted because the malloc metadata get corrupted. While it >> is reproducible, the place where it crashes changes with every versi

Re: advansys cleanup

2007-07-17 Thread Matthew Wilcox
On Tue, Jul 17, 2007 at 11:36:11AM -0400, Ken Witherow wrote: > Instead, I pulled the raw advansys.c from the tree provided and dropped > that in place. Hm, sorry about that. I suspect that advansys.c has changed since 2.6.22. > CC drivers/scsi/advansys.o > drivers/scsi/advansys.c:795:2:

Re: [PATCH] libsas: fix lockdep issue with ATA

2007-07-17 Thread James Bottomley
On Tue, 2007-07-17 at 09:12 -0500, James Bottomley wrote: > > process context, no need to save flags here either. > > OK, you caught me ... I was just doing the fastest thing I could to get > lockdep to shut up. By the way, it dumps about 120KB of logs so it's > fun to get an actual trace of this

[PATCH] aacraid: incorrect dma mapping mask during blinkled recover or user initiated reset

2007-07-17 Thread Salyzyn, Mark
Incorrect dma mask was used for blinkled (firmware assert) recovery or user initiated reset during initialization portion. Ensure that all callers of aac_fib_map_free null out the fib allocation references to prevent multiple free. Although serious sounding, no reports of these problems have surfac

[PATCH] aacraid: correct valid container response in management ioctl

2007-07-17 Thread Salyzyn, Mark
During an Adapter Initiated scan request, the query disk ioctl reports a value of 2 rather than 1 for the valid field. This presents a problem for some legacy management applications. This attached patch is against current scsi-misc-2.6 ObligatoryDisclaimer: Please accept my condolences regarding

Re: advansys cleanup

2007-07-17 Thread Matthew Wilcox
On Mon, Jul 16, 2007 at 02:28:15PM -0600, Matthew Wilcox wrote: > I have to run, but here's what I've benn working on today if anyone > wants to test: > > http://git.kernel.org/pub/scm/linux/kernel/git/willy/advansys-2.6.git I was in so much of a hurry that I got the URL wrong. It is: http://gi

Re: [PATCH] libsas: fix lockdep issue with ATA

2007-07-17 Thread James Bottomley
On Tue, 2007-07-17 at 13:29 +0200, Jens Axboe wrote: > On Mon, Jul 16 2007, James Bottomley wrote: > > lockdep noticed that with ATA support the port->dev_list_lock was > > entangled at irq context, so it now needs to become IRQ safe > > > > --- > > This applies against the aic94xx-sas-2.6 tree >

Re: [PATCH 19/33] scsi_debug: support sg chaining

2007-07-17 Thread Jens Axboe
On Tue, Jul 17 2007, Boaz Harrosh wrote: > Jens Axboe wrote ... > > Cc: [EMAIL PROTECTED] > > Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> > > --- > > drivers/scsi/scsi_debug.c | 30 -- > > 1 files changed, 16 insertions(+), 14 deletions(-) > > > > diff --git a/driv

Re: [PATCH 19/33] scsi_debug: support sg chaining

2007-07-17 Thread Boaz Harrosh
Jens Axboe wrote ... > Cc: [EMAIL PROTECTED] > Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> > --- > drivers/scsi/scsi_debug.c | 30 -- > 1 files changed, 16 insertions(+), 14 deletions(-) > > diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c > index

Re: [PATCH] Don't define empty struct bsg_class_device if !CONFIG_BLK_DEV_BSG (was: Re: block/bsg.c)

2007-07-17 Thread Jens Axboe
On Tue, Jul 17 2007, Geert Uytterhoeven wrote: > Don't define an empty struct bsg_class_device if !CONFIG_BLK_DEV_BSG. > > It's embedded in struct request_queue, but there we have > > #if defined(CONFIG_BLK_DEV_BSG) > struct bsg_class_device bsg_dev; > #endif > > anyway. Thanks, applied.

[PATCH] Don't define empty struct bsg_class_device if !CONFIG_BLK_DEV_BSG (was: Re: block/bsg.c)

2007-07-17 Thread Geert Uytterhoeven
Don't define an empty struct bsg_class_device if !CONFIG_BLK_DEV_BSG. It's embedded in struct request_queue, but there we have #if defined(CONFIG_BLK_DEV_BSG) struct bsg_class_device bsg_dev; #endif anyway. Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> --- At first I considered

Re: [PATCH] libsas: fix lockdep issue with ATA

2007-07-17 Thread Jens Axboe
On Mon, Jul 16 2007, James Bottomley wrote: > lockdep noticed that with ATA support the port->dev_list_lock was > entangled at irq context, so it now needs to become IRQ safe > > --- > This applies against the aic94xx-sas-2.6 tree > > James > > diff --git a/drivers/scsi/libsas/sas_discover.c >

Re: [PATCH 09/33] x86-64: update iommu/dma mapping functions to sg helpers

2007-07-17 Thread Muli Ben-Yehuda
On Tue, Jul 17, 2007 at 01:05:03PM +0200, Jens Axboe wrote: > > FYI, here's the Calgary diff on top of the outstanding Calgary > > changes. > > When are these bits being merged into mainline? I'll hang on to this > version for helping me rebase the arch bits of chained sglists once > that happens

Re: [PATCH 09/33] x86-64: update iommu/dma mapping functions to sg helpers

2007-07-17 Thread Jens Axboe
On Tue, Jul 17 2007, Muli Ben-Yehuda wrote: > On Mon, Jul 16, 2007 at 11:47:23AM +0200, Jens Axboe wrote: > > > This prepares x86-64 for sg chaining support. > > > > Additional improvements/fixups for pci-gart from > > Benny Halevy <[EMAIL PROTECTED]> > > > > Cc: [EMAIL PROTECTED] > > Signed-off

Re: [PATCH 09/33] x86-64: update iommu/dma mapping functions to sg helpers

2007-07-17 Thread Muli Ben-Yehuda
On Mon, Jul 16, 2007 at 11:47:23AM +0200, Jens Axboe wrote: > This prepares x86-64 for sg chaining support. > > Additional improvements/fixups for pci-gart from > Benny Halevy <[EMAIL PROTECTED]> > > Cc: [EMAIL PROTECTED] > Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> > --- > arch/x86_64/kerne

Re: [PATCH 4/4] bsg: Kconfig updates

2007-07-17 Thread Jens Axboe
On Tue, Jul 17 2007, FUJITA Tomonori wrote: > - add the detailed explanation. > - remove 'default y'. > - make 'EXPERIMENTAL' keyword visible to the user in menu. Applied all 4, thanks! -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a messa

Re: block/bsg.c

2007-07-17 Thread Jens Axboe
On Tue, Jul 17 2007, FUJITA Tomonori wrote: > From: Jens Axboe <[EMAIL PROTECTED]> > Subject: Re: block/bsg.c > Date: Tue, 17 Jul 2007 09:10:45 +0200 > > > On Tue, Jul 17 2007, FUJITA Tomonori wrote: > > > From: Jens Axboe <[EMAIL PROTECTED]> > > > Subject: Re: block/bsg.c > > > Date: Tue, 17 Jul

[PATCH 1/4] bsg: fix initialization error handling bugs

2007-07-17 Thread FUJITA Tomonori
This fixes the following bugs and cleans up the initialization code: - cdev_del is missing. - unregister_chrdev_region should be used instead of unregister_chrdev. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- block/bsg.c | 38 ++ 1 files changed, 1

[PATCH 3/4] bsg: minor cleanup

2007-07-17 Thread FUJITA Tomonori
- fix MODULE_DESCRIPTION typo. - unify MODULE_DESCRIPTION and bsg_version. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- block/bsg.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/block/bsg.c b/block/bsg.c index 55a4303..8e5fcf2 100644 --- a/block/bsg.c +

[PATCH 2/4] bsg: device hash table cleanup

2007-07-17 Thread FUJITA Tomonori
- kill unused bsg_list_idx macro. - add bsg_dev_idx_hash() that returns an appropriate hlist_head. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- block/bsg.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/block/bsg.c b/block/bsg.c index b253784..55a430

[PATCH 4/4] bsg: Kconfig updates

2007-07-17 Thread FUJITA Tomonori
- add the detailed explanation. - remove 'default y'. - make 'EXPERIMENTAL' keyword visible to the user in menu. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- block/Kconfig | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/block/Kconfig b/block/Kconfig

Re: block/bsg.c

2007-07-17 Thread FUJITA Tomonori
From: Jens Axboe <[EMAIL PROTECTED]> Subject: Re: block/bsg.c Date: Tue, 17 Jul 2007 09:10:45 +0200 > On Tue, Jul 17 2007, FUJITA Tomonori wrote: > > From: Jens Axboe <[EMAIL PROTECTED]> > > Subject: Re: block/bsg.c > > Date: Tue, 17 Jul 2007 08:59:40 +0200 > > > > > On Tue, Jul 17 2007, FUJITA T

[PATCH] gdth: remove redundant PCI stuff

2007-07-17 Thread Jeff Garzik
This patch * removes struct members that duplicate pci_dev members * replaces ha->stype usage with ha->pdev->device usage where feasible * removes PCI IDs that are already in include/linux/pci_ids.h I did this because I was bored. If this interferes with Christoph's stuff in any way, feel free t

Re: [PATCH] mpt fusion: add sysfs attributes to display IOC parameters

2007-07-17 Thread Prakash, Sathya
Reposting as this patch is not visible in the list yet. Resubmitting with the following change suggested by Brian King: The driver version from scsi_host attribute is redundant as it is already available in sysfs: /sys/module/mptscsih/version. So it is removed from the patch --- New sysfs scsi_

Re: [PATCH 09/33] x86-64: update iommu/dma mapping functions to sg helpers

2007-07-17 Thread Muli Ben-Yehuda
On Tue, Jul 17, 2007 at 10:51:23AM +0200, Jens Axboe wrote: > On Tue, Jul 17 2007, Muli Ben-Yehuda wrote: > > On Tue, Jul 17, 2007 at 09:38:59AM +0200, Jens Axboe wrote: > > > > > On Tue, Jul 17 2007, Muli Ben-Yehuda wrote: > > > > > > The Xen and Calgary bits are mutually exclusive, so hopefully

Re: [PATCH 09/33] x86-64: update iommu/dma mapping functions to sg helpers

2007-07-17 Thread Jens Axboe
On Tue, Jul 17 2007, Muli Ben-Yehuda wrote: > On Tue, Jul 17, 2007 at 09:38:59AM +0200, Jens Axboe wrote: > > > On Tue, Jul 17 2007, Muli Ben-Yehuda wrote: > > > > The Xen and Calgary bits are mutually exclusive, so hopefully (a) > > > will not be held up on account of the Xen merge (or for any o

Re: [PATCH] mpt fusion: add support for Brocade branded LSI FC HBA

2007-07-17 Thread Prakash, Sathya
Resubmitting with Eric Moore suggested modifications: --- Add support for Brocade 410/420 4Gbit FC HBAs. They are re-branded LSI HBAs [LSI7104EP-LC/LSI7204EP-LC] This patch should be applied over the following patches: 1. mpt fusion: deregister from transport layer if PCI registration failed 2.

Re: [PATCH 09/33] x86-64: update iommu/dma mapping functions to sg helpers

2007-07-17 Thread Muli Ben-Yehuda
On Tue, Jul 17, 2007 at 09:38:59AM +0200, Jens Axboe wrote: > On Tue, Jul 17 2007, Muli Ben-Yehuda wrote: > > The Xen and Calgary bits are mutually exclusive, so hopefully (a) > > will not be held up on account of the Xen merge (or for any other > > reason... CalIOC2 machines which are out there

[PATCH] add PCI_VENDOR_ID macro for Brocade in pci_ids.h

2007-07-17 Thread Prakash, Sathya
Reposting as it is not reached the list. On Fri, Jul 13, 2007 at 02:43:30PM +0530, Prakash, Sathya wrote: Adds PCI_VENDOR_ID_BROCADE macro in include/linux/pci_ids.h file. This macro is used in MPT Fusion FC drivers to support Brocade branded FC controllers signed-off-by: Sathya Prakash <[EMAIL

Re: [PATCH 09/33] x86-64: update iommu/dma mapping functions to sg helpers

2007-07-17 Thread Jens Axboe
On Tue, Jul 17 2007, Jens Axboe wrote: > On Mon, Jul 16 2007, Andrew Morton wrote: > > On Mon, 16 Jul 2007 22:10:03 +0200 > > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > > On Mon, Jul 16 2007, Andrew Morton wrote: > > > > On Mon, 16 Jul 2007 11:47:23 +0200 > > > > Jens Axboe <[EMAIL PROTECTED]>

Re: block/bsg.c

2007-07-17 Thread Jan Engelhardt
On Jul 16 2007 16:57, Andrew Morton wrote: >A belated review (I've never seen this before and there it is in mainline) > >> static char bsg_version[] = "block layer sg (bsg) 0.4"; > >`const' would be better. That moves it into a write-protected memory section. Or perhaps MODULE_DESCRIPTION() and

Re: [PATCH 09/33] x86-64: update iommu/dma mapping functions to sg helpers

2007-07-17 Thread Jens Axboe
On Tue, Jul 17 2007, Muli Ben-Yehuda wrote: > On Mon, Jul 16, 2007 at 01:34:27PM -0700, Andrew Morton wrote: > > > > I'll keep rebasing sglist and the other branches I pull into for-akpm, > > > so you can just re-enable the for-akpm pull when the a) is true. > > > > Andi's tree is very out of dat

Re: block/bsg.c

2007-07-17 Thread FUJITA Tomonori
From: Jens Axboe <[EMAIL PROTECTED]> Subject: Re: block/bsg.c Date: Tue, 17 Jul 2007 08:38:11 +0200 > > As a reader of this code I'm wondering "hm, why is > > BSG_SUB_PROTOCOL_SCSI_CMD unprivileged, while other modes require > > CAP_SYS_RAWIO"?. > > > > This design/policy decision maybe was discus

Re: block/bsg.c

2007-07-17 Thread Jens Axboe
On Tue, Jul 17 2007, FUJITA Tomonori wrote: > From: Jens Axboe <[EMAIL PROTECTED]> > Subject: Re: block/bsg.c > Date: Tue, 17 Jul 2007 09:10:45 +0200 > > > On Tue, Jul 17 2007, FUJITA Tomonori wrote: > > > From: Jens Axboe <[EMAIL PROTECTED]> > > > Subject: Re: block/bsg.c > > > Date: Tue, 17 Jul

Re: block/bsg.c

2007-07-17 Thread FUJITA Tomonori
From: Jens Axboe <[EMAIL PROTECTED]> Subject: Re: block/bsg.c Date: Tue, 17 Jul 2007 09:10:45 +0200 > On Tue, Jul 17 2007, FUJITA Tomonori wrote: > > From: Jens Axboe <[EMAIL PROTECTED]> > > Subject: Re: block/bsg.c > > Date: Tue, 17 Jul 2007 08:59:40 +0200 > > > > > On Tue, Jul 17 2007, FUJITA T

Re: block/bsg.c

2007-07-17 Thread Jens Axboe
On Tue, Jul 17 2007, FUJITA Tomonori wrote: > From: Jens Axboe <[EMAIL PROTECTED]> > Subject: Re: block/bsg.c > Date: Tue, 17 Jul 2007 08:59:40 +0200 > > > On Tue, Jul 17 2007, FUJITA Tomonori wrote: > > > From: Jens Axboe <[EMAIL PROTECTED]> > > > Subject: Re: block/bsg.c > > > Date: Tue, 17 Jul

Re: [PATCH 30/33] USB storage: sg chaining support

2007-07-17 Thread Jens Axboe
On Tue, Jul 17 2007, Greg KH wrote: > On Tue, Jul 17, 2007 at 09:01:02AM +0200, Jens Axboe wrote: > > On Mon, Jul 16 2007, Greg KH wrote: > > > On Mon, Jul 16, 2007 at 11:47:44AM +0200, Jens Axboe wrote: > > > > [PATCH] USB storage: sg chaining support > > > > > > > > Modify usb_stor_access_xfer_b

Re: block/bsg.c

2007-07-17 Thread FUJITA Tomonori
From: Jens Axboe <[EMAIL PROTECTED]> Subject: Re: block/bsg.c Date: Tue, 17 Jul 2007 08:59:40 +0200 > On Tue, Jul 17 2007, FUJITA Tomonori wrote: > > From: Jens Axboe <[EMAIL PROTECTED]> > > Subject: Re: block/bsg.c > > Date: Tue, 17 Jul 2007 08:38:11 +0200 > > > > > On Mon, Jul 16 2007, Andrew M

Re: [PATCH 30/33] USB storage: sg chaining support

2007-07-17 Thread Greg KH
On Tue, Jul 17, 2007 at 09:01:02AM +0200, Jens Axboe wrote: > On Mon, Jul 16 2007, Greg KH wrote: > > On Mon, Jul 16, 2007 at 11:47:44AM +0200, Jens Axboe wrote: > > > [PATCH] USB storage: sg chaining support > > > > > > Modify usb_stor_access_xfer_buf() to take a pointer to an sg > > > entry poin

Re: [PATCH 09/33] x86-64: update iommu/dma mapping functions to sg helpers

2007-07-17 Thread Jens Axboe
On Mon, Jul 16 2007, Andrew Morton wrote: > On Mon, 16 Jul 2007 22:10:03 +0200 > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > On Mon, Jul 16 2007, Andrew Morton wrote: > > > On Mon, 16 Jul 2007 11:47:23 +0200 > > > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > > > > This prepares x86-64 for sg cha

Re: [PATCH 30/33] USB storage: sg chaining support

2007-07-17 Thread Jens Axboe
On Mon, Jul 16 2007, Greg KH wrote: > On Mon, Jul 16, 2007 at 11:47:44AM +0200, Jens Axboe wrote: > > [PATCH] USB storage: sg chaining support > > > > Modify usb_stor_access_xfer_buf() to take a pointer to an sg > > entry pointer, so we can keep track of that instead of passing > > around an integ

Re: block/bsg.c

2007-07-17 Thread Jens Axboe
On Tue, Jul 17 2007, FUJITA Tomonori wrote: > From: Jens Axboe <[EMAIL PROTECTED]> > Subject: Re: block/bsg.c > Date: Tue, 17 Jul 2007 08:38:11 +0200 > > > On Mon, Jul 16 2007, Andrew Morton wrote: > > > > > > A belated review (I've never seen this before and there it is in mainline) > > > > > >