Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-13 Thread Benjamin Herrenschmidt
On Fri, 2007-07-13 at 16:19 +0200, Arnd Bergmann wrote: > I'm pretty sure that no ppc64 machine needs alias resolution in the kernel, > although some are VIPT. Last time we discussed this, Segher explained it > to me, but I don't remember which way Cell does it. IIRC, it automatically > flushes cac

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-13 Thread Benjamin Herrenschmidt
On Fri, 2007-07-13 at 09:02 -0400, James Bottomley wrote: > On Wed, 2007-07-04 at 15:22 +0200, Geert Uytterhoeven wrote: > > + kaddr = kmap_atomic(sgpnt->page, KM_USER0); > > + if (!kaddr) > > + return -1; > > +

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-13 Thread Geert Uytterhoeven
On Fri, 13 Jul 2007, James Bottomley wrote: > On Fri, 2007-07-13 at 17:10 +0200, Geert Uytterhoeven wrote: > > On Fri, 13 Jul 2007, Arnd Bergmann wrote: > > > On Friday 13 July 2007, James Bottomley wrote: > > > > > IC. > > > > > > > > > > - flush_kernel_dcache_page() is a no-op on ppc64 > > > >

Re: [dm-devel] dm-mpath-rdac.patch problem

2007-07-13 Thread Brian De Wolf
Andrew Vasquez wrote: > On Thu, 12 Jul 2007, Mike Anderson wrote: > >> Copying this mail to linux-scsi and Ccing Andrew Vasquez to possibly >> provide input on the Qlogic behavior. >> >> Chandra Seetharaman <[EMAIL PROTECTED]> wrote: >>> On Thu, 2007-07-12 at 18:35 -0700, Brian De Wolf wrote:

RE: [PATCH] mpt fusion: add sysfs attributes to display IOC parameters

2007-07-13 Thread Moore, Eric
On Thursday, July 12, 2007 10:11 PM, Prakash, Sathya wrote: > > Resubmitting with the following change suggested by Brian King: > The driver version from scsi_host attribute is redundant as > it is already > available in sysfs: /sys/module/mptscsih/version. > So it is removed from the patch

RE: [PATCH] mpt fusion: add support for Brocade branded LSI FC HBA

2007-07-13 Thread Moore, Eric
On Friday, July 13, 2007 3:29 AM, Prakash, Sathya wrote: You need to include in this patch, the fix that occurred between the 4.00.09 and 4.00.10 drivers. That fix is in mptDisplayIocCapabilties, where it was removing the first three characters from the prod_name. Without this change, "040" wou

RE: [PATCH] add PCI_VENDOR_ID macro for Brocade in pci_ids.h

2007-07-13 Thread Gwendal Grignou
Sathya, Sorry for the previous comment about pci_ids.h, I did not see you sent 2 patches. Gwendal. > -Original Message- > From: Prakash, Sathya [mailto:[EMAIL PROTECTED] > Sent: Friday, July 13, 2007 2:14 AM > To: linux-scsi@vger.kernel.org > Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; Gwe

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-13 Thread Jens Axboe
On Fri, Jul 13 2007, Geert Uytterhoeven wrote: > > It's probably a good idea to have the flush_kernel_dcache_page() in there > > anyway, if only to serve as an example for people that copy it into > > architecture-independent drivers, same as what we do for the > > k{,un}map_atomic() that is also n

Re: mptsas drops then re-adds hard drive

2007-07-13 Thread Philippe Troin
"Moore, Eric" <[EMAIL PROTECTED]> writes: > The [EMAIL PROTECTED] has been deleted, and replaced with > distribution list. This was done about a month back, and should be > updated in the MAINTAINERS file by now. It was not updated in the 2.6.22's MAINTAINERS file. > A return code of 0x1000 me

Re: [dm-devel] dm-mpath-rdac.patch problem

2007-07-13 Thread Andrew Vasquez
On Thu, 12 Jul 2007, Mike Anderson wrote: > Copying this mail to linux-scsi and Ccing Andrew Vasquez to possibly > provide input on the Qlogic behavior. > > Chandra Seetharaman <[EMAIL PROTECTED]> wrote: > > On Thu, 2007-07-12 at 18:35 -0700, Brian De Wolf wrote: > > > Hello All, > > > > > > I'm

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-13 Thread James Bottomley
On Fri, 2007-07-13 at 17:10 +0200, Geert Uytterhoeven wrote: > On Fri, 13 Jul 2007, Arnd Bergmann wrote: > > On Friday 13 July 2007, James Bottomley wrote: > > > > IC. > > > > > > > > - flush_kernel_dcache_page() is a no-op on ppc64 > > > > (ARCH_HAS_FLUSH_KERNEL_DCACHE_PAGE is defined on paris

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-13 Thread Geert Uytterhoeven
On Fri, 13 Jul 2007, Arnd Bergmann wrote: > On Friday 13 July 2007, James Bottomley wrote: > > > IC. > > > > > > � - flush_kernel_dcache_page() is a no-op on ppc64 > > > � � (ARCH_HAS_FLUSH_KERNEL_DCACHE_PAGE is defined on parisc only). > > > > > > � - For reference, drivers/scsi/ipr.c (another p

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-13 Thread Jens Axboe
On Fri, Jul 13 2007, Geert Uytterhoeven wrote: > On Fri, 13 Jul 2007, Jens Axboe wrote: > > On Fri, Jul 13 2007, James Bottomley wrote: > > > On Wed, 2007-07-04 at 15:22 +0200, Geert Uytterhoeven wrote: > > > > + kaddr = kmap_atomic(sgpnt->page, KM_USER0); > > > > +

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-13 Thread Arnd Bergmann
On Friday 13 July 2007, James Bottomley wrote: > > > IC. > > > >   - flush_kernel_dcache_page() is a no-op on ppc64 > >     (ARCH_HAS_FLUSH_KERNEL_DCACHE_PAGE is defined on parisc only). > > > >   - For reference, drivers/scsi/ipr.c (another ppc64 driver) just uses a > > plain > >     kmap/memc

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-13 Thread James Bottomley
On Fri, 2007-07-13 at 15:45 +0200, Geert Uytterhoeven wrote: > On Fri, 13 Jul 2007, James Bottomley wrote: > > On Fri, 2007-07-13 at 15:25 +0200, Geert Uytterhoeven wrote: > > > kmap() just returns page_address() on ppc64, as there's no highmem. > > > kunmap() is a no-op. > > > > > So technically

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-13 Thread Geert Uytterhoeven
On Fri, 13 Jul 2007, James Bottomley wrote: > On Fri, 2007-07-13 at 15:25 +0200, Geert Uytterhoeven wrote: > > kmap() just returns page_address() on ppc64, as there's no highmem. > > kunmap() is a no-op. > > > So technically I could just use page_address() directly, but Christoph > > wanted > > me

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-13 Thread James Bottomley
On Fri, 2007-07-13 at 15:25 +0200, Geert Uytterhoeven wrote: > kmap() just returns page_address() on ppc64, as there's no highmem. > kunmap() is a no-op. > So technically I could just use page_address() directly, but Christoph > wanted > me to keep the kmap()/kunmap() sequence because it's conside

Re: PS3 Storage Driver O_DIRECT issue

2007-07-13 Thread Geert Uytterhoeven
On Fri, 13 Jul 2007, Olaf Hering wrote: > This driver (or the generic PS3 code) has appearently problems with > O_DIRECT. > glibc aborts parted because the malloc metadata get corrupted. While it > is reproducible, the place where it crashes changes with every version > of the debug attempt. > I d

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-13 Thread Geert Uytterhoeven
On Fri, 13 Jul 2007, Jens Axboe wrote: > On Fri, Jul 13 2007, James Bottomley wrote: > > On Wed, 2007-07-04 at 15:22 +0200, Geert Uytterhoeven wrote: > > > + kaddr = kmap_atomic(sgpnt->page, KM_USER0); > > > + if (!kaddr) > > > +

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-13 Thread Jens Axboe
On Fri, Jul 13 2007, James Bottomley wrote: > On Wed, 2007-07-04 at 15:22 +0200, Geert Uytterhoeven wrote: > > + kaddr = kmap_atomic(sgpnt->page, KM_USER0); > > + if (!kaddr) > > + return -1; > > + len =

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-13 Thread James Bottomley
On Wed, 2007-07-04 at 15:22 +0200, Geert Uytterhoeven wrote: > + kaddr = kmap_atomic(sgpnt->page, KM_USER0); > + if (!kaddr) > + return -1; > + len = sgpnt->length; > + if ((req_len

PS3 Storage Driver O_DIRECT issue

2007-07-13 Thread Olaf Hering
This driver (or the generic PS3 code) has appearently problems with O_DIRECT. glibc aborts parted because the malloc metadata get corrupted. While it is reproducible, the place where it crashes changes with every version of the debug attempt. I dont have a handle right now, all I know is that the

Re: [patch 0/6] PS3 Storage Drivers for 2.6.23, take 4

2007-07-13 Thread Geert Uytterhoeven
On Tue, 10 Jul 2007, Geert Uytterhoeven wrote: > On Wed, 4 Jul 2007, Geert Uytterhoeven wrote: > > This is the fourth submission of the new PS3 storage drivers: > > [1] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver > > [2] ps3: Storage Driver Core > > [3] ps3: Storage d