Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2
Signed-off-by: vignesh babu <[EMAIL PROTECTED]>
---
diff --git a/drivers/scsi/NCR53C9x.c b/drivers/scsi/NCR53C9x.c
index 8b5334c..2868b1a 100644
--- a/drivers/scsi/NCR53C9x.c
+++ b/drivers/scsi/NCR53C9x.c
@@ -33,6 +33,7
Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2
Signed-off-by: vignesh babu <[EMAIL PROTECTED]>
---
diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c
index ec71061..c416154 100644
--- a/drivers/scsi/esp_scsi.c
+++ b/drivers/scsi/esp_scsi.c
@@ -14,6 +14,7
We will do AHCI link PM -- presuming that I can be convinced that it
does not repeatedly park the hard drive heads, or something similarly
annoying on PATA<->SATA bridges and similar setups.
IF it works as advertised -- a big if considering all the AHCI silicon
implementations out there -- we
Arjan van de Ven wrote:
>>> The data we have from this patch is that it saves typically a Watt of
>>> power (depends on the machine of course, but the range is 0.5W to
>>> 1.5W). If you want to also have an even more agressive thing where
>>> you want to start disabling the entire controller... I d
Tejun Heo wrote:
do you have data to support this?
Yeah, it was some Lenovo notebook. Pavel is more familiar with the
hardware. Pavel, what was the notebook which didn't save much power
with standard SATA power save but needed port to be completely turned off?
Pavel, if you have time, could
Arjan van de Ven wrote:
>> I'm not sure about this. We need better PM framework to support
>> powersaving in other controllers and some ahcis don't save much
>> when only link power management is used,
>
> do you have data to support this?
Yeah, it was some Lenovo notebook. Pavel is more famil
Henrique de Moraes Holschuh wrote:
On Mon, 11 Jun 2007, Jeff Garzik wrote:
on/off doesn't really make sense if the question is "do you favor power
or do you favor performance"...
Actually, it does if you think of it as "do you need hotplug right now or
not?".
that's a temporary shortcomi
On Mon, 11 Jun 2007, Jeff Garzik wrote:
> >>on/off doesn't really make sense if the question is "do you favor power
> >>or do you favor performance"...
Actually, it does if you think of it as "do you need hotplug right now or
not?".
> >How about just making it a numeric scale with 0 meaning n
Arjan van de Ven wrote:
Jeff Garzik wrote:
SATA standard defines lower power phy states. So the same argument
you're using for AHCI applies there too -- "just" enabling an existing
hardware feature.
yes I'm not arguing against that. I was trying to find out (and
suggest-unless-proven-otherw
Jeff Garzik wrote:
Arjan van de Ven wrote:
Tejun Heo wrote:
Kristen Carlson Accardi wrote:
Hi,
This series of patches enables Aggressive Link Power Management for
AHCI devices, as documented in the AHCI spec. On my laptop (a
Lenovo X60), this
saves me a full watt of power. On other systems
Arjan van de Ven wrote:
Tejun Heo wrote:
Kristen Carlson Accardi wrote:
Hi,
This series of patches enables Aggressive Link Power Management for
AHCI devices, as documented in the AHCI spec. On my laptop (a Lenovo
X60), this
saves me a full watt of power. On other systems, reported power sa
Arjan van de Ven <[EMAIL PROTECTED]> writes:
> Henrique de Moraes Holschuh wrote:
>> On Mon, 11 Jun 2007, Kristen Carlson Accardi wrote:
>>> Setting Effect
>>> --
>>> min_power ALPM is enabled, and link set to enter low
Tejun Heo wrote:
Kristen Carlson Accardi wrote:
Hi,
This series of patches enables Aggressive Link Power Management for AHCI
devices, as documented in the AHCI spec. On my laptop (a Lenovo X60), this
saves me a full watt of power. On other systems, reported power savings
range from .5-1.5 Wa
Tejun Heo wrote:
Kristen Carlson Accardi wrote:
Hi,
This series of patches enables Aggressive Link Power Management for AHCI
devices, as documented in the AHCI spec. On my laptop (a Lenovo X60), this
saves me a full watt of power. On other systems, reported power savings
range from .5-1.5 Wa
Dagfinn Ilmari Mannsåker wrote:
Arjan van de Ven <[EMAIL PROTECTED]> writes:
Henrique de Moraes Holschuh wrote:
On Mon, 11 Jun 2007, Kristen Carlson Accardi wrote:
Setting Effect
--
min_power ALPM is enabled, and link set t
Kristen Carlson Accardi wrote:
> Hi,
> This series of patches enables Aggressive Link Power Management for AHCI
> devices, as documented in the AHCI spec. On my laptop (a Lenovo X60), this
> saves me a full watt of power. On other systems, reported power savings
> range from .5-1.5 Watts. It ha
On Mon, 11 Jun 2007, Kristen Carlson Accardi wrote:
> Setting Effect
> --
> min_power ALPM is enabled, and link set to enter
> lowest power state (SLUMBER) when idle
> Hot plug not allowed.
>
> m
Henrique de Moraes Holschuh wrote:
On Mon, 11 Jun 2007, Kristen Carlson Accardi wrote:
Setting Effect
--
min_power ALPM is enabled, and link set to enter
lowest power state (SLUMBER) when idle
Hot plug not allowe
On Thu, 24 May 2007 23:15:56 -0400
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Kristen Carlson Accardi wrote:
> > Check to see if an ATAPI device supports Asynchronous Notification.
> > If so, enable it.
> >
> > Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
> > ---
> > Andrew, I cleaned
Sundry cleanups:
1) Use kzalloc instead of kmalloc.
2) Make sure probe worked before recalling the SCSI command to finalize
processing.
3) _aac_probe_container2 and _aac_probe_container1 return value goes
unused, change return to void.
4) Use a lower depth pointer reference to pick up the driver in
Kristen Carlson Accardi wrote:
This patch will set the correct bits to turn on Aggressive
Link Power Management (ALPM) for the ahci driver. This
will cause the controller and disk to negotiate a lower
power state for the link when there is no activity (see
the AHCI 1.x spec for details). This f
Kristen Carlson Accardi wrote:
This patch will modify the scsi and ata subsystem to allow
users to set a power management policy for the link.
libata drivers can define a function (enable_pm) that will
perform hardware specific actions to enable whatever power
management policy the user sets up i
Kristen Carlson Accardi wrote:
Use a stored value for which interrupts to enable. Changing this allows
us to selectively turn off certain interrupts later and have them
stay off.
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
Seems OK, though a bit disappointing that this canno
On Mon, 11 Jun 2007 20:28:16 +0200 api wrote:
> Good day,
> When doing make menuconfig one comes across CONFIG_BLK_DEV_SD.
> The help file states that this is for scsi disks.NO MENTION IS MADE THAT
> IT IS NEEDE FOR SATA DISKS AS WELL!
> Would have saved me a lot of time if the help was up to date
This patch will set the correct bits to turn on Aggressive
Link Power Management (ALPM) for the ahci driver. This
will cause the controller and disk to negotiate a lower
power state for the link when there is no activity (see
the AHCI 1.x spec for details). This feature is mutually
exclusive with
This patch will modify the scsi and ata subsystem to allow
users to set a power management policy for the link.
libata drivers can define a function (enable_pm) that will
perform hardware specific actions to enable whatever power
management policy the user sets up if the driver supports
it. This p
Use a stored value for which interrupts to enable. Changing this allows
us to selectively turn off certain interrupts later and have them
stay off.
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
Index: 2.6-git/drivers/ata/ahci.c
=
Hi,
This series of patches enables Aggressive Link Power Management for AHCI
devices, as documented in the AHCI spec. On my laptop (a Lenovo X60), this
saves me a full watt of power. On other systems, reported power savings
range from .5-1.5 Watts. It has been tested by the kind folks at #power
Randy Dunlap wrote:
> From: Randy Dunlap <[EMAIL PROTECTED]>
>
> Correct the module info text for the default value of
> "every_nth" to 0.
>
> Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
Signed-off-by: Douglas Gilbert <[EMAIL PROTECTED]>
Doug Gilbert
> ---
> drivers/scsi/scsi_debug.c |
From: Randy Dunlap <[EMAIL PROTECTED]>
Correct the module info text for the default value of
"every_nth" to 0.
Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_debug.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2622-rc4.orig/drivers/scsi/scsi_debug.c
Randy Dunlap wrote:
> Hi Doug,
>
> scsi_debug.c says:
>
> MODULE_PARM_DESC(every_nth, "timeout every nth command(def=100)");
>
> I don't see where the default of 100 is set.
>
> #define DEF_EVERY_NTH 0
> ...
> static int scsi_debug_every_nth = DEF_EVERY_NTH;
>
>
> Can you clarify for me, pl
Hello James,
I've got a question on NPIV framwork that is included in FC transport
layer. I'm using 2.6.22-rc3 with your NPIV-based vport patchset.
If I understood correctly, vport_disable and vport_delete attributes
have to be listed under /sys/class/fc_vport/vport-2:0-2/, once the
'vport-2:0-2'
Hi Doug,
scsi_debug.c says:
MODULE_PARM_DESC(every_nth, "timeout every nth command(def=100)");
I don't see where the default of 100 is set.
#define DEF_EVERY_NTH 0
...
static int scsi_debug_every_nth = DEF_EVERY_NTH;
Can you clarify for me, please?
Thanks.
---
~Randy
*** Remember to use Do
33 matches
Mail list logo
