On Sat, 12 May 2007 19:40:14 -0700 [EMAIL PROTECTED] wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=8469
OK, thanks.
Mark, we have a post-2.6.21 oops in aacraid:
> scsi 2:0:5:0: CD-ROMNEC CD-ROM DRIVE:466 1.06 PQ: 0 ANSI: 2
> target2:0:5: Beginning Domain Validation
> ta
From: Christoph Hellwig <[EMAIL PROTECTED]>
Subject: Re: [PATCH 1/19] add data buffer accessors
Date: Sat, 12 May 2007 16:31:51 +0100
> > +int scsi_dma_map(struct device *dev, struct scsi_cmnd *cmd)
> > +{
> > + int nseg = 0;
> > +
> > + if (cmd->use_sg) {
> > + struct scatterlist *s
From: Christoph Hellwig <[EMAIL PROTECTED]>
Subject: Re: [PATCH 0/19] clean ups on the drivers
Date: Sat, 12 May 2007 16:30:23 +0100
> On Sat, May 12, 2007 at 07:05:42PM +0900, FUJITA Tomonori wrote:
> > There are two patches for each driver, removing the non-use-sg code
> > and converting to use
On Sat, 2007-05-12 at 20:58 +0100, Simon Arlott wrote:
> On 12/05/07 19:23, Jens Axboe wrote:
> > Hi,
> >
> > This has bothered me for a long time, and it just seems to be getting
> > worse. Can people please STOP defaulting non-essential stuff to 'y'?
> > Grrr.
>
> Is there a reason why various
On Sat, May 12 2007, Simon Arlott wrote:
> On 12/05/07 19:23, Jens Axboe wrote:
> >Hi,
> >
> >This has bothered me for a long time, and it just seems to be getting
> >worse. Can people please STOP defaulting non-essential stuff to 'y'?
> >Grrr.
>
> Is there a reason why various 10/100/1000Mbit net
On 12/05/07 19:23, Jens Axboe wrote:
Hi,
This has bothered me for a long time, and it just seems to be getting
worse. Can people please STOP defaulting non-essential stuff to 'y'?
Grrr.
Is there a reason why various 10/100/1000Mbit network cards are 'y' too?
There's even a default SCSI 'm' tha
On Sat, 2007-05-12 at 11:25 -0700, Andrew Morton wrote:
> [ 715.196000] sd 2:0:0:0: [sda] Synchronizing SCSI cache
> [ 715.196000] sd 2:0:0:0: [sda] Stopping disk
> [ 715.196000] ata3.00: DISK MIGHT NOT BE SPUN DOWN PROPERLY. UPDATE SHUTDOWN
> UTILITY
> [ 715.196000] ata3.00: For more info, vi
This is current mainline plus a few patches which I've just sent to Linus:
loop_probe-fix-return-value.patch
fault-injection-disable-stacktrace-filter-for-x86-64.patch
ntfs-use-zero_user_page.patch
tty-flush-flip-buffer-on-ldisc-input-queue-flush.patch
missing-include-file-in-tpm_atmelh.patch
mai
On Sat, May 12, 2007 at 10:50:16AM -0500, James Bottomley wrote:
> > I don't like it at all. It means we tange up dma mapping bits into
> > a layer were they don't belong at all.
>
> Well ... libata already does this ... I don't remember you complaining
> about it being a layering violation in li
On Sat, 2007-05-12 at 16:29 +0100, Christoph Hellwig wrote:
> On Fri, May 11, 2007 at 01:33:41PM -0500, James Bottomley wrote:
> > Right at the moment, we're planning to clean up the way SCSI drivers
> > process commands. The proposals are essentially:
> >
> > 1. Get rid of the now unnecessa
> +int scsi_dma_map(struct device *dev, struct scsi_cmnd *cmd)
> +{
> + int nseg = 0;
> +
> + if (cmd->use_sg) {
> + struct scatterlist *sg =
> + (struct scatterlist *) cmd->request_buffer;
> +
> + nseg = dma_map_sg(dev, sg, cmd->use_sg, cmd->sc_d
On Sat, May 12, 2007 at 07:05:42PM +0900, FUJITA Tomonori wrote:
> There are two patches for each driver, removing the non-use-sg code
> and converting to use the accessors.
One patch would probably be fine aswell.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the bod
On Fri, May 11, 2007 at 01:33:41PM -0500, James Bottomley wrote:
> Right at the moment, we're planning to clean up the way SCSI drivers
> process commands. The proposals are essentially:
>
> 1. Get rid of the now unnecessary map_single path (every command is
> either zero transfer or
On Thu, Apr 12, 2007 at 04:01:31PM -0400, James Smart wrote:
> This patch provides support for FC virtual ports based on NPIV.
> For information on the interfaces and design, please read the
> Documentation/scsi/scsi_fc_transport.txt file enclosed within
> the patch.
Looks good to me.
-
To unsubs
On Sat, 2007-05-12 at 19:05 +0900, FUJITA Tomonori wrote:
> Add a set of accessors for the scsi data buffer. This is in
> preparation for chaining sg lists and bidirectional requests (and
> possibly, the mid-layer dma mapping).
>
> Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
> ---
> driver
On Sat, 2007-05-12 at 11:12 +0200, Heiko Carstens wrote:
> I hope that doesn't mean that each architecture is required to
> implement all the DMA mapping stuff?
Yes, it will require this ... or at least dma_map_sg() and
dma_unmap_sg().
> s390 doesn't have any support
> for DMA at all.
Well ...
Hi,
This patchset cleans up 9 scsi drivers, ipr, ibmvscsi, fusion,
aic7xxx, qla2xxx, lpfc, aacraid, BusLogic and aic79xxx.
- remove the now unnecessary map_single path.
- convert to new accessors for the scsi data buffer, the sg lists,
bufferlen, resid.
There are two patches for each driver, re
This removes the non-use-sg case.
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/scsi/aacraid/aachba.c | 64 -
1 files changed, 6 insertions(+), 58 deletions(-)
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
in
This converts aacraid to use the data buffer accessors.
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/scsi/aacraid/aachba.c | 96 +---
1 files changed, 41 insertions(+), 55 deletions(-)
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/sc
This removes the non-use-sg case.
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/scsi/qla2xxx/qla_iocb.c | 192 +++
drivers/scsi/qla2xxx/qla_os.c |8 +-
2 files changed, 76 insertions(+), 124 deletions(-)
diff --git a/drivers/scsi/qla2xx
This converts lpfc to use the data buffer accessors.
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/scsi/lpfc/lpfc_scsi.c | 55 ++--
1 files changed, 25 insertions(+), 30 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/
This converts qla2xxx to use the data buffer accessors.
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/scsi/qla2xxx/qla_dbg.c |4 +-
drivers/scsi/qla2xxx/qla_iocb.c | 96 +++
drivers/scsi/qla2xxx/qla_isr.c | 44 +-
driv
Add a set of accessors for the scsi data buffer. This is in
preparation for chaining sg lists and bidirectional requests (and
possibly, the mid-layer dma mapping).
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_lib.c | 26 ++
include/scsi/scsi_
This removes the non-use-sg case.
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/scsi/aic7xxx/aic79xx_osm.c | 24 +++-
1 files changed, 3 insertions(+), 21 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c
b/drivers/scsi/aic7xxx/aic79xx_osm.c
ind
This removes the non-use-sg case.
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/message/fusion/mptscsih.c | 35 +--
1 files changed, 5 insertions(+), 30 deletions(-)
diff --git a/drivers/message/fusion/mptscsih.c
b/drivers/message/fusion/mptscs
This converts BusLogic to use the data buffer accessors.
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/scsi/BusLogic.c | 38 --
1 files changed, 20 insertions(+), 18 deletions(-)
diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
This converts ibmvscsi to use the data buffer accessors.
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 52 --
1 files changed, 22 insertions(+), 30 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drive
This converts aic79xx to use the data buffer accessors.
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/scsi/aic7xxx/aic79xx_osm.c | 33 +
drivers/scsi/aic7xxx/aic79xx_osm.h |4 ++--
2 files changed, 15 insertions(+), 22 deletions(-)
diff --gi
This removes the non-use-sg case.
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/scsi/BusLogic.c | 22 ++
1 files changed, 6 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
index 96f4cab..9f2586f 100644
--- a/dri
This removes the non-use-sg case.
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/scsi/lpfc/lpfc_scsi.c | 52 +---
1 files changed, 2 insertions(+), 50 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
ind
This converts fusion to use the data buffer accessors.
TODO: use scsi_for_each_sg()
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/message/fusion/mptscsih.c | 51 +
1 files changed, 18 insertions(+), 33 deletions(-)
diff --git a/drivers/mess
This removes the non-use-sg case.
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 36 +---
1 files changed, 1 insertions(+), 35 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.
This converts aic7xxx to use the data buffer accessors.
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/scsi/aic7xxx/aic7xxx_osm.c | 25 +
drivers/scsi/aic7xxx/aic7xxx_osm.h |4 ++--
2 files changed, 11 insertions(+), 18 deletions(-)
diff --git a/driv
This converts ipr to use the data buffer accessors.
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/scsi/ipr.c | 26 --
1 files changed, 8 insertions(+), 18 deletions(-)
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index 8390bce..8002ecc 100644
--
This removes the non-use-sg case.
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/scsi/aic7xxx/aic7xxx_osm.c | 36 ++--
1 files changed, 2 insertions(+), 34 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c
b/drivers/scsi/aic7xxx/aic7x
This removes the non-use-sg case.
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
---
drivers/scsi/ipr.c | 122 +--
1 files changed, 41 insertions(+), 81 deletions(-)
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index 4baa79e..8390bce 1
On Fri, May 11, 2007 at 01:33:41PM -0500, James Bottomley wrote:
> It strikes me that in all of this, we could also consider doing the DMA
> mapping inside the mid layer (instead of in every driver). This is
> essentially what libata is already doing ... leading to confusion in
> SCSI drivers that
37 matches
Mail list logo
